From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F363CD59F78 for ; Wed, 6 Nov 2024 22:02:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F6686B00AA; Wed, 6 Nov 2024 17:02:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A6326B00AC; Wed, 6 Nov 2024 17:02:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 095126B00AD; Wed, 6 Nov 2024 17:02:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DFE2F6B00AA for ; Wed, 6 Nov 2024 17:02:15 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 999EAAAA15 for ; Wed, 6 Nov 2024 22:02:15 +0000 (UTC) X-FDA: 82757043516.18.289A2DE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id 3A8AF180025 for ; Wed, 6 Nov 2024 22:01:39 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=kHW6ciBR; dmarc=none; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730930365; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pfOPE8Ycb94wQvZvMOR043T9yfe82gWdcJgjMkNgOqA=; b=60LLveE2sw2ZiQWY1MZwbqcHmCFPpoe/ABhmlxOuIALTLxOEkUwBXHH77MR81mgIj2045K 0n0h/UKCdTqEFUzM6Nva41WvmnC1J73R/lOW1w4MYr6GFdHyIA91wJDypoykHirogY6oox S8f0oQxa5c6z1aq03bCwfakQ7bTMpCc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=kHW6ciBR; dmarc=none; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730930365; a=rsa-sha256; cv=none; b=01JIsAwA2C1lrbc3a09klMKNiV0+L7foeNW9XHjPyDCJ6CLWDZJc9dMLJe+1WLc+eFHUJB 1WDoydYU9wlnpBdVrOKJWj67bPmFI3Yim2pFA4ovUqTSpw3XmaOY2zAUobFoc7z0UKhDkS xkQTa5ligAaCQI/ciPCF1FO3ns648N8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id DF0845C4BE6; Wed, 6 Nov 2024 22:01:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9456AC4CEC6; Wed, 6 Nov 2024 22:02:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1730930532; bh=qQomBuQN4Q81ObHmsV989becOTbHMcs1fG5+uVha8/s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kHW6ciBRy1vtLDHEZh8B8siDDtOV9Uwhq6QqqFCpUDHK1lO2G2L0MDuje4PXoU1rE xy9DUV5UvujjGYKBvNgc7ghd7OE4yL/JrIhquwsg7IjRMg22vXxlJ4wUIacpeoWbJu lPrJ4Rl5+p2ftgh8ljEIEoI51eRIesaepqkVmbkc= Date: Wed, 6 Nov 2024 14:02:11 -0800 From: Andrew Morton To: Barry Song <21cnbao@gmail.com> Cc: Kanchana P Sridhar , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , Nhat Pham , Usama Arif , Chengming Zhou , Yosry Ahmed , Hailong Liu , David Hildenbrand , Hugh Dickins , Matthew Wilcox , Shakeel Butt , Andi Kleen , Baolin Wang , Chris Li , "Huang, Ying" , Kairui Song , Ryan Roberts Subject: Re: [PATCH v3] mm: count zeromap read and set for swapout and swapin Message-Id: <20241106140211.a1272fe0e23d99d7c37b7751@linux-foundation.org> In-Reply-To: References: <20241105211934.5083-1-21cnbao@gmail.com> <20241106150631.GA1172372@cmpxchg.org> <20241106124225.632b42c3680cae0b940d2871@linux-foundation.org> <20241106134446.aaadc57a2a88c9efe899c838@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3A8AF180025 X-Stat-Signature: nxp9p9wqenf5yrp7xza7ug9d4yu9yu8o X-Rspam-User: X-HE-Tag: 1730930499-821252 X-HE-Meta: U2FsdGVkX1/+vGJ1CTH8/amWCe2eQQnj573dD1mWvxyxNizhurRcxJuNjsbxEZ3JSuSzYgZ4CVkYmTm1EedLSyoWXRRVHXLUouChE64TXkmwIY2BQSARiutmLltICyLRnokl+r9zjuvxDRmQ//9NL0yzqh8/jKdwETZnC8X3JoWR/KtThdvGjfm9VTADAuudbzU33oIBSDWSljQH1gK47KhRukqQkVmNrlJcLn2Xydy4x2TRyT7jLnO4Ute1WXekghNNeO46jTuOIzJhNVHgV9BM31rnOY6QUz7CyI9Qfq46BoIoQG43gnshDVUEwKB1oPzLfP9ESWMT0laQ/xyvv5zuFVQmhCL6bPjuqnSRwzR/H8J940owpnUUjFVdlB0W8cA8dBet6OFFrs8APBOXkoyuCON7toUNbqxhUn+TRh4o3D+qFYiKbMXvCafx0C8v+EcgpQM6OVe9iW1e2Ee0vzzI1cQMQUZmDmx2oG9CYQVfx6+nLL06NJMKWbrTyaFOMdUD5DEXL0DlTsD+bMKRMPY5Plh2qGyjSgQ1vsTUIomlB7AyAUHDCwg+emiANCiti0OQOyVhs+scQaCXEmEby84El/fzK9vI2uEBrsKWNigb4kCcuSqU+GAuN8Jpe4LN0mCqaQrQdMBmLtLuvIanTBshCIgbi6jNFSYOy1uiBkJZUsmeWC01Z8ei/ngMO5qqp+bU2RjSF45EgCH41QjhFKiwRICwqFLgABuwUqEhsZk3X7TP10gum4/L9+hGoGC0m1brn0KikCpG9m4iU8K5EfMjqIY0yXOSeIwe/rtR8e64VPY/45NebXL6qTXsOq0zDAIhPgzCU+P6j205z/uqmy76FG5u4eFZfX+eht6G4A6WY3cLFQF7etuL6/xAaiWfK+wnSb793nO2yY8Je7lfKPnW3IGjP2Dt5AlFePtQEQwCPNvF3j49JOqDOR+riukVIPLf6oaDM4fr3ICGLLb WauXRGDJ jianxUfRmfcinzUawDxN9iFrDXextca4duQt5CBhjqj8Gxeq1He0AlN18lDTqfbyXWmeG2XU21U3HPks/aB90u7lnTmu7lPxgo0t4skoDwhgiJQSo4Udtt1WUekfFTYR3WrJ3FBDMGSjMUu4tvxIm2wo8YDJ1ZcYp8wuAGyhOkxCPBpkaFJp1A+DFm3jXtw9UFw4tL31fSuIdDpzqeuQV+wQAkAreGGQ8MnaUwNQZpL+9h8H6wqAPiYt0ktOvvFpsEd1tMGqZKZ2GVD1uYsgUJ1wWFaUHTz/aBDzA45Kei6tUF9k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 7 Nov 2024 10:53:11 +1300 Barry Song <21cnbao@gmail.com> wrote: > > Kanchana's commit 'mm: change count_objcg_event() to count_objcg_events()' > changes count_objcg_event() to count_objcg_events() and supports > nr_pages more than 1. This is what we need for the minimal patch of > fixing zeromap > as zeromap could be nr_pages > 1 for large folios. > > So my question is that, do I combine Kanchana's change into my patch > and send a single patch, or do I send a patch series with 2 patches: > > 1: Kanchana's mm: change count_objcg_event() to count_objcg_events() > 2: mm: count zeromap read and set for swapout and swapin A single self-contained backportable patch is preferable, please. > If we combine them into a single patch, I'll need to incorporate the changes > from 1 into 2. I'm also unsure how to acknowledge Kanchana's contribution > —perhaps mark it as co-developed? Sure.