From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CA7AD59F75 for ; Wed, 6 Nov 2024 21:44:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B64D66B00A9; Wed, 6 Nov 2024 16:44:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B14716B00AA; Wed, 6 Nov 2024 16:44:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A02C26B00AC; Wed, 6 Nov 2024 16:44:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 837D66B00A9 for ; Wed, 6 Nov 2024 16:44:50 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 18BBD40131 for ; Wed, 6 Nov 2024 21:44:50 +0000 (UTC) X-FDA: 82756999584.18.5174727 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf08.hostedemail.com (Postfix) with ESMTP id 44CC3160006 for ; Wed, 6 Nov 2024 21:44:25 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=nqfTyFvb; dmarc=none; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730929319; a=rsa-sha256; cv=none; b=0DROnBnVjNdevnJZorEmMzCl0cwDhAcqFUdfD0Xj8ikkuu5NUGjXqHf+A1AWKcilYpnTYg l9Nq95sTnTraM1Xvop+CnSQae0OpXIQI53iyRPpwHsGCx1zYxeru7/lmvq86WaWs5PswDX 1J00Mp6Dxqd3Y4NDQMPrBXC37bSlAfI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=nqfTyFvb; dmarc=none; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730929319; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6m1RPdLVtQiUp0lfCJtCgdHrXlqolae5lxtW2KOZBvk=; b=gfwuZrw2kyAawBZi/JIbfVcqk98xBp78yNHu7kHuEqqRucqyzB/HAomn/BvGcdX6PnsrrN 8H1GkFPI4Ywy138gvebEP7G+lT6ubH22SHaNkC8X1TOthpqACKmMd3NKtCQlVCJazWi+X7 DDQnHSyky/O3aROOJo5WMCYj4qg16xQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id BBC41A41BBF; Wed, 6 Nov 2024 21:42:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACC17C4CEC6; Wed, 6 Nov 2024 21:44:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1730929487; bh=Jk69uuIZIlC/VrdhdkQeZ8y3KBI1zh2bkeTXN/BasrU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nqfTyFvbYj+uzZfPFM2Cisv6TcVZpdYOz5ZJadwlmDUJ/gmnS8oMYmvdMuiNSxbtE N18nPXuopDhCf+uMWzzzdMQ/KBJp9aVUUnit0UFXzbGQpt+kz4fTdTxRlg5oQ3RkzX eA/jxXxWnaHwF1J8U+oQptp3tYCu7xAdRnbCJCVE= Date: Wed, 6 Nov 2024 13:44:46 -0800 From: Andrew Morton To: Barry Song <21cnbao@gmail.com> Cc: Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , Nhat Pham , Usama Arif , Chengming Zhou , Yosry Ahmed , Hailong Liu , David Hildenbrand , Hugh Dickins , Matthew Wilcox , Shakeel Butt , Andi Kleen , Baolin Wang , Chris Li , "Huang, Ying" , Kairui Song , Ryan Roberts Subject: Re: [PATCH v3] mm: count zeromap read and set for swapout and swapin Message-Id: <20241106134446.aaadc57a2a88c9efe899c838@linux-foundation.org> In-Reply-To: References: <20241105211934.5083-1-21cnbao@gmail.com> <20241106150631.GA1172372@cmpxchg.org> <20241106124225.632b42c3680cae0b940d2871@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: 4bc9o1z1rrfqphui9iktwes5s76su7t7 X-Rspamd-Queue-Id: 44CC3160006 X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1730929465-575463 X-HE-Meta: U2FsdGVkX19hJaOcPENuu9sLmiIbRN7v7H1iFmoe0Hc6/ZdqDSxje40S25wc+lyv0c/TKgRBSnhGyWeufO2hF6CBnKDRsR29sToFOY4VWn9TuLb/JKSjrHS2NaRapvEELPlpv71A34ld0kTiCbckh8/u5fmdW/+ZRRxYea9RD5nLzq00kBnGA7+1rSSvhMK71KpYoBdYK+4D+4ummFY2R+6JPU9lO1Fym1BKmFKa1EpsDJc23XmHe7f+e524YP4ctaxpl7U1HPt34uyItETfgN3Qo1GPyQSFK660a9t1sGV3zR6OBwjkEMKwGb+Napp3MQwRClqL3Y64RsKucb3HgRxWCBSjQyjbsID+RwuZ/qX5oSjh+s0AD735ZXuP+7fQvULpRU0jAIwjbcz376YUEIy3tKqkfGP+vVHV+r3ZByvXQsNIox8+IqepDr0suEySlwwGyoFmtr0Q954J3NbYvXGOsrigFNsRwp/1yCQh042I3EuEyo4bMZjHtH0N52HusRaBXH1QHIpd7vttNcSfiSNa4K1EAD5tw0J6MH2q6rsN2db3yMFMvv/9IMXxhsJ0k+o01yIIdYBhQBx74PgidPsa3dVsIIBNJ+OA1QPdBwtqrFSwE+xr+LUlIhRhM0E3aBsou6K2ySHCshTFz8zIsUWzf1G4WuVqGNj1uWo7BJfQUhBXz7mx7LfI4nkrCkaCjA/g6YIFln97idFDbZ3L3jRGxUvvmoeRTZTFJGyXibzer8frv+qwk0+4AJAiT9D51J+LXh9LQINcG/1+Qd2amd5HD8Nao/MrJUeJh4dFH0ADJLXCxs1xwmNqsqal/B2BCxBbIa1uw7/MI1kXJB5j+3gWNJcqBEXMNoa+/hUapqs6QK1CzRHW1NCmbn0LLCXxBm3JO5D3wHL9DMPXKYgMOZHtJdPoJLuvaOmK0ofZE0Az2T1px8I0UvJG8TobvpLW3baYGv7vVIl++OxvtNY goACi8u+ BL9Ac42dw4+cuIt2pqdrmkc9kuzZuTlUqm20phFZjC/MDYT2k2y2Uhpr25TeVfg5I2HomjKKxdPTOT1XbSWIcBETIUTTsZYfR92iHXAcHkelc0UNuhhQ48yU5XuUzYH4sjXy13Blfd5XhKpFGjlQUvXO8ZlncJPqPPWWj10iNBpFtttjzjmZCg7ShJvwSd3aCaZj7XWgpbVAMgnkJbOvHTxZ7PUqOX63HMKS25lUudptF1zMg7tJZItOB642pGQLJ3VjtrDf+vVVM+dNdMSWI4B5PepCguY9cIfXjBqrtQEKM0H78KT6dO9Xj+b1xYQdBNuOYICNV80eNuIPcq3esNeC0IP77oJHOJNANV94XUVMwYq23R2LDLq0J9toKf5jKdH7k X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 7 Nov 2024 10:00:47 +1300 Barry Song <21cnbao@gmail.com> wrote: > On Thu, Nov 7, 2024 at 9:42 AM Andrew Morton wrote: > > > > On Thu, 7 Nov 2024 09:01:14 +1300 Barry Song <21cnbao@gmail.com> wrote: > > > > > Oops, it seems that it depends on Kanchana's 'mm: change count_objcg_event() to > > > count_objcg_events() for batch event updates,' which also isn't present in 6.12. > > > > > > Otherwise, it won't build, as reported here: > > > https://lore.kernel.org/linux-mm/CAGsJ_4whD31+Lk0m2uq-o=ygvkRsw1uXcPeqxBONV-RUXkeEzg@mail.gmail.com/ > > > > argh. > > > > Apologies for the inconvenience. > > > > Hi Andrew, > > > What’s the best approach here? Should we include Kanchana's patch that extends > > > the nr argument for count_objcg_events() in 6.12-rc as well? > > > > Let's do the right thing here. I'll drop this patch from mm-hotfixes. > > Please send a v4 against Linus mainline fairly soon then I'll redo > > Kanchana's series around that. > > Alright. The question is whether we should integrate Kanchana's 'mm: > change count_objcg_event() to count_objcg_events() for batch event > updates' into 'mm: count zeromap read and set for swapout and swapin,' > or keep it as a separate patch as patch 1/2? > > I guess integration would be better, as hotfixes may not be ideal for a patch > series? I don't fully understand what you're asking here. I'm suggesting that you prepare a minimal patch that fixes the bug in Linus's kernel. Then we figure out what to do with Kanchana's 6.13-rc1 material after the bugfix is sorted out.