From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B2B0D59F6F for ; Wed, 6 Nov 2024 20:18:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8FE76B00A4; Wed, 6 Nov 2024 15:17:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D3FD76B00A5; Wed, 6 Nov 2024 15:17:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2E5D6B00A7; Wed, 6 Nov 2024 15:17:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A4E076B00A4 for ; Wed, 6 Nov 2024 15:17:59 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4BF7EC1DD0 for ; Wed, 6 Nov 2024 20:17:59 +0000 (UTC) X-FDA: 82756780428.23.131242D Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf23.hostedemail.com (Postfix) with ESMTP id DCC35140017 for ; Wed, 6 Nov 2024 20:17:34 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=UEEEZG5p; dmarc=none; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730924218; a=rsa-sha256; cv=none; b=fAkZVWb5dSFHBps4lTHNs3vcuSxpFgxnCjzNQ2c3BFt1bTdr+LEfg5ZsS96vnIDJELxPn3 yXjwIOUj76CsWU68v3Gwpgpk5PHapD3O94+Rw8FO238aivJscw7NAM3Zbi+THBHHibxxGU w0zzXbD6YSoXghbNtiqr1rG4PMcsuhs= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=UEEEZG5p; dmarc=none; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730924218; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=93ZOCm+GQpSLe0kfwRjQfZKVtGwROOXA3GS756eu3Dk=; b=A52q1CzYCH+VOA+nUW28yCZeqV24tzTgAinrwOIfgM7b+9Fh/08L3yy6Faet14jVZlkCvr 2q1GCt7YKe0W04L+hKqwmhE/lAcXgT7EWvJH9YNYKi8Hp1HTfQnx18htDxD4J8WmMsWSQ7 r/K3Dfj5q+ptKLz03/9l1REzIRiu8dM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id AECDDA4326F; Wed, 6 Nov 2024 20:16:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E915C4CEC6; Wed, 6 Nov 2024 20:17:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1730924276; bh=WwTbFmFx1P5sUSsJ6hCKDOYwNpexIk7UJAsHBsokrdg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UEEEZG5pndg/EOyEjAyK7t8vb4dIDrTcpK1dd05wHxYVFVMl+8hxjU1c1OaOuj5lE THQu6/35mNaHTejGY+7FlPHigfFPwdLARBPnNaNWx4w3P3MdRcWjuOzCAM31Y1Q+sP O6zQ005Nmd4huqj5qC2WARKtMuEAJp7g6rmXkAk0= Date: Wed, 6 Nov 2024 12:17:54 -0800 From: Andrew Morton To: Kanchana P Sridhar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, clabbe@baylibre.com, ardb@kernel.org, ebiggers@google.com, surenb@google.com, kristen.c.accardi@intel.com, zanussi@kernel.org, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Subject: Re: [PATCH v3 12/13] mm: Add sysctl vm.compress-batching switch for compress batching during swapout. Message-Id: <20241106121754.644440c6d8d1edf60f6163d7@linux-foundation.org> In-Reply-To: <20241106192105.6731-13-kanchana.p.sridhar@intel.com> References: <20241106192105.6731-1-kanchana.p.sridhar@intel.com> <20241106192105.6731-13-kanchana.p.sridhar@intel.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: DCC35140017 X-Rspamd-Server: rspam01 X-Stat-Signature: h8of9nfwxnq8jzarqnadcozt8ww9fbm6 X-HE-Tag: 1730924254-430577 X-HE-Meta: U2FsdGVkX19A4/rsxNlp4RNQAhCqNQCjEPqZgFG7M2P3QF+WtqQCRjMGEN1GG0SxnRMCPuFKluS/Iyy06cvRLJm/cVQLcBOHmElynAwj37ApthJ/EBRFPryzEsxDHJ0U9BahTSvYH4GkYVgr77GC/eUOmYLLGCgKvsIts1RVJJznfvlB5bHUO0LWyHA7FRCElg+Pn44USQXyVX+pI27HyhSrOvRBktW/FukjYKJEFV/XsZFl25zzHhoOGVTiPVRbxjqMHmLfNFp29dCM2m4QvkWlL0WCODpb3WcHHh+YrI7bIQIM37ruidgXg4IJHC5BkGa68A/7VLaDYffg0P2F2USJ7mJL2iw/FYuxbo6sKwpk+SBi3lmpS1reyyVcJZ9s/OBxesGGC3nExKqZ0k77XxFr/uagKpy1+rqA0ngEdCW42VHjPPhzNQiGLiE7J1tH+qv0ZATYOa3AFCih0ycVRRQezoSogfemAS/+1bzxlcHTFmjXx8n8eE9VJSqipggBibQ8ntaIoKnV/4tVBECdJksTF7dSOyxC6s0kwnioySRBBYRpQkWozFTFWPg1eeqKkesfdNpgxT2ymeW/uyCQNbbR0A26CdpoRAB5pLDwwrb5WCb6Hi5i04xavwhLfnN4GTi7NJDdSQxGKKyXY6tdsxvxt8l9x6Hg6SnH3ADUSvgpBG4kIonKI+i7ZlgQQG+UUvz3UlcGl33ncOo5JPO5vsYWSHnDYL6uMEQAz3LrNNQoWPBU2S1uYRvLV+GZyE5S5bzxbvM39OZ9Xu/ZWrNn51uyPgqZomjPEvyFWKVYS4+gpR8klAdjeknKmArjT7EPaNtOkbYHeWDixu3LV64HoTu+B709V/SwpFK390VbxzijEoF/7D9NbO6w4Wqu+sS4K0QKsionIkD7CaQNQ+a4FArM+juGI+lOND80q6QDqCLuTsZVstjRx4b90q2uBc8Mt6NeMrwOgFLFKSILdIK 9khrSVwT /CnoM1RnPuXnEq/r7vI22Fwl63itjgxSELabFY3ftFYUng8fyKYcUVBgpUhc/ku9aI0m9/to2uGgU3xJVY7VQuXdVg5aLCpxw0Zp4lS7/BeV4HzDfs56SOke6Y39Cz6DrV7lLH8MtRj+846421Hx5BH5fnBB3UCLPYOZd916XaOUAxBD1CeAUD5asNvMY3CscTqnZRchmcG5XXVycqlWhN2+UePIugoOQj2ngEdo40qVjyEzo63Gw2mIr1xNTghQdnakXiR6E3mVbTNTEvG4sSY44/A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 6 Nov 2024 11:21:04 -0800 Kanchana P Sridhar wrote: > extern int sysctl_legacy_va_layout; > +extern unsigned int compress_batching; nit: I suggest calling this "sysctl_compress_batching". See how we treated sysctl_legacy_va_layout. > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -47,6 +47,9 @@ > int page_cluster; > const int page_cluster_max = 31; > > +/* Enable/disable compress batching during swapout. */ > +unsigned int compress_batching; > + > struct cpu_fbatches { > /* > * The following folio batches are grouped together because they are protected > @@ -1074,4 +1077,7 @@ void __init swap_setup(void) > * Right now other parts of the system means that we > * _really_ don't want to cluster much more > */ > + > + /* Disable compress batching during swapout by default. */ > + compress_batching = 0; Not really needed? The compiler already did that. > }