From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CCF6D36129 for ; Wed, 6 Nov 2024 02:13:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 389426B0096; Tue, 5 Nov 2024 21:13:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 338B26B00AF; Tue, 5 Nov 2024 21:13:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2014F6B00B0; Tue, 5 Nov 2024 21:13:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F25356B00AF for ; Tue, 5 Nov 2024 21:13:25 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9D18CAB9BB for ; Wed, 6 Nov 2024 02:13:25 +0000 (UTC) X-FDA: 82754047740.04.9CF965D Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf25.hostedemail.com (Postfix) with ESMTP id BABBDA0005 for ; Wed, 6 Nov 2024 02:12:59 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tLajrSC3; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of sashal@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sashal@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730859145; a=rsa-sha256; cv=none; b=6/GckK5WVfBSBnPHwHpmZJP80xdUmh7apnngr1q3Weg83xmpHQM2844Rn2bRBaLWNKwS2Y VOLciSIaZxefSD6McWS2SFWhNKMLvCGvUbUkcfydfVcLla+xppStLjFldSR064ISF+Npti b3L0Z3i7EmKcX9bUton5CCt3/Swbmx0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tLajrSC3; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of sashal@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sashal@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730859145; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=oo/tXuqmBLM0x99zJuW7TF2FeYM3l+Wbca9Tq5Mwchc=; b=dyVo5Kwa8w67J08zgx00prlpX3xeh5dxz0bbuuWpqevt+HbPUpqXMeb7yw02bXroiuKTcv S0E5cYxk6VwG8rlFckhQoaF0ypC/bWyBiaqzyHO/oJ933ye1N8ctVLUTbIJbTU4dbEmqre vRWa0vjpcQ1VcRpVhF3YpBtVGl0PGDk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 78475A41BD4; Wed, 6 Nov 2024 02:11:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8D8EC4CECF; Wed, 6 Nov 2024 02:13:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730859203; bh=tpgSQdA549AkQm26IWCCPT/JiU010lRhNBPW7Ul8z7M=; h=From:To:Cc:Subject:Date:From; b=tLajrSC3lhu2lOdwLXlWLH2Cp+FRUpCqYysDp3liwCn+pMqB/tfs5+Tla+5mZPqUA FVtFldUjkn02OREyWDZm1G4LDmOyEVYOnVoyCnBR543BuQOSpv0Xa/X/3mnq52qIwq KDsyIpT7QXNaxCjcWBofTexnuhZ0lgrhaj6Qpcu1iWouz27ca8kOYFtFhseXkFk6Of NouNotSYEQHme9wlc2f/SvZPlhdyaDOW3F0jRe6tXNx4dsgv96SLkt6xu0ABckBVBU 3C8rtp8c0etVdWIkWYKppG5o30MKk23M2D4ogRN1h5iRZR5xIVnNWj9Gj5WEWf2/gn xxmY68/0Jk9EQ== From: Sasha Levin To: stable@vger.kernel.org, aha310510@gmail.com Cc: syzbot , Hugh Dickins , Yu Zhao , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: FAILED: Patch "mm: shmem: fix data-race in shmem_getattr()" failed to apply to v5.4-stable tree Date: Tue, 5 Nov 2024 21:13:19 -0500 Message-ID: <20241106021320.183519-1-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Patchwork-Hint: ignore X-stable: review Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: BABBDA0005 X-Rspamd-Server: rspam11 X-Stat-Signature: d6g8twsrtamebru9mfec3kqp4dz1b5oh X-HE-Tag: 1730859179-298694 X-HE-Meta: U2FsdGVkX1+ny2vOkWHGu2Ag3TfJSOd2gGocGB90t1pYg0jBM7lvi7wFNfFWfX/G5LCJNzd3KY/W1h1KTmoSWCaEqbW9AYLvL+rW3A8F5NfUbZMPyIzKF31OBIOordvu9epO6qq0GBucQLFTx5w02/NdqlNMQqVYoccWFByF5r93jr3M09iuRSLDw/uk8PS0DWF2ZVJbLAy7YewfRFBkg1tRvKsfj/d0+goIO8IojV+Z42zLi2jyiotw+Rkgzd/NceJLpCfjftby3Tgja6Gpe5JmpIzzZbQ3Jw2MlBexjywFAPUyQeOLR8De4q67CWwryY+QFL+hdFWVn2IFh6q22tTXVbI2ltIp6nFObCn5SgojU1nO/ToliwdhlKSYrAn+6DNDoshCH5d50XSrnDPQ6DCAZ7m4e/gvOFvv8QzlLIfUTo0okPqFEiNWZ2YJSkytRRj6jZPKxOdllMHtOQxsyyv9bs2Q5fgdBhBVxE8em2/7/so3YsbWEIvDlR8mn6HLXlp+2HfdPUxfCJmZFBttnjpdprumgYDY2/9UN9qj4TW0sXlpqwx/u6spoobTSy/QHfc1ScQcrFZV+380HIu9x+zwY3DIgzd80A2VGFoUmPo3I8ODcjXgvKLuqyADOA24jGKoxBcVP/FfksHhow5M6he4PkbzszbuWNqWUEFRAj6va3zbsAFCjHcA62it6MS0tBWAYLgweGoY6qdU78dtsVgPKpDdPPuajKrdfLEiAbqE4YSL3hqOpy+WTh8/ibyAZ5XUJPCv6T9h/aaOmFKHB7pBfX42sFYLpWJCiviHqNsT5dKSk62Nb4JATSY9xLCq1qyWsR+tJDkPfg2H/vqRLmQtupiM2Wj4AubEqJzE8GWvewILumM6XINSoEdbj0X2pMsX4nEBbwYytchZylwhvqj/O8VODnev/IPVZqa1o6qaHfB/yuv2PpGnFQlC1ByTcWlJaHwIjIrNlYJUxwa YPZMjHat AJ/gMZPv2RHMqBiUFeczEpp1qk46irLdHUiFqUbOrGMFoGzp2KlE94T9IxQIxVcx59Y4TB+9LboDV6aHxqil5XV/zAJGlxPobKm8MrKMYjGggsYu8k2B83ez0J/GKQhIOA08iZCq9rTTlxb6F3FEX4nV8auGTi+AX/3LzFkECLQns1uJ3eNw/U8MCkjts3H/soMcIA9GFkRq83yBBUZb4CVymwV8ep76Hgjk6Nereu2OoaId6Q2n32y7jD689sZe8P3spAeX1CqfyfjhaoQX6JUzub7rKHw6/hOKpNMUS0dh3zYJR6Yctrfh6p1Be5LrTctjRIy7PlKlr9MO8EDKoUEsDIOrbgHSfZ0helomrOuAqhnW4XgUijn2weBVO3NsIv9ejcMtA0oqksFPww+xew55SxBZZWaI/uUuZb5lfc1uAx1eNZnlbTYaHGwSdKu1q4b4E X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The patch below does not apply to the v5.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From d949d1d14fa281ace388b1de978e8f2cd52875cf Mon Sep 17 00:00:00 2001 From: Jeongjun Park Date: Mon, 9 Sep 2024 21:35:58 +0900 Subject: [PATCH] mm: shmem: fix data-race in shmem_getattr() I got the following KCSAN report during syzbot testing: ================================================================== BUG: KCSAN: data-race in generic_fillattr / inode_set_ctime_current write to 0xffff888102eb3260 of 4 bytes by task 6565 on cpu 1: inode_set_ctime_to_ts include/linux/fs.h:1638 [inline] inode_set_ctime_current+0x169/0x1d0 fs/inode.c:2626 shmem_mknod+0x117/0x180 mm/shmem.c:3443 shmem_create+0x34/0x40 mm/shmem.c:3497 lookup_open fs/namei.c:3578 [inline] open_last_lookups fs/namei.c:3647 [inline] path_openat+0xdbc/0x1f00 fs/namei.c:3883 do_filp_open+0xf7/0x200 fs/namei.c:3913 do_sys_openat2+0xab/0x120 fs/open.c:1416 do_sys_open fs/open.c:1431 [inline] __do_sys_openat fs/open.c:1447 [inline] __se_sys_openat fs/open.c:1442 [inline] __x64_sys_openat+0xf3/0x120 fs/open.c:1442 x64_sys_call+0x1025/0x2d60 arch/x86/include/generated/asm/syscalls_64.h:258 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0x54/0x120 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x76/0x7e read to 0xffff888102eb3260 of 4 bytes by task 3498 on cpu 0: inode_get_ctime_nsec include/linux/fs.h:1623 [inline] inode_get_ctime include/linux/fs.h:1629 [inline] generic_fillattr+0x1dd/0x2f0 fs/stat.c:62 shmem_getattr+0x17b/0x200 mm/shmem.c:1157 vfs_getattr_nosec fs/stat.c:166 [inline] vfs_getattr+0x19b/0x1e0 fs/stat.c:207 vfs_statx_path fs/stat.c:251 [inline] vfs_statx+0x134/0x2f0 fs/stat.c:315 vfs_fstatat+0xec/0x110 fs/stat.c:341 __do_sys_newfstatat fs/stat.c:505 [inline] __se_sys_newfstatat+0x58/0x260 fs/stat.c:499 __x64_sys_newfstatat+0x55/0x70 fs/stat.c:499 x64_sys_call+0x141f/0x2d60 arch/x86/include/generated/asm/syscalls_64.h:263 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0x54/0x120 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x76/0x7e value changed: 0x2755ae53 -> 0x27ee44d3 Reported by Kernel Concurrency Sanitizer on: CPU: 0 UID: 0 PID: 3498 Comm: udevd Not tainted 6.11.0-rc6-syzkaller-00326-gd1f2d51b711a-dirty #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024 ================================================================== When calling generic_fillattr(), if you don't hold read lock, data-race will occur in inode member variables, which can cause unexpected behavior. Since there is no special protection when shmem_getattr() calls generic_fillattr(), data-race occurs by functions such as shmem_unlink() or shmem_mknod(). This can cause unexpected results, so commenting it out is not enough. Therefore, when calling generic_fillattr() from shmem_getattr(), it is appropriate to protect the inode using inode_lock_shared() and inode_unlock_shared() to prevent data-race. Link: https://lkml.kernel.org/r/20240909123558.70229-1-aha310510@gmail.com Fixes: 44a30220bc0a ("shmem: recalculate file inode when fstat") Signed-off-by: Jeongjun Park Reported-by: syzbot Cc: Hugh Dickins Cc: Yu Zhao Cc: Signed-off-by: Andrew Morton --- mm/shmem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/shmem.c b/mm/shmem.c index c5adb987b23cf..4ba1d00fabdaa 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -1166,7 +1166,9 @@ static int shmem_getattr(struct mnt_idmap *idmap, stat->attributes_mask |= (STATX_ATTR_APPEND | STATX_ATTR_IMMUTABLE | STATX_ATTR_NODUMP); + inode_lock_shared(inode); generic_fillattr(idmap, request_mask, inode, stat); + inode_unlock_shared(inode); if (shmem_huge_global_enabled(inode, 0, 0, false, NULL, 0)) stat->blksize = HPAGE_PMD_SIZE; -- 2.43.0