From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53B59D36129 for ; Wed, 6 Nov 2024 02:12:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0F9A6B00AC; Tue, 5 Nov 2024 21:12:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DBF576B00AD; Tue, 5 Nov 2024 21:12:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C87C06B00AE; Tue, 5 Nov 2024 21:12:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A7B586B00AC for ; Tue, 5 Nov 2024 21:12:50 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 695BC160BD2 for ; Wed, 6 Nov 2024 02:12:50 +0000 (UTC) X-FDA: 82754046186.18.ADFE387 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 43BAB140011 for ; Wed, 6 Nov 2024 02:12:25 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cRIuiFbD; spf=pass (imf09.hostedemail.com: domain of sashal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sashal@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730858945; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=WLGK66Ejym480CNb9QTu0Y5aNLSEF42VCo0OealRpO0=; b=FTNEB8KHwzAJCxVjVOn1oaBS96muKNYFuj0t3wMFIKyM5xjZDEVUzczwLjFC7Ahc6iVP83 cvJUV+8yoHruusy9lXdGC1lUdHetiv7/59zsHbsI6yhVGlQ/T6+RjZRsp26op/YzvefzX2 YbsyQP4lOS+Iqb8NvKJIXmm7RixDFi0= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cRIuiFbD; spf=pass (imf09.hostedemail.com: domain of sashal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sashal@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730858945; a=rsa-sha256; cv=none; b=1zbqJxiczUV6FwzF/H4FEQnxp1KzSzgfFm9yCoSM50vyqXokoS55bpb5Ren/IY2zCwYI9g oWuPAYpa03YRvSt/ga+mrTJUC3ZOXXRHbnUIZx7v5O/S8UJw0xTuGhSmG+DYN3+rRQEGZF CpkQ5Lg0Tp1BHg3O2WmbhqlbLsAWiuQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 575DE5C0696; Wed, 6 Nov 2024 02:12:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A3C7C4CECF; Wed, 6 Nov 2024 02:12:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730859167; bh=2o1BZqFvRH5tNGMpGOTU38S45OqjdSIjDmHM0nXBnAI=; h=From:To:Cc:Subject:Date:From; b=cRIuiFbDeN2660gQPau2yy94PiSdT+0hkuAli5AZNjZMUqSgxDLBeALvLC2tkc9ds SpwIZ70NLky+z+dzec9In22gfyUDlEgvQ9vdniadIJ4WdEwqPzcCOkRHrneEVgVVdo LAhntl9q4KAFqHUdejqlexexdhUXrvSAxYPFzrhgPGeUjrKypLmMQB5Ki09qd1RaKy cCkuu6q1vmWYRopKfLAxsW+OEWvLBa5nYFrKfpb0V74vBXQbIDBS93cEKETP+RRE1Z 5Bf1brwSXVks1WMW2/+fB1B6WZ5ueATKbbXBmOIEIIKyQLKyo0PBwJRuTbcTNF81Ky yb8dFQJTjNsdQ== From: Sasha Levin To: stable@vger.kernel.org, mfleming@cloudflare.com Cc: Vlastimil Babka , Mel Gorman , Michal Hocko , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: FAILED: Patch "mm/page_alloc: let GFP_ATOMIC order-0 allocs access highatomic reserves" failed to apply to v5.10-stable tree Date: Tue, 5 Nov 2024 21:12:44 -0500 Message-ID: <20241106021244.183133-1-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Patchwork-Hint: ignore X-stable: review Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 43BAB140011 X-Stat-Signature: myfae5fk199c4418x1z8oxewqyfpascr X-Rspam-User: X-HE-Tag: 1730859145-841947 X-HE-Meta: U2FsdGVkX1/P5GzwHix4MIRizcETo4iYJiSOwT9kvOLUDUEY038cBihsG38S9psDwSKkl2FYEBMSGlvxzp/IIy3Xpo/ipwQsta7OTyzEKzNnXQf7jpdq/5e//deypnu8IoWkSnsPcCcohCHJwfEGsuLpR5G1HiaqRpYyLUeWtuSWtY8Ap4IBBMxx2t23s5RF3gNGiL1Ys5H3txNjzqfpI+63juMzLeiUJTTTfVi88uY5jrNvb2fAihsU6IgUFFMNKm9D55Nye2QiYAdhGzjbZEcK4gKQMr4O4x0RXd2zriPunm6voxod9Fc1iE7q+feRa92Kmofgwyp1ppmDH/aowTR2DsM3z4zsBI37hI7QVRY7avOVwFCEDdFO3NKW0b+JaE4nNUkOT1qw6kivrKQ63G0T0rR1ndHZFPNd7eZ1XRVwYJGwnqTGhHjaEGEQWC0+XZXx6dt9BSfq5PZHdkDaWFoZIAzmsSxFmftDtY6ph9HVOF91b7DBJ9x24bC4WeiDbyiniLxd7mUXOu9IrySVoNzSawrJa7N10VgeCQ7Bks99q8dgwlpiP79DntCS4nve0rh3aOcKDTT0znqP+5YPqBdIimOqp84vZwhn0NyN/XVEVBBQI6zQ/yiGkbV15ZTt+dVwIMK6P9CUgQIfBnC1haMdxrIgygXOVzTkxcCnFc0gPDNNMkoMv/VZdTNG1GwzqLPKNrCUWzgAn4vs3HwqKcNaPL/LTD9jrbpaT2rg6up0zuOHlwx07XMkBed7EJHCv4FFEM7wZcXU+RlvqhqEgSyET9LYLl8ZsV4a4DhnxoHzEXU8BMCykCt4daoO8baCBBduiqmvwyOGW8oH+buPOcpmB8f4ZkUOx3ii3y8A4FA8BlI2tYiinT3aljUMxgSTP3J6Ppf332XPRg0J+S9aFnafH874rtsbR5eGpFA0S0crzWpJ1P/8tSO2SMcVGDwWq8g2WraHd24vP1+4S30 wcuIgEPC qMrQYGQtGZtge7nihDlGyxWGvKt01cLOZNOz9SoAJr+tig0yUy1XFOyqTrHDwouIBw+SscpH2H+glqtTYYBwZJdRPCg6VYXEF1eqr1xAIPvTUODqXK+l/sGOr34Gv7OcWwARrE+JonK9NMoSPGu9GHZ+uGylHJPkgcmV+7IeWi5FPeFM1ufHcZDnK+cZhbR1vm4aP3qs3A1qyJ6FOBt29P8z29pGd4QytN97ABML0CzbT2bRn9SGB7uOg4cMscX2Y6VIFkk4X7HMkBhCQYgpDuAhbMBs9rqU06+rqUp0lT8nO1i0lSi+E4YiKDFH8vNbTdIucQVsUs0fGWV22/+t9sadcw27fz7cD1Ex3Q8EFfF4r3ETaeq4/F/hRy4q3RQWJCeMHW+AKmz8SJ2ahYfXdSDLrDngPImg2nfK5Svac9oFoJoF6koOPfjvCxktpMaikGl9dABZzLlmXrmrvaeb0IC70jfM+eZa6ZJMIz8qwGx66GJXtoslgB8I+/yo7bvxjRuW4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The patch below does not apply to the v5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 281dd25c1a018261a04d1b8bf41a0674000bfe38 Mon Sep 17 00:00:00 2001 From: Matt Fleming Date: Fri, 11 Oct 2024 13:07:37 +0100 Subject: [PATCH] mm/page_alloc: let GFP_ATOMIC order-0 allocs access highatomic reserves Under memory pressure it's possible for GFP_ATOMIC order-0 allocations to fail even though free pages are available in the highatomic reserves. GFP_ATOMIC allocations cannot trigger unreserve_highatomic_pageblock() since it's only run from reclaim. Given that such allocations will pass the watermarks in __zone_watermark_unusable_free(), it makes sense to fallback to highatomic reserves the same way that ALLOC_OOM can. This fixes order-0 page allocation failures observed on Cloudflare's fleet when handling network packets: kswapd1: page allocation failure: order:0, mode:0x820(GFP_ATOMIC), nodemask=(null),cpuset=/,mems_allowed=0-7 CPU: 10 PID: 696 Comm: kswapd1 Kdump: loaded Tainted: G O 6.6.43-CUSTOM #1 Hardware name: MACHINE Call Trace: dump_stack_lvl+0x3c/0x50 warn_alloc+0x13a/0x1c0 __alloc_pages_slowpath.constprop.0+0xc9d/0xd10 __alloc_pages+0x327/0x340 __napi_alloc_skb+0x16d/0x1f0 bnxt_rx_page_skb+0x96/0x1b0 [bnxt_en] bnxt_rx_pkt+0x201/0x15e0 [bnxt_en] __bnxt_poll_work+0x156/0x2b0 [bnxt_en] bnxt_poll+0xd9/0x1c0 [bnxt_en] __napi_poll+0x2b/0x1b0 bpf_trampoline_6442524138+0x7d/0x1000 __napi_poll+0x5/0x1b0 net_rx_action+0x342/0x740 handle_softirqs+0xcf/0x2b0 irq_exit_rcu+0x6c/0x90 sysvec_apic_timer_interrupt+0x72/0x90 [mfleming@cloudflare.com: update comment] Link: https://lkml.kernel.org/r/20241015125158.3597702-1-matt@readmodwrite.com Link: https://lkml.kernel.org/r/20241011120737.3300370-1-matt@readmodwrite.com Link: https://lore.kernel.org/all/CAGis_TWzSu=P7QJmjD58WWiu3zjMTVKSzdOwWE8ORaGytzWJwQ@mail.gmail.com/ Fixes: 1d91df85f399 ("mm/page_alloc: handle a missing case for memalloc_nocma_{save/restore} APIs") Signed-off-by: Matt Fleming Suggested-by: Vlastimil Babka Reviewed-by: Vlastimil Babka Cc: Mel Gorman Cc: Michal Hocko Cc: Signed-off-by: Andrew Morton --- mm/page_alloc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 8afab64814dc4..94a2ffe280089 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -2893,12 +2893,12 @@ struct page *rmqueue_buddy(struct zone *preferred_zone, struct zone *zone, page = __rmqueue(zone, order, migratetype, alloc_flags); /* - * If the allocation fails, allow OOM handling access - * to HIGHATOMIC reserves as failing now is worse than - * failing a high-order atomic allocation in the - * future. + * If the allocation fails, allow OOM handling and + * order-0 (atomic) allocs access to HIGHATOMIC + * reserves as failing now is worse than failing a + * high-order atomic allocation in the future. */ - if (!page && (alloc_flags & ALLOC_OOM)) + if (!page && (alloc_flags & (ALLOC_OOM|ALLOC_NON_BLOCK))) page = __rmqueue_smallest(zone, order, MIGRATE_HIGHATOMIC); if (!page) { -- 2.43.0