From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 969D0D36129 for ; Wed, 6 Nov 2024 02:12:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 360376B00A9; Tue, 5 Nov 2024 21:12:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E9616B00AA; Tue, 5 Nov 2024 21:12:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18B1C6B00AB; Tue, 5 Nov 2024 21:12:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EBE866B00A9 for ; Tue, 5 Nov 2024 21:12:05 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A3D96C1A61 for ; Wed, 6 Nov 2024 02:12:05 +0000 (UTC) X-FDA: 82754044002.30.224FE9B Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf19.hostedemail.com (Postfix) with ESMTP id C05921A0014 for ; Wed, 6 Nov 2024 02:11:21 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Re+NKPPn; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of sashal@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sashal@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730858955; a=rsa-sha256; cv=none; b=tJfVs3Uf688akC+lUcmEHIWY8EJzmXtwA2mrS+kKCJ+As2wtTeq1mxIhtaUzkAu9M6xsV9 RSqYTyH67qhKMMKaARif3/S28+MEY1KeL5kdMk0W9Nd/k2hOBV5G27vjYpTbHK5wKCyWSP lPhHtOhdWXX+xHb+ALwY0ql0STW1NGQ= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Re+NKPPn; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of sashal@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sashal@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730858955; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=3zwUwGZN/5hygbexfJwjCC9QcVXwE4Jlnqb2FQjZHtk=; b=HgbeDMf9dweEsP42+RBXiNQgYiaJPmHuCNvbACCvzuAb7+3XeIOCjRPSwoyZeBhGiNt5Ag unTgNbI2Bfj/jlm7Sxv29DUKqbkTKJ9OrShQwgggaG0Hg9sUnBE7VnJmnFINB6i/6V6aCh KvLWHraqgIEobUmm0kFRbX8Mx2nVU4w= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 849ECA419B9; Wed, 6 Nov 2024 02:10:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76676C4CECF; Wed, 6 Nov 2024 02:12:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730859123; bh=s5pww47MAPQozDd3hmUkgIR6Hr/gQ7mIcYl+0/uI4GI=; h=From:To:Cc:Subject:Date:From; b=Re+NKPPnxVkQ8Sg8s8amQSLcBf+uJuStJvg83w5z26BoYEEzFF2y2W/ejIbXikUlq iXyLw7PgKI/8kfHa26udxWaWd4htAh6LeXPsGQNBsC+y/zR47i9Cra/JFcmZ1tJkCw 7daCJEyHN0Xn0878mDqdHgKqVGk6Sk19xTZFDmA4NmDO9CWsVmMjo2R8/8Hvfn7Ple ad53oQEYdsOuM0ci6a5pFWjOrIYGB0gMZbARMnC6MPZKLkOE+hPrAyyz9vrduC+udi EyQSfhBGl4nQ+18EdwXPaVDXKRmRpv46DVAaRQnwdarkWcu8CK10GRUDAxElvmBE3q D6p4HlZdzJb7A== From: Sasha Levin To: stable@vger.kernel.org, gourry@gourry.net Cc: Yang Shi , Davidlohr Bueso , Shakeel Butt , "Huang, Ying" , Oscar Salvador , Dave Hansen , Wei Xu , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: FAILED: Patch "vmscan,migrate: fix page count imbalance on node stats when demoting pages" failed to apply to v5.15-stable tree Date: Tue, 5 Nov 2024 21:11:59 -0500 Message-ID: <20241106021159.182619-1-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Patchwork-Hint: ignore X-stable: review Content-Transfer-Encoding: 8bit X-Stat-Signature: 6qigi7hruo5qyngg9f8yrrnzcq59tfzq X-Rspamd-Queue-Id: C05921A0014 X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1730859081-962126 X-HE-Meta: U2FsdGVkX1+cdfOfwrV/B8q7P0zMoF7Z9feDex9hHDSP41AtXvvYi24Pnel3XGwZEIY7lLx826BLTaB6b12kYIQZjiH4QBQL9H3Z1u8QCY3gxqghAAu5MIm/omAE7GkJDBeidCQhILOBq7SO6zXFfxj38mAx3zA2K6M8puGfB5xdo5h5aW8FZOR2JE17OLSUn+/0vmzmk9e35qtV3DFQxK99PNl0tWRsaTl/BkfLPP7H7l5BytD00bLUVjZDR5YnIVue0xvDupzwBS0UL6NCIpnaKMyOMa6G6KKk4f2ZO3urOHTgJLm8KdxWuksFGIPIM+nyPXiS8X+Te1piU5HRYGGJj/jfRjiO2AOwTZ1KSRSy7nHAy+GGhFpStJ03olZJWp+lXz75i38ttTCMwij9ZVtIPvkoo7fEEzgAt3xNEGd9MHrwNVE26/cclrKYNlmMjm5RColyGktOYB+OpFPUUNH9hDUrKGQDU2H9tnqjXEZ4IIL26WrOaDmATdTExrp7ISO0/PzFaaM6JCpoq8XzJHLwbMaX10cRK++fattuJXS/YQuWFwHlvRfix/ZUTQzmLITq8s/7BPEEI2iioObOVoBimvDeg9/0H828de7A0qh4hJY/pIZT27bpqwr2aOr5F0I6aRX20jO9yWf6M3JJEOPubShVy/0FS7KL9SBDbe3AZSB7ZGwhBxObL6njQRI+o0f6B6U9279z8ba8OsT+/nEnpWhSLksz1ORCw54zB95IPmoxF7lF/+UOdNZHDtZSlm9oVGxGKwa5SQJv4umbzHFcfFXKhzABitszPTZ5S+P7JaEKsUfr9N5LpU/s/pw4gRPZaRbdp1rbCOttj7b1eSFN1GLS7DaDVvCPVRwN8HYCLTipujiLJvwe88omMPw8vJU7PceXzD3nqC2SCnBHnmYCxzc/UPI8DbYH7H/uar23Zwv7uQgr6wGWJW3U61PsinPCVZ82pBBmdUpynoz sW+3goNW vy2QEqYAJGHs2EWNulbgLV+oLAcK4n/oU3UcJLOSeI8jwFfPlcONzDo4q/i/e1f/JRkRRBOYoqER2HOhoW+997Ly+w+CfjaC1Ont2p7dNjxo79N5F0a1TzDCROfiigryiVIwI7QN81gfMwVta41jZ3lI/QwwKbuExmatVbWqMQlcohz8NOY6961k2FxThMFY1IaYNA7ppNNOOC5yGPkZsCM22IEYIm8epHhDa7fS2B9UmjFZbPV20GsIwn2DxNHMTWVAS6bu5lMsNwPwGjJpZVsgpg4nONgOF3gvtxWu8MxFrabJoauX6i/MNSQd/fVQwf9cKFsAJLaHy9v/8/yFmsEPsN52/BeMjFEAxnXebQzVtNYIFpu6MR1OTIHBYbANaHWj9ykgMs/QbCgenpZmwNjtCbs7N3VdyUMEeM2gOk7mz2UdlZAkbJcs7JkU7cbfOF4Q1aHvWcUVoIIFZToZ6hLZgMWfzrPMwTTZT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The patch below does not apply to the v5.15-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 35e41024c4c2b02ef8207f61b9004f6956cf037b Mon Sep 17 00:00:00 2001 From: Gregory Price Date: Fri, 25 Oct 2024 10:17:24 -0400 Subject: [PATCH] vmscan,migrate: fix page count imbalance on node stats when demoting pages When numa balancing is enabled with demotion, vmscan will call migrate_pages when shrinking LRUs. migrate_pages will decrement the the node's isolated page count, leading to an imbalanced count when invoked from (MG)LRU code. The result is dmesg output like such: $ cat /proc/sys/vm/stat_refresh [77383.088417] vmstat_refresh: nr_isolated_anon -103212 [77383.088417] vmstat_refresh: nr_isolated_file -899642 This negative value may impact compaction and reclaim throttling. The following path produces the decrement: shrink_folio_list demote_folio_list migrate_pages migrate_pages_batch migrate_folio_move migrate_folio_done mod_node_page_state(-ve) <- decrement This path happens for SUCCESSFUL migrations, not failures. Typically callers to migrate_pages are required to handle putback/accounting for failures, but this is already handled in the shrink code. When accounting for migrations, instead do not decrement the count when the migration reason is MR_DEMOTION. As of v6.11, this demotion logic is the only source of MR_DEMOTION. Link: https://lkml.kernel.org/r/20241025141724.17927-1-gourry@gourry.net Fixes: 26aa2d199d6f ("mm/migrate: demote pages during reclaim") Signed-off-by: Gregory Price Reviewed-by: Yang Shi Reviewed-by: Davidlohr Bueso Reviewed-by: Shakeel Butt Reviewed-by: "Huang, Ying" Reviewed-by: Oscar Salvador Cc: Dave Hansen Cc: Wei Xu Cc: Signed-off-by: Andrew Morton --- mm/migrate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/migrate.c b/mm/migrate.c index 7e520562d421a..fab84a7760889 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -1178,7 +1178,7 @@ static void migrate_folio_done(struct folio *src, * not accounted to NR_ISOLATED_*. They can be recognized * as __folio_test_movable */ - if (likely(!__folio_test_movable(src))) + if (likely(!__folio_test_movable(src)) && reason != MR_DEMOTION) mod_node_page_state(folio_pgdat(src), NR_ISOLATED_ANON + folio_is_file_lru(src), -folio_nr_pages(src)); -- 2.43.0