From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62171D35E5D for ; Wed, 6 Nov 2024 02:10:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D71AC6B00A1; Tue, 5 Nov 2024 21:10:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CFA546B00A2; Tue, 5 Nov 2024 21:10:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B520D6B00A3; Tue, 5 Nov 2024 21:10:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8F42F6B00A1 for ; Tue, 5 Nov 2024 21:10:20 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 36845121328 for ; Wed, 6 Nov 2024 02:10:20 +0000 (UTC) X-FDA: 82754039634.12.0FE7413 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf15.hostedemail.com (Postfix) with ESMTP id EF7E6A0005 for ; Wed, 6 Nov 2024 02:09:43 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PU47tdYs; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of sashal@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sashal@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730858850; a=rsa-sha256; cv=none; b=VIKdXJNXJ/a/R19zwk1/qOOqHjSHCPUzdtU9CgWmOCmLXqQiC2QwX5R3542aRLbbtIVJMh GN9CCtcKAiOXYraB2cex/pW4c7ayIxbrZwS56nqAwturZKo49NSC48OBva8NhMix0OSC7f ESV2rZ6kU8NySatNaWkUT2n6Vb4HtUs= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PU47tdYs; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of sashal@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sashal@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730858850; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=EVXOJb9G0f4czY/huB9aToVFmK+ZVFUND3xR+Jbd8ho=; b=Fv6N+Xovbaj+OiqlrOocwHcK3QuChX71ooesfndYYaB2YLALMJCZIEUoCZEw+ijivFj8s0 OLuHbWkP+OJ359IveK5dhKiX1ChSo2/dCatQg2UnIqezwiPdqU+/3aVxufa7tm5EH8Gh8L K45tMb0n1lE8vAnUbJGKcVjEA7ES76w= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id D3E6BA41BDB; Wed, 6 Nov 2024 02:08:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 689E7C4CECF; Wed, 6 Nov 2024 02:10:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730859017; bh=SN/F7j50A1cjRLVeVc+cJ+1ynHn5Rvk8WoMVzF1nZis=; h=From:To:Cc:Subject:Date:From; b=PU47tdYsb6+KapFzmI0HtgWNAkfRHWJH4bGnlcZRinsGGXLMuX5TFZxK4IqaZvxtG B2ghdz36t0lYGcowpBGEjhshiS08v16K5z76tn4cZEhZPQ9e16CqiZZJ/JIXamyFLQ 5uEtPx+JFiC1GzPLNaKzOblKHHRpbflowDyhqNs343RPXUaEm1oZ9+LdaFWD6gcwM5 VPYQVtwHclX4+vtSF0zF4/XtYhDdHw6Mus9lD2sUGdDruzSnzTPkyUrxcS0CahCkl+ folCivwsjC69DioWvyzKv8VkCbuwQbDj+6FjnrQ4CBDp/ahOkbgZECARXAAI5ySRYO ZJZGE/zhlWi9A== From: Sasha Levin To: stable@vger.kernel.org, aha310510@gmail.com Cc: syzbot , Hugh Dickins , Yu Zhao , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: FAILED: Patch "mm: shmem: fix data-race in shmem_getattr()" failed to apply to v6.1-stable tree Date: Tue, 5 Nov 2024 21:10:14 -0500 Message-ID: <20241106021014.179357-1-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Patchwork-Hint: ignore X-stable: review Content-Transfer-Encoding: 8bit X-Stat-Signature: u1gm6bbcjy6wj5suqhsbmzcu8m8q6ozh X-Rspamd-Queue-Id: EF7E6A0005 X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1730858983-778370 X-HE-Meta: U2FsdGVkX1/fWBsT23NlObrMRBJcAOdEyX6KPCzLKsaEo6L6YbC/45ECHjh+prWX65yvHS5uTH5oo0YSO5QmPaLf4yY2MDLosSPUV5x3iua8l2Uu/e537s4mjAmxa3arPWo/ydgR2eXlvIKrzMoEWX4kOdohRZVY8Qo3SzswfBAwrudImeeubLopS5t3b9zSwEr3Y/Ocore9ZUslYlRbjAxijw5JqeQmiI3Ljppa+12F6hXBbq+Rkw7822OftUvDLeL142+UBc4zVGzkWc6CRfj2DN5yR+mAJTwrA8S5/wTTzHQI+22kAVPMxJJGuSUN3JCv+LbxNKKmWFUV28DhwkHE/njekHyzd4FisihNYKaHoMQIWcYR4NAeFP4v6VCTCG30LHAwcEJ9GUQCMmkQNGfqIgbAgV/GP7rg7RVeiaS1vCoMWeMYOtlmsiDNV0ddVepBr/zyINeqkOOVfCKT342oSpO/4xu9XfMWyLjtCDT72Ak7gf0hdITtIF7vCaDVYALL1cjToronwi6mnq2Cjedy99AjD7Lz9Gb7o0hInLsoskwLwwIGDwy1HdUKp7CrHfklJPMsHy6YdYS/afujA2/QaJATM1U6nXPFxS6B5Btu52VhyEu5Ttd7zj6JqHJTvCM2H8bYm6ljXIbK7p9VfwQ6WEmBJ9imoKc6kYsCimk21LQTxP3KFFKWubYUa3jUMFEU1ILBBz3e8g1XK+gWHbCmeGMUNh8KxeGImQ0bThdDh34SkhiZCfIgykJfPqxbz+tHm4keQDMhiFrryUQcMOAo5NLBCfh6nJMrLDZ7jPR25F3/5MNWKJU22YoD91Laea9PNg2DatZvjbH/6WEyaex+zU7pqMkTVQ9NkIzg3NsJ1AcWTLGxmzPEUVns1OtugL9uTKreKcn+LxvVl+ujPUcIumVS0Y6SXM4Yeh6D/u3D4yNKGMcVzqJ+1WHN4gVA+mh0ehNgClPcpR72bam tgEM37HD +Twh+Ky0MYm3XEqEDmXEh9K8u6AXBaxdnmf3RBnvJL/NefhzFF6LAEJiyypOTb/C26tA95xzDzeS30yItz0Xyik/KNe3MqUn99u6LQzVdByaS8/x6v1Yy9oYH3IdnuTwJ8L4faiIZoE0b8IvQIS9+6mthwQUqIi2f8k48vHYKwduDIcWsoLBfQVn6jgpqvcbEPNRwWqyiRVJ73KzKakzmZQcCCBRdCXzarvPw9S3c9SULqExsz6+XYV0RTc6RS2zgY5cMuupAdckar0gvTRnQoMuE2EZXAZEyRmij5beVMHgil/NJwNi4aSmAgOF/sBRkMgFl7CfPyqbnKXLJXMOWWuEMyzW2ymH83tQZRb2LcF/uOfPXGa5AZXD6bTY4bSDTl4sFSmNO5R0YSTiX7hDZO1W3AzR3u1BwZ4KsRJ/pNjtDJcqYLAOrh9R9p3WDoKeOHHE9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The patch below does not apply to the v6.1-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From d949d1d14fa281ace388b1de978e8f2cd52875cf Mon Sep 17 00:00:00 2001 From: Jeongjun Park Date: Mon, 9 Sep 2024 21:35:58 +0900 Subject: [PATCH] mm: shmem: fix data-race in shmem_getattr() I got the following KCSAN report during syzbot testing: ================================================================== BUG: KCSAN: data-race in generic_fillattr / inode_set_ctime_current write to 0xffff888102eb3260 of 4 bytes by task 6565 on cpu 1: inode_set_ctime_to_ts include/linux/fs.h:1638 [inline] inode_set_ctime_current+0x169/0x1d0 fs/inode.c:2626 shmem_mknod+0x117/0x180 mm/shmem.c:3443 shmem_create+0x34/0x40 mm/shmem.c:3497 lookup_open fs/namei.c:3578 [inline] open_last_lookups fs/namei.c:3647 [inline] path_openat+0xdbc/0x1f00 fs/namei.c:3883 do_filp_open+0xf7/0x200 fs/namei.c:3913 do_sys_openat2+0xab/0x120 fs/open.c:1416 do_sys_open fs/open.c:1431 [inline] __do_sys_openat fs/open.c:1447 [inline] __se_sys_openat fs/open.c:1442 [inline] __x64_sys_openat+0xf3/0x120 fs/open.c:1442 x64_sys_call+0x1025/0x2d60 arch/x86/include/generated/asm/syscalls_64.h:258 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0x54/0x120 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x76/0x7e read to 0xffff888102eb3260 of 4 bytes by task 3498 on cpu 0: inode_get_ctime_nsec include/linux/fs.h:1623 [inline] inode_get_ctime include/linux/fs.h:1629 [inline] generic_fillattr+0x1dd/0x2f0 fs/stat.c:62 shmem_getattr+0x17b/0x200 mm/shmem.c:1157 vfs_getattr_nosec fs/stat.c:166 [inline] vfs_getattr+0x19b/0x1e0 fs/stat.c:207 vfs_statx_path fs/stat.c:251 [inline] vfs_statx+0x134/0x2f0 fs/stat.c:315 vfs_fstatat+0xec/0x110 fs/stat.c:341 __do_sys_newfstatat fs/stat.c:505 [inline] __se_sys_newfstatat+0x58/0x260 fs/stat.c:499 __x64_sys_newfstatat+0x55/0x70 fs/stat.c:499 x64_sys_call+0x141f/0x2d60 arch/x86/include/generated/asm/syscalls_64.h:263 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0x54/0x120 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x76/0x7e value changed: 0x2755ae53 -> 0x27ee44d3 Reported by Kernel Concurrency Sanitizer on: CPU: 0 UID: 0 PID: 3498 Comm: udevd Not tainted 6.11.0-rc6-syzkaller-00326-gd1f2d51b711a-dirty #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024 ================================================================== When calling generic_fillattr(), if you don't hold read lock, data-race will occur in inode member variables, which can cause unexpected behavior. Since there is no special protection when shmem_getattr() calls generic_fillattr(), data-race occurs by functions such as shmem_unlink() or shmem_mknod(). This can cause unexpected results, so commenting it out is not enough. Therefore, when calling generic_fillattr() from shmem_getattr(), it is appropriate to protect the inode using inode_lock_shared() and inode_unlock_shared() to prevent data-race. Link: https://lkml.kernel.org/r/20240909123558.70229-1-aha310510@gmail.com Fixes: 44a30220bc0a ("shmem: recalculate file inode when fstat") Signed-off-by: Jeongjun Park Reported-by: syzbot Cc: Hugh Dickins Cc: Yu Zhao Cc: Signed-off-by: Andrew Morton --- mm/shmem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/shmem.c b/mm/shmem.c index c5adb987b23cf..4ba1d00fabdaa 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -1166,7 +1166,9 @@ static int shmem_getattr(struct mnt_idmap *idmap, stat->attributes_mask |= (STATX_ATTR_APPEND | STATX_ATTR_IMMUTABLE | STATX_ATTR_NODUMP); + inode_lock_shared(inode); generic_fillattr(idmap, request_mask, inode, stat); + inode_unlock_shared(inode); if (shmem_huge_global_enabled(inode, 0, 0, false, NULL, 0)) stat->blksize = HPAGE_PMD_SIZE; -- 2.43.0