From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 275B9D1CA3A for ; Tue, 5 Nov 2024 06:45:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C7CC6B0098; Tue, 5 Nov 2024 01:45:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 678776B0099; Tue, 5 Nov 2024 01:45:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53F4E6B009B; Tue, 5 Nov 2024 01:45:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 327E96B0098 for ; Tue, 5 Nov 2024 01:45:18 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C78341A0F14 for ; Tue, 5 Nov 2024 06:45:17 +0000 (UTC) X-FDA: 82751103204.08.F219187 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by imf11.hostedemail.com (Postfix) with ESMTP id 9F86540014 for ; Tue, 5 Nov 2024 06:44:34 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Nd1VRjss; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf11.hostedemail.com: domain of lkp@intel.com designates 192.198.163.7 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730788993; a=rsa-sha256; cv=none; b=O3Ihmh1/TugupUIdf/kvsx4dbL1ZosGOsX04qjNnesNYVq6YYHFzsUGgX4tWfNwlhZYHqV mdMGXeQmwsaVfV9ttqpklQfTkwB6P8M8gmwIzJVjgFNdV39F4HdM2qtaBr9105yCgYCJgc +GC8CzqJHNfw86FzlJIvBq7Ma5oNSzQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Nd1VRjss; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf11.hostedemail.com: domain of lkp@intel.com designates 192.198.163.7 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730788993; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6UfZGHJZa44s4M19ExOFhqu9/RGrliNx6kddfzCFjDo=; b=a/mdA+FObgC6Q6wowm90hLsoov/TlRZruA0bQGD7vZvjUldGpPmgkaRkXM73g+1RYBnZ4j zop9v1hDynQydMnzOh/nGi6ygV+Eah33SCCm+IrZc4BSet6I8GyTE+MHpJe/8NiWjhf+6I 3SDF4ribQnr2BwglpnQG+Y/KQ0ghQYw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730789115; x=1762325115; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HnRLlzYKPDHFqQcA6nesvQKWwD+lCsYk536ldKLd+fM=; b=Nd1VRjsswypI6Gfhv1kxdzDdB1AHyimlP4m9utKIXoVGzqE0T9v5AjKM ueUjDhAYAniqx55+nJ8RRflJ+Ukggp2IACmlbt6eCDENdH8jCdXim4nta ls6RgIORLzWxawEVHGacsbt+CSARn1jJL0rGLlFDGH+3bdIjnqyppZZth VlmcCFYc7CLfPOMyQ05+1AvC6XdFIG8VgqWX8WqYxAuAQPTI25s/K+hzt 859M4K+ElahjBYMYIHZZn+Yes5M5caqpmV8YMRup9QpDd0cfhkr9hilF6 bH2iU66w+CHCCFv76tiqiOEiOgJdBjAtrXR4mKv8eN1ROuzhq8+eVsQsC w==; X-CSE-ConnectionGUID: 2m8vpgXKQjiHSvHzFdTqFg== X-CSE-MsgGUID: gOlx3WdyQeWM6WmPNKjNig== X-IronPort-AV: E=McAfee;i="6700,10204,11246"; a="55917526" X-IronPort-AV: E=Sophos;i="6.11,259,1725346800"; d="scan'208";a="55917526" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2024 22:45:13 -0800 X-CSE-ConnectionGUID: Hjc4h4/XQdS87HpuHl5KNw== X-CSE-MsgGUID: ht/tApraRjenOm3mZHbyjQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,259,1725346800"; d="scan'208";a="88711450" Received: from lkp-server01.sh.intel.com (HELO a48cf1aa22e8) ([10.239.97.150]) by orviesa005.jf.intel.com with ESMTP; 04 Nov 2024 22:45:09 -0800 Received: from kbuild by a48cf1aa22e8 with local (Exim 4.96) (envelope-from ) id 1t8DJL-000liz-1X; Tue, 05 Nov 2024 06:45:07 +0000 Date: Tue, 5 Nov 2024 14:44:56 +0800 From: kernel test robot To: Keren Sun , akpm@linux-foundation.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, roman.gushchin@linux.dev, hannes@cmpxchg.org, mhocko@kernel.org, shakeel.butt@linux.dev, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Keren Sun Subject: Re: [PATCH 4/4] mm: Replace simple_strtoul() with kstrtoul() Message-ID: <202411051411.1N0Ziqjh-lkp@intel.com> References: <20241104222737.298130-5-kerensun@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241104222737.298130-5-kerensun@google.com> X-Rspamd-Queue-Id: 9F86540014 X-Stat-Signature: t3yon9kwj4bgksujur96ywiek9nb7ush X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1730789074-533938 X-HE-Meta: U2FsdGVkX1+3hMM8ys7CeufowWwE6AUrcwbyGHn2yZoIR/hA/S956C3g1jXlqNC82C3H4OYmzbkcKvGh7cl20ejAGmT6vCLjZIm951hfZDx2ZBChlC5IkK5YHmC6hCDBZsBUhO5Gd6y7LdPaV4GZ+P5ZI+UqajBkI4kRP2x9KB5B1m3Sl04QmyfpPaxfTXBTaIYTBzIgh4gSbO5BtVmKzMI++RqURYbqdoEvN9YhQN5qWWzHh3d2luUmxkl3d25dMeNXMq9Tbts6IDZEe2/zirzB8ABjv/36x9cMACd0s0Vxhh9UKvnCGi324oV92o9kDCe9PSHm2dGb/sd3M/ePTTdcP/lzM62i0Sr5RQw1yTLZezXhwQLlJ+5qvUzf/mMy0L5s2YOKXbrRiQlMRnz44utNCi277APuUUarfMKzH6Fyed2KVOWD+0vq0GlMkC3cj9wRhS24t3fFfQtlSDiQG6ODc9rEYNh8H6f2HmUkNwYglv6crV5qANEakg0+XsNpBTHsSL44I2ASfT9c5LfOcFeXSOAobz2Jxf5tMjzU5eDp0x4oS6PtwfvPRqjeoVSxdvIeSGPOln8tBXN69hHCa02NaQSd1tb32Zo3UgnPkvpK1PQ7treHLa9u6jXHMQ2IzYZjvOZsmOOUVGIAGHC1AEZQoa9S6yoZn2JfPi3GNVA5CwphnI4Niv1n871vt0WVlNBR0SPtKA7xeNooOwtQq1k45IRhsHX2woKK9TjuRG7nere4g88KSOK8gogCjiYHeSBkeZbdbVkZBdbYkQSo6P8k2n0oCHAp8dRFt5OracWsWJ4mMOk0XpOj20E5TawqOn00OzgHUME2aVsPJXCHjwSshtjYCC6HkLOdYF45Xdot+tdAUDHGcXuejzb/K18cKnxJ0wp2zkWYlYmdFKLhkCMb4TzN1Gc91CsprtKZQJikxgvNgyPkz/1QPqYJOAW4JWzyOu1MzOqbpSvBj1C SvrBjEq5 cxPiHkV7/5ojSt2beMteUEbXqJQ/Rye8EFXGOGmyWB0OGTkxhCwpcKFB0sMMBIYjwCjJ7bryoJutLG7WEhRhWUzQUul5CVSuK2DI5/DVcQheiusCFA27CUBcHGvn0rthgAfbW9gg3r9km1ia+IGskf/THNawd3oxXjnDiffZn1WeoFWqj20tgZyNz8oosF4r6DzKfexx7jN9qM3mzO03q1lV/b22wYdKkAhbPt+gQmWaONt8+X+swj4BLa35rOg9UkLAqw19qvcFBmT3eMANVkb0rGXVet3sTLf1RYRp5wdq5/CNrnOP1gIgv4HPlvP4EVXe6vDcB6spCkSMKAK1tmGTtLpRK1v611Se2RSZ6NUKkopJKw0XjbtyoMBXZVSg09L103d1KaEvWcJO7XqHB2pArHwicfYBX3yVgQ//yhWrKYkUnLQRoxx6wPogCHRllfRcoemRWVBJwgeMGsoJ/ECw7wvP6XpEAtHqLBqwVqX8+Yss= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Keren, kernel test robot noticed the following build errors: [auto build test ERROR on v6.12-rc6] [also build test ERROR on linus/master] [cannot apply to akpm-mm/mm-everything next-20241104] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Keren-Sun/mm-fix-quoted-strings-spliting-across-lines/20241105-063007 base: v6.12-rc6 patch link: https://lore.kernel.org/r/20241104222737.298130-5-kerensun%40google.com patch subject: [PATCH 4/4] mm: Replace simple_strtoul() with kstrtoul() config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20241105/202411051411.1N0Ziqjh-lkp@intel.com/config) compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241105/202411051411.1N0Ziqjh-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202411051411.1N0Ziqjh-lkp@intel.com/ All error/warnings (new ones prefixed by >>): In file included from mm/memcontrol-v1.c:4: In file included from include/linux/memcontrol.h:21: In file included from include/linux/mm.h:2213: include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 504 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 505 | item]; | ~~~~ include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 511 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 512 | NR_VM_NUMA_EVENT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~~ include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 524 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 525 | NR_VM_NUMA_EVENT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~~ In file included from mm/memcontrol-v1.c:6: include/linux/mm_inline.h:47:41: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 47 | __mod_lruvec_state(lruvec, NR_LRU_BASE + lru, nr_pages); | ~~~~~~~~~~~ ^ ~~~ include/linux/mm_inline.h:49:22: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 49 | NR_ZONE_LRU_BASE + lru, nr_pages); | ~~~~~~~~~~~~~~~~ ^ ~~~ >> mm/memcontrol-v1.c:1926:20: error: incompatible integer to pointer conversion passing 'unsigned int' to parameter of type 'unsigned long *' [-Wint-conversion] 1926 | kstrtoul(buf, 10, efd); | ^~~ include/linux/kstrtox.h:30:90: note: passing argument to parameter 'res' here 30 | static inline int __must_check kstrtoul(const char *s, unsigned int base, unsigned long *res) | ^ >> mm/memcontrol-v1.c:1926:2: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result] 1926 | kstrtoul(buf, 10, efd); | ^~~~~~~~ ~~~~~~~~~~~~ mm/memcontrol-v1.c:1931:20: error: incompatible integer to pointer conversion passing 'unsigned int' to parameter of type 'unsigned long *' [-Wint-conversion] 1931 | kstrtoul(buf, 10, cfd); | ^~~ include/linux/kstrtox.h:30:90: note: passing argument to parameter 'res' here 30 | static inline int __must_check kstrtoul(const char *s, unsigned int base, unsigned long *res) | ^ mm/memcontrol-v1.c:1931:2: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result] 1931 | kstrtoul(buf, 10, cfd); | ^~~~~~~~ ~~~~~~~~~~~~ mm/memcontrol-v1.c:1918:8: warning: unused variable 'endp' [-Wunused-variable] 1918 | char *endp; | ^~~~ mm/memcontrol-v1.c:2606:48: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 2606 | nr += lruvec_page_state(lruvec, NR_LRU_BASE + lru); | ~~~~~~~~~~~ ^ ~~~ mm/memcontrol-v1.c:2608:54: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 2608 | nr += lruvec_page_state_local(lruvec, NR_LRU_BASE + lru); | ~~~~~~~~~~~ ^ ~~~ mm/memcontrol-v1.c:2624:46: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 2624 | nr += memcg_page_state(memcg, NR_LRU_BASE + lru); | ~~~~~~~~~~~ ^ ~~~ mm/memcontrol-v1.c:2626:52: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 2626 | nr += memcg_page_state_local(memcg, NR_LRU_BASE + lru); | ~~~~~~~~~~~ ^ ~~~ 13 warnings and 2 errors generated. vim +1926 mm/memcontrol-v1.c 1897 1898 /* 1899 * DO NOT USE IN NEW FILES. 1900 * 1901 * Parse input and register new cgroup event handler. 1902 * 1903 * Input must be in format ' '. 1904 * Interpretation of args is defined by control file implementation. 1905 */ 1906 static ssize_t memcg_write_event_control(struct kernfs_open_file *of, 1907 char *buf, size_t nbytes, loff_t off) 1908 { 1909 struct cgroup_subsys_state *css = of_css(of); 1910 struct mem_cgroup *memcg = mem_cgroup_from_css(css); 1911 struct mem_cgroup_event *event; 1912 struct cgroup_subsys_state *cfile_css; 1913 unsigned int efd, cfd; 1914 struct fd efile; 1915 struct fd cfile; 1916 struct dentry *cdentry; 1917 const char *name; 1918 char *endp; 1919 int ret; 1920 1921 if (IS_ENABLED(CONFIG_PREEMPT_RT)) 1922 return -EOPNOTSUPP; 1923 1924 buf = strstrip(buf); 1925 > 1926 kstrtoul(buf, 10, efd); 1927 if (*buf != ' ') 1928 return -EINVAL; 1929 buf++; 1930 1931 kstrtoul(buf, 10, cfd); 1932 if (*buf == ' ') 1933 buf++; 1934 else if (*buf != '\0') 1935 return -EINVAL; 1936 1937 event = kzalloc(sizeof(*event), GFP_KERNEL); 1938 if (!event) 1939 return -ENOMEM; 1940 1941 event->memcg = memcg; 1942 INIT_LIST_HEAD(&event->list); 1943 init_poll_funcptr(&event->pt, memcg_event_ptable_queue_proc); 1944 init_waitqueue_func_entry(&event->wait, memcg_event_wake); 1945 INIT_WORK(&event->remove, memcg_event_remove); 1946 1947 efile = fdget(efd); 1948 if (!fd_file(efile)) { 1949 ret = -EBADF; 1950 goto out_kfree; 1951 } 1952 1953 event->eventfd = eventfd_ctx_fileget(fd_file(efile)); 1954 if (IS_ERR(event->eventfd)) { 1955 ret = PTR_ERR(event->eventfd); 1956 goto out_put_efile; 1957 } 1958 1959 cfile = fdget(cfd); 1960 if (!fd_file(cfile)) { 1961 ret = -EBADF; 1962 goto out_put_eventfd; 1963 } 1964 1965 /* the process need read permission on control file */ 1966 /* AV: shouldn't we check that it's been opened for read instead? */ 1967 ret = file_permission(fd_file(cfile), MAY_READ); 1968 if (ret < 0) 1969 goto out_put_cfile; 1970 1971 /* 1972 * The control file must be a regular cgroup1 file. As a regular cgroup 1973 * file can't be renamed, it's safe to access its name afterwards. 1974 */ 1975 cdentry = fd_file(cfile)->f_path.dentry; 1976 if (cdentry->d_sb->s_type != &cgroup_fs_type || !d_is_reg(cdentry)) { 1977 ret = -EINVAL; 1978 goto out_put_cfile; 1979 } 1980 1981 /* 1982 * Determine the event callbacks and set them in @event. This used 1983 * to be done via struct cftype but cgroup core no longer knows 1984 * about these events. The following is crude but the whole thing 1985 * is for compatibility anyway. 1986 * 1987 * DO NOT ADD NEW FILES. 1988 */ 1989 name = cdentry->d_name.name; 1990 1991 if (!strcmp(name, "memory.usage_in_bytes")) { 1992 event->register_event = mem_cgroup_usage_register_event; 1993 event->unregister_event = mem_cgroup_usage_unregister_event; 1994 } else if (!strcmp(name, "memory.oom_control")) { 1995 pr_warn_once("oom_control is deprecated and will be removed. Please report your usecase to linux-mm-@kvack.org if you depend on this functionality.\n"); 1996 event->register_event = mem_cgroup_oom_register_event; 1997 event->unregister_event = mem_cgroup_oom_unregister_event; 1998 } else if (!strcmp(name, "memory.pressure_level")) { 1999 pr_warn_once("pressure_level is deprecated and will be removed. Please report your usecase to linux-mm-@kvack.org if you depend on this functionality.\n"); 2000 event->register_event = vmpressure_register_event; 2001 event->unregister_event = vmpressure_unregister_event; 2002 } else if (!strcmp(name, "memory.memsw.usage_in_bytes")) { 2003 event->register_event = memsw_cgroup_usage_register_event; 2004 event->unregister_event = memsw_cgroup_usage_unregister_event; 2005 } else { 2006 ret = -EINVAL; 2007 goto out_put_cfile; 2008 } 2009 2010 /* 2011 * Verify @cfile should belong to @css. Also, remaining events are 2012 * automatically removed on cgroup destruction but the removal is 2013 * asynchronous, so take an extra ref on @css. 2014 */ 2015 cfile_css = css_tryget_online_from_dir(cdentry->d_parent, 2016 &memory_cgrp_subsys); 2017 ret = -EINVAL; 2018 if (IS_ERR(cfile_css)) 2019 goto out_put_cfile; 2020 if (cfile_css != css) { 2021 css_put(cfile_css); 2022 goto out_put_cfile; 2023 } 2024 2025 ret = event->register_event(memcg, event->eventfd, buf); 2026 if (ret) 2027 goto out_put_css; 2028 2029 vfs_poll(fd_file(efile), &event->pt); 2030 2031 spin_lock_irq(&memcg->event_list_lock); 2032 list_add(&event->list, &memcg->event_list); 2033 spin_unlock_irq(&memcg->event_list_lock); 2034 2035 fdput(cfile); 2036 fdput(efile); 2037 2038 return nbytes; 2039 2040 out_put_css: 2041 css_put(css); 2042 out_put_cfile: 2043 fdput(cfile); 2044 out_put_eventfd: 2045 eventfd_ctx_put(event->eventfd); 2046 out_put_efile: 2047 fdput(efile); 2048 out_kfree: 2049 kfree(event); 2050 2051 return ret; 2052 } 2053 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki