From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3499E7716D for ; Thu, 5 Dec 2024 15:25:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D69F76B00A3; Thu, 5 Dec 2024 10:19:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A63A76B00B9; Thu, 5 Dec 2024 10:19:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1ADAF6B0100; Thu, 5 Dec 2024 10:19:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 48B446B008C for ; Tue, 5 Nov 2024 06:14:25 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D878881240 for ; Tue, 5 Nov 2024 11:14:24 +0000 (UTC) X-FDA: 82751781378.19.3EDD8BF Received: from forward101a.mail.yandex.net (forward101a.mail.yandex.net [178.154.239.84]) by imf30.hostedemail.com (Postfix) with ESMTP id 833F680019 for ; Tue, 5 Nov 2024 11:13:20 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=yandex.ru header.s=mail header.b=n8NUD6SU; dmarc=pass (policy=none) header.from=yandex.ru; spf=pass (imf30.hostedemail.com: domain of dmantipov@yandex.ru designates 178.154.239.84 as permitted sender) smtp.mailfrom=dmantipov@yandex.ru ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730805180; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=VkCUlBwbHpvqxpryuAIL9yfb2eN3wHf9AAGorb+LevM=; b=PImilVUwod0OggSiYM1rnEBjmPHge9aQ3fj2TWZJvW7QZo5tv29kvqEKXaNOA+4om7570P KhEtOqQoUgkzJwae7hEFLwC9it3zijhtcpuMbwP3cMTwLlIgBkXBPXZgQ0knLaqjWNJ1b2 VyMDHjQeRk3yEk/kdsUto+M9+3vrpLg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=yandex.ru header.s=mail header.b=n8NUD6SU; dmarc=pass (policy=none) header.from=yandex.ru; spf=pass (imf30.hostedemail.com: domain of dmantipov@yandex.ru designates 178.154.239.84 as permitted sender) smtp.mailfrom=dmantipov@yandex.ru ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730805180; a=rsa-sha256; cv=none; b=g5ct1yEnTc0xqZ0lned63r3BpaF37s4Q5rElcLw0N/xCA7UHbMG7qSQI9ysW9xvS7Vp8Xs ZIIxSCIWcdHrDhrsp6xRg3iH3bpCGex0DAeHkDlI1DL5Cx0HAY41chqS44mR9l8o4pw4Fn KEFgGwKrnEHdYl0oTctAGhX0p4zvX4Q= Received: from mail-nwsmtp-smtp-production-main-84.vla.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-84.vla.yp-c.yandex.net [IPv6:2a02:6b8:c15:2e15:0:640:bcf8:0]) by forward101a.mail.yandex.net (Yandex) with ESMTPS id 5F64A60DC3; Tue, 5 Nov 2024 14:14:20 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-84.vla.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id IEe9B37qB8c0-hxYvLQYY; Tue, 05 Nov 2024 14:14:19 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1730805259; bh=VkCUlBwbHpvqxpryuAIL9yfb2eN3wHf9AAGorb+LevM=; h=Message-ID:Date:Cc:Subject:To:From; b=n8NUD6SUZ6c33eErZQZ1syfDP25jIB2JFyQAbmnjaQw/5whUbpXtN9CJmTJoLhY+I xNIAioBfc7wmdNobSJrVLnmOEQ32lYnMQaQBCNsBG81IjSk2PUnP8NxfkaDO6zrTjN jl2BEjNidf3E6dfq1rTmzJ8qqGfc9nKQcfoRylWo= From: Dmitry Antipov To: Tycho Andersen Cc: Alexander Viro , Christian Brauner , Jan Kara , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, lvc-project@linuxtesting.org, Dmitry Antipov , syzbot+03e1af5c332f7e0eb84b@syzkaller.appspotmail.com Subject: [PATCH] exec: do not pass invalid pointer to kfree() from free_bprm() Date: Tue, 5 Nov 2024 14:13:44 +0300 Message-ID: <20241105111344.2532040-1-dmantipov@yandex.ru> X-Mailer: git-send-email 2.47.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 833F680019 X-Stat-Signature: 8k14uas7m68jbz3uqzuk6u7gtnn5nf5y X-HE-Tag: 1730805200-244508 X-HE-Meta: U2FsdGVkX19bWin025J/nallxHVn5svBRGEx6pMteFco2mVtZSskvQxqD7K7YYC1eWSTY2Yzd0D5AAfmupIR46k6qDP4LrZPasgMlBZ1gRPnY5E99xcNRVjT5j/nn76muftd//mSrQ9ABDysjpl9qdLxkfaoMrTG9Nq04t/r+YB2d0rii4dQ045y0K+zmJ6d14tjkopw/lKDeFOIYqCUE27bLBBVs3aq9Z97H9crwRTbHfAF18n796CFwgS/E0fQxWROSei9JiBLRhM1OR+Y4cp7fNS62JELgUZqO5LWroiqJOYE0yVUCUd/6ClsNIBwXUFiZ5XnfYXesdMpXJB3r5FFep/0t7M5GP3fo2nbPQ/PABsKUQR5Kh3tyu2PUs9vQPFVEsQpyMQrCwaD803krxHLHbHF/IGhWntCuEV3CWQ90F53b5TM6lapHLjPxXkjq81LRtsAE8lEsiZaoqodG0QyovgWPnfAa1Z0WWRAj9ExHhw9GvThvh8XQLQZj5TqdnYmWgOrq34NmkpkUrbsRgmQxOFxEIk8BmBKHRwfURdTakm1VTwDqp37Cf9XXzX8tUCodLxHIK7hvTvrnS0onX3XDlgpNbFcuNc+RREfcVIIr5nOJGpBMImrNGx5WYRUG+D3vOGlNN1C/UVVjw+cA9HcnDgGQkEOzujXDQ8z9P3K/DWmFch7z8wzkgO9NlZtULnryVVpmLPXp9NG0fMJxXLc/k4gfSOVp2k3D16R04GUs1SDg0sfBDkGycwH9IzX+BOZmXCcOCqHPN4c3BM9oSmqa/6xlBkavI7sJJWm3CEPVI8q8hDE5sbaiXSw7O0RPd3AOBoA+ADxdCGCFHelw0t5Wxm9PBfFRJ7eX9dTg6T5XEuQY8Systj+Xg7ELItE7SnmMOZPY1ECjxr9mUST09tvRj7gGcSpibtLRqgC+vW8HPLhZikj/AgwoFDTP4uGTytDj3437UX8tgSsgNy THimdEpX b0F9hPnl2ca9eAi7O3UE+oi565vY87lkFfgebV4/WzlJ/FLETosgtWLZe23oAWinAde2aOASD9A/r2z5KfZRELe0YXqUZCoBJPgRxs/Hkyo1PjTD2Nma2oJ9z1oqgCcCt3aOqKKqFDFYXyELC3uXJJTJG7Mbzy9CEw+xg0iDU0IqWRvQ7miCy9RryNAyjseE9qzWXZEAHk+jEAs72aatBcV2Xb1zydtTUB0vryYf7v7FzRQODKcvGCED99bWK4WQCRjqtMS3WwlvZNHas5XwTvdPeYTkHm55jxqCi6TZV+/Qm4NxVZygzW0+/hVqxp9e8rmJsxE9+ORQfpWPkVx61/dnLgVvNJlMiaai6AbFJRd7Uk7ZwbDEizuR3pIw7xBKEQFsBa3JtTkmiyJfjKuUOqNtz7NKJyzOlQ4bb2zYefCg71drzRL6YMTxDutrz4t3L6Zuv1AAxUz2jW3n4spEwu/z3oWHL29GVuCrBh426PT9gAMvZohKPQLkQLdqIKBAMNUIkTMMQxdk07qAeAcxH+/k+fb++e8O774I571T812gm5cuKZaydfHttkL4qPgEYA/7ariKpp/HViBIEnuwq+cg6YQzo4J3AZiDUNSpYaE+KgFwsyxG42PO2ZwOzDhurQIxK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Syzbot has reported the following BUG: kernel BUG at arch/x86/mm/physaddr.c:23! Oops: invalid opcode: 0000 [#1] PREEMPT SMP KASAN PTI CPU: 2 UID: 0 PID: 5869 Comm: repro Not tainted 6.12.0-rc5-next-20241101-syzkaller #0 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-3.fc41 04/01/2014 RIP: 0010:__phys_addr+0x16a/0x170 Code: 40 a8 7a 8e 4c 89 f6 4c 89 fa e8 b1 4d aa 03 e9 45 ff ff ff e8 a7 1a 52 00 90 0f 0b e8 9f 1a 52 00 90 0f 0b e8 97 1a 52 00 90 <0f> 0b 0f 1f 40 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 RSP: 0018:ffffc90002f7fda0 EFLAGS: 00010293 RAX: ffffffff8143a369 RBX: 000000007ffffff2 RCX: ffff888106df5640 RDX: 0000000000000000 RSI: 000000007ffffff2 RDI: 000000001fffffff RBP: 1ffff11020df6d09 R08: ffffffff8143a305 R09: 1ffffffff203a1f6 R10: dffffc0000000000 R11: fffffbfff203a1f7 R12: dffffc0000000000 R13: fffffffffffffff2 R14: 000000007ffffff2 R15: ffff88802bc12d58 FS: 00007f01bd1a7600(0000) GS:ffff888062900000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: fffffffffffffff8 CR3: 0000000011f80000 CR4: 00000000000006f0 Call Trace: ? __die_body+0x5f/0xb0 ? die+0x9e/0xc0 ? do_trap+0x15a/0x3a0 ? __phys_addr+0x16a/0x170 ? do_error_trap+0x1dc/0x2c0 ? __phys_addr+0x16a/0x170 ? __pfx_do_error_trap+0x10/0x10 ? handle_invalid_op+0x34/0x40 ? __phys_addr+0x16a/0x170 ? exc_invalid_op+0x38/0x50 ? asm_exc_invalid_op+0x1a/0x20 ? __phys_addr+0x105/0x170 ? __phys_addr+0x169/0x170 ? __phys_addr+0x16a/0x170 ? free_bprm+0x2b5/0x300 kfree+0x71/0x420 ? free_bprm+0x295/0x300 free_bprm+0x2b5/0x300 do_execveat_common+0x3ae/0x750 __x64_sys_execveat+0xc4/0xe0 do_syscall_64+0xf3/0x230 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f01bd0c36a9 Code: 5c c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 4f 37 0d 00 f7 d8 64 89 01 48 RSP: 002b:00007fff034da398 EFLAGS: 00000246 ORIG_RAX: 0000000000000142 RAX: ffffffffffffffda RBX: 0000000000403e00 RCX: 00007f01bd0c36a9 RDX: 0000000000000000 RSI: 0000000020000000 RDI: 0000000000000004 RBP: 0000000000000001 R08: 0000000000001000 R09: 0000000000403e00 R10: 0000000000000000 R11: 0000000000000246 R12: 00007fff034da4b8 R13: 00007fff034da4c8 R14: 0000000000401050 R15: 00007f01bd1dca80 Since 'bprm_add_fixup_comm()' may set 'bprm->argv0' to 'ERR_PTR()', errno-lookalike invalid pointer should not be passed to 'kfree()'. Reported-by: syzbot+03e1af5c332f7e0eb84b@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=03e1af5c332f7e0eb84b Fixes: 7afad450c998 ("exec: fix up /proc/pid/comm in the execveat(AT_EMPTY_PATH) case") Signed-off-by: Dmitry Antipov --- fs/exec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/exec.c b/fs/exec.c index ef18eb0ea5b4..df70ed8e36fe 100644 --- a/fs/exec.c +++ b/fs/exec.c @@ -1496,7 +1496,8 @@ static void free_bprm(struct linux_binprm *bprm) if (bprm->interp != bprm->filename) kfree(bprm->interp); kfree(bprm->fdpath); - kfree(bprm->argv0); + if (!IS_ERR(bprm->argv0)) + kfree(bprm->argv0); kfree(bprm); } -- 2.47.0