From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C18F4D1CA19 for ; Tue, 5 Nov 2024 03:40:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 494726B00A7; Mon, 4 Nov 2024 22:40:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 444636B00A8; Mon, 4 Nov 2024 22:40:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E4DB6B00A9; Mon, 4 Nov 2024 22:40:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0E4F06B00A7 for ; Mon, 4 Nov 2024 22:40:29 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8584680932 for ; Tue, 5 Nov 2024 03:40:28 +0000 (UTC) X-FDA: 82750637970.30.EC8329F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id 8611C40007 for ; Tue, 5 Nov 2024 03:39:46 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=R1b4aJ4N; dmarc=none; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730777943; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fjBbTxB9lt7stJTXeKsqUGpJC56+c8ffa0owaMVrB/Y=; b=4gM93ZJ564QZBBdpukM5F7INy61VKzqqQdiuBLDKBH9G5PXVOWiueybLuRz7TpKyzE9bnN zv7GqfgWFWIBSSoxKI82BDsPClZRf8jeZMcvUim/FDFlj5vIIIzO+sJ0bkjUUakEAo3yYk c9ORlnG9OuNSig83Y2SWW1EHptnaVz4= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=R1b4aJ4N; dmarc=none; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730777943; a=rsa-sha256; cv=none; b=MjVBvnnwW9psZy0RE+TQeG6vE1iw6LNjcFrkyJHAykdwUcxpCaIOC8hqd5HeKdDIrez+1+ EbCXdF3E2aZ8sj7nLTfryKweAIz19pE6W0xO/FWetMNTSmUj2djzhjVUyskTNY+lPfQOVE goJJroYS4G8P0O0FYerFnJWS2jjT4z4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C87805C0233; Tue, 5 Nov 2024 03:39:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B19A4C4CECF; Tue, 5 Nov 2024 03:40:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1730778025; bh=QxjNHT4TitqMtQmgK+mrt83B6I4xGZlhjxuQha47rTo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=R1b4aJ4NyjKe6zc2SBzWEdsakiDQzkHlWwJzpqU3Mcn0CexPwa52HVR1q0FZZ0cft MQPNDvPyHo0tDMPivyrj8CFkeQDF9KyAdH2s8xTgr+epB0b0KgARAtJekPW54dheGy w+OLM6KzcGbzuXplZllIJzdHpx4IZwHg9BzY3sgs= Date: Mon, 4 Nov 2024 19:40:24 -0800 From: Andrew Morton To: David Hildenbrand Cc: Barry Song <21cnbao@gmail.com>, Usama Arif , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , Chengming Zhou , Yosry Ahmed , Nhat Pham , Johannes Weiner , Hugh Dickins , Matthew Wilcox , Shakeel Butt , Andi Kleen , Baolin Wang , Chris Li , "Huang, Ying" , Kairui Song , Ryan Roberts Subject: Re: [PATCH v2] mm: count zeromap read and set for swapout and swapin Message-Id: <20241104194024.0284288a28a71a70a3eab9b0@linux-foundation.org> In-Reply-To: <3f943f72-59d6-4124-96b2-e0bb8d7a5ebd@redhat.com> References: <20241102101240.35072-1-21cnbao@gmail.com> <6c14ab2c-7917-489b-b51e-401d208067f3@gmail.com> <3f943f72-59d6-4124-96b2-e0bb8d7a5ebd@redhat.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8611C40007 X-Stat-Signature: 7ss3rawekxqfh55ctjmhe7jyfizaerq4 X-HE-Tag: 1730777986-971098 X-HE-Meta: U2FsdGVkX18m7PDB3Hpcc2zCZTQIEYsQ57gmsYRL79h4U+UzPTe4rDEApcuQi0m8nT6HPXJ8KjtQ8KCMUMvj+9XEujdYvLMbRkcD1hr35LA0w9lHwEJhNC9117fkowGlu9wBVP9zeXZP46Dr/9w7iWMkPPkdgiWk6VbaGi/q9ke0qEBaL0WWuVi/0FAa5EE9G/Bd8RTLpBZGCuYGn36b7BnH7pKOMhai2/bIMn31zwZlC6hJhzc8UYRgj44dA2XMEeagoh0PO1YeB4asTp/tPA4nalpDBeeYWJ6cws1hmUlZ61WtWA7Z3BgJ8GrCzLCCY++GDs8Ulq2ghDZGcAL/A2uB7hftotWhW9kn07IX8LAmBHI8rsY8LWmXKoPDJbVO1LpeJf5XfSXJUUYTwdQW4+gpr3s+mSqUjs+uOTatTFb+gMTzN4Bj7h8M2Pa04qfxd21ifmBrCrkuVSriVilAC63zrF6n+0+0A7nGPEwFhZALL4ZWtN4CnLe0LwqFScDbvxLVIqynUFmtUO/aA69RLvA7Os2/lfONdBn2/VxFO/783qxn41cTXLXmVuWmVM7tSAe+wg9YPQMnjmHnmMLAFf03bR43ji8DqQGzcquSfrNGJrPGTRt2EZkExkXQKzWb44z8BAxit0gZNnIhwKx35g6PRn6WfsMuO4z9P6gQvjnPEKlyApSX3zts29yI/Pbo37t0Mb/PLN1jqfbzaAgeR+7UVu57ZNyTQIRIfwfRUx/ObK+PeDb13BZmnp5zmP/o49lHE3ZoqJm7exf0tGTG6f9qFL2HuvxZy7m4BB6m7d9cD0XzFbq0Dvp010wZlxyi05bmlTKmdHogFje1L58AVV72wloZieoti/6mf5M3fGOLoyswoahiKajkVZRLCkab6HUumlqgKW3+5RpL2wx0UWb0y4zfIuZH1JoXaHhu3bkZT+FdJMUmMRaHM6rzmAMb7eSHYjHIzNu+JT/WklO Bqpladz2 cqphKSZJXMbhDrKqzjd3YjyKhxQVp4Iu1Z7HKyKRDOBVpyPk1hRLXjY2K4e3AV68gF2S89QE0G342jofZejZ5IJAhPIK2NCRu2ZTXmiL3X9JOPOb9TAAnoAnBwJJlRQShnOqRD4cj/LXcu9U1LOA48SolUbHPVJGaa5XyJBuRb1qLKq4oylcciloWMoj2/9cFsehmcNg/JPBwNNQqhjJ0xB2O28TqVlU9LEEvtNNBawmzhSqJatbwbAl064yu7RgK9QXD2V1SZC0t9yI4IDQs6BeqHg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 4 Nov 2024 13:32:55 +0100 David Hildenbrand wrote: > > As mentioned above, this isn't about fixing a bug; it's simply to ensure > > that swap-related metrics don't disappear. > > Documentation/process/submitting-patches.rst: > > "A Fixes: tag indicates that the patch fixes an issue in a previous > commit. It is used to make it easy to determine where a bug originated, > which can help review a bug fix." > > If there is no BUG, I'm afraid you are abusing that tag. I think the abuse is reasonable. We have no Should-be-included-with:. 0ca0c24e3211 is only in 6.12-rcX so this is the time to make userspace-visible tweaks, so the 6.12 interfaces are the same as the 6.13+ interfaces (which is what I think is happening here?) And including the Fixes in this patch might be useful to someone who is backporting 0ca0c24e3211 into some earlier kernel for their own purposes.