From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCC27D1BDC0 for ; Mon, 4 Nov 2024 16:24:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46F116B0089; Mon, 4 Nov 2024 11:24:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 41F116B008A; Mon, 4 Nov 2024 11:24:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E6836B008C; Mon, 4 Nov 2024 11:24:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0A7616B0089 for ; Mon, 4 Nov 2024 11:24:18 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C948DA01A3 for ; Mon, 4 Nov 2024 16:24:16 +0000 (UTC) X-FDA: 82748933148.09.D77F982 Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) by imf29.hostedemail.com (Postfix) with ESMTP id A6F4D12001B for ; Mon, 4 Nov 2024 16:23:31 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=i2858VXv; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.128.181 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730737288; a=rsa-sha256; cv=none; b=UTDaB+PjrU9XoVp7QlZA5gEXK+nPRe8/Jva9NhCSHaDk3TYguAalWGRPuNDnfqmo2J6j9V ykbFPkzbsGgM4e9oXZAbH9xBlOjTj1UV9YqhqQP/gUc0X35ZDh/gbHs4nsZpUVWtv36pIh hIScASPnR+CjooXFAnkilpuKzPSGeaY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=i2858VXv; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.128.181 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730737288; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gDG3pXtVip+KfodA4/0kQzuYn7NY3gOyTP352pqCET0=; b=UNhF0nHCy2wLMqpr0lDhR19AoU6BoDFo9EkriREMO9RCtham8leF/vmzcg+RinMJRmxEVe MaVJSEzS3pKiT39Zf7Hz2Gz126+ixlRYQZYVVvhYdURE0nYfOmWKoFse86gCHHslTtFnwg uyfWnsXyrU6Y8l88DzlFZHNPc3C48Ig= Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-6e38ebcc0abso49492227b3.2 for ; Mon, 04 Nov 2024 08:24:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730737451; x=1731342251; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gDG3pXtVip+KfodA4/0kQzuYn7NY3gOyTP352pqCET0=; b=i2858VXvkS0xG/zu5F1ukQSQgeFxab03TYpGRpkWeV8owbKtOpHdGGpf5/RrDl/cgh 6daTuyoKDM/E6aN1X5fiisECJQLmUvlnJUK4pWAiMuYm7dFmJZwcK1ivp9iGN9B43lT6 iqV5pYkk2mNSR+mNxoveK0/leBDhbosBJLUoljRoZyb7Lhe4kDGaXVWZ44RYWi3aX+6j 4YT/hxbSFTF5Vt3kvcT0pe/DYYl1v6BjdSUONv7hPieN0un6v7xV4nz51JXL2IKl1YvL utI0igSv6BCJcdpwNwM627Ypi9bJPaX6U/TxYcOLIiYMgTgpVfa67jFPDTdlhq8zQ/k6 BYlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730737451; x=1731342251; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gDG3pXtVip+KfodA4/0kQzuYn7NY3gOyTP352pqCET0=; b=oIVkpH60f45LXNyGxaDf200ysXEt/+9Gth+45Q2o//Vjld7upvzQHJwKDltcwcmFTa ez4kOcXWoq0qgvvM26ngpeGq/eiUuLRPpNMBPFAnhacLFXUChbEnToWbJptfvstQsb6B UGrBVXJ9Yl5wj9sB6bhiuXBWKb4VzVdPHI7yeIvtdQR92mEmBiNUmhYDcPdjTrWTvr/S F0GOcONDmthQ3ER7VjMDsmayQH0DUH3OMd+p295EhRQ1Z4SnPddKNNrTpRAyPKfyFt+T ikdtX9C8zFChKk6JlSnfJDpbo8xwbTN2rVxw1hZPtUJo+XolOuNdiBh9ZJTLo1p87mgF 8GfQ== X-Forwarded-Encrypted: i=1; AJvYcCUk5mycbffGeT+e9kx33lThfyRgBuPee9QsOKBs0oxxhNQnq+Ri4GTOyz4dK/8BRPzIQOhg6R/t4w==@kvack.org X-Gm-Message-State: AOJu0YymX9EsR+p46Y4429GAFrxlCK8hZKh5wr35spxxHhpLX3C21KPR eauxMifBQDrHU0wUPR+s9t43dmAZhRAASC1RKsCODq218QWcXKDA X-Google-Smtp-Source: AGHT+IF8Et8+CgvYS0NUpJMFFTR142xgrloNK0418EFcQi3KHe4p7OMOSNlYAypZO3thIC+YMTpJoQ== X-Received: by 2002:a05:690c:318:b0:6ea:8a23:76a7 with SMTP id 00721157ae682-6ea8a2380e0mr49198477b3.3.1730737450980; Mon, 04 Nov 2024 08:24:10 -0800 (PST) Received: from localhost (fwdproxy-frc-011.fbsv.net. [2a03:2880:21ff:b::face:b00c]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6ea7beaae0dsm11050907b3.48.2024.11.04.08.24.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2024 08:24:10 -0800 (PST) From: Joshua Hahn To: usamaarif642@gmail.com Cc: 21cnbao@gmail.com, ak@linux.intel.com, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, chengming.zhou@linux.dev, chrisl@kernel.org, david@redhat.com, hannes@cmpxchg.org, hughd@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, nphamcs@gmail.com, ryan.roberts@arm.com, shakeel.butt@linux.dev, v-songbaohua@oppo.com, willy@infradead.org, ying.huang@intel.com, yosryahmed@google.com Subject: Re: [PATCH v2] mm: count zeromap read and set for swapout and swapin Date: Mon, 4 Nov 2024 08:24:09 -0800 Message-ID: <20241104162409.2750133-1-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <2d73b4cc-47a1-44a2-b50a-0f67d25b3e22@gmail.com> References: <2d73b4cc-47a1-44a2-b50a-0f67d25b3e22@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: dfnhtxqg3r4fjn86xiqdm5asys8gusoo X-Rspamd-Queue-Id: A6F4D12001B X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1730737411-933406 X-HE-Meta: U2FsdGVkX1816BBckCi2u5FJ875RtAsVifV6dOm1OgOhVg/9s/93YbJfSdD/H6LSF6S4wPTF/W1lbKZceoIZZkUGJ5PSgBnN7Y8f9UATJk2B3mNL49t1NaXqD7Gs2VsYZjljxf1MLk1Nrmuf3YGmY6B2cclpw9xXhG+RfRq2wEsRBfBE9PaAY4vNoZfgcXC2xvbArQbwVqLLfup24+vLxPIpyZmqCQ5vYdfy50jLkn8r3L99EA2JWcs+Cf0YYejRq9IFuOZFqyy9NSmNjt7RZxmWyXLkbz9QFw+4RBUOhIEnfYwmaptFjk2WSrPiBIBA6UlpQQ/Hmy1HDV43vR5l/3ZWNp5wIG0ZMDSA4RSinTVDkIrhol5YD4TJuOTf4kiu42zo5+hYlbH2e1gK0MTQDhAzmss5pVna8xxvJ0fdmYyzqP2yin1ekvlDK8dsXMkTpXmFuf00cQyn7tQYcYg8B7H5wMp5egcUm8gIiA6KBBJCz4ytFr82NGnno2+EtXvQziwPOE5oPjh4p2UuoKY+TmezO4FZ5xtYGdJmeA31shs9wsjAwR97xxRekX/xERLASrVxCaBcNcAxojn4u4hV03gcwOl3Ck5wCiLJSLniDLpi4t6LLvGLGpdlgjUZtXG9j4yhSUHjr8LqKXOWZG8yr0SKAGRRp0WEDObzzefmA/SN+jeSb99GWWx62ZEF4fZ9Ud8KTS/NfAjBjqBgx+iQycPhHDcPjAhQbHkZGdh3Ii9FMTeRUQ4oYdMsd6my38eKx1S0Sos32Z1aC42UvHt6Yb0nrcdWm4Prp0eVZad/uBBYUtkzmSW2yxSNCzU7RH5eSXQ2Cywao/UvYR9GcQl5+ceGvT6t9DAYHipNZFunYorCKRcqzppPqEULs0214Ar6HE7peDFAJhE4oKiinbT1Q3sVn48Urcx0qm0KombmE8QCrhp+ha7Ln3yScWPpGB914ggt6zM4B8Zenz8VWxO xGjSvKja dl//ojqijGp+HwKQLoc0aArN+gK/COS9lGpi1ykhCTtdH3WsjNQmzrtuTXlOhuFVMrGtFzvFP6plSmKcSKaACT3Y4tJyF6Wcf/d76EymSRxm3hqx4+M687BnO3Xj0V00JMtKotX4pd3viamBzXL01p4kI0Ozpn+zng2/B+khQK3QVOxhj9OcnDyBKDBl4koSl/sJ1BtQ9KjREdCCEJJj3+2IcLTX6UFVj+dvxPzzPwTDcxdRrqsLbOFddUT1Z5l89A6e+JuHkYMPxrCPfgu6yn2AbeD0ZqUSh+CyRGNmT20NOz0lB53LRaZh2yMa9sSsNoQgkOM8wfPGGU8ObJPZDc5xuD3YjG6a2E5alSYef+BTy/RFG7RRBIsqhaoBMIAOY99G1fV3N5XKx4aSJC0NA1ld784aMdNA47TZ1FmQGz0KXIdGPUL5HoUZMVzYprKx41+bc6Io8AenUhlAcXwx/i1PglfDmkeo3EyYi X-Bogosity: Ham, tests=bogofilter, spamicity=0.028872, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02/11/2024 14:43:07, Usama Arif wrote: > On 02/11/2024 12:59, Barry Song wrote: >> On Sat, Nov 2, 2024 at 8:32 PM Usama Arif wrote: >>> >>> On 02/11/2024 10:12, Barry Song wrote: >>>> From: Barry Song >>>> >>>> When the proportion of folios from the zero map is small, missing their >>>> accounting may not significantly impact profiling. However, it’s easy >>>> to construct a scenario where this becomes an issue—for example, >>>> allocating 1 GB of memory, writing zeros from userspace, followed by >>>> MADV_PAGEOUT, and then swapping it back in. In this case, the swap-out >>>> and swap-in counts seem to vanish into a black hole, potentially >>>> causing semantic ambiguity. >>>> >>>> This patch adopts option 1 as pswpin/pswpout counters are that they >>>> only apply to IO done directly to the backend device (as noted by >>>> Nhat Pham). >>>> >>>> Fixes: 0ca0c24e3211 ("mm: store zero pages to be swapped out in a bitmap") >>> I don't think its a hotfix (or even a fix). It was discussed in the initial >>> series to add these as a follow up and Joshua was going to do this soon. >>> Its not fixing any bug in the initial series. >> >> I didn't realize Joshua was handling it. Is he still planning to? If >> so, I can leave it >> with Joshua if that was the plan :-) >> > > Please do continue with this patch, I think he was going to look at the > swapped_zero version that we discussed earlier anyways. Will let Joshua > comment on it. Hi Usama and Barry, First of all, I am sorry for not participating in the previous conversation about this, it is my fault for the lack of communication on my end on the status of zero_swapped (name pending). Sorry for the confusion! I am hoping to pick this up in a few days (I have been working on a few patches in different subsystems, but I will wrap up the work on these very soon). As far as I can tell, zero_swapped and swp{in,out}zero seem to be orthogonal, and as Nhat pointed out [1] I think there is need for both. Thank you for this patch Barry, and thank you Usama for keeping me in the loop! Have a great day! Joshua [1] https://lore.kernel.org/linux-mm/882008b6-13e0-41d8-91fa-f26c585120d8@gmail.com/T/#m7c5017bc97d56843242d3e006cd7e1f0fd0f1a38