From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAAEDD132B8 for ; Mon, 4 Nov 2024 12:19:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E1B56B0088; Mon, 4 Nov 2024 07:19:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 36AEA6B008A; Mon, 4 Nov 2024 07:19:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E51C6B0093; Mon, 4 Nov 2024 07:19:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F1DD36B0088 for ; Mon, 4 Nov 2024 07:19:29 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A00C31A1919 for ; Mon, 4 Nov 2024 12:19:29 +0000 (UTC) X-FDA: 82748317428.16.15C62E2 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) by imf13.hostedemail.com (Postfix) with ESMTP id AEC992001D for ; Mon, 4 Nov 2024 12:18:54 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b="AJy96ef/"; dmarc=none; spf=pass (imf13.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.47 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730722709; a=rsa-sha256; cv=none; b=IQvZKEl/NN2JcORBzqv94A7eeDCjm9FtZ5mwBQJywDz38WRrkCxwbByV7XbUulxX0m11KX +VUk/oHbiEPBEniTKH/S4x1CV2rn2KNo9gVbsU7vF8DXDoWLhIGDpy4oNDEEiFXKjEM8KH xEyYbN8v/h1qqvRMZxPAQWInEBKbMcg= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b="AJy96ef/"; dmarc=none; spf=pass (imf13.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.47 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730722709; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tx1bOostXz+VH0GPtKgcyKswUQOWFhDDl/A9OfJb8HU=; b=5W7Qve3ex2HfW7cuuNEstmv3RzvLnXH707Ji7K67DjMHWY4Gjw/3PXBsvVm7BM5demc9Aq 4WNRnFojMB4EKCmhmsSNEjW/3wZ0DzpHSI0l8J759ZOsheQd/r7mgwNYNi81rbBCpIMujS BT0rFyPXeepQBeI3Bg4NEscm/E2ynjQ= Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-6cbf347dc66so27626366d6.3 for ; Mon, 04 Nov 2024 04:19:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1730722767; x=1731327567; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tx1bOostXz+VH0GPtKgcyKswUQOWFhDDl/A9OfJb8HU=; b=AJy96ef/wjzhx9EiI5s3WUxuqoxOr43Vqbi0K4rykUPgxTsIEcWHcsLmf9PwzSQneF zUq9BfbNm4oJAk8HJ7aklxaGfwZxe8hfZGdSncTlz/G//rQnJiD3JPB+pA4Lc3x5sEsb K3ZwU85DQnH21qp7v4dkv0350YjastnJwijIow1pwpssr+h9iJNKww+azQaXg9wOKdmI n8cFmsnqcdsB6eHIr9ms+wCoAdoFz3ho+dg2UFrO3LzlddK8SF/lBcQXFVDAHeDHEMil 73lWcIZICPFtUGRK/r6iDNQu1lwmPeJ5YTBURAGOsMXxzYh6SF28zjJj7GLtda5wAfCM C29w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730722767; x=1731327567; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tx1bOostXz+VH0GPtKgcyKswUQOWFhDDl/A9OfJb8HU=; b=vehb4j4VcozlcMbWOZBcvWGS10dlYYNY55r6zyBGWuwDbs3dVKmZ1aPY64zZO0OCWq zi980fbDd+NTnM9l2n52yQDWu7H/1Zye1ISRHiDhErachn1D/oxjbzH2o5598Vo/SwEy HI77FzIuSWMFqinaVeiAKwLJXVmlQ2RBlVnZf3I+BBFU8/QouOjvJTgCcvbkwv1JstXa OIyXhXhnM1RVYKspiGGZ76E32BTUyFJeiuQMF7D1DCa+KDfFZC2MrmobgUsRyuyMH7aB uLU0fNxfYvJbAWdApxQwp30U6Ycl4l1LWEsDh0/Fx7O6Rxf1camg4imbmgh0Pn0VnsjQ NX+g== X-Forwarded-Encrypted: i=1; AJvYcCV4yZQRMoyVH/zcKaPqXAQJTT2Rsbf94bj9dODChQKmUuD6/QMq2isKzOP7swqcYdwFnK3AGOl63w==@kvack.org X-Gm-Message-State: AOJu0YyANPUv0gNWuzV0vo+p6a28xaY4+2BU8y8OAyTDjS2ZZ8dAgFXE lngnKCMlM5AneUoAGma4Nk0H73XLZHN+Etd0axnuTPYJ1pN+mXwn3F+8fDJwi7Y= X-Google-Smtp-Source: AGHT+IGGw97HgDqXEc70DPdglFSAiLC2/hvL6iix2sWZheUlrSMhSyN4gGvDNAQMyTZfPVibvICZkw== X-Received: by 2002:a05:6214:3a8b:b0:6cb:c199:462a with SMTP id 6a1803df08f44-6d35c137657mr208089456d6.27.1730722766648; Mon, 04 Nov 2024 04:19:26 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-68-128-5.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.128.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d353fc718csm47611946d6.38.2024.11.04.04.19.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2024 04:19:25 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1t7w3I-00000000hJn-3gHO; Mon, 04 Nov 2024 08:19:24 -0400 Date: Mon, 4 Nov 2024 08:19:24 -0400 From: Jason Gunthorpe To: Christoph Hellwig Cc: Robin Murphy , Leon Romanovsky , Jens Axboe , Joerg Roedel , Will Deacon , Sagi Grimberg , Leon Romanovsky , Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v1 07/17] dma-mapping: Implement link/unlink ranges API Message-ID: <20241104121924.GC35848@ziepe.ca> References: <51c5a5d5-6f90-4c42-b0ef-b87791e00f20@arm.com> <20241104091048.GA25041@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241104091048.GA25041@lst.de> X-Rspam-User: X-Rspamd-Queue-Id: AEC992001D X-Rspamd-Server: rspam01 X-Stat-Signature: naoa8xonsioa8gjyz7mfwqdx7ofrb4zn X-HE-Tag: 1730722734-567814 X-HE-Meta: U2FsdGVkX18dyvFvpjB778pJxUOZHNlgSg5cjmANL4IdUiF1Hsu56HMP1hJirFXWgxNxrE3JbsRPJRAwGHs86am5sROgBEiW7fyWeeWy9a8XjZuKNtDhnZhF1a13BjQclVZ//cJnj8rPrxSuZUAFrdecMKe4at+Eg8nQHqMJofOS++/GHOTIHdFpzy9LpU+oUT+hSo2vlMbOZGeET28VcPXRP2XfzI223ffC8pqdgL9/CT60Fi2D9I8vmdV/yi+UWu02G/m/CSJqY83wfHPxz1YWYC3dAJQrShcH4ok1vIvMneAOl90r0eq6g2hpc+vIwjOpQUU0EbcN7C2BNOG4zz7noW2V08vApyMS3VqIONu2qXTTqS3Deuyxh5NCIEYL14YaKJ7jocVtVlf2z8bUmElm0lHZCXG55mY4teauHBPqdXhMm34whYKkewGrQEvEwbOp+Fto9Yz0Wqg66DqKveHeMYdakRQTYUi2gXO0cL8wdlOrIlxpST4Q7zkKq7kmUKfs7bUdK5fjXgdpxuOcg6F6Omo2Nksbf2GdDUig+pm38G0J/MfYQMy1QvM6+/vZzsVuY2IxF/+mfoIAbSuyaOI2/g9yU1YB6ZmcwSHHkfICElvwNLSzMCoONKsRlbAvx7u4POETrG3x2Cvlw/DL3Y4kB4zwOTTMuffYPcWaGkts3fN46+Me9MKMuqAXbQso71ufj5I10d4vlQBn6shXAB7Q+KA+eZluTaGnLwrHawEmLFcdVsIxSSaooXqhMPC8peIlGX1aEtBgfEIJoiyDThBNmL6IPutzuj0rI0Iq/vSJKzB9KLSL4X8GputU+XKBJe5Ao0IkGihrQyYK4KrvE4U1VUFuQcP8MiDoJBa3qUJCVRO6ptpzvtlC7P4KT26GxYkKLlMdEH0pxwL0BpsKutaaE5SD94LNI6ynjKQTS3OAhj+ngvjSmigaJXLpyjlrrcILrxHm5eehMeCI9rh QsXyyQHn 56+aGfptJ3hJy7pQ0Tkfivmaq6e1ZDgaZYx7+IsWZ2y1mX/9JbaPHegM4JqvvNj9Y5IjdgybIdg/1Dt22X2xK0VDqJyAI6c2Zs63KzIktZTaICoNKklbZbMXO4ANXxSj1Fp7p+LRKIKG4sZiRpPimLURCUr6R8wqq+tVNivIKvDBf5Ccuaqoz8dAia2dLSmISrfF1VzHCZ9gjW918zNClHuKw13A4gfcDUlWYMk/oPWMBvORfJXnA7UKaeh7GcQTY/zXZ2dT7iD3lfV8MXMtg3XAq4w88e/S0i16/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 04, 2024 at 10:10:48AM +0100, Christoph Hellwig wrote: > >> + arch_sync_dma_for_device(phys, size, dir); > > > > Plus if the aim is to pass P2P and whatever arbitrary physical addresses > > through here as well, how can we be sure this isn't going to explode? > > That's a good point. Only mapped through host bridge P2P can even > end up here, so the address is a perfectly valid physical address > in the host. But I'm not sure if all arch_sync_dma_for_device > implementations handle IOMMU memory fine. I was told on x86 if you do a cache flush operation on MMIO there is a chance it will MCE. Recently had some similar discussions about ARM where it was asserted some platforms may have similar. It would be safest to only call arch flushing calls on memory that is mapped cachable. We can assume that a P2P target is never CPU mapped cachable, regardless of how the DMA is routed. Jason