From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F9B3CFB422 for ; Mon, 4 Nov 2024 08:55:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93A546B0083; Mon, 4 Nov 2024 03:55:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8EA966B0085; Mon, 4 Nov 2024 03:55:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D8C86B0088; Mon, 4 Nov 2024 03:55:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5E98A6B0083 for ; Mon, 4 Nov 2024 03:55:29 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 024B3ABDCE for ; Mon, 4 Nov 2024 08:55:28 +0000 (UTC) X-FDA: 82747802760.25.F033820 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf28.hostedemail.com (Postfix) with ESMTP id D4BCBC0008 for ; Mon, 4 Nov 2024 08:54:54 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf28.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730710469; a=rsa-sha256; cv=none; b=7V9Lz194iVPLz0j9ce3tFpdcxqn1Bp+nV92LpbejCTTvmhGE0gDAPdEOe+xKrtwPjKFrKQ bHDlcNl7ASFIC6Wgh3eXW7tUaz8P0YFnsbIaFcw4QmwwJDgcKFUNMW//+03FEqy8sm4k3O gHGTtCQJNOykWd3KYwAYvWn7Zkyidd0= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf28.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730710469; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XJMROuE4JjYsw4wo8HK5SvAvW9x90cNUd3R+iiehUbQ=; b=KKHMPZMGWckV1O0nRtk2zBHqTfpf6zjyzHc/BSWNviZ+Ll/LVfHkJP0tQDJZbXYTnG74eM FG40lZweprxgV+6mTTJihkq32/qnzhf83A2RtbvZEiqwukGxmQa11e5ee6axIj/qmAJI0q ZBH2yVUp/6qqPfPLFTFIi7b/mliyRww= Received: by verein.lst.de (Postfix, from userid 2407) id 95EF3227AAD; Mon, 4 Nov 2024 09:55:21 +0100 (CET) Date: Mon, 4 Nov 2024 09:55:21 +0100 From: Christoph Hellwig To: Bart Van Assche Cc: Leon Romanovsky , Jens Axboe , Jason Gunthorpe , Robin Murphy , Joerg Roedel , Will Deacon , Christoph Hellwig , Sagi Grimberg , Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 1/7] block: share more code for bio addition helpers Message-ID: <20241104085521.GA24211@lst.de> References: <4c7e679a-d3e6-4426-a679-ee581b5c728c@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4c7e679a-d3e6-4426-a679-ee581b5c728c@acm.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Queue-Id: D4BCBC0008 X-Rspamd-Server: rspam11 X-Stat-Signature: m8wu5y61pgzofx1gw5rf41q3nuh1hhx8 X-HE-Tag: 1730710494-29416 X-HE-Meta: U2FsdGVkX1/HbiiEoPGwsgrRgRQhrx8Bs27yUKCF2GtCXS0XZNTvgKmVHLUKMFdSd7na93cQseDfQBXq19nbjfoJ+x2cw1QH+GjHxqWhsUk51pZNvjeYbMCLuNZuptIOxAMTEJlh/J54IsB716L9lDNH2H7WCJ13R4a7Ilh9LP2gyka5GWgyizu6Dy6eDz2lBhWObIP71ke+vMwmztS8I+dnAcEDvjZSwjlQhMubIIoidooc28trCyXxXVRcL2Sneg6Wmilq+x4ztyFCO/oKyoDA19Yd5f4Xyz/EbZlQ4fHsaTiR+8oF+gTKUYePYRC0zY40O+qogdXYDfmZHFX22eAKX6UwBt8uKEUEHs/8yPm0GtL+lqjukuCeK/Z7IM4FnaUBaJ7pgM47bbgbznVn9QtzuO/+o45JyYivPY920aPUZVotHbGrmp6aa6tIs+ny0mtPkjHisFSHgCMaqb+IPkYj777bEI0PtIrQzKLlqEOG+NjBc8HEMTUIC4QNR/r3t5TPULk1bnoPW4oTF1bWGPFdV96zlHpxdwRCWdqgQglgMTlqPQkUCPQrNj9DrTXqNcFt92o1T4/ZCuYOujDdwHDF3sS4/SRi68S7W3OwZN5Ddpvn9euTzs3+i/ZFTfKC4Dr5pqaYNeLOjU+10tLIME65JSKYZQckOahTAy4Qd0O0YwhHuUnCDzdzQ4a2bhA/LyO3Q/5D6V/Brr6GlILQSjtKfZhI4Q2ElLeCKf4tTy/bXt4mSYiMz7wi8zmrszhsOxdEIRjVYQ7LIzfwLjY903HAfBP4tNusPmsuWCwnhr6AmqGNz2mUu+nMlTFExlt03AtMXIjDCi6UDrAW6hPgcIXyRzRAo0blqkCdjrUJ6AMeI5rYO6czlT638eRH+ir9dl1wxk9p8+gytueE8uRvcOyiQuqwFx/ILQgtB5f5suWxiCoaU9VZOjzaEq8ahH2zP3aZJaYanhDMTKaeHnF M9k2XJVC S6EdhUX556W5pywbFKa1IFJDyFIOhaoTNx1787RpxlwWNlViWUi57Ucq/1SBuRaHASzFRnrOyJ17JQLvPRsa0bYCtCprBDIQKbq0t X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 31, 2024 at 01:55:11PM -0700, Bart Van Assche wrote: > Does "_int" stand for "_internal"? If so, please consider changing it > into "_impl". I think that will prevent that anyone confuses this suffix > with the "int" data type. _impl is even more unusual than _int, so no.