From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AA5BD11194 for ; Sun, 3 Nov 2024 22:46:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC9B56B007B; Sun, 3 Nov 2024 17:46:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C52B16B0082; Sun, 3 Nov 2024 17:46:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF2EC6B0083; Sun, 3 Nov 2024 17:46:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 903DB6B007B for ; Sun, 3 Nov 2024 17:46:16 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1C9A41A05FF for ; Sun, 3 Nov 2024 22:46:16 +0000 (UTC) X-FDA: 82746267744.10.5904135 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by imf13.hostedemail.com (Postfix) with ESMTP id E3FE420009 for ; Sun, 3 Nov 2024 22:45:41 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZeSgj7nO; spf=pass (imf13.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730673810; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ity/6nabfxr8flx+hnaBXEEiJLX3NKyfL9l87yocJjo=; b=DrremKrz6irReuchVOFFsqG4pCnUUdFNizmUSa6qd9xvEXXfaotZx1guAGoaty9Exatqxv th4QZoR+UgXeGN1Fm7YtL2UbYTLHu3mKItkiaIndNopOfZ0oLODJq/wztsiUCoD64hbaLV S4DmwK6TyI/7B1xaWLXrhfGA2U1pz1s= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZeSgj7nO; spf=pass (imf13.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730673810; a=rsa-sha256; cv=none; b=n1KRwq7Mbfv4zLaLo4PIXS/i0so3xYadyTXAN2iuZ9k7oC4v6gJlguJ+rt4kSfvynNVo3O 05LMzMUlh5S1cpih4boyKjnm8gd/D41ydOoCb1R9hiRx45r/py9Psx9rpB9lVteLgqdmPL sI854kflnTECAqsjW6qXIonPxqiLyow= Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-37d808ae924so1949543f8f.0 for ; Sun, 03 Nov 2024 14:46:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730673972; x=1731278772; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ity/6nabfxr8flx+hnaBXEEiJLX3NKyfL9l87yocJjo=; b=ZeSgj7nOWhQAj+Y5M9UNsNLPJ0Hz/F0x1iweAe4QAmBu7nh1U8pgYckQ7+PqFUg6Ev 13S3EX48sIColWe8Hs45YnSnUm4iJJ05oHV97h5kk+0D81s9C8Jv/oLDC61+wht6bnjQ Zk0bf/1uO0vN5/3fSPsZ7MmYto52qkx2gLqehVUGPhyrdWgmUjcz9BM102Qnuu6YMEMg VOxcT+8YQk9WOBl7LSgn8UmjJmIwgjgRfsw5BSJ39HHIa2s6D+Xdloz1uUz7U1WACUjD O9I4bg4yJujezZlpySjMPBQYpTujwHjNuI4IA9XInN6t3/U/vMjQFbyrWVAySHhnP5Le IcRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730673972; x=1731278772; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ity/6nabfxr8flx+hnaBXEEiJLX3NKyfL9l87yocJjo=; b=eqPOCivNGyQg9fJaLKame/lvAkGT1c0zv6zAG4z8hFlELmWyBZOmfR8x2tIBV3P/dz ZiTHYdy4Z98IvVINlrPlPhLkfeWRW/VRAUteXBamGwlJWIi9LiEjBmk92iGpAxoiMT2y K72nDJGQTaMes9w3n8clV4/xFRRjzgpBNwQilQOur8M2Omqc+QFB7X4VVmiLRQe90U7n yBQo4Hhh6Y7LXQgzQpEUmOw3oIKGRMQdznnYyxUxbic6vlpPW9hI4K7abpr4clXQEBWl 5hro2lDhrzHXLT5aY7n7pEyKDW0T+y55i8pGEsCsBF8BwS+pLTD4ZOVbGT+tJrThayA3 Om1g== X-Forwarded-Encrypted: i=1; AJvYcCU4V+dH1AwiVbsMPVv5KK4JdPK6VZNunD/t5bS+M1MayFPSqzbWeMTjLChuF53wtkg44jhrPK0gAg==@kvack.org X-Gm-Message-State: AOJu0YyLlW6m8KILK9ZYeLEBRIyxeUWK1iwL3PA3F0gZZTiJcmMAOYSY jCv4cwWcLEaE8by6bDmHB/FT32qaaqJ9TprU4PbNnWmljS6DAzfE X-Google-Smtp-Source: AGHT+IEkI0l15nyKMZiMdVioL47ClKLGdVshNrgER25iRvBjNSolVhuOecR+DJ6B/IVegd+NiQp1Bw== X-Received: by 2002:adf:eac9:0:b0:37d:4ebe:164c with SMTP id ffacd0b85a97d-38061200742mr22195614f8f.45.1730673972265; Sun, 03 Nov 2024 14:46:12 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ceac770057sm3813131a12.22.2024.11.03.14.46.08 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 03 Nov 2024 14:46:09 -0800 (PST) Date: Sun, 3 Nov 2024 22:46:08 +0000 From: Wei Yang To: Andrew Morton Cc: Wei Yang , Liam.Howlett@oracle.com, maple-tree@lists.infradead.org, linux-mm@kvack.org, Sidhartha Kumar , Lorenzo Stoakes Subject: Re: [PATCH v5 5/5] maple_tree: add a test checking storing null Message-ID: <20241103224608.qkbgiz63wcglzg7g@master> Reply-To: Wei Yang References: <20241031231627.14316-1-richard.weiyang@gmail.com> <20241031231627.14316-6-richard.weiyang@gmail.com> <20241031203757.171bcfe311460e7d61b7f1fc@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241031203757.171bcfe311460e7d61b7f1fc@linux-foundation.org> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E3FE420009 X-Stat-Signature: zfz8umeofj5swpg6wmb3ojy1kwtyhto1 X-Rspam-User: X-HE-Tag: 1730673941-178450 X-HE-Meta: U2FsdGVkX18zqQs9K/5tFy/wGBQ72KM/g/nK4Km5csB6+QHochQPn4a7PsHzF6KJPrZ3i66UdI78QLPK17AZj2W0xQstmSTg5SV01k6b5VKphEBL443VYjBMi0mKikR2Wqp+BpU9nNgR+Yy0OMFXXnr9EwyWXiANd2vucJGBL83pCQ1kShtJhY7G5zBo64EN3QcB2pKEnt+fx92ty9J5Sm5tPiW31Z/6JLGFhAs2blUXjzd/ETj448TXfcwJzmsA8AcbZkJpkGYZ7+NM/O1vgfRl5E/HinsU4bZOlGeZWpQfCmABEPjRohFJrt8jQZnbc7bMtVLlymV5qPvfhZ3q8ZSuN9p6++Lo15Q3B2d9vi3kB9RdO8ydTC6EcDU1GW750cPOfel4fU8N/44vfDsjvv5stjWE4WgqAPwJB2fYarLzfS2WfjtA9eeEQBCfdO7RKKvrJ1Uj38xFiWNJzCzLmGwSbfqrONEHGkoETIgaPT5BxussExW6YqD7C4+MXy4lJo5SVriObzf2m5UXnyaCR0NzfWRN472EZTHhJmcbQNt6gqU2+K6LwJqhzkaVyKpn7//zC2oYf3qlQDj2lLYyXtFFVwBLrxFiCY+zWLLCE4Yi8yM6MyyefPs21Vn0/LpskJana+dF0SKwwUPREQLxlG7+C7vIot7K8kbhn2OJ5g1N7IqHJ/gTS4kAYlMgyUd8gsF8P+vni73ekVgXHIKgakIJwpzOSH4qaW4hnqgkHvRvs6p/Su7K/CXXDjtfWpQt8QfRBNG/68mm5Go+5FSZeYKtCZ6aAjGbkr0Fo1+E7tUbbxnmi3Udc6E6mbUzwhsJVyd8bOkz3CzxJzqM/Gfic9Q00enYua3DhwK2DHiYc5DS1gH38KrNsjFBBaa9Bpjyimi1g7r3BbFwH7xKYN58PsUJiCPDOIBlloTf+5KbQ+eWqgZ+aIwjnNR18NpTCZ+NQ8VegKx2qy4c6ICXrI3 1j6c5B44 +nBCxi5VaY0YS+1wl/F8tJfpZ+3/QoW14lN7EUxzZ9mq90smqRcwUxsiTnsUWkAyZLC6sLxI8On1u+UvBK4ZcfhRaybeF6sygVBToFPIjpm9iJ+Rl/yArsDILmceJFwnkHl5fx5SefDpmI2OfDFQziDvBn3zHy9xCrjbesBeqqCXv+nzvM1jkWZjWRuG4CQXIDgULAkNM1viRF/VDs2BiNmaE7uoLgvFL1cwUQhmYK3NyKB8MRhQuAFcAUacrvqq35HA9ozPZtlzdgG5B06iFs2Y1RWk0SxDQlrBq7xi9w0Qc3rp3gMhZRdT6+KAWejO9plBM2pXpWVwIJTU1KsSzrD4rTVSqVXVO27cLy2NLiAFdIxECJwCcKgB/edDlpjkZYFzKpEIxZknb0p3wUmkYbXZIIraWtNob+VCKO+0sQHMCUgL0yHaK5EXEUiIXsZBQZaa16ybJ3j7epD15AHQqJRysP7lMe+xwxa2wMRLz629DJGqO2/JxPc5fOtm903anmR1Q0xreUuxphTbv/7QHjlSPo8f1yUQE9HdBBVcJUdQGKv5+PveWcK9GezhwdCmnLKTsd7jhk8TEuv+eI85bfQT0e2W9zcNGi3ZyONDrgf+p6exU+wEidfeluKzijVfLXy9sFGYWw6EDJFNXi91IM77rRajU2vvklxNhXRqFFePYbx4rhIZIB9wkqM3xwhcvINVo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000053, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 31, 2024 at 08:37:57PM -0700, Andrew Morton wrote: >On Thu, 31 Oct 2024 23:16:27 +0000 Wei Yang wrote: > >> Add a test to assert that, when storing null to am empty tree or a >> single entry tree it will not result into: >> >> * a root node with range [0, ULONG_MAX] set to NULL >> * a root node with consecutive slot set to NULL >> > >I don't get it. > For example, if we store NULL to [3, 10] currently, we will have a root node like this. maple_tree(0x7fff2b797170) flags 5, height 1 root 0x615000000d0e 0-18446744073709551615: node 0x615000000d00 depth 0 type 1 parent 0x7fff2b797171 contents: (nil) 2 (nil) 10 (nil) 18446744073709551615 (nil) 0 (nil) 0 (nil) 0 (nil) 0 (nil) 0 (nil) 0 (nil) 0 (nil) 0 (nil) 0 (nil) 0 (nil) 0 (nil) 0 0x2 0-2: (nil) 3-10: (nil) 11-18446744073709551615: (nil) Slot 0, 1 is consecutively set to NULL. This is not expected. >> --- a/lib/test_maple_tree.c >> +++ b/lib/test_maple_tree.c >> @@ -1387,6 +1387,92 @@ static noinline void __init check_prev_entry(struct maple_tree *mt) >> mas_unlock(&mas); >> } >> >> +static noinline void __init check_store_null(struct maple_tree *mt) >> +{ >> + MA_STATE(mas, mt, 0, ULONG_MAX); >> + >> >> ... >> >> + MT_BUG_ON(mt, !xa_is_node(mas_root(&mas))); >> ... >> > >mas_root() is private to lib/maple_tree.c. I'll do this for now: Oh, thanks. > >--- a/lib/test_maple_tree.c~maple_tree-add-a-test-checking-storing-null-fix >+++ a/lib/test_maple_tree.c >@@ -1453,7 +1453,7 @@ static noinline void __init check_store_ > mas_set_range(&mas, 2, 5); > mas_store_gfp(&mas, NULL, GFP_KERNEL); > MT_BUG_ON(mt, mtree_empty(mt)); >- MT_BUG_ON(mt, xa_is_node(mas_root(&mas))); >+// MT_BUG_ON(mt, xa_is_node(mas_root(&mas))); > mas_unlock(&mas); > mtree_destroy(mt); > >@@ -1465,7 +1465,7 @@ static noinline void __init check_store_ > mas_lock(&mas); > mas_set_range(&mas, 1, 3); > mas_store_gfp(&mas, &mas, GFP_KERNEL); >- MT_BUG_ON(mt, !xa_is_node(mas_root(&mas))); >+// MT_BUG_ON(mt, !xa_is_node(mas_root(&mas))); > mas_set_range(&mas, 0, ULONG_MAX); > mas_store_gfp(&mas, NULL, GFP_KERNEL); > MT_BUG_ON(mt, !mtree_empty(mt)); >_ -- Wei Yang Help you, Help me