From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBDE5D11194 for ; Sun, 3 Nov 2024 23:15:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03C6D6B0089; Sun, 3 Nov 2024 18:15:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F2C8C6B008A; Sun, 3 Nov 2024 18:15:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCD5D6B008C; Sun, 3 Nov 2024 18:15:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C13516B0089 for ; Sun, 3 Nov 2024 18:15:22 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 692C0C0504 for ; Sun, 3 Nov 2024 23:15:22 +0000 (UTC) X-FDA: 82746341118.26.9851C4F Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf08.hostedemail.com (Postfix) with ESMTP id 8948116001A for ; Sun, 3 Nov 2024 23:14:59 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XqhK+qgq; spf=pass (imf08.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730675538; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hbXrKtaGqeDbpy9vHzvywWUrKzDRuCnmtPRX5r2Teqk=; b=4lU/fh0Gx9sn91t2aN/+BYqEGB+BKcC/gtDVfqVvqsB4klCoPB0of659nai4SnB1OSOJ0+ WT+SM/v0RdLgXggpDxVl4xN0Uy6/y3qR/kaXbhB4eeE+5P2L2N8QodF/ceine9gVVa1Dke wKSiMDWpFy6QwJ1L8Lf2OZ52fkacxOI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XqhK+qgq; spf=pass (imf08.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730675538; a=rsa-sha256; cv=none; b=56nnPOQZdbrqry+uOY46q0fcZc2idjYsj2NiVl7GZKhQ0FUEOpPVP4kcP6Qa/peQRUl+Dn fzQCjSXBH4dwa51Nal8Ixfd4onpvKdrcZb2NPyNtQaeXEqjnvgpCAdygbdk/sX/R2vv5iv 33cc0p9YUtE2P4DWb5oSPUy0X65kG2k= Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5ceca0ec4e7so1588972a12.0 for ; Sun, 03 Nov 2024 15:15:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730675719; x=1731280519; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=hbXrKtaGqeDbpy9vHzvywWUrKzDRuCnmtPRX5r2Teqk=; b=XqhK+qgqqRTJEWBRsNvw+tiiflI0TQ33CfY7kcXCKICZ5V/UhbWAv5Xq1/hUvhzFcM 4pkQkVWEW8PSV7Z3umKbfe9pQ1Y91yruD7balTO5OVDkqsdSW4W26vx6XoWh9J/7EHM2 oNQ8rbgEbeWaUYd0nBK6BkYwNGywwP36hsBcxj1fBudk+HXk7FRAgCmvLD3FYzGD+5pq uBaCYTFOefS7BfzTVWkIg0wQZtg9WCXwn2wniWDcjwEt1gduTGvDShpQoDKkphUIlxlU 0q0uui8oWq/bOnc6JDo9f3rTI8N/mZ17R3/RTEaS5CZCmiBvmI94z8vsohWFlFyqxmsy 5czg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730675719; x=1731280519; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=hbXrKtaGqeDbpy9vHzvywWUrKzDRuCnmtPRX5r2Teqk=; b=P+sDOOBjsf+OASpCkgi76RiAO34gS1yCzT4o8WJvJcTywzRUOjMbqjYx6Ihzf7aC2X XKMGLXpF3qlIjEiCCghUPfn2dMduXfPHQ903ORdsnBPBW+goqsJ/q5iVlkOuUiuhV8ZN SpvjAmv/pPQvyuEuulms+VnVu4BCSpFjvabBrkH3ihc/5S0aUlIFUiKpaPwe+twHfFQA 52qTIS+aRIAw860oNotldCpKNiUK2ZmsiHVcoKCoAGxcKL4jWCK+Bu9QQ7z1wa6k1VJn vKjK/kZQebvn7n2OE9XSWMpxiefCPHFXUIsZjJ/XDhmTjDKiYjXdcRzToOGxx58rAt1D FzGQ== X-Forwarded-Encrypted: i=1; AJvYcCVBRtaxQmGv3ixtONRpgvVeNZu9u4tlhTkoWVYvQDd5NvT9+iS0h/adFM0hyHkrae+o12rfW4Ve8g==@kvack.org X-Gm-Message-State: AOJu0YxtYCVJ6DBtIT9SAm0DbCk6F6qkHWt3y8CFc+tueFB2xiRqVyWu LLwUV6f26zFZdQSHfOJ239gRQwisOMuKM/Q0n3mKaLA9UDTR4vHh X-Google-Smtp-Source: AGHT+IFg2STZMVoLEFH25SB9VvPvMtDKxdVMTJq8hqIBT1wcTij7dNAFRM6sOQ5P3OBiwlO93rqf/A== X-Received: by 2002:a17:907:728e:b0:a99:ff2c:78fc with SMTP id a640c23a62f3a-a9de61a0632mr3039459866b.57.1730675718372; Sun, 03 Nov 2024 15:15:18 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9e5663cbddsm480326766b.145.2024.11.03.15.15.17 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 03 Nov 2024 15:15:17 -0800 (PST) Date: Sun, 3 Nov 2024 23:15:17 +0000 From: Wei Yang To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, Sidhartha Kumar , Lorenzo Stoakes Subject: Re: [PATCH 4/4] maple_tree: only root node could be deficient Message-ID: <20241103223300.kqx4bkb5tzz4xmzk@master> Reply-To: Wei Yang References: <20241020024628.22469-1-richard.weiyang@gmail.com> <20241020024628.22469-5-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8948116001A X-Stat-Signature: wjp6xpeknpfhje817ebxuzg3ds9yngq4 X-Rspam-User: X-HE-Tag: 1730675699-781858 X-HE-Meta: U2FsdGVkX18luDMwLFE8fDqiiv+CHfo4M5oClAaFW3fAIFQzmIkFI4N9v+Gej6ngcQwzGyVef851A5D3gi1cbkONhWuJUdP34KyGi0aWefijmXgjnXEJRrA+yOxztkv4j7TWy3HpXk4NTd8jp10J0cRCeFh9BXR7nGDnXl1g4CGT257IfTegMUx25vQlARNnC3bsckbY2ABwwIr6sVkk0HdIR1qy+wjPJbFKvKDeGzCymWFaLLGEdIn5HoQeBxisEqVVsB7J5ZYSEvEnINiYNzIY7M8H5NgwaDoxWU39lIjBOWLdCnUD4jVGKenGGWYduDwaudoS2mB6LdSEg16zcwWd8KrcfU+gtS2lP3BIY3sUHYW8tSLqTfzPKD4BGivpo9ZIG7uBriChvc2QfvNd6OYNTOnDmDygnntRAHysitP+D2ftyQi/QhoY6EC23A9YTAOEaECr+C7bKPOq89j46P1eYm7x3xaagKkDn+pnYOq4BK/3KXuy0+uYkJod32tI0qh858XLA51sA2AkJilEvlCqWRbocX9f2Zg+ETDJxzZB1GLEdS4DWLKuqGHYZMjKjoYgOxfge17UdmSy5mTVPkzLE1VgRh4vcpRTbz4c8rGrIc1wmfSn8v094olqI8L/WO4tAkpXA0VEc6uLM75nrPBaIJaLwI89RVU1onAasGUIR5WAseWQ19UVk7d4h4gjsFe+E0I95IprH0QluFLv59wICFZqyxcgdjv6sLwo7CVNoOJS4yuKS/bFPttpdffey4NYP23ws7GNERC9+tlSuY60WY72OMHbRfgp8OFMcYCyaj2PsRTcZYWL0WYDqBI4bzLHMEWZXs+omJ9DVoKYkotfOvDnB66WMdjHlHZHpUQX194D1/IOuM2VCbG0t4XfZ09RSqHW5jNA5y0dRn3VRhmxEoQY1xeL/W+PNvkR5iex+wGqLMAnQBUSRWnCCoTHiRvCvIrRzAZYDpv3cyb tpGytgb0 U8KgJGMV3pBR2Z+Aq6vhF73tT8VNfRrfbu9vwtDqQI/EJEyiZPGt0VhODn0q/QjncD7mPNk53/xDF2lT6vlQUuuDlJ7qw/dJ8nJkfbt7/GsOFxtOUr5w6eYLLdQUvmv76JzoyqGpZgpR1naWVjXTnRLcLeJz2QWh1xDongeCZDPUX3tNB1jR9CtD9ehGAmI71vnmgkdrh7ntLeAkCuAb6gC+B5fSYdRPrPRX8NPHmgzoaqPYDOJxh5J6OWVT0RD0HRTqpEFqS2xRMEEhMN7JmnrFljiSf9x0b8cAGcY3jY7VIUsA6C2G30Nmq11P2HbCteXGDNiNQGhvCyRfQD/nk15LeG8so4rDHGEayNK8SN/gyrjlsVmbGZcEZZmCERKsDkHqa9bkp4DbZlHAGbU5lad7cLyDBCLkIAlkSdEK9xnsVcPVgaJUZG/v05sfl+Axb7zrwEcmu4KV1P3TXehHoTFqU1S9neiVKile5FSUsIp6jEt3PGyp1ULH3TJJd67bcqhQ5SV9yK4Ut+DScGssKP6j7tv6S05X24XFpqxdRssh4KjFfFsOy4Rvv7MqYlhNGEBMU+jebrvzxqiTh40bvnUEmZFik8jgz8l1VMRDyfiVfOloRFrltHhpnVy/Zz9HKnK3HYyc//aS5QC09A2zvDRJnrYZ5/FxAWXONvphivya6CdKMFIk1Hu36rCzSu3drEsbyycEY/0YL6E8fIkriLScSxA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Oct 20, 2024 at 05:56:36PM -0400, Liam R. Howlett wrote: >* Wei Yang [241019 22:46]: >> Each level's right most node could have (max == ULONG_MAX). > >I think each levels right most node MUST have max == ULONX_MAX. > Yes, I should be more accurate. Will adjust the message. >> >> Only root node could be deficient. > >No, root node deficient is defined as having 1 entry. Only the root >node may be below the minimum data threshold. > Thanks, would rephrase it to "Only the root node may be below the minimum data threshold.". >> >> Signed-off-by: Wei Yang >> CC: Liam R. Howlett >> CC: Sidhartha Kumar >> CC: Lorenzo Stoakes >> --- >> lib/maple_tree.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/maple_tree.c b/lib/maple_tree.c >> index c2d4b188646c..e6b2ab5e27b0 100644 >> --- a/lib/maple_tree.c >> +++ b/lib/maple_tree.c >> @@ -7610,7 +7610,7 @@ void mt_validate(struct maple_tree *mt) >> MAS_WARN_ON(&mas, mte_dead_node(mas.node)); >> end = mas_data_end(&mas); >> if (MAS_WARN_ON(&mas, (end < mt_min_slot_count(mas.node)) && >> - (mas.max != ULONG_MAX))) { >> + (!mte_is_root(mas.node)))) { The change here looks good? >> pr_err("Invalid size %u of %p\n", end, mas_mn(&mas)); BTW, this patch could apply on top of current mm-unstable, since this line is changed. Will rebase it in next spin. >> } >> >> -- >> 2.34.1 >> -- Wei Yang Help you, Help me