From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AA9DD11101 for ; Sun, 3 Nov 2024 15:20:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D4E76B007B; Sun, 3 Nov 2024 10:19:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 95DED6B0083; Sun, 3 Nov 2024 10:19:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FE5A6B0085; Sun, 3 Nov 2024 10:19:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 596A46B007B for ; Sun, 3 Nov 2024 10:19:59 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CE112AC733 for ; Sun, 3 Nov 2024 15:19:58 +0000 (UTC) X-FDA: 82745143152.26.41A9A1F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id D4BB61C0025 for ; Sun, 3 Nov 2024 15:19:18 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=j5cWNoE8; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730647114; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2Wvx0XOKfGs+Recd6943nsECYiCGgVMKahj+Yyyubsg=; b=s3rymJau+ALzZ9CvSYU2veGRVOtTXcBlQvz3FBTSEa+1dS+yBhLzfEiDUA0e9dQ756p+xx x+O2IckzquoYrv1RK7i/k4RS8pYwDtNHZ0Mui/xrLaWfGZkUUzIBO6QMY+DCG/AZ88W/L3 i89U1XdoFvWr98ADJUMN7h/vLsOSwYE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=j5cWNoE8; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730647114; a=rsa-sha256; cv=none; b=hqM17THPRRRW+wOlY1xPjdB7IXrZBINk6mn4ykjT4Sec5cLxVRB5/uSx12YC0JIo1QDrwM qmkp6OuNLX1GMKjkS0MPyOnkq4DO/EJxf/uil288pPuZIDe6KYRPwdLPmZ/QCQEj1zqM+h 0VjsXGrlJEEOsn5SgmSkBPLRXDtW50A= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 15F335C4A07; Sun, 3 Nov 2024 15:19:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D95DC4CECD; Sun, 3 Nov 2024 15:19:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730647195; bh=SfCXMZbNHN7ZBHtRMXT8dYyPlDizsgfBlczM/Izb1OA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=j5cWNoE8etENxU7IbfrBszJT10f6EWlfJqpPGvOpaZLTiWI1AidHTPWSL24msep+k At1fyHSehamOum/Kpf4tDMLVsWjyCbFVB1L3+uJPROcdL+JtfpRWtGbmTmmXws4+mU 6Tax5d+Pem6waJZPuDXZsKSMbCUFxwDHGiatqmjanHAiNyMOnFy3GO/14wUoY9qDlK mafUcrdLGbf/qNYnEXemxmwc/kgO13ERQSBD0Q59NhZKcEgGCMs/Jsfq3Fei7V6xWc KS0Si/iP8Vl1pnx/fUh5aIOdBMiN7U2MYN4bxu2bUCfSI0yrbv2ocwZ0+G5O8IPgHi San3mdWHVOs/A== Date: Sun, 3 Nov 2024 17:19:46 +0200 From: Leon Romanovsky To: Zhu Yanjun Cc: Jens Axboe , Jason Gunthorpe , Robin Murphy , Joerg Roedel , Will Deacon , Christoph Hellwig , Sagi Grimberg , Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 2/7] block: don't merge different kinds of P2P transfers in a single bio Message-ID: <20241103151946.GA99170@unreal> References: <34d44537a65aba6ede215a8ad882aeee028b423a.1730037261.git.leon@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D4BB61C0025 X-Stat-Signature: xacztyunxishcr15tz537f4jweridgr5 X-HE-Tag: 1730647158-617271 X-HE-Meta: U2FsdGVkX19U9UBv7j2KI6kzl/iQmk02ceB+rx535r3Zr4p/yL9v4QuavSNlrORsgyVQHJAb0ejZyV1iQ19LsLiHIX6+5g24TgelqxtuFYLiQwYLXO4ApwuX1X8S0dYmaYbAeFb4fhAkt2DK84JdHNvgO/RUREWZl3HUYI5LZIfR+9sw+ndQ7CvDbOxlrSGjDZdAnm1HqQqDiq41vw9ercms5BO02aBJg+OQH0zGs7g3i0K0r7jv6AE0hKqAIoxZzukO7Ygd+LbPH22k++s1l6kyVuEbaKLurWBk8X+7oKAIKjdBVrxJgOW4CqWje76PCsyu13p0S8NiD9VkEzc2Lg+7OmsWm/9bHNi8ZKBf7GLMANeF06YTXmqcRL5Weyxs1sC9fzj3wPdRGT/UhRrMhkQRkhX34YT9+vthsxSXkE9BtyLjOAiJbwe4dBqUMpWFXTjc5rSmCqlOzqmzw0lLKukRJDoLEjmO7YVXVvNDoSV5yWJtWz84rePrceiRQgP6Xd3i/jbYBtLf494tlzewKWz1HZ7XTpvn5iLtAbrQ5tlNPumGC9FumEl1mZ+dvoT61NxPXOEj99HxSs4Zc0OSpDfIQurhhv4Y2XtMIBmGdp6yxFJAwtc3Bj0aY7ywyi9OR16uHT3KPl7E7YXhSEqWLLEr+JvGKmniWn0Hr+dS4/rAbjIWwa9JPXIuQxnpxN8Pn5y5BPlCo2Uwrdx3VR8FzJ/I48vduHYHIBfH4ruJl44xUSEPnzsgK/YNKSQReiQVHsqY7OhoKpjPYGWbPXNJs83oZLnDd2rJRlCnaSk//UZt5RwxxEylNmXScM3gRnhB6nYCTU/AYZdcNw3KqhnxTLlLLD07GYC+MIkz1xvvbJrjO/genmo8KiPNFtLd/FPMg5zyFwOIMU9twrn/dP9dQamKuzFgSvVqg3/b4R1uSu5W6KoRlh96lulYt9SSvifk2FAUiAnuPhjntT/vniC UpJ/5j5A fmYEgmqoZ6i4fJiaQZdWqowhy9T8DisnvU4soCvI43o7cM+iGexJscOwd1akK9oQQOSOfhjYsrT7DP6RZqnDP+iqe+hHNZVbAkF+7M/uAJBgah9VtB2d2d004hD+o4PPqVHdIxyFA4BZK1cREKPbEMF6wvaFATAyz41BjXaG2QlPzSTBgVsLJRzCNBIDxMbb+rKNq9NASFjIeDg+ypRn86AMILbscwoEwAbxQOxiHYan7Mz9TBabvn6WLvys3uZLiH1woBt6Z1wgV/tD6oiHdPcmChPfOslcOEAEUVFR/5WXC4cU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Nov 02, 2024 at 08:39:35AM +0100, Zhu Yanjun wrote: > 在 2024/10/27 15:21, Leon Romanovsky 写道: > > From: Christoph Hellwig > > > > To get out of the dma mapping helpers having to check every segment for > > it's P2P status, ensure that bios either contain P2P transfers or non-P2P > > transfers, and that a P2P bio only contains ranges from a single device. > > > > This means we do the page zone access in the bio add path where it should > > be still page hot, and will only have do the fairly expensive P2P topology > > lookup once per bio down in the dma mapping path, and only for already > > marked bios. > > > > Signed-off-by: Christoph Hellwig > > Signed-off-by: Leon Romanovsky > > --- > > block/bio.c | 36 +++++++++++++++++++++++++++++------- > > block/blk-map.c | 32 ++++++++++++++++++++++++-------- > > include/linux/blk_types.h | 2 ++ > > 3 files changed, 55 insertions(+), 15 deletions(-) <...> > > @@ -410,6 +411,7 @@ enum req_flag_bits { > > #define REQ_DRV (__force blk_opf_t)(1ULL << __REQ_DRV) > > #define REQ_FS_PRIVATE (__force blk_opf_t)(1ULL << __REQ_FS_PRIVATE) > > #define REQ_ATOMIC (__force blk_opf_t)(1ULL << __REQ_ATOMIC) > > +#define REQ_P2PDMA (__force blk_opf_t)(1ULL << __REQ_P2PDMA) > > #define REQ_P2PDMA (__force blk_opf_t)BIT_ULL(__REQ_P2PDMA) > > Use BIT_ULL instead of direct left shit. We keep coding style consistent and all defines above aren't implemented with BIT_ULL(). Thanks > > Zhu Yanjun > > > #define REQ_NOUNMAP (__force blk_opf_t)(1ULL << __REQ_NOUNMAP) >