From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF5FCE67808 for ; Sat, 2 Nov 2024 20:20:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3670E6B0088; Sat, 2 Nov 2024 16:20:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3173D6B0089; Sat, 2 Nov 2024 16:20:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DF986B008A; Sat, 2 Nov 2024 16:20:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F37186B0088 for ; Sat, 2 Nov 2024 16:20:23 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5C35BC116E for ; Sat, 2 Nov 2024 20:20:23 +0000 (UTC) X-FDA: 82742271990.02.F3CDFDD Received: from lichtman.org (lichtman.org [149.28.33.109]) by imf21.hostedemail.com (Postfix) with ESMTP id 18F771C000F for ; Sat, 2 Nov 2024 20:19:24 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=lichtman.org header.s=mail header.b=WQZqGS87; dmarc=pass (policy=none) header.from=lichtman.org; spf=pass (imf21.hostedemail.com: domain of nir@lichtman.org designates 149.28.33.109 as permitted sender) smtp.mailfrom=nir@lichtman.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730578657; a=rsa-sha256; cv=none; b=sqperDN0i1TSS1cKPjc1itxSJOTkcgVQkJkDlvhMYAj+sCUGU5zqH2emJWfOsuwFFKyDbg Fe65++I8t8Scu8OSkxBl5h3QWnEm1dYIl9Ix+FyXZ44mfHgqhDkgtfLqW0JjkEHSbeJsaS 5p/bhuyzy1RbEATTu7Z50zo6397nYAo= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=lichtman.org header.s=mail header.b=WQZqGS87; dmarc=pass (policy=none) header.from=lichtman.org; spf=pass (imf21.hostedemail.com: domain of nir@lichtman.org designates 149.28.33.109 as permitted sender) smtp.mailfrom=nir@lichtman.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730578657; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sHxvENCmVHwbUXyC0fEeN5jZEOOiJ5go1j2J+NEmSao=; b=d6PtOclmi4ukiIlOcpphNTJTrmtiFgkELujWSQv7/wpTXlT9sy+fYKP4qP13sLw2A1dGHi Go3VP8SZjED6DYJgqjReTAdQtxzqxW/zVveI/HPSyV3l5gDYkJ0Ns68iVGmwlXxTUhX+bw L7MZZkdgeB52UGhCrI2w7dPo0H6OGaE= Received: by lichtman.org (Postfix, from userid 1000) id 04FD71770FE; Sat, 2 Nov 2024 20:20:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=lichtman.org; s=mail; t=1730578821; bh=MCQ3fDQH1zb0wCaMg7Jj/z86jg/r5zXBrm9w0LNaa5E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WQZqGS87fNtHQE/POPwg9D6SH7OeHuuxCiKV2c07DkbEhstJCoq3h12Q9E6RVavdn NiBXy77Qz2k25T7O6RzgU/ApY4rYBiRzxDdVlhg2jIh/QMA0gkxIlRhVModiGtwSDl WOJVB8JJQ7cVwIoM3OhWwtOmFg92w9+A/QQMnTnPRuPdjF4ReRgRi9RerILbF13GQy 5LtYvtLfpexyfqA/7ILWdIPBg/YuqF7NNqpUUgpqPa56lUKzJKiPBTyo1lZbJsDZ13 lA0cEPwscK9SBiYK/37ZrVt0TMYzwQ90nfkyiXZ17oG6uuPH0l0oqDGrVqQQidVWrY huOYTe46LeNHQ== Date: Sat, 2 Nov 2024 20:20:20 +0000 From: Nir Lichtman To: Kees Cook Cc: ebiederm@xmission.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] exec: move warning of null argv to be next to the relevant code Message-ID: <20241102202020.GA51482@lichtman.org> References: <173057792683.2382793.11435101948652154284.b4-ty@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <173057792683.2382793.11435101948652154284.b4-ty@kernel.org> X-Stat-Signature: pt6919y7k5gzcryph8eg6bb3b1y3km7f X-Rspamd-Queue-Id: 18F771C000F X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1730578764-249922 X-HE-Meta: U2FsdGVkX19UR4HCThUyhxV5fw8TeTNbn1wc4rH/57wB6Veniiosm+PMrax4+NmOywT7W/C02weUKpXOI1xdk67UHN+PPMj/rF/V0/7KYwwZVKVcCIXyLGtk6kqXlDhUQpZ2mMSlRCZZo1sy/JZ/Sx7B1sT1rHc3DS+SOqMnogBw/EDRoUvhY2v1e8SLOdyLA8GWdGtO5TY3rVf3u9kSZzy2FiuzMgjkTxZmdgoBikt5SBwqnaqn0oHC8cVX3NJ4ZeYRCdDnOfHlts/73cl0UubM/GNMCGh2Mw92Q/kEl7u79kagbIKuWp3DP3CAujEvVA+U5UFfEtfr0b6ZUA0kpH3UWlneX4Fy4kSC3kJQJ/DjYQQWfe+TYAEXRyoGEZoFlw36uLRDbkk7jIvi9YmH56kqiufNmdr6tN6IjA8p66X4/frcop6zPYDMjXSylcgdCZLiCdq9JyNgRgKtX2iZsSnAunw+TSGoK9GqMlZdFzp/htxDqrRlGmTaPJ7axRoDZDZBZHHhnPGTHjOOwOrdjE60+OrImscQHyxFeWFyYTMTTeKS4SluopunuHDslCVWH4GrFE60ltUf2d1EkkPbP10lNqN6ycKZTUOBhE2i2Z9/YTxh8ZhQjq1VIjbJhbrRd9IMw4bUPezuIdXxmjSqnk8oA34sViuGXMEmEQPNbGp8SaKP9AaBQQbNRWzjTLK85eKI21YFOS2iCUQX2yYzNpjJoHDJB50It6c++lSAQNObPq5toGCLoVF11UpvKTfbB6uc7Wyc8oEC2hGRQzmCZPPei1HfHpav+bYU8EWs0vlQgREmDm1kmc+pjFNn965mPNsVfbKArPiOO4NynOI6kM7krhHnM8q3lY1OdU+HHsjj85vF3z89kAdaFTNquRoFKa0Vc9yTNjvLlcoBB94Kgu6BafL/Q5+QVhzlWbhQy2fL0qLwNQso7betYGe7E+hPwQhI2YJcVtOBhlLH7BY wcrf0dg9 KSqn9BH/+SLYqZXWJPNLHbBQnovtJ9icKqcRf35Hwln1DFoTpnwnyIvSAK7a2WQ0olKH5ZuSGr61Unnfa63HpAj6HhXvP1kMAZKVNwZM6cFK0D520YPOn+fJbDT41108SNOo9rQ3gUnbYn6I+y9jKqhWcRgC6Wk9+xsjJ0KnHf70RXn6lyzrhhvrKlvr83MoZajueHcWVPVnyDomOBK/a+U1evRM1442rA9mONAEc7JXc4lUzzuTBwmgRT4ji10YTFrHTTz5lhJPyICcj8Sz8uv+gJUb0HzmcmdEFvHrGpR9Z3dzilKhVUJWpCLZ+hvNmj4vpAkvj+IWBt/4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Nov 02, 2024 at 01:05:29PM -0700, Kees Cook wrote: > On Sat, 02 Nov 2024 14:01:22 +0200, nir@lichtman.org wrote: > > Problem: The warning is currently printed where it is detected that the > > arg count is zero but the action is only taken place later in the flow > > Applied to for-next/execve, thanks! Noted about the warn once, and thanks :) > > [1/1] exec: move warning of null argv to be next to the relevant code > https://git.kernel.org/kees/c/cc0be150ca0e > > Take care, > > -- > Kees Cook >