From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EE1AE677FD for ; Sat, 2 Nov 2024 19:58:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B73DB6B0093; Sat, 2 Nov 2024 15:58:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B23B86B0095; Sat, 2 Nov 2024 15:58:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A12DE6B0096; Sat, 2 Nov 2024 15:58:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 84B3E6B0093 for ; Sat, 2 Nov 2024 15:58:53 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 15EFBA0DF0 for ; Sat, 2 Nov 2024 19:58:53 +0000 (UTC) X-FDA: 82742217222.23.284519F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id 2645CC000A for ; Sat, 2 Nov 2024 19:58:20 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DdmKgENs; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730577474; a=rsa-sha256; cv=none; b=2LP/rw2Yt8ElqJ0G5r0GQayxn7uphOreawhlLoF2VmgLdb185N6QrOpd2XyhrrsswR6Ykc FWcklINjN1dLx35dfAYB5/5bKMmGGJJkVlxD4+N3inQqY7zgYS1NpyS9eNtEfjHJJFXRF2 KiqUVIBCTindHRa7An6dpPheWxBa58A= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DdmKgENs; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730577474; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+bV8VbTW7jt4+gr7QMc2WXmGw8loPAQAYroQ2CbdGQI=; b=NdTFq2HRz817LYKqZ4itXntTdj08FurdODg72JXLkB4WUjNvI6WpWmDdqW+oJkUoqfsW/z 8jBHCdYA+AXCJ1ZODaoaByiJGO4Oyy3Up5ZhTxk98jDc3Z2bWunhTSXPSDpd8ocOKpVBGH q/1bN8vtnkoL7o8MBXR+FHRNbf5zQDA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CD5765C4958; Sat, 2 Nov 2024 19:58:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61E6DC4CEC3; Sat, 2 Nov 2024 19:58:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730577530; bh=JUI6hhefhoPmDatTKsy4pqsfjwmhOnV4eb6LBjksVQ8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DdmKgENsI5ODLmVFU2RNr0QQqkmCaoHm8FA3BgVkYnpB/nGQyoTRgnZbFf0YxSIUD 7PEiu6+LBVAiAcb8Zs2CeSt/Cxd7h4p9RlaI5AUmuu7zN6pA/WJ5vQ3xxzG+PnJHju /Q2qZCl5fSwFi8G8rlsBrb3vBX5dLSsvWB2zCNAwaP5KirBFdPFzI6MPeuXBGBG/GC hF6VIdsI5bKImG9CkjtTZw3C64a55hbM9OgPjeUeCuBi89jvJAMnQ5/N8bTpYds22v iqRaBJ3EliDPPKpUlXahMqJ+UNpEfubJl/Q+G+TDFyTJHI3NUFiKFZsmVRAtCs+Det SN2d/j5IrA5lQ== Date: Sat, 2 Nov 2024 12:58:47 -0700 From: Kees Cook To: Zbigniew =?utf-8?Q?J=C4=99drzejewski-Szmek?= Cc: Tycho Andersen , Alexander Viro , Christian Brauner , Jan Kara , Eric Biederman , Shuah Khan , Aleksa Sarai , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Tycho Andersen Subject: Re: [PATCH 1/2] exec: fix up /proc/pid/comm in the execveat(AT_EMPTY_PATH) case Message-ID: <202411021258.6F1CD2AE28@keescook> References: <20241030203732.248767-1-tycho@tycho.pizza> <173041263505.1781237.9706368369948860422.b4-ty@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 2645CC000A X-Rspamd-Server: rspam01 X-Stat-Signature: rtye8zagtwqat895y66g9yjzu1hruw77 X-HE-Tag: 1730577500-789203 X-HE-Meta: U2FsdGVkX1+r2Tdzj6cN6yNu7bAbG5MBRvdFFwLGLwLYFS37J8FspsM5rf1/Ff0nmN7Py+TL+bIzWwp5xwnzoz99NmDYY7Jsm9sVxl3NQt+HdW9307tDXf5mDdJOHNhEB+PHF2OHyzEwTStuvj9VWtxGbZsRHL5YoOz2j6Z+AKtRKTM2cE6scs1pESh5r7ZQV6Gp2g4ZMiHUEG5Zuyn+jH42DaInOec3EMxo171tCZ8og0nGuA6W6eXU93bE5GB1jODByH0BOWKYAG3xRASPK15OugT3KQyDRRbzeitMa7nJAsWYhXFe1kU6Q+FjZgzQGU1Veasfl81Ra162yNgiTjgP8sdAKRiC6kF1iI5s2Vxd42C9CVZ4agvH6Ny/GEcRPficNTCnp5MT5SJbiBCMGGZoKm0+UakBgwDh3N4TC79W0HmdAgJiiPxc4M4RK89eX9yMWMHIL+mwPLFg7TSyDED75DRhiASZGD+FIlFF2fTvzKvnjE5lzugaUgmtaKhezGVADAM/W3cNOTbO/4jQZFXFTES04xs8BOjfgyQiK1GnC30/3hScPlIJL0qRoDhSLsozuPKALfDCFUSnW7lI2has7uG56ieAYcwmfq3RX3orEmXlPaya9fEsd1InOScFwg9qNo6Xtvng0YZLWrEXiKnZaoX30vidhCRU8PAlo+X56ghJI83RIf3UkfRvENtonHsE8v1/RjuERdKtHtNfLgh++xmJKZcXC16i7549TdffPKrwEjKkCvBHEeOiOjsLBJ8u/m+ShP3iiMYU2MMtYPDhxPHvbDmGUi2Ex7l8Rnkv2ivnkVUKdg7zKxJiIt0IcG9plxhj6NUGvHViY9PuvSZKLxseFVpfhjjRUlNQ1F94C7L40ymCfum0VY34kkjg1JwkZthFtb02GImyqAgBhps5grVtMN3SVLeFEI9uLfgjeRKQdmT/LvYVfUx+gvAfCoxtQgXvhcIBQTfzkrs lfHpeMmg B41ilQijEcTWTFWzO3cMbs8w+FJB8dHOQBrrFWjfrJLnFnc+QMW5L7MRu5eY9UnfMxJW7WZZKIgfJpbr7q9qm6SyncSkv4epKFU+jpUKBJPY9JEeB+BQNblk+uTAmfq2CmcFO0iCN8slOrDixBe6/0F/ZOBXCKLdBWJawVkiRHunEQLdo5aQIPqMOScCo616ugLvEmbm60fYvKEkbQBnwlIaFUqC1FrLIAVuG7iwiLdAYjWBiUpoGPwhWbMsLRgQf07tgihFRjsVhehGElPdis/5bw+3gWPE/wj9p5DNGszO+DXazAwDyotCy7P3qVw1uKYU9eG+b8bC7mE7mC+MCDmzplIQ8msyhm+mj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Nov 02, 2024 at 11:29:55AM +0000, Zbigniew Jędrzejewski-Szmek wrote: > On Thu, Oct 31, 2024 at 03:10:37PM -0700, Kees Cook wrote: > > On Wed, 30 Oct 2024 14:37:31 -0600, Tycho Andersen wrote: > > > Zbigniew mentioned at Linux Plumber's that systemd is interested in > > > switching to execveat() for service execution, but can't, because the > > > contents of /proc/pid/comm are the file descriptor which was used, > > > instead of the path to the binary. This makes the output of tools like > > > top and ps useless, especially in a world where most fds are opened > > > CLOEXEC so the number is truly meaningless. > > > > > > [...] > > > > Applied to for-next/execve, thanks! > > > > [1/2] exec: fix up /proc/pid/comm in the execveat(AT_EMPTY_PATH) case > > https://git.kernel.org/kees/c/7bdc6fc85c9a > > [2/2] selftests/exec: add a test for execveat()'s comm > > https://git.kernel.org/kees/c/bd104872311a > > I tested this with systemd compiled with -Dfexece=true and it all > seems to work fine. Thanks! Great; thank you! -- Kees Cook