From: "Maíra Canal" <mcanal@igalia.com>
To: Jonathan Corbet <corbet@lwn.net>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>, Barry Song <baohua@kernel.org>,
David Hildenbrand <david@redhat.com>,
Ryan Roberts <ryan.roberts@arm.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Lance Yang <ioworker0@gmail.com>
Cc: linux-mm@kvack.org, dri-devel@lists.freedesktop.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-dev@igalia.com, "Maíra Canal" <mcanal@igalia.com>
Subject: [PATCH v5 5/5] mm: huge_memory: Use strscpy() instead of strcpy()
Date: Fri, 1 Nov 2024 13:54:09 -0300 [thread overview]
Message-ID: <20241101165719.1074234-7-mcanal@igalia.com> (raw)
In-Reply-To: <20241101165719.1074234-2-mcanal@igalia.com>
Replace strcpy() with strscpy() in mm/huge_memory.c
strcpy() has been deprecated because it is generally unsafe, so help to
eliminate it from the kernel source.
Link: https://github.com/KSPP/linux/issues/88
Signed-off-by: Maíra Canal <mcanal@igalia.com>
Reviewed-by: Lance Yang <ioworker0@gmail.com>
---
mm/huge_memory.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index a6edbd8c4f49..1ebe18ec4560 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -969,7 +969,7 @@ static int __init setup_thp_anon(char *str)
if (!str || strlen(str) + 1 > PAGE_SIZE)
goto err;
- strcpy(str_dup, str);
+ strscpy(str_dup, str);
always = huge_anon_orders_always;
madvise = huge_anon_orders_madvise;
@@ -4167,7 +4167,7 @@ static ssize_t split_huge_pages_write(struct file *file, const char __user *buf,
tok = strsep(&buf, ",");
if (tok) {
- strcpy(file_path, tok);
+ strscpy(file_path, tok);
} else {
ret = -EINVAL;
goto out;
--
2.46.2
next prev parent reply other threads:[~2024-11-01 16:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 16:54 [PATCH v5 0/5] mm: add more kernel parameters to control mTHP Maíra Canal
2024-11-01 16:54 ` [PATCH v5 1/5] mm: fix docs for the kernel parameter ``thp_anon=`` Maíra Canal
2024-11-01 16:54 ` [PATCH v5 2/5] mm: shmem: control THP support through the kernel command line Maíra Canal
2024-11-01 16:54 ` [PATCH v5 3/5] mm: move ``get_order_from_str()`` to internal.h Maíra Canal
2024-11-04 2:25 ` Baolin Wang
2024-11-04 11:16 ` Maíra Canal
2024-11-01 16:54 ` [PATCH v5 4/5] mm: shmem: override mTHP shmem default with a kernel parameter Maíra Canal
2024-11-04 2:33 ` Baolin Wang
2024-11-01 16:54 ` Maíra Canal [this message]
2024-11-01 18:30 ` [PATCH v5 0/5] mm: add more kernel parameters to control mTHP Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241101165719.1074234-7-mcanal@igalia.com \
--to=mcanal@igalia.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hughd@google.com \
--cc=ioworker0@gmail.com \
--cc=kernel-dev@igalia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox