From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85138E6F06F for ; Fri, 1 Nov 2024 16:48:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14D0C6B0089; Fri, 1 Nov 2024 12:48:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FD866B0093; Fri, 1 Nov 2024 12:48:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F07B46B0096; Fri, 1 Nov 2024 12:48:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D31A46B0089 for ; Fri, 1 Nov 2024 12:48:38 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8E0021A09B0 for ; Fri, 1 Nov 2024 16:48:38 +0000 (UTC) X-FDA: 82738108488.03.2B3ABEB Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf04.hostedemail.com (Postfix) with ESMTP id 7F7A340005 for ; Fri, 1 Nov 2024 16:48:00 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=HpLdezW8; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf04.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730479660; a=rsa-sha256; cv=none; b=oEB+bifBDWkbT5wAGc8mi/h7oF4LmOOq6nLtqNgfASnn5pxx67VkD2h9gUa5A/QOftFeQX vJ+h95M0in+yyuBgtxXeGG5N0fELQ3c0e4LcQt99dBHS6VuqAdGY20mt1NKl+yOTeHB6rZ GPuq5v8ylTL9fjY9nMK7wm7o72z83no= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=HpLdezW8; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf04.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730479660; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OMMDrgLOSB2qpzgDwcq8B2U0GznJU8oQ+4h52sCCWjg=; b=zt4cF/MGUX+znJYZxMW4OjoMAprQvMAzKsXYHOPa0Gktm2eYWaMY3dkbxSsINA7vige/8j aWYjUosRuVPInNrMkB/WyZA3q9VQsKZcCzdtIm4FB/R/LXPTXWa9O8ITj+8b2DG6t5Udxn /qvLd0vUWFoZ7a1uaEKQSlCZrSBseZU= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 5E70740E021C; Fri, 1 Nov 2024 16:48:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id e_X65bLd7ZEI; Fri, 1 Nov 2024 16:48:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1730479708; bh=OMMDrgLOSB2qpzgDwcq8B2U0GznJU8oQ+4h52sCCWjg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HpLdezW89bcbIP48ARNiRiO1jZBz1adgCt9GZooz/jLAxxbfGeYjyAivPmbsqxd4c UwsPIl2tUaVrJ/Wl297DPj87dHaec9g0HbXlGSYtIZznpW9Uc1ARsguRWeJhYJJPma xJE/HibJR0GTPZv3gTluwzBLVNBM/bunsQWgQNrl+vB832YxnerRsP0+hhm+yhRYB3 H/9krU239yGIljkrH4zsWBswaPylNbIRfsVW/2MHdTQbc5TyFLoJ6BZuESHMsIY+Ya 9h1hCpGnf83g/HNH5Wk/9r4YcIa9DZSBvNhZknlROcuGzVAvOfrZ8z+CMg3gJCW7vM LQCGC4SbXDfo9+PpraS07geDr8IVQtF2nL8i3VCn3ySw1IGQJxoi5u64ItE1GAifjO LvRyxRv1LV7Vfe/MKJ0zhhJW9/0wkCuI8kk6JfvT/UnGOTauwjwQXmi8Vu7zg2kMTN 1cl6iINfWBRpdRj/5jaa/YydoLx464xbaPHkAVFFJXNqA+XEDzAakE7+54ozTe8JWd ABl7ElLJnKQh9RVxIdg/IzNPwVYkotG+OidXRQLN2+t31YiY0YoiuffPuD6L/IgU/4 d2xUQRRc2lmTbkrBvBMie6B7Xd1kOkO7tHOhx9loF7N0nIUfZLyDfdJI8uXYIAXiwV k50KPDzTo9HOBZfyqjC6tBq0= Received: from zn.tnic (p5de8e8eb.dip0.t-ipconnect.de [93.232.232.235]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 1085540E0219; Fri, 1 Nov 2024 16:48:02 +0000 (UTC) Date: Fri, 1 Nov 2024 17:48:01 +0100 From: Borislav Petkov To: Gregory Price Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-cxl@vger.kernel.org, Jonathan.Cameron@huawei.com, dan.j.williams@intel.com, rrichter@amd.com, Terry.Bowman@amd.com, dave.jiang@intel.com, ira.weiny@intel.com, alison.schofield@intel.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, david@redhat.com, osalvador@suse.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org, rppt@kernel.org Subject: Re: [PATCH v5 2/3] x86: probe memory block size advisement value during mm init Message-ID: <20241101164801.GDZyUGQbe6g4FqtPf6@fat_crate.local> References: <20241101134706.1185-1-gourry@gourry.net> <20241101134706.1185-3-gourry@gourry.net> <20241101155147.GBZyT5E190IxnQMzaP@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 7F7A340005 X-Rspamd-Server: rspam11 X-Stat-Signature: 8onndwscpps4tjqy4rh8q31dh3rx6hgc X-HE-Tag: 1730479680-906997 X-HE-Meta: U2FsdGVkX1+6vxHd0ZskvJPuA4sKGDy7W1kXFC247Db8qAjeoTIqk410tFZAF/+hPZH0UB82TVRhj3PdmB92/PDa5IjaB9E0NZ/cTiONDGJd6q8hVrdMIYsTIyxXTfmdQDm78GFDDsAPtkwd6GCJNa2aGVST6MOrCAI8rP3jbSXrcqPd+mIOhurFZerk+LcRlV7vSTA7bdOfsaMrlzXT085ivpT+I9ax10zI+tlnb7ZU+U7775OsyD1fvG18PMr6KgrdD41mEOdRHM1Apeb3TSEYZ0I2aULoHtV9dH04MM6UFCh7PRrje+OJ4WUm+uZLHboL/UM2vL7/CCyIOPY4cLspL78fEmnJsbeKae8GQnVGrtl1uzXuad3WS+RBlWjiUfIhJJztyFSH03pdofJ3VLiREE99+GrlvMw9axz9RR60GrIcKgvFtAEbLFg3Ygs+3io2fzblaGViLFZW58iQdf/KVrD00BBi6dUXirYF3OO9W26s72ZCbQ0IfJaCyXs5JnNArVXufbN9wQzLF5ygoeL8A2VBE8/SmAHrJ4kUlRB6ert2dYUOTby7GU6sp7dZe4+k2kEszi7GQTOX2Ee75OjMMCbo9PnQrkhnK2G54E6GOe0viFy4wrE01DBP3XWBiceozMqT+LO7QK3UKa1oXhf2OrWVhvxn6eg4acDESK8vm5xotPV/cUh+ytDNe7fxuvFD6AHUd4VbdBYeh7uvtrr68FbE8t8/bUTOaTLL1/BGT52QHlRtMIPUuDtKdrspLBzMurP5MTkHVglTPENnXTw3Wje5QUWewv9d9ywOcucezkQKSHuoyXQ1w7DzBg+iDggKSpexnpxvZwqqq0O4Yj+4qCdoSm+q8UA+hk8QFFKVGc4ODaBTxnwLDSl/N4le6WlSi8z1daCGD/G8OsBfUaBSHV2B71Lv8svgLVN3qhz05EJmSDKwrICJXRsgXwfbOFH1nJ8dguEgKCVro5b S8yZ37sD gF3VDG3qj9ZV0xCFBUCStWWavdbwUNoBBK9O2+mLxpxgNCcEblwKROV1K2EydMZp2Xf9rbCoosu7Q/J5KkIIppp7r+jAjgy2YXKgfsaL4ZXpsiN4IJeGruBKpgIG04Q+asOSowM+89RKhAglS22VFcOkV6ojzi9kHGTo/ApgpdxsodeOC5yQQLRsWgW5++8n4EOxHVpNQVOu/3rozuC3MxZs8t36uoRr1pqsA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 01, 2024 at 12:19:08PM -0400, Gregory Price wrote: > I don't personally understand the implications of this switch off hand, > probably warrants a separate patch submission if you think it's important > given the original logic is boot_cpu_has and I don't want to increase > scope change here. We want to switch the code to cpu_feature_enabled(): https://lore.kernel.org/r/20241031103401.GBZyNdGQ-ZyXKyzC_z@fat_crate.local and it is not increasing the scope at all. You can simply say: "Convert to cpu_feature_enabled() while at it." in the commit message. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette