From: Borislav Petkov <bp@alien8.de>
To: Gregory Price <gourry@gourry.net>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-mm@kvack.org,
linux-cxl@vger.kernel.org, Jonathan.Cameron@huawei.com,
dan.j.williams@intel.com, rrichter@amd.com, Terry.Bowman@amd.com,
dave.jiang@intel.com, ira.weiny@intel.com,
alison.schofield@intel.com, dave.hansen@linux.intel.com,
luto@kernel.org, peterz@infradead.org, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, rafael@kernel.org,
lenb@kernel.org, david@redhat.com, osalvador@suse.de,
gregkh@linuxfoundation.org, akpm@linux-foundation.org,
rppt@kernel.org
Subject: Re: [PATCH v5 2/3] x86: probe memory block size advisement value during mm init
Date: Fri, 1 Nov 2024 17:48:01 +0100 [thread overview]
Message-ID: <20241101164801.GDZyUGQbe6g4FqtPf6@fat_crate.local> (raw)
In-Reply-To: <ZyT_fLBsVLlcnYNi@PC2K9PVX.TheFacebook.com>
On Fri, Nov 01, 2024 at 12:19:08PM -0400, Gregory Price wrote:
> I don't personally understand the implications of this switch off hand,
> probably warrants a separate patch submission if you think it's important
> given the original logic is boot_cpu_has and I don't want to increase
> scope change here.
We want to switch the code to cpu_feature_enabled():
https://lore.kernel.org/r/20241031103401.GBZyNdGQ-ZyXKyzC_z@fat_crate.local
and it is not increasing the scope at all. You can simply say:
"Convert to cpu_feature_enabled() while at it."
in the commit message.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2024-11-01 16:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 13:47 [PATCH v5 0/3] memory,x86,acpi: hotplug memory alignment advisement Gregory Price
2024-11-01 13:47 ` [PATCH v5 1/3] memory: implement memory_block_advise/probe_max_size Gregory Price
2024-11-01 16:02 ` Mike Rapoport
2024-11-01 13:47 ` [PATCH v5 2/3] x86: probe memory block size advisement value during mm init Gregory Price
2024-11-01 15:22 ` Dave Hansen
2024-11-01 15:51 ` Borislav Petkov
2024-11-01 16:19 ` Gregory Price
2024-11-01 16:48 ` Borislav Petkov [this message]
2024-11-01 16:02 ` Mike Rapoport
2024-11-01 13:47 ` [PATCH v5 3/3] acpi,srat: give memory block size advice based on CFMWS alignment Gregory Price
2024-11-01 16:03 ` Mike Rapoport
2024-11-04 9:11 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241101164801.GDZyUGQbe6g4FqtPf6@fat_crate.local \
--to=bp@alien8.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=Terry.Bowman@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=david@redhat.com \
--cc=gourry@gourry.net \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=ira.weiny@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=osalvador@suse.de \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rppt@kernel.org \
--cc=rrichter@amd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox