From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5597E6F06C for ; Fri, 1 Nov 2024 15:52:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47C676B0083; Fri, 1 Nov 2024 11:52:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4049A6B0085; Fri, 1 Nov 2024 11:52:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A64E6B0088; Fri, 1 Nov 2024 11:52:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 080066B0083 for ; Fri, 1 Nov 2024 11:52:32 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9E8671C6A7B for ; Fri, 1 Nov 2024 15:52:31 +0000 (UTC) X-FDA: 82737967074.07.844F4B9 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf09.hostedemail.com (Postfix) with ESMTP id 826E2140002 for ; Fri, 1 Nov 2024 15:52:09 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=Oc2g9E3M; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf09.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730476293; a=rsa-sha256; cv=none; b=sAjwxE/dEfFARIzVvLEpMpJX1oljPgeJDaZy+FOeEaiHQ4V8+cJCdqiZ4SeN7mMV2q9zKX pUN3hGVMhmU4ByraUcnYox+dz1VOZqdkvPLhaS7em9C+p6zYvwIB5FNkwXwPt8EBPZPLCC F7H0+iQ+kwjyYD72w+BIall0m0fq+30= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=Oc2g9E3M; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf09.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730476293; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ot+cpDN3KZgTcegLKYz3Z1iXBLYw+MQdN5T6/AjXwXc=; b=nD0KkM7AhXW+W0Q5FJVP3ix4pe+Su6O+6Fc7wtdAUnJOTh86ZFMuSoJx/JSSMNzC52k347 V1KWRmG8AkQbr3udz7WEmZNCXjl5GtPgeiCEIH0WuT/VWgaRLVERvtDBhUvhYemuAZRM63 2gvMvLcBodr0pH+nnYWbZvmuRwOpHzg= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 15D6140E0184; Fri, 1 Nov 2024 15:52:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id QRbgms-A4_gD; Fri, 1 Nov 2024 15:52:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1730476339; bh=ot+cpDN3KZgTcegLKYz3Z1iXBLYw+MQdN5T6/AjXwXc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Oc2g9E3M8kggscgtwga/u7mKVKyp3j5DXTEeBiGdybq88oRgLh47GNEAW1umFyZ/y pkdPEEQHR+4RrWcmE3S/+YND4dl43ugQBWaT0TjwGVV7GXzwGV8cQSrnOvqL65BqrJ IuVY850Yi73qoUJjiIPTALT+/hcwD3RCc8D7JBouOSMLBWhpuKk3EdRA/ucH+xCj1L ZgMsNyzXGRMgd95pmNQ5kNJvnSZiGx3o7lO+aIyfU9dp0OqbGGX5gh5UuCTCeaNir1 HAt04kbIySSpPTp+QglDlfiCHjx7/1s+MOX4Lfj3t806S7zKRAb0tgF3G3bN5OfmSx 96T227O2ky0AAENgtZ5pfJYu/zUZvnwj3rjlmVJF+gw2EW9n0CuBtD41sqV4CTkcud J/4L9nTUFFOrvRn9ww9kqsPrROnlEtoF707eWz1RXoWfwzuhSwRUqS4uDT5+G2HC8n RVA8l3+cvFr2R/TZC6d6jMiz29oH/fu5Q3IEWK1BrQG3tPuUeMpdjbqfJGRPRUCrj4 0BjV8v2Z8ja2UOCmGW77iqmz/nGsP8XImtoowihAbNwUmpXXcg5sS9FdmX8jkKLxIM yC4SiP/C+YLk/4ljVjcdrpgRoX0CgxKX6h/e9eLdydJBU6meg1IEPG/QGzvnSxxCpc 7HrPxIP8Lx0/0aDS1wtv5ld4= Received: from zn.tnic (p5de8e8eb.dip0.t-ipconnect.de [93.232.232.235]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 53D4140E015F; Fri, 1 Nov 2024 15:51:53 +0000 (UTC) Date: Fri, 1 Nov 2024 16:51:47 +0100 From: Borislav Petkov To: Gregory Price Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-cxl@vger.kernel.org, Jonathan.Cameron@huawei.com, dan.j.williams@intel.com, rrichter@amd.com, Terry.Bowman@amd.com, dave.jiang@intel.com, ira.weiny@intel.com, alison.schofield@intel.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, david@redhat.com, osalvador@suse.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org, rppt@kernel.org Subject: Re: [PATCH v5 2/3] x86: probe memory block size advisement value during mm init Message-ID: <20241101155147.GBZyT5E190IxnQMzaP@fat_crate.local> References: <20241101134706.1185-1-gourry@gourry.net> <20241101134706.1185-3-gourry@gourry.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20241101134706.1185-3-gourry@gourry.net> X-Rspam-User: X-Rspamd-Queue-Id: 826E2140002 X-Rspamd-Server: rspam01 X-Stat-Signature: rcme8sk9cre7pxwg6d65j4f1ocxih578 X-HE-Tag: 1730476329-698756 X-HE-Meta: U2FsdGVkX1/sLPqR6s4Qn4hck8V8pQV7NlY4HZW1JAkDlZRLfUcsauGAMRDKBddMw4TZheLtzixIL755nyQoNoXNMO9rKJ7yuQrLpiCeKDFa72kwgFUtgbweDRBVDJEjnkUcr36TJEst3heBhwuIF1e/+mKwxE1NgohcWkNGgoQTL394vgL3vim7foTjQRhpt4ZjYyY1BAZjczDtVgksm6OJyjAJ3isr/pEuOllAwmhwgxixcx/+kS1iWM8QIx1m4aVDFY87R9Nq3xmxXbGLnkSBwPJ1pUrlvNK7B/804zXrotcAs7Tiz6P4IJxPJryuaEHp2JSi5FZWI0kNV2C96GIP8UwiaFv8iXT4KtaOe2Injau2exzu68h4H8c8d/dLq43aivzA3S1zjz/ER+hNZT1HHe4cSZIb9iwpZ7Xx2qtqMTIabnB/YDvSODn9nK4/yF5v9MUNxKZSE1wXF5I8v8FEP0PgkZSXq2ByCcFOZ3BWD7Ge5MUG3EEj41dFNO9uuM5Me2hupXcVOBp/rDMyezY2bDtE4mX3SRKMkmkEaNsFzmiUQo0ACqzwcBTiitDLoTf9xt2Jxgy/jW+FcN6ga5HYKtB6q8G7IWBoFyCmY1EtRlt/DKb0SY9xv/a6lXV7ucQSDBrq/xrtwY8GamY4ND1tQUqTyVH64Vf32Ssblg6OtOoF6bpoS2LcqeFIKRvQKdAOhw/KiV5kpn40NJ6HzDNFqWOqCQTq/AngT8lS98D2Vv9KWLfy9t23oojxpCKHejgw0q1hgXh4P0prZgSBQSTFwJPkKXKSLyVTfo7+KOVMRdJH5OlEYHePXrb0uR51C/q8yuIJBOWl5wqgN8CT6bdzWrbyGg5lKILKW8KfeN9pP1Z98TUp2Tes9pxmPqR3MkAjOt2rsfDpihyAxizuYO2ojHB27OK4Il+IRFj7kY+9MZddRAJI3CWDOBC7s3tf7IhUPN6i/8esCbDTXHu fsS47QE0 603Ts/eKvABHPQtlIQ1DqpdgYdz/40yhoarHEMYTD9Nll5bzbiUgTIdYCpfVe9EmwVp/gxoY2UTLlaEp9K81U3j7ncYT/oAK3oL+mdzrjqZN6Rr6KFzx8DD560j4b95Ah5T0cyGbmvg/y47AmntOmodyPXyxDFHrK3f8ZLWhhil0dOKGcmt0k7fHdgre288JjpRz+zY+ZI/DVVyZPc1tvKNL1lmfOO9iyFam79uXs5RwteWKmzN0D+PDNoMFAF5jabe/TcYgHg71U4Ugh65KMCoJ+T+czNu0V5kCLBadOFTxc14Y9RfFUbgPRZw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 01, 2024 at 09:47:04AM -0400, Gregory Price wrote: > Systems with hotplug may provide an advisement value on what the > memblock size should be. Probe this value when the rest of the > configuration values are considered. > > The new heuristic is as follows > > 1) set_memory_block_size_order value if already set (cmdline param) > 2) minimum block size if memory is less than large block limit > 3) if no hotplug advice: Max block size if system is bare-metal, > otherwise use end of memory alignment. > 4) if hotplug advice: lesser of advice and end of memory alignment. > > Suggested-by: David Hildenbrand > Signed-off-by: Gregory Price > Acked-by: David Hildenbrand > --- > arch/x86/mm/init_64.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c > index ff253648706f..f1a495e998ce 100644 > --- a/arch/x86/mm/init_64.c > +++ b/arch/x86/mm/init_64.c > @@ -1452,16 +1452,21 @@ static unsigned long probe_memory_block_size(void) > } > > /* > - * Use max block size to minimize overhead on bare metal, where > - * alignment for memory hotplug isn't a concern. > + * When hotplug alignment is not a concern, maximize blocksize > + * to minimize overhead. Otherwise, align to the lesser of advice > + * alignment and end of memory alignment. > */ > - if (!boot_cpu_has(X86_FEATURE_HYPERVISOR)) { > + bz = memory_block_advised_max_size(); > + if (!bz) { > bz = MAX_BLOCK_SIZE; > - goto done; > + if (!boot_cpu_has(X86_FEATURE_HYPERVISOR)) s/boot_cpu_has/cpu_feature_enabled/ while at it. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette