From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DF54E6B278 for ; Fri, 1 Nov 2024 13:47:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E9506B0099; Fri, 1 Nov 2024 09:47:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 99B996B009B; Fri, 1 Nov 2024 09:47:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EB566B009A; Fri, 1 Nov 2024 09:47:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 613246B0098 for ; Fri, 1 Nov 2024 09:47:23 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D47BF40411 for ; Fri, 1 Nov 2024 13:47:22 +0000 (UTC) X-FDA: 82737652242.10.761244F Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf12.hostedemail.com (Postfix) with ESMTP id 320C940005 for ; Fri, 1 Nov 2024 13:47:08 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=E97ctTQh; spf=pass (imf12.hostedemail.com: domain of gourry@gourry.net designates 209.85.160.169 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730468708; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y+zdKugU7xiryBghEkTtjHu3m1t20HIVG0keEZ55skE=; b=lXebF/erAab2vcmTHrfqi1ayTln8+53rDoaJLLLEJAwj2iU50wuxfy54Kp407O1Zukp9E1 FDHGmonPrMCjcUe9nQpJYaah+N4PVmc6vOQ3QuQA7zLaqFbZkHfQfzJ9y8vB976VQIew6o T7iE66tEcmdugUNUynJP+cdnkGEttWQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730468708; a=rsa-sha256; cv=none; b=Rb1RsFNQJaipUVWz8UsY6w9wEQQjZVFY1Qdkg+h+GEhucLxP5dQ7H9vo7bBCJr75Ualze0 Y/JrM5BTWbWOuWUYCBg2isUnlPz6GVNUsBZXenwT2SxrNYEN2OOzDCtYkVJxSqExjH7z7D zfU5tLJwsEDakNY4zQb1wALpzyjVqY8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=E97ctTQh; spf=pass (imf12.hostedemail.com: domain of gourry@gourry.net designates 209.85.160.169 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-4613162181dso12460551cf.3 for ; Fri, 01 Nov 2024 06:47:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1730468840; x=1731073640; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Y+zdKugU7xiryBghEkTtjHu3m1t20HIVG0keEZ55skE=; b=E97ctTQhm9Amr628HMZQRmYI0qfow3aHnCgQ7khkfrCqbLFjgaeEQDlXt/27k0gD99 KLBsEVQHE1wdxOoxfCVsSN4o20eVn4qC5LikL8132clbgs9WyCKnC4XDIs7aOJIStFtl mk8VtlOthUEp05IBpCuPIO6r+4Vneu3xSnG0ZRtmXDUh4+RmW1zaxWimbca7tqq3eSs2 yhbhIXfXsDKHssB7SEdMrHgW4YGddDkSaNQBGBGXtzoixof7Iff1KSBkbeYmsM7XFyU7 ljmsKPd4qxxuH8Wr8ssBnYKpNW2hXRHAJ37Ns//JL3nU5QLnNY4/5SHwkbVdY/5Pu+k2 BaUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730468840; x=1731073640; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y+zdKugU7xiryBghEkTtjHu3m1t20HIVG0keEZ55skE=; b=xT/hVHvY5cmP+Oc3ruM0LTE4/q1m4eG/DH2HBM7yisTSN85PrNCh1X4eL95Xv3tidS PnzvrI8og7gEQCAMV5oJCPEGhG5oL/8pRzle7tyFW316GI1+EKJ3c+X21YZ3NREMSrHf cxA40p0FSTA1Qgemc4rjNKiFrJ38TVp/75lCAPG/QTlIIw/44vIjspYojU5Um7YQjTQW 3t6IBGgm/+VOu++m395cPTt6Xj54CSJVDWL+vGC5/oAGYH7ETp9zB2zt2GAVl1l/LlPb h4HyfZM0QNRjnUehg1EYpTfnHWWFZWElMJA/OSuN1Qf7f0RTZRQtliFfvPh3VUenGPad QCYQ== X-Forwarded-Encrypted: i=1; AJvYcCXHpJJOO6gCAVkwSScAi7JhSWf0aUOYnopSEWZV2TXK5km9ptMPI5oiPNFYLkNA1WlrJqogSuKJuQ==@kvack.org X-Gm-Message-State: AOJu0YwD/Xric27CMR47weW3Vx5bQ1bwTV0tB+v6XKhldtIAPkyFOJrW 0Gsp4qsNqosXMi3P8lSeiRbMt/wQonyZoIuhi14uPaOYGmw+eOTTRGNY4bGoxLE= X-Google-Smtp-Source: AGHT+IEqYRg/5UZkjuUahc1kZYI/R3+uQRVmb1D8Hw7IJxtfAawWOive+EatrYV0MOKL9iMFUrnP5A== X-Received: by 2002:ac8:5acc:0:b0:461:15a1:7889 with SMTP id d75a77b69052e-462b8680102mr46144121cf.16.1730468840141; Fri, 01 Nov 2024 06:47:20 -0700 (PDT) Received: from PC2K9PVX.TheFacebook.com ([50.193.156.113]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-462ad0cac07sm18840631cf.48.2024.11.01.06.47.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Nov 2024 06:47:19 -0700 (PDT) From: Gregory Price To: x86@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org Cc: linux-cxl@vger.kernel.org, Jonathan.Cameron@huawei.com, dan.j.williams@intel.com, rrichter@amd.com, Terry.Bowman@amd.com, dave.jiang@intel.com, ira.weiny@intel.com, alison.schofield@intel.com, gourry@gourry.net, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, david@redhat.com, osalvador@suse.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org, rppt@kernel.org Subject: [PATCH v5 3/3] acpi,srat: give memory block size advice based on CFMWS alignment Date: Fri, 1 Nov 2024 09:47:05 -0400 Message-ID: <20241101134706.1185-4-gourry@gourry.net> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241101134706.1185-1-gourry@gourry.net> References: <20241101134706.1185-1-gourry@gourry.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 320C940005 X-Stat-Signature: ixn3uxp1jwozggyfbijey9j84riighjz X-HE-Tag: 1730468828-321741 X-HE-Meta: U2FsdGVkX199exFx0592/hgpuxutLNF3D0NWL67sMxtWaIILMAYHBmiPcw5Y8ip/KVLYaLBaKlGtXo3QO2XWSaX27d3h5OEwNxeZS1CGrLn1pXAjvDOLjfcH/3XHPBuz+/eYYc18417q9VEM16tobQllM/3eK0aOfsiP0bCx6hyX9KE6dvrwPBSGuV9gz/bH778cGaG8QPKG4TWZYI5iPhX7i/sQk7G2LP9pELFleg+EvjS4qSMtRRUHBg6M0H0w5fdqq/RcJH494J9wSXGhCTunwoTM+QqwzgsA/n9ePIlQOC3ZCzSbKM85bqL3JeX2wHbsu+EqJCwO9aLhQzIcDrJgiVmRg+bEJPSgt3lkAzutMxGjRPJOZzGViAAyYtNUHm32ResmQzU+jJC+hWcFW1m87uAb+6KpmLLrjzVgAWStwpnNOzjbb6TAOdwMvN9pdo90qi0JbcelGvlnrHnIaQBBOqFPqBHoqMRjfjTmew7TxgCpVPUi91Bime25swon0zO6oGRf904/i9W36K/H1lK5dd6JCNw4CDQYWTyD9W7+IS0X6Hskb5VWaCBgGvh8qD08O5qlHtWeVsjRqXDDyzcG1+5MKTwn4LCNhYuzfdksUSWvOR5+XBh7hqwa8sOToZdV2ouhxrpQLBfMRmae32loERpZ9kyX6vnuTIoeRQ0k9u1o89HMjOlqf4WmjG/rx0ySlaxFwr06qVGGqUsJSNgscWEdV8B2jZ2mm7o4wckP+ZBqJ7gP17Mjof5gfhXbmm7J1mWwjgjZqTi2XlTqJebtUYvP+Jzpg+dbHCfWwQpGwLswBVdnhpgJFJv0CFULgFBOr/Lyx5/BJviDvb9kDQBCoMlQA63/379ovAiY23mRWl/og8GFmL+Ajz6bAZSGJDZIUzS3sWoMqU5b+27q+/O9nN/WqOF5go0rAVAjofuSkhwqMNgGkQe4CVQUJCYNfZksWEk/3pOE1vyEflw u7XHP1Nh fCQLuyaqj0sRnqeCtRzUkuMZ7mEPELg6OhSdkkqfXs/35cGhNXYkYfsuNZ7lJILljxyl5ncpGxvGpbzs7rwM24X7okQbhAAqcmVD1q0nle2F/xGkqz+VS/TX3VqAgSNdfD87/y+W3/mJ8CQJRBQ/QTkUoXGWs9K2ZlEC7gSd/cc8udnEFECPRpXE1ArJmAgr7mwozlGk907lxT9VWYoCXNEmfG7TQQ47SjEzUjQ3YrVILyJTr3/i79ornEC/X0ZNJkEFhZOAkc8ZJQCZ0i8DYCy7bXLnheWN0VKxF/Zy/z5ZOSZPyJV4uZU+/jaD2kLhrVcZgFL90PH9JcAw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Capacity is stranded when CFMWS regions are not aligned to block size. On x86, block size increases with capacity (2G blocks @ 64G capacity). Use CFMWS base/size to report memory block size alignment advice. Suggested-by: Dan Williams Signed-off-by: Gregory Price --- drivers/acpi/numa/srat.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c index 44f91f2c6c5d..34b6993e7d6c 100644 --- a/drivers/acpi/numa/srat.c +++ b/drivers/acpi/numa/srat.c @@ -14,6 +14,7 @@ #include #include #include +#include #include #include #include @@ -338,13 +339,22 @@ static int __init acpi_parse_cfmws(union acpi_subtable_headers *header, { struct acpi_cedt_cfmws *cfmws; int *fake_pxm = arg; - u64 start, end; + u64 start, end, align; int node; cfmws = (struct acpi_cedt_cfmws *)header; start = cfmws->base_hpa; end = cfmws->base_hpa + cfmws->window_size; + /* Align memblock size to CFMW regions if possible */ + align = 1UL << __ffs(start | end); + if (align >= SZ_256M) { + if (memory_block_advise_max_size(align) < 0) + pr_warn("CFMWS: memblock size advise failed\n"); + } else { + pr_err("CFMWS: [BIOS BUG] base/size alignment violates spec\n"); + } + /* * The SRAT may have already described NUMA details for all, * or a portion of, this CFMWS HPA range. Extend the memblks -- 2.43.0