From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5A8AE6F07D for ; Fri, 1 Nov 2024 18:54:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68BD26B009B; Fri, 1 Nov 2024 14:54:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 59ECB6B009C; Fri, 1 Nov 2024 14:54:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43F0B6B009D; Fri, 1 Nov 2024 14:54:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 26F616B009B for ; Fri, 1 Nov 2024 14:54:21 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C018CC0CF4 for ; Fri, 1 Nov 2024 18:54:20 +0000 (UTC) X-FDA: 82738425840.22.635F815 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf21.hostedemail.com (Postfix) with ESMTP id E2A8F1C0008 for ; Fri, 1 Nov 2024 18:53:24 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=qFYWzjwr; dmarc=none; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730487202; a=rsa-sha256; cv=none; b=QgIIa8s3NAJewGNGTvUf2IJgzKWC/aqXY7ts6AEPAfvYtNyuh2GubXYAeiJRVptdEuRk9m Zhk7PUmgmDCW55VRIWe7hXQhPXZiMr1PgDW6JXshGeqTG0XGqtQX1YV//Hg45Uz+NSjCgz VgBTXtTYZ8VuBEwpS9j9VI/7ELm4noA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=qFYWzjwr; dmarc=none; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730487202; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eFgWI4hCbRHDYM3pUIKrSvIi4g/BWCqzglZXXOqz1Cw=; b=D/yVYeq3315XqlfnTUNs99g7BGKkd1sn6wMY4hAlpBESX3yN8t+pxF/tQj0Pd2sOelUmAn 7nqkuT/WMmSZRdrRvLyzWDglDACVkjypihC6aHxsNF8zbUjTFPY1xdolXXVsOHZNrNU4kr mzzvdtun5GFOLDKMx8qr52ZgugugRyY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id F2A1EA44A87; Fri, 1 Nov 2024 18:52:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DAAF0C4CECD; Fri, 1 Nov 2024 18:54:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1730487258; bh=SUFxQ7ZLqI0rTTC6IQzP13/0lOXlrIozwL/6c1iShRU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qFYWzjwrK1CtLgKBZ9Yi/cThIRWOk0cu66mnAm5azK465QxY42od+XKxoPzPT8Bzr HOyNdSSCLlxegWeAIHEGBdXHj6X6pu2Ynw4OEw8pb5iXpTPqMDWd7C802CVQW8jB7M J7DGnMpxNIgzbbPAFueNuqFltz3vZLiOha4I1n6g= Date: Fri, 1 Nov 2024 11:54:17 -0700 From: Andrew Morton To: Muhammad Usama Anjum Cc: Shuah Khan , kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Donet Tom Subject: Re: [PATCH] selftests: hugetlb_dio: Check for initial conditions to skip in the start Message-Id: <20241101115417.dae7bfe1230575378e07a147@linux-foundation.org> In-Reply-To: <20241101141557.3159432-1-usama.anjum@collabora.com> References: <20241101141557.3159432-1-usama.anjum@collabora.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: E2A8F1C0008 X-Rspamd-Server: rspam11 X-Stat-Signature: ythu86swikmnsxaazyqk34yxm89j4ndh X-HE-Tag: 1730487204-906672 X-HE-Meta: U2FsdGVkX184VJIsLFz/gRO2ErtPYnCO44CsUE3emXON0ninlDvaV5BAVSQGvievs3c/5m7+B41sUUwpGPjzh5QeFt4l6LR+qD6n2xC9vKH4NsIAJ+5Ksi0PUkHo72Al0EhsK7OYFSc+jJLdEunba2vIMoxVYXRxAkO+VzMfI4Fy0ze3Faah/8ZcxhAU0ZcO56XHPKpva0XKZkZwDjb4ht2pkV26DQt9DDsS5sm0BO0enLVDMHzLifN3neZfaFk3j44XlXukuKXTMWMiShChGWvbdJmenei84kBKJF2cv/l8aiS24xITat9lz+HhiZMNHZeFXs7gXOTRBJO9ieIYs+eGRVOn/KaWFmSSuME32i+LLb1bJqEV/HtjzSIdSJTksVulyVnNoI+4+507uP3r6l3e7tsdePXGMyNLWXSjzhyDuZmSZCkfiwY5VFr7N/Q6zh4UBzncaApI66FJYsYfLj1SvXkQv/iJext9kH3xCEWqbX3dmDMCxYr/qi4zjmNrzc3ezOfU9saXZlqBnGv/iTRuWSZXzeAcgDYSCeC+yNDOHudrM6ftySyK7eeL9rcEYL2TreyQOT0lb/LAeWiXvBq41pMkqn264DxazcnBzBlFfaDLhsZMO5z6moFro5odDGYErtZt7pPK/+4K60YTO8GZsp6I0ofezgXEDOSDyBfrTRK97zSB/t28SwyvMj8Of9x4AbMurLItg2+WSXfYCS3Uglzjp3UC+FSZnaczj1nG4V6LYmmh6WOWPfWCTh1Ds+ReTZ+yFTL43+M4N7Hr1YCjIjGufB1Nf7KR6Axgtik1aRzBGpmPclBRq8pgTmf1AaUazdWOBSu6KEalqQBrep8lAhnrpqT9/ePi0Q0Af+hbfN5fY6VTPb2YVkGIoNTAciGb4CL0V1xTVL3+rzvCJhQU/LoBWH6290A5LKJw2OOtCFbYYY3nIOzAr1H4A221oK86MzMEPMkhYxgBlrP U4IOJNXo hDDgb8L6I8W+o8MtIBjdnfXoZdnaa7t5DInkacsZNUe3Cb78zG/EuaDVX90SeO/hncK+tJhDu69lgv+vkVP7EBIlWy0UdcooD6dPVLa660DYp1EdO7u70WX8zCN3bpuWJnoE/KfRIXHFD/sLVMXYddB0NYhUnR0BldSYm4Gph4AKX6yP2eZm3inVqhWpTK4JaisH07C9C8a7EQ2Ba8OXlQbsqBTIyKbWv+rdJpbPdYXiVXbbTSekE2nMDgz38cAWGF+V0aXkgZKj3j6CjV+LTGFcJeIBtPomfZoDkI9wl3xTEF4sssEX+SzakMzCAyH6hMeeyVKY6jYaaAOVvDVzXgQ8+8TTWAC9HpLsx/lYW9GBSQBG+XRhtkTjvR2p7AF9ArS12 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 1 Nov 2024 19:15:57 +0500 Muhammad Usama Anjum wrote: > The test should be skipped if initial conditions aren't fulfilled in > the start instead of failing and outputting non-compliant TAP logs. This > kind of failure pollutes the results. The initial conditions are: > - The test should only execute if /tmp file can be allocated. > - The test should only execute if huge pages are free. Cc Donet Tom. I added Fixes: 3a103b5315b7 ("selftest: mm: Test if hugepage does not get leaked during __bio_release_pages()") Cc: > --- > Before: > TAP version 13 > 1..4 > Bail out! Error opening file > : Read-only file system (30) > # Planned tests != run tests (4 != 0) > # Totals: pass:0 fail:0 xfail:0 xpass:0 skip:0 error:0 > > After: > TAP version 13 > 1..0 # SKIP Unable to allocate file: Read-only file system > --- And I moved this useful information to the changelog.