From: Andrew Morton <akpm@linux-foundation.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Shuah Khan <shuah@kernel.org>,
kernel@collabora.com, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Donet Tom <donettom@linux.ibm.com>
Subject: Re: [PATCH] selftests: hugetlb_dio: Check for initial conditions to skip in the start
Date: Fri, 1 Nov 2024 11:54:17 -0700 [thread overview]
Message-ID: <20241101115417.dae7bfe1230575378e07a147@linux-foundation.org> (raw)
In-Reply-To: <20241101141557.3159432-1-usama.anjum@collabora.com>
On Fri, 1 Nov 2024 19:15:57 +0500 Muhammad Usama Anjum <usama.anjum@collabora.com> wrote:
> The test should be skipped if initial conditions aren't fulfilled in
> the start instead of failing and outputting non-compliant TAP logs. This
> kind of failure pollutes the results. The initial conditions are:
> - The test should only execute if /tmp file can be allocated.
> - The test should only execute if huge pages are free.
Cc Donet Tom.
I added
Fixes: 3a103b5315b7 ("selftest: mm: Test if hugepage does not get leaked during __bio_release_pages()")
Cc: <stable@vger.kernel.org>
> ---
> Before:
> TAP version 13
> 1..4
> Bail out! Error opening file
> : Read-only file system (30)
> # Planned tests != run tests (4 != 0)
> # Totals: pass:0 fail:0 xfail:0 xpass:0 skip:0 error:0
>
> After:
> TAP version 13
> 1..0 # SKIP Unable to allocate file: Read-only file system
> ---
And I moved this useful information to the changelog.
next prev parent reply other threads:[~2024-11-01 18:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 14:15 Muhammad Usama Anjum
2024-11-01 18:54 ` Andrew Morton [this message]
2024-11-08 10:35 ` Donet Tom
2024-11-08 10:49 ` Donet Tom
2024-11-08 14:13 ` Muhammad Usama Anjum
2024-11-10 6:20 ` Andrew Morton
2024-11-10 6:34 ` Andrew Morton
2024-11-10 6:49 ` [PATCH] selftests: hugetlb_dio: Fixup " Donet Tom
2024-11-10 6:52 ` Donet Tom
2024-11-11 6:59 ` Andrew Morton
2024-11-10 6:56 ` Donet Tom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241101115417.dae7bfe1230575378e07a147@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=donettom@linux.ibm.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox