From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1D0CE6B27C for ; Fri, 1 Nov 2024 13:54:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 841F96B0098; Fri, 1 Nov 2024 09:54:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C9B86B00AC; Fri, 1 Nov 2024 09:54:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61D1D6B00AD; Fri, 1 Nov 2024 09:54:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3D8F16B0098 for ; Fri, 1 Nov 2024 09:54:02 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DF016AC62B for ; Fri, 1 Nov 2024 13:54:01 +0000 (UTC) X-FDA: 82737667992.20.0525414 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 33D001C0012 for ; Fri, 1 Nov 2024 13:53:25 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GxotyBrg; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730469184; a=rsa-sha256; cv=none; b=e2kd9nmPMUOTgK+vQijt1lC9vRS5ZsDyxf9xqEWJaVz4xtDAvaiJzrriJ+4Yn8/95KLW/R avi/BuuOU4+9+mBYyZnRczx7btjZY4rxOT0N2DYAhI1ydfPqSxgRV4FCjSh0Yrjhn2/Fb4 o0LpzsUFT6Mx/gaEfUaL9VjdAsxCsU8= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GxotyBrg; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730469184; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aCursz3mmtrcUPW/QvYFU4szIN1SR2q2jGdUimroVho=; b=o1DwNlPpr6fMx9Ss5vi6dCPh5eQ5utBF3FYBHT1zvo7NcwGIyQqy+5J4KfqZnXlGYGt5vK 1yejH5eJvArrKpcg8JuxJUyh/C9PTfVcWF3CqBjSkYGLLpAwFn9sc9CvIBv49zTXav7vl7 odXjYm+CGUsidzWzaZqFqftHotkCrRg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id F3B715CB7CF; Fri, 1 Nov 2024 06:10:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C71BBC4CECD; Fri, 1 Nov 2024 06:11:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730441481; bh=xuvDhMPsSnRBldbb9zqlIWoH9RpyHnNr2U6kz9Sckdc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GxotyBrgjRANc5p7HrsCLBXgaj4HLa5WC8j/hwfVk4KJAdkHmExC7kSQTYNp89ILA Yx2fbg2gbC1Wjyn01FDcCrk577MzfB5np9DJobJUCMYKqeBjjKbyJl4ye3AMAvF9/M eWLWv6oFnkXuCdVlONIFHy4LNALMfsWKyHZrQE/pe6g5rPZdzyyrOB4cB2hoNjYS79 lqHPB1G+uBa5evs4A6a/506EDsJ0Nq/l3fddVEF8YAVmp1SK1vnA6Z0/l70YE3mAJc C3wKq7ppvuxcUZM3NDVqxKZW+swjVBkdxdhk2qeZWESspprkV0FeKW4hemHsE21yeg a8+9J8MNFi77A== Date: Fri, 1 Nov 2024 08:11:16 +0200 From: Leon Romanovsky To: Bart Van Assche Cc: Jens Axboe , Jason Gunthorpe , Robin Murphy , Joerg Roedel , Will Deacon , Christoph Hellwig , Sagi Grimberg , Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 2/7] block: don't merge different kinds of P2P transfers in a single bio Message-ID: <20241101061116.GC88858@unreal> References: <34d44537a65aba6ede215a8ad882aeee028b423a.1730037261.git.leon@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 33D001C0012 X-Rspamd-Server: rspam01 X-Stat-Signature: twjyk9585ecdcc76h3xsc3hrcn8bttsh X-HE-Tag: 1730469205-326653 X-HE-Meta: U2FsdGVkX1+WTSO0BhPyjUa9s7y5al3r0ojXJfaEQe1Ms5WIjafwBk2tahwaAahqX0FNzSB3QTarjCnLOjTZMgUM4rtvD31Pemolg8eNPtgC4oZW3gcEXgN9lsw31PLPNitDVD6tS8dmtBBo7iyYuZMxA/TQ9AAvWcbAA+aPgVAMy9cy7MCyZ0xVCapAI3fbETmDEjJGN0zwInBynbwTZzTuMoAs/46v7zWHsvptyZuQJGs4Tl5R8k2EJXAPDHnP63hR0VduO0Hf/vmP8UFk23owO20yRes/IMQY67yVYLCJDz6hznOzd+xqZ+jtX/+waYAHvQuaK5l0eg5xkVPB3/eCeOjgdRvAEuopOFu+NflRm9/huI4S38p0Vj7FoQrbyk5d33+NAe0k5/CzHGeqG++tAltntbqEkJ8QclFs7uIEARDrnQokGeL9IwrsvEX1dRJ2BdqD3dKOdaJXhaKqZgldPdOW3OICcyq/OkwM480jO/kXjBRELW/BRQOmz2QLHMtKSLmD/ML/78Z1WLlvqaVUDQw8uMUiNGIOISmTIoUOQTRYqSghOHF/B/QPQyFRV3RRqP9ku+JHxMjI+rsjTSwk0j5oAHknQLCHuly6Ydv3XEh/PUYx7vjd1u3O/HgaxgDwOBYUPeLFxsPlyKan44/HwxgYk3tuyQvX8O4mjY7mtEf5mvejw/NaVEj6BEonWCZUR/2JZoftYrbv0nMVELD5OvZ3IZMIIvWhhvxlG8Qj4cJ/2WR0alN+1RzNnDq9xYyEV/t9SFBQ6gUQSPa/8URB3Xlk8+bDt8xl+Ntf6WTqbk9Xn8SGilqdldCJsgtDCRqKac2YCyR0Rf9hDVcBKstLC4qXkeIP5SAbpzdRkCszK/CYxEhTjcgE1tazgverD7a+MvsQFEDprPtQ0YsUWhiGz1crZpCpQjHDzasCh8vWynCOg/5haB6kp1ygBVhwf6K3IqNcJ2fKJ24QVAo +L9X4AJ+ zQOo3MHKAsKasGnknHx2t81GyRXckGE7sEi6SY6tCL63V81RNLALDzGA/TrLKZKf7ZNANL313GgK60fb6M2WDJZphR3b6WeApM9VlriXTwid61Kxbe4XZIzp3pRPGvGU3Wk/oJazgT0dS9Ztsrkuan4MSjYLSyC4AUbdmvy3x8YsXlfeN2a9EhQ+fWlA5aiJnxvfenfVDC3hFiye76iuTW+ofTHhd9/u056TD6G8Om8UJ/V33sox0g7QrEE4gCKOQ3Dpd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 31, 2024 at 01:58:37PM -0700, Bart Van Assche wrote: > On 10/27/24 7:21 AM, Leon Romanovsky wrote: > > + /* > > + * When doing ZONE_DEVICE-based P2P transfers, all pages in a > > + * bio must be P2P pages from the same device. > > + */ > > + if ((bio->bi_opf & REQ_P2PDMA) && > > + !zone_device_pages_have_same_pgmap(bv->bv_page, page)) > > + return 0; > > It's probably too late to change the "zone_device_" prefix into > something that cannot be confused with a reference to zoned block > devices? It is never too late to send a patch which renames the names, but it needs to be worth it. However it is hard to see global benefit from zone_device_* rename. ZONE_DEVICE is a well known term in the kernel and it is used all other places in the kernel. Thanks > > Thanks, > > Bart. >