linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Wei Yang <richard.weiyang@gmail.com>
To: Liam.Howlett@oracle.com, akpm@linux-foundation.org
Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org,
	Wei Yang <richard.weiyang@gmail.com>,
	"Liam R . Howlett" <Liam.Howlett@Oracle.com>,
	Sidhartha Kumar <sidhartha.kumar@oracle.com>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Subject: [PATCH v5 3/5] maple_tree: not necessary to check index/last again
Date: Thu, 31 Oct 2024 23:16:25 +0000	[thread overview]
Message-ID: <20241031231627.14316-4-richard.weiyang@gmail.com> (raw)
In-Reply-To: <20241031231627.14316-1-richard.weiyang@gmail.com>

Before calling mas_new_root(), the range has been checked.

Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
CC: Liam R. Howlett <Liam.Howlett@Oracle.com>
CC: Sidhartha Kumar <sidhartha.kumar@oracle.com>
CC: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Reviewed-by: Liam R. Howlett <Liam.Howlett@Oracle.com>

---
v4: add WARN_ON_ONCE() to check mis-usage.
---
 lib/maple_tree.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 071d3055f1fa..4900f182e99d 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -3670,7 +3670,9 @@ static inline void mas_new_root(struct ma_state *mas, void *entry)
 	void __rcu **slots;
 	unsigned long *pivots;
 
-	if (!entry && !mas->index && mas->last == ULONG_MAX) {
+	WARN_ON_ONCE(mas->index || mas->last != ULONG_MAX);
+
+	if (!entry) {
 		mas->depth = 0;
 		mas_set_height(mas);
 		rcu_assign_pointer(mas->tree->ma_root, entry);
-- 
2.34.1



  parent reply	other threads:[~2024-10-31 23:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-31 23:16 [PATCH v5 0/5] refine storing null Wei Yang
2024-10-31 23:16 ` [PATCH v5 1/5] maple_tree: print empty for an empty tree on mt_dump() Wei Yang
2024-10-31 23:16 ` [PATCH v5 2/5] maple_tree: the return value of mas_root_expand() is not used Wei Yang
2024-10-31 23:16 ` Wei Yang [this message]
2024-10-31 23:16 ` [PATCH v5 4/5] maple_tree: refine mas_store_root() on storing NULL Wei Yang
2024-11-01 14:59   ` Liam R. Howlett
2024-11-01 18:41     ` Andrew Morton
2024-10-31 23:16 ` [PATCH v5 5/5] maple_tree: add a test checking storing null Wei Yang
2024-11-01  3:37   ` Andrew Morton
2024-11-03 22:46     ` Wei Yang
2024-11-01  0:20 ` [PATCH v5 0/5] refine " Andrew Morton
2024-11-01 14:52   ` Liam R. Howlett
2024-11-03 23:09     ` Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241031231627.14316-4-richard.weiyang@gmail.com \
    --to=richard.weiyang@gmail.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=maple-tree@lists.infradead.org \
    --cc=sidhartha.kumar@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox