From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D562E6748C for ; Thu, 31 Oct 2024 23:04:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55F376B0092; Thu, 31 Oct 2024 19:04:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50D2B6B0095; Thu, 31 Oct 2024 19:04:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FC046B0096; Thu, 31 Oct 2024 19:04:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 223296B0092 for ; Thu, 31 Oct 2024 19:04:42 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BAD86AD7BE for ; Thu, 31 Oct 2024 23:04:41 +0000 (UTC) X-FDA: 82735427754.25.6530226 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by imf29.hostedemail.com (Postfix) with ESMTP id B2E5312001E for ; Thu, 31 Oct 2024 23:04:02 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HVUN1VpT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730415823; a=rsa-sha256; cv=none; b=R0ixqRshN/ae3wO87jsOv1tV8prLmYFSgXNUd8/bbK2hxRvXRWnXN4wVx9z96WRj4C3mB4 +i+LNHK4fq9ohJ6/Tc6r++tNofEn/WRMNnR7udIfAfkSRRYseFb1KMMiPX0K84QjdcIPWl 1Kbhzf+XrdaB+iZ4vOyiCcUqffmS8Mw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HVUN1VpT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730415823; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EtMvKgcLmtDgywPHUvKzUUppWYf3nYFWnoQ7FpAhK+E=; b=1o9zxQR5N6nVr44GIg3n60lDm+99cZoUwXU10Gr9vfw/PzY0H1gG3aB0w/SZmDLuZE3IFB KhSHPVA4xIEdqN4talU1wUd8DWmZX7R/q/Nzvw5Og6zVUwuFuJP3Elp4l46L7uTubTMZG4 Q4QmYwKiBM4OsfqTL0uBEHqGTMLz+NE= Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a86e9db75b9so195391266b.1 for ; Thu, 31 Oct 2024 16:04:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730415878; x=1731020678; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=EtMvKgcLmtDgywPHUvKzUUppWYf3nYFWnoQ7FpAhK+E=; b=HVUN1VpTGmUa943aXqvNIHjcDSpDuaKAvEmdTDgYrGna/pgKhY06F8J+EkknnX1JDd 3kBJ90SRbupWOThz+vND7xUjvV5K9ehgCUGx705AOrluNF1an7+zfqwy3NKa9+UBmDbP KRGBh1fJ0HaQv6FMkL40nrXV+bVFtnCf0Tzu64WGEALZDD46ZRthLBfyZgvlMtFehyCy tnMZfaDklXXcjXliaamBcZ/RBkb2Tyma1qKSgZGGz9VHgcYGdCa/rNExomRUPX6mfpsp U57JTml0d14drJ9ciIEIAIrYC7TGGq6ThYbO9MR0m3lRGEV+cB3bQJzFD6bXn2CZa38Z X3Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730415878; x=1731020678; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EtMvKgcLmtDgywPHUvKzUUppWYf3nYFWnoQ7FpAhK+E=; b=PTb4UVENx1dNStwS2ItYSk5gKkIL0M9FEmFXt+N9S0r89ka3bpiYiOGchHlbnogRXb djNCqxERc8xVVH8QIiHDD24udz+iQwYJc9KmnLDVQN7JaSFoCr+kH66pLu4FR+VwCLS4 pV87TsJFmx4GVkflj0AaILxe4yNtTgH73QLHZySOyWg9qFw4qWTWLJ2DTJ3W5BrqW5qZ cvkPhsHvB67TJ0doaPqjy+zt0nz39+V986IfMU83Ep5fpr9MtdXhzbxkgyhzgooIhK5E rhBCY9+dwohImalPCJ/KCqKzSML2Q7C1YRIb4AebOvXCiMMUU9v0yaKWaR16XSCTE74g QFbw== X-Forwarded-Encrypted: i=1; AJvYcCW4r1t9wFuderXidFNfDrI09LbvgNuhjEPiy4TsTTszf6fhCIXd34wp27eym3c/SZNqk+WFPwllRw==@kvack.org X-Gm-Message-State: AOJu0YwMS1rfsUCr39S0F4Ls2TiBnpclcKQHmpDlh7OZN/SeMmEHdFyV g+YujKWx3WUzLX+dqAfx10RYKOdEcOkxLN+5yPYnKBGkkqDniG+5 X-Google-Smtp-Source: AGHT+IEyghKprvLsxiAcZC+3o0cVoTuBuCOTFhpz0/CUPftpSUvEqr4DFrq8vUdyRqr5xRsR9gBQzg== X-Received: by 2002:a17:907:6eaa:b0:a99:fb56:39cc with SMTP id a640c23a62f3a-a9e509787a5mr456889866b.38.1730415877805; Thu, 31 Oct 2024 16:04:37 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9e565ea53dsm113297766b.114.2024.10.31.16.04.36 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 31 Oct 2024 16:04:36 -0700 (PDT) Date: Thu, 31 Oct 2024 23:04:36 +0000 From: Wei Yang To: "Liam R. Howlett" , Wei Yang , kernel test robot , akpm@linux-foundation.org, oe-kbuild-all@lists.linux.dev, maple-tree@lists.infradead.org, linux-mm@kvack.org, Sidhartha Kumar , Lorenzo Stoakes Subject: Re: [PATCH v4 5/5] maple_tree: add a test checking storing null Message-ID: <20241031230436.5lqih4wfrlshcq3v@master> Reply-To: Wei Yang References: <20241019023716.4516-6-richard.weiyang@gmail.com> <202410230105.UApdwd9S-lkp@intel.com> <20241022233247.htf7diduw2ojce2p@master> <20241031080248.7bd5iy52wenptsp4@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Queue-Id: B2E5312001E X-Rspamd-Server: rspam01 X-Stat-Signature: 6m8g3ek7c1yzckbh3awofcb9u5obzt55 X-HE-Tag: 1730415842-165841 X-HE-Meta: U2FsdGVkX1+L9bqFcEG2v9sT9eOt1yYStx1BT2yVHlQV4UVkSlroWzIYUCGCHDhFDgfZ+h4yz6Hp8a+3VAka3KSBWiIrpEJIXax7PTTENpl1G8oH+FIu3xgwQ4X1sKZYrgnZ8ctPsyBzrZ5SpCB9aPO5kQF3SaDwwai8Ghho+T8kykbKor/El1V+U5/djOlWBSETTcWu6ywN0W38SP4Voh2GW+3N9QmDhimAyTOTuXdVKvtZgTX6S3ibOSfn8v8AWInPHUjZZsTwRghy9vCVdV/wFRMWHIT0a6K2TMocTqDivJ2z6xuunX2gWszEUX1w2kMKXRiq/GPV4g8PVCKss8dn9G3pcUNCfCjoioGWTfHCJJ6yVcXCuWPwtzgVXL0mp0UdOYt3pnLdVp6q2l2g4Xly7rmt6wm3syYLmvAkqPOweUN7EMzlOUHHZWsLUpfwaBf/SREaOltYxdyFi1NS1b2x7Z/2AZ1juV0f5jMHs+fM63Bf+R8XoiadUeoYXOh8Q/D+hNXN5GWKEyYVYpBWadjkpCWNN+ty6EifdMXj8/u+65fbESVFu2ZgK1zsg9fEQX0kDwSrtZu5lZL9G2K7Vx7jNXHlatv3Ok13A6PUprqAVgZfGTGtBwDZ4ZSJAZCraYKzLKa4NuH+BmyPSB6I/5OOQa1xQ4iO3xo0wc/Dm0hVytkMLlwUyqeuK5EEcVRhP1Wk4BfagN89/2Nb8zLWcJPorvhlPFIlXEh9nECjQTb4c9vd991HxWfTWdcy+K6aQ0Z3pmuNJ+Iubobd2kvP5UcOI4jZR+ss8qYRAM+OW2hskeFIiZnW3/lsfJ9Xk6T8gAHVLtgm6qJA4S1kJux/XHzNB36y8UuqsZgE86l8gKkfNQf4N011ZBiUGN568E17N7bUq5SehR1FAm3CkZ/TpjzEySbI26jOT/1onPZqkikr2j1/IBkA6eREC8/UwE/psT3dwenceahLcnxsosr JEKdR0Jj wymzNfHTL+uftAU5RisPPeL6BrIngi8L/wE2VOH/+mhigNuXPMJ4/emedl1lhKhUiok7OJmop6lILeTX5ei01V7W4N9PNpdivLKWfjLU/cadvyUN1QvMMLYAaCQxaFrTUAl0hWU8xLm7f7BcD0s1HwGtYl7XZlrFtsIb1Kna38LLuZPenehZnpDMwuvl+hZc5NUR2p96y/vCoYRVHe+aDOqPOFdnVa8k2TRRySuxmWR2geczVies387cYrws4+YCaMoM2hLCxctbH9DvrVdhZdkhgqgEAos/9Pc4lJ0AgtuOPsSWq/kxeyjPE0aLmFp4KNN7h1UC4nFpHAFxTTnM8/rWllrvPoj8OFBh7HyYUTlMo8o6SJmp40Gpm8JXfwilGfsUSmFu5Q0bh5RLus1wh8q0MfSIssHHaWKAjptlxlKbpLpejsMA26QqUZ9DCnYFGzq1iNx2BNceYk5MAnv4W0Y8+BOuq8c/C1IvUecNbasQ56Drl2KTnBNcEko5IqpOP+ah7/OWPFk+XoiHip8btw9Fq2lOVJSHak4pFoq666z3ujItWaek7M/tUrSAIlOTuvGwUs/DXxs9Y9bGyf+PWGCSZerjtgJWW25Y54xbuM6X6oK3ZVbGLR959TkB7cNYTvivta1cCtK3mJScAHANB0198Mhbr3aZ+Bi/R1JfHXdvH3ribgVHzAIAgfneE4K64aD7wGA3e1VGZyXYuA3+fiy7sNfe8wnUs4ffyDsQhxUg4dxMw2p2fpLeob7AgidO+ZjDraYTMyHytnQyUC6U/u9H60fjAB3qOsURqAiqA55C8ZJNTfmzVTsi25OAPI3WKKFekYyKVbmiM17GnUeRrIt39bw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 31, 2024 at 07:17:28AM -0400, Liam R. Howlett wrote: >* Wei Yang [241031 04:02]: >> On Tue, Oct 29, 2024 at 11:29:39AM -0400, Liam R. Howlett wrote: >> >* Wei Yang [241022 19:32]: >> >> On Wed, Oct 23, 2024 at 01:37:50AM +0800, kernel test robot wrote: >> >> >Hi Wei, >> >> > >> >> >kernel test robot noticed the following build warnings: >> >> > >> >> >[auto build test WARNING on akpm-mm/mm-nonmm-unstable] >> >> >[also build test WARNING on akpm-mm/mm-everything linus/master v6.12-rc4 next-20241022] >> >> >[If your patch is applied to the wrong git tree, kindly drop us a note. >> >> >And when submitting patch, we suggest to use '--base' as documented in >> >> >https://git-scm.com/docs/git-format-patch#_base_tree_information] >> >> > >> >> >url: https://github.com/intel-lab-lkp/linux/commits/Wei-Yang/maple_tree-print-empty-for-an-empty-tree-on-mt_dump/20241019-103832 >> >> >base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-nonmm-unstable >> >> >patch link: https://lore.kernel.org/r/20241019023716.4516-6-richard.weiyang%40gmail.com >> >> >patch subject: [PATCH v4 5/5] maple_tree: add a test checking storing null >> >> >config: x86_64-randconfig-123-20241022 (https://download.01.org/0day-ci/archive/20241023/202410230105.UApdwd9S-lkp@intel.com/config) >> >> >compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff) >> >> >reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241023/202410230105.UApdwd9S-lkp@intel.com/reproduce) >> >> > >> >> >If you fix the issue in a separate patch/commit (i.e. not just a new version of >> >> >the same patch/commit), kindly add following tags >> >> >| Reported-by: kernel test robot >> >> >| Closes: https://lore.kernel.org/oe-kbuild-all/202410230105.UApdwd9S-lkp@intel.com/ >> >> > >> >> >sparse warnings: (new ones prefixed by >>) >> >> >>> lib/test_maple_tree.c:1456:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const *entry @@ got void [noderef] __rcu *ma_root @@ >> >> > lib/test_maple_tree.c:1456:9: sparse: expected void const *entry >> >> > lib/test_maple_tree.c:1456:9: sparse: got void [noderef] __rcu *ma_root >> >> >>> lib/test_maple_tree.c:1456:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const *entry @@ got void [noderef] __rcu *ma_root @@ >> >> > lib/test_maple_tree.c:1456:9: sparse: expected void const *entry >> >> > lib/test_maple_tree.c:1456:9: sparse: got void [noderef] __rcu *ma_root >> >> > lib/test_maple_tree.c:1468:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const *entry @@ got void [noderef] __rcu *ma_root @@ >> >> > lib/test_maple_tree.c:1468:9: sparse: expected void const *entry >> >> > lib/test_maple_tree.c:1468:9: sparse: got void [noderef] __rcu *ma_root >> >> > lib/test_maple_tree.c:1468:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const *entry @@ got void [noderef] __rcu *ma_root @@ >> >> > lib/test_maple_tree.c:1468:9: sparse: expected void const *entry >> >> > lib/test_maple_tree.c:1468:9: sparse: got void [noderef] __rcu *ma_root >> >> > >> >> >vim +1456 lib/test_maple_tree.c >> >> > >> >> > 1389 >> >> > 1390 static noinline void __init check_store_null(struct maple_tree *mt) >> >> > 1391 { >> >> > 1392 MA_STATE(mas, mt, 0, ULONG_MAX); >> >> > 1393 >> >> > 1394 /* >> >> > 1395 * Store NULL at range [0, ULONG_MAX] to an empty tree should result >> >> > 1396 * in an empty tree >> >> > 1397 */ >> >> > 1398 mt_init_flags(mt, MT_FLAGS_ALLOC_RANGE); >> >> > 1399 mas_lock(&mas); >> >> > 1400 mas_store_gfp(&mas, NULL, GFP_KERNEL); >> >> > 1401 MT_BUG_ON(mt, !mtree_empty(mt)); >> >> > 1402 mas_unlock(&mas); >> >> > 1403 mtree_destroy(mt); >> >> > 1404 >> >> > 1405 /* >> >> > 1406 * Store NULL at any range to an empty tree should result in an empty >> >> > 1407 * tree >> >> > 1408 */ >> >> > 1409 mt_init_flags(mt, MT_FLAGS_ALLOC_RANGE); >> >> > 1410 mas_lock(&mas); >> >> > 1411 mas_set_range(&mas, 3, 10); >> >> > 1412 mas_store_gfp(&mas, NULL, GFP_KERNEL); >> >> > 1413 MT_BUG_ON(mt, !mtree_empty(mt)); >> >> > 1414 mas_unlock(&mas); >> >> > 1415 mtree_destroy(mt); >> >> > 1416 >> >> > 1417 /* >> >> > 1418 * Store NULL at range [0, ULONG_MAX] to a single entry tree should >> >> > 1419 * result in an empty tree >> >> > 1420 */ >> >> > 1421 mt_init_flags(mt, MT_FLAGS_ALLOC_RANGE); >> >> > 1422 mas_lock(&mas); >> >> > 1423 mas_set(&mas, 0); >> >> > 1424 mas_store_gfp(&mas, &mas, GFP_KERNEL); >> >> > 1425 mas_set_range(&mas, 0, ULONG_MAX); >> >> > 1426 mas_store_gfp(&mas, NULL, GFP_KERNEL); >> >> > 1427 MT_BUG_ON(mt, !mtree_empty(mt)); >> >> > 1428 mas_unlock(&mas); >> >> > 1429 mtree_destroy(mt); >> >> > 1430 >> >> > 1431 /* >> >> > 1432 * Store NULL at range [0, n] to a single entry tree should >> >> > 1433 * result in an empty tree >> >> > 1434 */ >> >> > 1435 mt_init_flags(mt, MT_FLAGS_ALLOC_RANGE); >> >> > 1436 mas_lock(&mas); >> >> > 1437 mas_set(&mas, 0); >> >> > 1438 mas_store_gfp(&mas, &mas, GFP_KERNEL); >> >> > 1439 mas_set_range(&mas, 0, 5); >> >> > 1440 mas_store_gfp(&mas, NULL, GFP_KERNEL); >> >> > 1441 MT_BUG_ON(mt, !mtree_empty(mt)); >> >> > 1442 mas_unlock(&mas); >> >> > 1443 mtree_destroy(mt); >> >> > 1444 >> >> > 1445 /* >> >> > 1446 * Store NULL at range [m, n] where m > 0 to a single entry tree >> >> > 1447 * should still be a single entry tree >> >> > 1448 */ >> >> > 1449 mt_init_flags(mt, MT_FLAGS_ALLOC_RANGE); >> >> > 1450 mas_lock(&mas); >> >> > 1451 mas_set(&mas, 0); >> >> > 1452 mas_store_gfp(&mas, &mas, GFP_KERNEL); >> >> > 1453 mas_set_range(&mas, 2, 5); >> >> > 1454 mas_store_gfp(&mas, NULL, GFP_KERNEL); >> >> > 1455 MT_BUG_ON(mt, mtree_empty(mt)); >> >> >> 1456 MT_BUG_ON(mt, xa_is_node(mt->ma_root)); >> >> >> >> Thanks. >> >> >> >> Will fix it to xa_is_node(mas_root(&mas)) in next version. >> > >> >By the looks of the bot output, there are quite a lot of existing cases >> >of this in the test code. >> > >> >> Hi, Liam >> >> Thanks for your review. I may not follow you. >> >> I saw you add you RB. Do you prefer me to spin a new round with this adjusted >> or the current version is fine? > >Please fix what you added. The rest will need to eventually be fixed, >but someone can do that later. > Got it, thanks. >> >> >> >> >> >> >> > 1457 mas_unlock(&mas); >> >> > 1458 mtree_destroy(mt); >> >> > 1459 >> >> > 1460 /* >> >> > 1461 * Store NULL at range [0, ULONG_MAX] to a tree with node should >> >> > 1462 * result in an empty tree >> >> > 1463 */ >> >> > 1464 mt_init_flags(mt, MT_FLAGS_ALLOC_RANGE); >> >> > 1465 mas_lock(&mas); >> >> > 1466 mas_set_range(&mas, 1, 3); >> >> > 1467 mas_store_gfp(&mas, &mas, GFP_KERNEL); >> >> > 1468 MT_BUG_ON(mt, !xa_is_node(mt->ma_root)); >> >> > 1469 mas_set_range(&mas, 0, ULONG_MAX); >> >> > 1470 mas_store_gfp(&mas, NULL, GFP_KERNEL); >> >> > 1471 MT_BUG_ON(mt, !mtree_empty(mt)); >> >> > 1472 mas_unlock(&mas); >> >> > 1473 mtree_destroy(mt); >> >> > 1474 } >> >> > 1475 >> >> > >> >> >-- >> >> >0-DAY CI Kernel Test Service >> >> >https://github.com/intel/lkp-tests/wiki >> >> >> >> -- >> >> Wei Yang >> >> Help you, Help me >> >> -- >> Wei Yang >> Help you, Help me -- Wei Yang Help you, Help me