From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B70B8E6B278 for ; Fri, 1 Nov 2024 13:53:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F1F016B00A7; Fri, 1 Nov 2024 09:53:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA7F26B00A8; Fri, 1 Nov 2024 09:53:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D21376B00A9; Fri, 1 Nov 2024 09:53:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AFF046B00A7 for ; Fri, 1 Nov 2024 09:53:38 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 803ED1C620A for ; Fri, 1 Nov 2024 13:53:38 +0000 (UTC) X-FDA: 82737667740.27.0F86344 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id 4358C40021 for ; Fri, 1 Nov 2024 13:53:14 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lr7kPUgI; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730469053; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n9jNoVWgAyz3OKPEI/xBwz4OBmPP5FmNVgDNrMfFvnU=; b=8qXVn6rStHmtTasDwFKqcLxliiXmA0OjyOb5zax0fhWoA7LXq9Zc8meeMY+o8A7dI2xfj7 XhN0CQFDDcs8Rghm2S4JSzy3lkq6d1Ix/z+1gFtm6+VRI1v2wE+nKA391OZYmJg6eHMjyg LmCcixS0naxbrTnRLj6XbjrzyBTef7Q= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lr7kPUgI; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730469053; a=rsa-sha256; cv=none; b=Xa39ZDX7EDV41zaJSbcLyEVwVpC3FvcN/0h6bvC+eeZQBtlasKaAD2ztbQD8OqcNd6a0lY Gx+P+NMWwnBT59gDBHXZd2YOIKXxBQogak/28vCVMNTN8zBQHCFjJBv4QL45jkuCEKX2QF 3lYaQmowi9zdYjV0Xx2KEuA9dmw8HRA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id AE1635C58C6; Thu, 31 Oct 2024 20:42:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7011FC4CEC3; Thu, 31 Oct 2024 20:43:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730407391; bh=H9TYKTBvHoQ5rvWOlZrf5R8cp5gm744S0WtiOVj2YhM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lr7kPUgI/7iVNgICJResGJ30FaV5ODcyHJ9WGRkVobW4I+2qmOuISPyR7TgVvtOL0 SmzSJOoShZhbOMucGyUH2uuWA6uV+MEqkVpWqucL5pewOQIRjkLlpdRuvDl1QVDfWX j1897yIh4R6d4BkCIdg8zDSKqwvM5/ucAQVUt6ez1WZ9F859wkA3oJfZDIz3/BvZ9Q CFmDxviw5iM6FMEQKmQ/YcUbuNijZ7G5KlXaJgFBJfCLtyj90f3jtiAtedA93PWWwn Aojx0RCSHe5LU/8+xXjxLd+N9OOoZAjQdgre/g+5QavM+S81ng8FOAv7tC01+C4SFj e0eXzNVUyHdgQ== Date: Thu, 31 Oct 2024 22:43:06 +0200 From: Leon Romanovsky To: Jens Axboe Cc: Christoph Hellwig , Jason Gunthorpe , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v1 00/17] Provide a new two step DMA mapping API Message-ID: <20241031204306.GB88858@unreal> References: <3144b6e7-5c80-46d2-8ddc-a71af3c23072@kernel.dk> <20241031083450.GA30625@lst.de> <20241031090530.GC7473@unreal> <20241031092113.GA1791@lst.de> <20241031093746.GA88858@unreal> <8b4500da-4ed8-4cd2-ba3b-0c2d0b5b4551@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8b4500da-4ed8-4cd2-ba3b-0c2d0b5b4551@kernel.dk> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4358C40021 X-Stat-Signature: aawysm9gse346467y9m1cibqn9r16a86 X-Rspam-User: X-HE-Tag: 1730469194-772834 X-HE-Meta: U2FsdGVkX19MF+P7HuzebOi6R2bfOM4ulwMIcWAWKlxtWOwwx+aYGz6qNJEndyT+VvRU6AS6x6R76LxxLQisEhVpJiMMHmaPPEAmhrVH3NeWOqLnuhyvOsNzOHWu8ae9Jb6e3bf8y514X4OXBd6B7AGmvcqpZSwK352pcrWeY0J9IJgbEUFl5fA/A4EyWUvF3MaQQiCE4u0cbNEtwIULaGIL8PrkY4gqPR6Egh+/TgdafrOJ+PocWeQ6QFd7MVi89bi2I1JrZF0F2NPQ9tzQLShwPTe+Inn/+jQyIbtb5NA+3agGIKQ33URAJ+c8CHXqbgOM2La/ajFXfgK1VWGOvdt8HIEe5wQc9V6OCxWF8+wGATb6AgScCECBgzUZEa12euYGTQq0fcFJ+AySuAK46gvzJWDhfqkOk13fzJze2FIc9PZxOjXPQ6NLhK73zBZ4xffpZ93ZnpwF1/5iU2Hwnvw+8q9fku3MaXYhO8xaDBd0Q80ttuEG8qKwNO+NxW4rt7gy/K2vWGrKle/70ba2hEwW+qqC68K3Yxqyc1EzKmlTE3Fu4dzFktBXsVwiphwbsUi7MdFaP+BG9YC5l9DF4MpY5nasFe1M4tYIk4aEANvQ1wPPUc7Phb3jM3ex0swxPdWiMMhQTos8/bFNt0vhV/JziIItW+MvLIruCpNGoTNab0QAkmjFEvwUSUXSW4mVLWv8cPEBuUVWe3PqXUvrIamPMoBoCiRNgf1QhxlwMihgI+ojhMCqnN9QHQS/8YkYt7PpHvJW1cWVk0vKSDufAZ9id3pCIJ/X6cSj/b+S0ddKX5pyPa0h7AvF7kSA3oY0YbDI6YEx4PiO7nCi+sQbE0bJnfWQVwPMTMGyQKoYZg/5ySSWU6rQjQSBWcSfFTNJkiA0PncvKK1XAGBpJJjBF1n1ObT5kdjRTEq9hsc7Wv76rE9R7ET1iOA26yJAhM0tfQPuki/rKt47fmplaaM uzS0cby9 kRL1kqebCYzXYPWI5e5ou3U+gNs34jJ0TdTg0ISvBDuGRAmQ76BTq0assoeFWX5u9LKu9860wX07PQBnRPV8nFri+XDB4ZVY3fpGRMBmTcvti+ADp5kv9R8YV0IIO6m4tLXXofZePDlR/J+lFSEItd4rUAMmue0xF8odtuE3tCNlB0znjvl60vIp+xIFFA60FW2L22QBCwEw+MLkhFqfXDDzFra6K0qJdObOMk6xatashPdorqk5WdBXjvJ2J5Mtxlw7g X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 31, 2024 at 11:43:50AM -0600, Jens Axboe wrote: > On 10/31/24 3:37 AM, Leon Romanovsky wrote: > > On Thu, Oct 31, 2024 at 10:21:13AM +0100, Christoph Hellwig wrote: > >> On Thu, Oct 31, 2024 at 11:05:30AM +0200, Leon Romanovsky wrote: > >>> This series is a subset of the series you tested and doesn't include the > >>> block layer changes which most likely were the cause of the performance > >>> regression. > >>> > >>> This is why I separated the block layer changes from the rest of the series > >>> and marked them as RFC. > >>> > >>> The current patch set is viable for HMM and VFIO. Can you please retest > >>> only this series and leave the block layer changes for later till Christoph > >>> finds the answer for the performance regression? > >> > >> As the subset doesn't touch block code or code called by block I don't > >> think we need Jens to benchmark it, unless he really wants to. > > > > He wrote this sentence in his email, while responding on subset which > > doesn't change anything in block layer: "just want to make sure > > something like this doesn't get merged until that is both fully > > understood and sorted out." > > > > This series works like a charm for RDMA (HMM) and VFIO. > > I don't care about rdma/vfio, nor do I test it, so you guys can do > whatever you want there, as long as it doesn't regress the iommu side. > The block series is separate, so we'll deal with that when we get there. > > I don't know why you CC'ed linux-block on the series. Because of the second part, which is marked as RFC and based on this one. I think that it is better to present whole picture to everyone interested in the discussion. Thanks > > -- > Jens Axboe >