From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D0F2E67490 for ; Fri, 1 Nov 2024 00:46:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BD3E6B007B; Thu, 31 Oct 2024 20:46:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 645D96B00A5; Thu, 31 Oct 2024 20:46:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E6EE6B00A1; Thu, 31 Oct 2024 20:46:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 22D0C6B00A5 for ; Thu, 31 Oct 2024 20:46:02 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B4A8AC188D for ; Fri, 1 Nov 2024 00:46:01 +0000 (UTC) X-FDA: 82735682232.17.BF4047D Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf12.hostedemail.com (Postfix) with ESMTP id 749C44001A for ; Fri, 1 Nov 2024 00:45:47 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="2BQupkX/"; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730421878; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=utveTlCo5HyqFWxeYZdZbn5/TYJH4iynRZqaWj/pQ1I=; b=3bocCdgpzlgVQSG+VsspEqlsc3z5Jddc014gIBHm7OmCKIV2QQ5c2BKUhnud5jGhrN8qjy jd2JG86qhCT40wyordecBASLzCWr/F0LXfZwtLAcEFX97Fvy22NRhgEyJLLneM1eKgzsxn 4z7dYBOlAf7nZoDT/Y21X1lI9Uk3IiA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730421878; a=rsa-sha256; cv=none; b=oafjgU9OeAw04r+R/3PGBA+4RRJyyOij8XweCeCfO87iKwDla+UJ9iuIPHCoBUmjuaU8Uz T2E04qktGIEIb9cTzHWq+roX+c9YdeZkdL+PBvlDHEZqRPE/1FeKBnPj6XbGH5M0UI2k+l AEjyCoR6XrSZdyKYBrQfhzRb5W2nb/Q= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="2BQupkX/"; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id C3B0DA44AFF; Fri, 1 Nov 2024 00:44:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95EA3C4CEC3; Fri, 1 Nov 2024 00:45:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1730421959; bh=Yl0Nq/X2C+orEWo5hcJOW21CSwUj1o3v/S2ZVXjvMew=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2BQupkX/pYNAp73p4KB9XxE/1ZiGGuZx5jx5Lgftm78Y1wsf8m6JRUOI7aG+xK0JY Q+sBukFekSbNwi1kId03qRE94o97FmiuXkFMczMVJluENlvu0vznILaI+ofEdu1s7f NOps3W1+og/Wn7nD8aH2rgVx7GMUAuiAkt9kx2NQ= Date: Thu, 31 Oct 2024 17:45:57 -0700 From: Andrew Morton To: Suren Baghdasaryan Cc: kent.overstreet@linux.dev, dan.carpenter@linaro.org, rppt@kernel.org, mcgrof@kernel.org, petr.pavlu@suse.com, samitolvanen@google.com, da.gomez@samsung.com, yuzhao@google.com, souravpanda@google.com, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] alloc_tag: fix empty codetag module section handling Message-Id: <20241031174557.18b8f408a6b810b3fe7468c6@linux-foundation.org> In-Reply-To: References: <20241101000017.3856204-1-surenb@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam10 X-Stat-Signature: 8pkogp8fm8twhymphknx4txesg8yajqg X-Rspamd-Queue-Id: 749C44001A X-Rspam-User: X-HE-Tag: 1730421947-280498 X-HE-Meta: U2FsdGVkX19OZ5LZ2v1YY5s0vP0OX3vQs/z7jyvHGZiJ8cPEianrbk9bryuYUaHn8KGC1ztRdMwlhA8zCwelP2cZ0WBBTvtiCoKJ1XEY/WvLiaM88hlp1DOVSNW/UrJAKQUcS860xHlJTn3u79YBNSney1wFlq3O1jaF4SBJYwRjpxG75QFaKut42WtR7h89rmPHUcRKNX4vOCW9UZ67D4R6cQwZQbhoNxYCpgKtErUrOdOKh/XYGN+KvMJJrc5xr/pRJqbxcVm2Depu+46tW2akpfeA6ZPTuQOOpuojkRBuTD5m2YmX+NaoWQEpOHwAXrnEzf510nUSv/EB7fwBYrK6mX3ueO3Mk5MRjeNo+9ZZzGBV3jCadwE5B3xOk50M+TRmPUulNt46zvsU6uNek51wb/wy8Qcu34pdNFH/D1ZseILJG+7+jYvtmmBBVDnZtff/pjIV4dKzCc+fcvwyj9VhLw4IAzAcCBbeIvOi9RdGMZsCuyT3HlxWlo3xXAcZ+xJBu6Xiw7zrNPk8yW7NJ6xBT42+3Nw/pk57Wq8Ylj4ujqtbeE3l2f+ik6J6/8t+7nWxkq+JAMBGV9DschBNzpEklCHUMa+b1yd60YyqZSAd0o/adOGGFGqWiUHQDGBTgv6nKrJs9HUfrwqrZqjgFvdwyrOD5EXGe4t7e5dQwriKctSkQSVPvDxsMTPKOFxzyqMSyqIvUaKkMsFD0kbq3ESAiDSU+8caDVkOli3Zpu7H5urrAptVZoX0UAByMRbX37WnOw80vb7vIIEzhbbZ0jHCrxgUkZ7c72mjeA1yea4lhniFflb3j7N+Y8VZeNEX1r0Jbk6vqX7KG50hZ0pKJqAi+vEAUbJbT+lZFa8hMP7wWKcP5SlOVUj6OU3JSiStu6jGW7pnCDpFR2ktFtTMDZ23E2shM126yYcdINAStmN9bJYIN39YAaMFoSHdcXGunaWZX/kvVepRBsR5K+z 4O4Rxx54 MpGyx+uKPk3NUmiqHz16IvER8puHd8Cs4QIUNIq3M8UvFxTEb96xpKTv3CqdbeItBC482hILoWKs2HRi0Q0vPdheK1MADc9ZuQld219flTrkJMvrrZi7YTjxv16/5w0wWB9ewng2ZguDGq2fxfFyyl1PMp9Cwnzn78r2EYyHGlOJ9LQaoPvuSVo9ERVaila0vBHAIB46eFYtiyh7+QdcsWEHzVrlIFfuTLG2+2JVpiuS92ciJXxVmisQjtsrO56Xt5KJBPTTmklNc1NG5qPFW9WxLhIdwN+zwV/d/gjGKJ8TMoZY/inOEvm8Ozura2IOBLqq+GpEeHLBZGpJybr3BTlAGnyd+lWFe7T+njxXX2nowbGlmP6sdf9451dIg84YgB+C32AY0UMQoM+biKT0gyWKc9RiFRouEGROFjAtbPBTFYv4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 31 Oct 2024 17:13:58 -0700 Suren Baghdasaryan wrote: > On Thu, Oct 31, 2024 at 5:00 PM Suren Baghdasaryan wrote: > > > > When a module does not have any allocations, it's allocation tag section > > is empty and codetag_alloc_module_section() returns NULL. However this > > condition should never happen because codetag_needs_module_section() will > > detect an empty section and avoid calling codetag_alloc_module_section(). > > Change codetag_alloc_module_section() to never return NULL, which should > > prevent static checker warnings. Add a WARN_ON() and a proper error > > reporting in case codetag_alloc_module_section() returns NULL, to prevent > > future codetag type implementations from returning NULL from their > > cttype->desc.alloc_section_mem() operation. > > > > Fixes: 61c9e58f3a10 ("alloc_tag: load module tags into separate contiguous memory") > > Reported-by: Dan Carpenter > > Closes: https://lore.kernel.org/all/50f12fa1-17c1-4940-a6bf-beaf61f6b17a@stanley.mountain/ > > Signed-off-by: Suren Baghdasaryan > > Andrew, I was going to respin v5 of my patchset and include all these > small fixes in it but it's a bit tricky because I would have to revert > another unrelated patch [1] from mm-unstable which refactors relevant > code. So far the fixes are rather small, so I think you should not > have much trouble folding them into the original patchset when the > time comes, but if that becomes a problem I can prepare a new version. > No probs, thanks, I figured it out. The descriptions of where-it-fits-and-why are helpful. Of course we could just pile everything onto mm-unstable HEAD and live with a messier commit history, but I think things are manageable at present.