From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8BC6D767D8 for ; Thu, 31 Oct 2024 16:09:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DD596B0083; Thu, 31 Oct 2024 12:09:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 58E006B0085; Thu, 31 Oct 2024 12:09:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 455516B0088; Thu, 31 Oct 2024 12:09:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 29E076B0083 for ; Thu, 31 Oct 2024 12:09:20 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D67A01C7462 for ; Thu, 31 Oct 2024 16:09:19 +0000 (UTC) X-FDA: 82734380862.19.15EAC96 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) by imf11.hostedemail.com (Postfix) with ESMTP id 72EC040010 for ; Thu, 31 Oct 2024 16:08:44 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=zseI24bh; spf=pass (imf11.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.179 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730390780; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0MP1EJU+2Idek3AiA2s9w530Zbh818fE5dZH3t/ZqUU=; b=ADFpkKzQ87vWqH6Ht0d3nar6rRQiLkFRvNQCt57+4+QFfn3S+DItkuLKH1NXipg0sYkLZO JOh9zE0Nt3yWqMoQmTSf0Yi6JZc9nBTB4A/7AsMbhjp/pqW7FsN4S0dvGS3PGwELsYV/rz 62kBXL3uDeIF7+z2wIdVFDG4mewvvXo= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=zseI24bh; spf=pass (imf11.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.179 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730390780; a=rsa-sha256; cv=none; b=XWVZb0ZQubtaUOYofNs70bFn4KF0BnpA4tP+avOZPHT3482u5L6zWmysWMQlvE0tOkE8gM uVjOKeM4gEvdgdNKhFQiClmtwNbCM7qdnZmBTQOY6/1eawrJuS6Jfv/V3U29lmp+SIm4VZ oZK8uFjzTE9WQvZao4IiQ+b6j/e9274= Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-7b1b224f6c6so75732085a.3 for ; Thu, 31 Oct 2024 09:09:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1730390957; x=1730995757; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0MP1EJU+2Idek3AiA2s9w530Zbh818fE5dZH3t/ZqUU=; b=zseI24bhkI6+qTgnCtFYN1DOkWDQWwSA0OnWzT9AtFAmw89PGSumMzpkdcEU/pu7by K54P2HmGinqC1oqVsBj9hfv77UCvoAzVmI73H0acb26qzDIbEkTi0QHt1WF8NZ1EI202 GSkhpru3Q8LC4fZ1x1LjyE0Vet6nVkunRXtUiJsByYHKhTdvJaEZe7FCUYhjKZj6vGPJ N1Ksc+86aymDRt8VZZAO//Rlg1qz1uVhqmOZ36r8YeoF3BPNv7NKoaj/49d6xH9TO5kL MJTV1tPh+ugHaYVmi0Px9t9imBeHPfdZEn0g+s+CeW+GXpB+n7ksu8AFYxeOo/OxkPB6 libA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730390957; x=1730995757; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0MP1EJU+2Idek3AiA2s9w530Zbh818fE5dZH3t/ZqUU=; b=O5lORDhtLeTmIsEDTMyDaZvZE/gcOEs8SxPI2Hi0E1j6z5d9sbm2XFUnR+nBfrynA3 oEgIxrXZP5YEVekvf0YWhbYg9fzbOBY6gdhJhpV+teqURk8bOUbZwuOU6xG+ZAvhXu1N +mTJG8l6+1OLlPATcRL+RFWOetgP5b3cdhuhYDaB9iNzK+OYN7hTe7DLD2DpWLGW6HS5 c2dBV8XU03n4/nJNwdi2A2mFq6q4j4qcB2tuKjxRDJLoOQcANVX2+4kJsXB9jhdA4aL0 sOzGwZy3aPR0B4c9T7YW/d800pbiGc491fGxs3WOuD8GnO9SmvA7dxzexG4+xl11pQuZ leNA== X-Forwarded-Encrypted: i=1; AJvYcCUOBMIpmRcIoLi7gyuXHPcUqCvgNUs3Fdk8s3njAul7PkiL6wFTiocq4yj/snwqyjQdqK4brysHgA==@kvack.org X-Gm-Message-State: AOJu0YzZ81lRlV9IUY2UsgCdtwRGYpuSb6WbVoRMr/mWkzVWH0rgnY4e FswLXY59dICIvvjVn1jYNkyDAl19pg9e36rP8djxwq8E9VdlJMstKDMVshHzVE0= X-Google-Smtp-Source: AGHT+IEnjifKtBJHoQrQwgD4KdMGYeT83HWXRNYBXlmFZgg8SK4wbJtKEMJF5yR99revJMvIDc8S8g== X-Received: by 2002:a05:620a:4108:b0:7b1:5089:4867 with SMTP id af79cd13be357-7b2fb9bfe02mr17647685a.62.1730390956566; Thu, 31 Oct 2024 09:09:16 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b2f3a708c6sm81355185a.91.2024.10.31.09.09.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2024 09:09:15 -0700 (PDT) Date: Thu, 31 Oct 2024 12:09:11 -0400 From: Johannes Weiner To: Michal Hocko Cc: Joshua Hahn , nphamcs@gmail.com, shakeel.butt@linux.dev, roman.gushchin@linux.dev, muchun.song@linux.dev, tj@kernel.org, lizefan.x@bytedance.com, mkoutny@suse.com, corbet@lwn.net, lnyng@meta.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v3 1/1] memcg/hugetlb: Adding hugeTLB counters to memcg Message-ID: <20241031160911.GB799903@cmpxchg.org> References: <20241028210505.1950884-1-joshua.hahnjy@gmail.com> <20241030150102.GA706616@cmpxchg.org> <20241030183044.GA706387@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 72EC040010 X-Stat-Signature: xubdfop8riopqikjrcpcp9qyagtufpez X-Rspam-User: X-HE-Tag: 1730390924-543171 X-HE-Meta: U2FsdGVkX1+S9dVMNkoLxHr7/fHgxaGuoOYtB+dDx/n7OX+MnOQmq281KQtnrqhGZZ91r0zi5Z21ucBwfZuTQTNc+SBmrNQCs/6DFgXw/m6NME6UjlB8oif/5wooQNgFkolKhhacVW+nHxNRIqeyAH3Wnoa+6Kll2mPPcy021IW/oT41Tbs7HXmTbE0QzX85ITzuydwivtiruq1KcmV/sqLsO1K7zCKXK4SttfZLnWJYjQc/ORV+jQRqwdbvwpujaWi4J3oRuFX/62iDqbrQZRi5xb+BdemzLQ99xeQjSlIieLFhPRUgjeYWD0K9MyBEl+w/6TwCWH+0uZ5gQtG+a21h5OrMj3ve3BGFWDt2a9Rpmv7kw2naDrPH9HuOL5GB8TkECzLGYROs6aXiW8wbkquXYor5ik+zkldza5PQPIs1Jej5eFb5CF5irK4n9ALuDj0qQ6EMyob8Ti8zU4SUqcFjltgjUiRrjCyrDGBgSr82yskkq/iVMCuVo5QbFFAFn5SQkxC8eSc+VbZRpd2QhkRtxJl0sxE0CpRjcP1Rguj+jvRMwlTBUgwLr+rJlSb8UNoLrPyw+YeAM/JgYHC7ZZwmUzrG+jEUQ1V/6fjm+lpJeHSCk7GTtJBMQJ2Jp1DeVwhCslrxNPkC3PLYmcGv7FujH12IAwYXafRGHtlYl+fYTfB0QvfyA3xc460+ZR4TfOUh4y2p3JeEj+IJogHtmP+81d4jBuEtXXM4pK5A/1iLEUVfn45Md0NHSgcLZzq9xfuCJoWcL6CJiPKHmrxiYUcca2YTRsx7+P9RznA1yzDhDDiaFFepKCz8694JBAJG8caUIAPH6asxWZVriLF9CE831nIREh6B7KfPOhEHcJ99M5L/+GFcwk8GQhiN7EkcAHlgeQq1eu1zFLmPsVG+0iu3lehuXnh3mjREb/c/oXO6H9hLMteUrx55F1qXs9LJKJe4wDL3IoC3jGXhdZJ TMNR0L8n pplxGqvHceCSWDSMsQzX9T5Ay3VHKwOK1IFLFKBCEaDxNcWDWEJP8NGgic97UFUcUIVGZGko0BGi9cesLxP1c79hV7052d00llsyQsmSHtTbRNaX0zyDg/xVFl7WvQTASLxQNWUck5poYHiVLFTG1eGsSG5RuhINXWLEZim1jNdJTgaXl0MxDHeezXJe8R+kEtJC4jahw3+gfvlCCRgi3NSNx5nfd1P0IVkdXZAntZ4JOGMrgyH2jinLgM8Kf1MpTc7lBL3CimP96cPE1jViR1g7adZ9b48iY/Qg7Qt2+AiwIm98Gyv0iHQt0KO2qc8lEK2moqG/3Z6ZbI/wmOqIxpngEGU84MPF9a6ilIa2gDwJslYdkfOGdChTpf66jtLe0o5fB49xpTVGw+XSgHh5LGWtx64ivCTWjbyl7O+u9rCi+UC1lm/aLGjip0uQyFpkur+CuELClXtHTpabEct+eWrRpN0istBOHH278QRor2XY5HtsvIOJJjvZOnoX7I748Xy2wzPjkwS13DiIs19EVTdvXAmH52xV3Tk5GNBHKC/wXvaQ3TvEuDWGMKDB6DLr32FdjIxlQDkIGmSMJWuC14jKbpjf8v1UCImR5Be28D0DAF1E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 31, 2024 at 09:12:46AM +0100, Michal Hocko wrote: > I will leave up to you whether to add above paragraphs but I believe > they clarify the intention and the implementation. Both seem reasonable to me to add to the changelog as well. > Acked-by: Michal Hocko Thanks!