From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5091D767DF for ; Thu, 31 Oct 2024 16:06:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 342F66B007B; Thu, 31 Oct 2024 12:06:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F3566B0082; Thu, 31 Oct 2024 12:06:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 195DC6B0083; Thu, 31 Oct 2024 12:06:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EEA6A6B007B for ; Thu, 31 Oct 2024 12:06:41 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 31090816B2 for ; Thu, 31 Oct 2024 16:06:41 +0000 (UTC) X-FDA: 82734374184.19.245BB00 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf10.hostedemail.com (Postfix) with ESMTP id 10541C0007 for ; Thu, 31 Oct 2024 16:06:26 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=QwWiRLHB; spf=pass (imf10.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.160.171 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730390667; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SO7v+RfZoLfypZ4KKZMOHUyo7JMuVsRRPoIxDWu9s38=; b=YEFCWcoBbwuwYkVfO/noveffH5K5AIgyL8kxj5R8GEUCKwglEMLKMw2mu2A870ocEeLgkz egczXECFcJKYyRVFvirQVhn2WgPTwD59t7kw1+BrYaRC1k8VV1tPYuHUf6KjnmXSoyo+4U fjMtXeMZw26LHaXaqjV+g/WsjdZODv0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730390667; a=rsa-sha256; cv=none; b=4SZI3ezNVwBwaaFEH9Y9bDqeZ2DuVKtq619iQVGvO6Ya1Hl63Fkx5ZDmK432OCRgGlXwp/ f087JYW+jFXMCyaga35XXGH85svQZjhfMyf+veWiCI3/b8J7UBT8zAOJ+zdIYw5Icyp/Yk 5R3AV47odKMAaYBHGdNOMqSLQEnI+hw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=QwWiRLHB; spf=pass (imf10.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.160.171 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-460ad98b031so7273521cf.0 for ; Thu, 31 Oct 2024 09:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1730390798; x=1730995598; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SO7v+RfZoLfypZ4KKZMOHUyo7JMuVsRRPoIxDWu9s38=; b=QwWiRLHBsuVl502dLrvEHpSLR/er5+abWqqDwLsO6t4OS8qtfDz5TpJi5pNJ5ZQo5b mKBCHqaicgry3OARvwb8Uok8SalRtUQi5xu/xiYY09ZKh29dhv78NB5+kmBgfXZR+Zct bdNY5nEEzXxQD9ORWUpPT8DRF8KdDFEXLOvB9iFc+ZgSuCO2BOTjxzFXtlALDlSBA6fz /UXHtw/YMdqO8FH//4tRBMYwzYVQYLG0NMXftbnQ3VRjUBi2/pdEvPoAWUAGfSnOkN4z 18tMpocYG33xjFUR1cjLrvDrL5zNg0mrkX8zwzb30DXGXXh+BIBDjNs6Duam7p7TpJ+J ZbwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730390798; x=1730995598; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SO7v+RfZoLfypZ4KKZMOHUyo7JMuVsRRPoIxDWu9s38=; b=fUM3GRs0SmOcXxYH7K06C6eunR2VY9Cwgv7YyisHXBn+gkzxk87JJW7Yle+YRHs1aV 0V87gk5ZDqKtUFskE8YG5cnlkW/9vkTcCcBPv90Yefb7xORNsNvfLjgdDNYPqfDTD1bt NhKjnq399CA4cDw4BF5ZDSsW5sJAsnUvKfuUGzKvhq7Ox9DmEO5740vY4AyF4UHTcqgX 2Ici9YraxUx71u3ZkiSJauf2VZSZwEZNcKltmTVi9mAgHZAyiOzhCfjT8gJMynWdi/70 h665j+6qxJnLoPyFqQ4BAfBsUcf6orhf6ATbbbjtbriwCgaUej1KIi6SNzK1twkfTdG6 kUAw== X-Forwarded-Encrypted: i=1; AJvYcCXpwiwkrBO9kmuSD0D+Cu/O1A65SV+xAwLacU0p0uhgtvK69Y5M7wo2nghZ6FjDS+Nqh/43mDKKgw==@kvack.org X-Gm-Message-State: AOJu0YzLdzdnMid6lJzkJh/vIvNfya5IqvZCBIENRAd5yoRB6VOJVmTI NgrvSTWkNzJOTVretEB93QTZggzYOHaBJtuXBcN/byA5Sr8n/DkmHu+AOQ/hOk8= X-Google-Smtp-Source: AGHT+IED7ZEPsYL/J2+WAEkVhkkEbmae8OqhC99bUW9D4jOFLXnCuUGOPCgezgCfHDV8eABlx8kETQ== X-Received: by 2002:a05:622a:144b:b0:461:15fc:7fe7 with SMTP id d75a77b69052e-462b86a6a75mr989681cf.28.1730390796638; Thu, 31 Oct 2024 09:06:36 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-128-5.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.128.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d354177d2fsm9043376d6.107.2024.10.31.09.06.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2024 09:06:35 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1t6Xgx-00000000Ic7-0kQP; Thu, 31 Oct 2024 13:06:35 -0300 Date: Thu, 31 Oct 2024 13:06:35 -0300 From: Jason Gunthorpe To: "Gowans, James" Cc: "quic_eberman@quicinc.com" , "kvm@vger.kernel.org" , "rppt@kernel.org" , "brauner@kernel.org" , "Graf (AWS), Alexander" , "anthony.yznaga@oracle.com" , "steven.sistare@oracle.com" , "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "seanjc@google.com" , "Woodhouse, David" , "pbonzini@redhat.com" , "linux-mm@kvack.org" , "Saenz Julienne, Nicolas" , "Durrant, Paul" , "viro@zeniv.linux.org.uk" , "jack@suse.cz" , "linux-fsdevel@vger.kernel.org" , "usama.arif@bytedance.com" Subject: Re: [PATCH 05/10] guestmemfs: add file mmap callback Message-ID: <20241031160635.GA35848@ziepe.ca> References: <20240805093245.889357-1-jgowans@amazon.com> <20240805093245.889357-6-jgowans@amazon.com> <20241029120232032-0700.eberman@hu-eberman-lv.qualcomm.com> <33a2fd519edc917d933517842cc077a19e865e3f.camel@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <33a2fd519edc917d933517842cc077a19e865e3f.camel@amazon.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 10541C0007 X-Stat-Signature: 5aa4fwaj77ysnjsz6s7q338a3uu11k4r X-HE-Tag: 1730390786-763135 X-HE-Meta: U2FsdGVkX18mcSeo2v9o8x9pfP9U4JkZTqgwudiAdj3ob8NEqtYS24Uz7tB9oLZ8Q92IIFWkPRWXNznB3XZaibezx5fMhJVjr9EN5SJklw9xuoF69TE6NAHLv3hQKXd8l/LG+NbC4MVpLu1dBos0wXfowl+zUXLkZesX+Tsp3CH6chC5H4K6DIcp18JyjtNDwhqmeceJeBmr1hNEXYjmF2cU71q9HwE0ys2vTyuYAKJuZ9nK5bdj+dv7ic9gVzXQzXuEWyfQHtm44xJWErOnCuGO29I7bqDau7Fo0etNSX+HedloZF549uxtheIvvv0alKiVjeMWjDyyreMGfDec7a4Liu57xwq4EHYHuNO/QIXrVHyRQTy52flpjzREsdAPV6STtvDsWFqWXAHyP4XPXuc6dhU2uzcMLhVCSBmwPClr6yyQxRhr/r4JGGAF+BC6jOQnekEAMwpbn8+1duM0lPdigpRysojqVJOl1dvkD1gp6/l1lAmtzqIrAyAyr6yvKrv6h4Ft8vMd8RjQ+p7+iimAXPB6PMN46rhmLtxIR5sNXwIooLweHi59iVYtLSXm+FY/X7WDPhKoqwdTAWPTAR/7bxu9bWvpFi5Wc/H4NH0Gyo44fDdYo7ZEWIqPMO//qEWkCGOPjuqkYiKob80HzmYSux9BWVDZrI1hmukia2YGmy7FM5Gh14j2OKL2aZNAIyumpXHqCxm2qskLEhtqmgf+mzJxhdzBZYJxe3Q0rtgzW+A3sAUzTRsVD6R38bVmD3wCRUXvfxqRNA8MCTohyS5y/trYacVfmkFR7YH2f7F3PzDgtKe4LfdJhF3flQGapVeyMcPE4ICGZQyM8eO4ZjATAclW9n9vGMw/15uVjFKC7Xfl5T5oeH+C6gyIt4Od731AAN0Aelar217eFWtp5JIoqnnu0DNOCkv7vedWCkIEerqOwu2UZ7zzKfTjk1xjyZt+3BmKUnybRc3Dehb LBQowUEk 337vOKE3t1ATUJ+uMRnaKsEGUZBKkhCHcR6LZ11jvTaevliYC3hoDnRq+hEifD0nJnQOFeBNkmGyZpzF2XG9ezNZm9YNSUq/hgalZZqNLnKLI1OQAjiKVTtDCYHGwcuUTYYQjny4FaGZ4LSN+fBrtRhJRqT4Ah8oRg8QsBOT+B9+7GlN6iGZTQpEnacmW7mTK5BaRbmVGkTpZD1XAMWhBGul4dKkpd9GcxENmwOC/+bjGbdM/xBDC85vH0fZeY7seGsHyp+2VUb3aR84IEdB1QXZR0bRJB6ZhHe2B++Ez49v6qcpfg9XqzllvF/ZK4WkIYkLaeL+eO829pRvDaOyaJty2c0Ab/sTUpk8suYcMn3DsWXxsJ3QeIaYCoQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 31, 2024 at 03:30:59PM +0000, Gowans, James wrote: > On Tue, 2024-10-29 at 16:05 -0700, Elliot Berman wrote: > > On Mon, Aug 05, 2024 at 11:32:40AM +0200, James Gowans wrote: > > > Make the file data usable to userspace by adding mmap. That's all that > > > QEMU needs for guest RAM, so that's all be bother implementing for now. > > > > > > When mmaping the file the VMA is marked as PFNMAP to indicate that there > > > are no struct pages for the memory in this VMA. Remap_pfn_range() is > > > used to actually populate the page tables. All PTEs are pre-faulted into > > > the pgtables at mmap time so that the pgtables are usable when this > > > virtual address range is given to VFIO's MAP_DMA. > > > > Thanks for sending this out! I'm going through the series with the > > intention to see how it might fit within the existing guest_memfd work > > for pKVM/CoCo/Gunyah. > > > > It might've been mentioned in the MM alignment session -- you might be > > interested to join the guest_memfd bi-weekly call to see how we are > > overlapping [1]. > > > > [1]: https://lore.kernel.org/kvm/ae794891-fe69-411a-b82e-6963b594a62a@redhat.com/T/ > > Hi Elliot, yes, I think that there is a lot more overlap with > guest_memfd necessary here. The idea was to extend guestmemfs at some > point to have a guest_memfd style interface, but it was pointed out at > the MM alignment call that doing so would require guestmemfs to > duplicate the API surface of guest_memfd. This is undesirable. Better > would be to have persistence implemented as a custom allocator behind a > normal guest_memfd. I'm not too sure how this would be actually done in > practice, specifically: > - how the persistent pool would be defined > - how it would be supplied to guest_memfd > - how the guest_memfds would be re-discovered after kexec > But assuming we can figure out some way to do this, I think it's a > better way to go. I think the filesystem interface seemed reasonable, you just want open() on the filesystem to return back a normal guest_memfd and re-use all of that code to implement it. When opened through the filesystem guest_memfd would get hooked by the KHO stuff to manage its memory, somehow. Really KHO just needs to keep track of the addresess in the guest_memfd when it serializes, right? So maybe all it needs is a way to freeze the guest_memfd so it's memory map doesn't change anymore, then a way to extract the addresses from it for serialization? Jason