From: Andrew Morton <akpm@linux-foundation.org>
To: Kinsey Ho <kinseyho@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
Muchun Song <muchun.song@linux.dev>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
David Rientjes <rientjes@google.com>,
willy@infradead.org, Vlastimil Babka <vbabka@suse.cz>,
David Hildenbrand <david@redhat.com>,
Joel Granados <joel.granados@kernel.org>,
Kaiyang Zhao <kaiyang2@cs.cmu.edu>,
Sourav Panda <souravpanda@google.com>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH mm-unstable v1 0/2] Track pages allocated for struct
Date: Thu, 31 Oct 2024 16:06:04 -0700 [thread overview]
Message-ID: <20241031160604.bcd5740390f05a01409b64f3@linux-foundation.org> (raw)
In-Reply-To: <20241031224551.1736113-1-kinseyho@google.com>
hm.
On Thu, 31 Oct 2024 22:45:49 +0000 Kinsey Ho <kinseyho@google.com> wrote:
> We noticed high overhead for pages allocated for struct swap_cgroup in
> our fleet.
This is scanty. Please describe the problem further.
> This patchset adds the number of pages allocated for struct
> swap_cgroup to vmstat. This can be a useful metric for identifying
> unneeded overhead on systems which configure swap.
Possibly dumb question: can we switch swap_cgroup_prepare to kmalloc()
(or kmem-cache_alloc()) and use slab's accounting to satisfy this
requirement?
> Before adding the new stat, Patch 1 introduces a generic system-wide
> counting interface.
I don't really understand this one and would like to hear much more
about the motivation.
And: "the existing use case" is OK with a global counter, but what about
future use cases?
And: what are the future use cases?
Thanks.
next prev parent reply other threads:[~2024-11-01 13:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 22:45 Kinsey Ho
2024-10-31 22:45 ` [PATCH mm-unstable v1 1/2] mm: add generic system-wide page counters Kinsey Ho
2024-10-31 22:45 ` [PATCH mm-unstable v1 2/2] mm, swap: add pages allocated for struct swap_cgroup to vmstat Kinsey Ho
2024-11-04 16:22 ` Michal Koutný
2024-10-31 23:06 ` Andrew Morton [this message]
2024-11-01 15:54 ` [PATCH mm-unstable v1 0/2] Track pages allocated for struct Matthew Wilcox
2024-11-13 0:19 ` Kinsey Ho
2024-11-13 19:18 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241031160604.bcd5740390f05a01409b64f3@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=joel.granados@kernel.org \
--cc=kaiyang2@cs.cmu.edu \
--cc=kinseyho@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=pasha.tatashin@soleen.com \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=souravpanda@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox