From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C51CAE6B278 for ; Fri, 1 Nov 2024 13:57:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6224C6B00BB; Fri, 1 Nov 2024 09:57:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D2AF6B00BC; Fri, 1 Nov 2024 09:57:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 499616B00BD; Fri, 1 Nov 2024 09:57:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1DC806B00BB for ; Fri, 1 Nov 2024 09:57:23 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C17ED805CB for ; Fri, 1 Nov 2024 13:57:22 +0000 (UTC) X-FDA: 82737678030.02.11F514B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 852EA80008 for ; Fri, 1 Nov 2024 13:56:27 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dTQP7PS+; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730469359; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IFtadrMJSRC2bhRhwtJqH1xosuWz+cF6ZPVZbQmWVFU=; b=mVblNzY2hBo71Kvq4IoLjm3pX10CnG8GrbiOhzeOO89pBlV+xIU/Eb8vKxvb0zOGjEEB0L hQWF6KKdG9xNGfSxwPyO6Q3X9XO34PQlTYUYGMMdAIQxXMJDCOzXLoCyHqByuoaOieSBQx xYhBEj7nly/O/WL4dWQK+AZTyA7BkZk= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dTQP7PS+; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730469359; a=rsa-sha256; cv=none; b=pswmFhSXwGDMpWygwwjnLwSvBAP3EqFxq9mj8pbloy7Yvp00zdHAs2ObKypyeF6hgA4QAd lIGyUeYQJkSz5Qpt+2HbX5MJy3P+mULkqDCgquArZmKySh1vlX+3/3MEv50bcOP6T3cdme FgoTWIbWifTbnMGehBEmlCwk7URS564= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 230E35C9565; Thu, 31 Oct 2024 09:37:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04050C4CEC3; Thu, 31 Oct 2024 09:37:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730367470; bh=tqzJLh5GYRL2KEmKB06uhDKvLABRYtBWXtB3Y8bMEKA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dTQP7PS+/MTyTtUMPwFCdUdEd1qWr3BPPQ8pvyYPVrtbourx/L8sdNPTr9lPj1QPB g933lrXQqvAJxMV1kQiG2xyG7NF8LnS9wKQBA9lsBXrn5RHD1+siwDoEBnl+zfB8NV DrhOyVxwnAVdg5G2IeaEo3cxX9HtNdkNEj0b51HcYMeCY5S9sSDgNsPLzN1l7uwEAl 8UAGh7dlC4XLOOvyRno1rlDrgXdZkQFymJIkdmkKL/RzKkO8mH98WS4qTpitL+TrzB j4UfpaLbeZXfuUbC0SIp4WAe0T7KDxaEbIsTC03s3SAkoAGz9+Sya4ZfdJPQPVNS6T b1awtly2cL7Qw== Date: Thu, 31 Oct 2024 11:37:46 +0200 From: Leon Romanovsky To: Christoph Hellwig Cc: Jens Axboe , Jason Gunthorpe , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v1 00/17] Provide a new two step DMA mapping API Message-ID: <20241031093746.GA88858@unreal> References: <3144b6e7-5c80-46d2-8ddc-a71af3c23072@kernel.dk> <20241031083450.GA30625@lst.de> <20241031090530.GC7473@unreal> <20241031092113.GA1791@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241031092113.GA1791@lst.de> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 852EA80008 X-Stat-Signature: cjtda9ny4m173tn19skfz3k43m6pz9r4 X-HE-Tag: 1730469387-184427 X-HE-Meta: U2FsdGVkX19ZTX7JuxMYldbdywdyomQb8TsaM374ddXAInSL0ifeqqoL+x0GYIAwMPSA3UvG27nxTSk9ZWmkuLGYkpYFS+Ap92/kAq+Wg4ppXYOPxAJJo1NJx220pb9D7IiJxa49Kq0RRLpIhlJVXhc7IJIsoRfQSC7K8Djq6wY+fLBujjtbzUEeEVZ7Zd+LZJOtawCOpeALlbTYc8iFuN+lQpAQNW1W2FQVe7zbncUzo8t57cwKsXPLteijdUphuSVt3Vy1mYnVoZlwi8/zOpgBJ5NMeNW5eYLn975gaDPF2Xan6tHIbIXVoh2AkHJWc34L+7qjeb7BbgTdElOH/Xs2BUZSQ9wjehrjI2T7clf/M5heGe7OgEEPwSVSXRlb1kW4jz8ME/Uo49tyau1VXGKWgSp4atVYigOMmceMNKU71Sah8RUgcvp1rA76+Wr+m9GLRY0UBz16djO0nr1Sf0HcGZXRj+ctC3+tIyXeb4gscFy6/gDvS0b6p/mlh1vSvS+QAtfQ9K9vfGMNxIZ86/3bq7QCPdPe2WQl4fQWxwql+0Q52VhH/vd4UcU2hMcROHaMOjsgTvIiskqeq/pxbETZtKcHciM6lp3y8AUa3kNkxMo2sd8oF/G3sbGPTaLJzSj1Up1KIngWagAJKRAyUG2LRiVrvOG9/aZbqJxCykN3XHmcjNjK9Q8IMH0mIbZ8gX64sKrMZMQ0y8tqw6pCn4pEvV24kSg9NQK3TIyz32Q4Diz+Vojqt5P3hYJl+Sb1/aNthfLNAEAJzCiU0z26jI4bmGd4kn4H+jeC8p5qt1IY/a2vDk+ih6/WhhQxibFjbgYzGIOmQrJf12aDla5xJQ4H1hjbWZRHgDqO0cI6oq0npPyhNBkIuPIAIsEl0FCXKA1Kxn7gVpq9EhszyEwT06JX1mLeBaCtWlKIl5YH9tH4uWosL4yL8AYUodnmnNsJbleCgjxG7t/qNDy8dcG +jgnmDu5 KQJRgOOQ3/Vd+488+OCC2Tc0WMKZ6qwMThhD9NRcmkoHMHfsIG7/sLRsui+3Feli0u45Gq24UhMKfCbgzCzsrbUnAt1ptjNgCT/PMIV63pjoAFNWnf83jNLI+D+SUPZisaP0XzfjKKJ/V8hNJ9KtQA3gVxcihynV4z15oCgOQUz7wTDR/Ed4XpCA1EGkZohbWk4Yy0KCV0xsJF1pemJLVgNNCLVE4buwond3k8wXdIZS5Ep4VhA+HmyRJeu208bxQy5jDfUYu2jlGk5/rl1kAHcokK0YQnPKITi3H X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 31, 2024 at 10:21:13AM +0100, Christoph Hellwig wrote: > On Thu, Oct 31, 2024 at 11:05:30AM +0200, Leon Romanovsky wrote: > > This series is a subset of the series you tested and doesn't include the > > block layer changes which most likely were the cause of the performance > > regression. > > > > This is why I separated the block layer changes from the rest of the series > > and marked them as RFC. > > > > The current patch set is viable for HMM and VFIO. Can you please retest > > only this series and leave the block layer changes for later till Christoph > > finds the answer for the performance regression? > > As the subset doesn't touch block code or code called by block I don't > think we need Jens to benchmark it, unless he really wants to. He wrote this sentence in his email, while responding on subset which doesn't change anything in block layer: "just want to make sure something like this doesn't get merged until that is both fully understood and sorted out." This series works like a charm for RDMA (HMM) and VFIO. Thanks