From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5689CE6B27C for ; Fri, 1 Nov 2024 13:57:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E113D6B00C0; Fri, 1 Nov 2024 09:57:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC1D96B00C1; Fri, 1 Nov 2024 09:57:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB0B26B00C2; Fri, 1 Nov 2024 09:57:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AB7C26B00C0 for ; Fri, 1 Nov 2024 09:57:57 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 674CD80507 for ; Fri, 1 Nov 2024 13:57:57 +0000 (UTC) X-FDA: 82737679248.04.B538C8C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 69AA580011 for ; Fri, 1 Nov 2024 13:57:02 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=caiZOHyS; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730469419; a=rsa-sha256; cv=none; b=6sxvdUfft3Q9zTIZTw2+fkQ2n7ut6OBT5KjTlxYsp3iDYdN2YrkWaRkwlmLWJFzOAm8D8v 01pbQWVdLbjAo5bg5Okedsglh5BBJIn3tfzI1cVsy/Ap1IJotJaHoZTlpPbtDTXEytpwJd lvZflVCLdV2pWSMSlr02KIRsU22Bpwg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=caiZOHyS; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730469419; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N36+sZTgOxFU489MYbUlUcrQkmTMpbbSczJ6ZFcprwU=; b=nXxo8d8FMjFfW4Kp0Lt8rGEYy5+/Wr9srf3aXL26uIbHRJRi2hWeKbRHUQWFYEDIsG06bG lHhTgXBoHBJfhVcGfJeRZqqGr457cNBvZTOQaMT32GtOMghnus/SfhqQiad/sVCBNPmlKH KsUDLbwZ2SCAD2d+Bam4LNdvx5sH8QI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 63F725C7EB6; Thu, 31 Oct 2024 05:20:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DFE78C4CEC3; Thu, 31 Oct 2024 05:21:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730352076; bh=oKvzKHSIFV/9a64ZyFXNr4nz7kAn5pfeSQBzNS7WmCg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=caiZOHyS42Gmy/N5hIh3F5TJLHa7uuNoOGhtp8aCIsFwS4zu/CDMaOaZagD+I791m umBpbe/HVeTlgmX9sTjx40wXeASJem12UVa22xfvhINX4WH+LdXv3DchJhTMGTpuCJ kUsy98+o/QOcdK9jOqEHe0vruZpJxUpPx5bo7OaRLWft8meWBp6b9+3JRxmVKt6jxZ rphERfYhjCK+GyYjGcEX0Vh5CmxX+KgxdBEhSccOJVNblIInleRdzznjPmSWSG4N/b sH596P1e521UefZSXg4HSDvW6KGQc3pKdD/OXEgnWt8dOCr134Gc3CrXDl0AG/i3r0 ZqPWmhX1Igq5g== From: SeongJae Park To: Guenter Roeck Cc: SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] mm/damon/core: avoid overflow in damon_feed_loop_next_input() Date: Wed, 30 Oct 2024 22:21:13 -0700 Message-Id: <20241031052113.66155-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <4dd8ba2c-e994-417d-baa9-47e40b50c1b4@roeck-us.net> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 69AA580011 X-Rspamd-Server: rspam11 X-Stat-Signature: 47fa4igkjepmajdstit55nwepfnr7h4a X-HE-Tag: 1730469422-107812 X-HE-Meta: U2FsdGVkX18Dsq1dCZb6nFqBX51pXENKQv6YX5VQf2VBwXf7EMykvPFhCOCQ5JeH0QtJUtG9ho9WSkL8hHuYcsa+EBhrKULTwgjzILPpgTYRZyq35P2Wq4p1143OIMwirBfhqYa1C1yd2TbUfGFoQj1++d2FgdX9x69PIWZIVQbF+dWy96sYLJdD4HYfIe+wodUNmTz4QLlcgAdoAIKNrdABFLNJpIaHQaRThA7HdYKrVEAzX069yKlih4Z7VF/kRR2n2jHF3cMp31mP1RAA3JSDOCi4nBiE0z7s8VKkhN/h/1cSWFlVlKdclv4yMdzIfsAi3SZNHQbE5m62LeDyAs/6cYF08nJ+btqKedCXJ9h6oiZQAkusEFTm1/HgaYZOgKlkWJs5CsmAImQcRyQzG9njBNPQNOhG0oo6MkO6zFlJcfEdiWDKDCsftEWzaU8+uUvJ8OJmKIfEFL1bwV7kM6V+TIiAMQpjOGW1NH9eJwfvS1YFwKUT+vvGreQI5n5pW+96KugeuGglvMiZenH+dxaHgGgIJhAFJdyo0OZOFgEPV5FzAVMPGQD9RSW68Kqez/alBO9S8pw+KljFmeSeuyzWJWfu+kkE7V7CWYRxGp2HtsxP4zRCS5u8Koq1bqjZUM/R3wheGUOrPFVz5JjwK8qEjAXVo5h4d0NuQlwCADyKKiXgRibsjXxBs77D8nuEUfRf3WuQG2JvZn3V6zlQmyr9SZmolcJRyAE/qadQnjPQyENZBTxZwqoDnXLAMNDUD4MDSbzznL0GZJ6c/mLITviQs2X2+YeMAEWv3FHgs4ALlaHw6H1acPV1RjnuWWR8R401msnxPPRpvh/NbJEzpDbBUEwsYAtES7PAvcPNf3KLLUi3iiZX7kLcdRmwoyZuqMFxiDYTq1ttaHBSy3HdhY8JcSHT6Ml/XRdNOlykvoesauT4MkoN6Naa1mfUWAoLSQA3ewFw2b3z5NhmJPI UctlxLlS q+hi8IBlE2vvHjZm/sDGlYHbfxbBgE5c0sQOElhGRJTQtzDq5qpZv5+GwC9g7d7aBhZuCwj86FxHf/9vdMuE1D9JmRDhvdsn6b+YoYZpweFm4C4rFptPg15TCJBkTMEwZklGkVDUQuOgsGQS7bu7XSGf0t8lxae3IH+HHyf+bEaHcpKgn4MchzycXHOviHhQ0GdNCZeYsGAK0bNyD3+kxQ8wYKlHViQKzXuMZa9znUCDXhv9+Zw5YhQs213en8C4h1kUu+MwglwLd8CE9iXds+UeIu63SaF3r6Ar/sglD4+u9W0jS9Z/MDdtPMuJBW/Lyyqkm1/UpxYbcU6m12yWQnGsV66Ge16cWkzrUXsFEuIB7n1+HOlcmcgQJCQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Guenter, On Wed, 30 Oct 2024 21:18:51 -0700 Guenter Roeck wrote: > On Thu, Sep 05, 2024 at 10:24:05AM -0700, SeongJae Park wrote: > > damon_feed_loop_next_input() is fragile to overflows. Rewrite code to > > avoid overflows. This is not yet well tested on 32bit archs. > > > > Reported-by: Guenter Roeck > > Closes: https://lore.kernel.org/944f3d5b-9177-48e7-8ec9-7f1331a3fea3@roeck-us.net > > Fixes: 9294a037c015 ("mm/damon/core: implement goal-oriented feedback-driven quota auto-tuning") > > Signed-off-by: SeongJae Park > > --- > > As mentioned on the commit message, this is not yet sufficiently tested > > on 32bit machines. That's why this is RFC. > > Is that patch going anywhere ? I have been testing it on a lot of 32-bit architectures, > and I do not see any failures. Thank you for this nice reminder with the grateful test results, Guenter! I was recently cleaning up the code and commit message, and testing on my own with test setup. I should confess that it took more than I expected in the last RFC posting. Sorry for the delay, and thank you for your patience. I believe the patch is now in good form, but I was waiting just a couple of more days before posting it, for a case that I find any mistake on it. So unless I find something wrong on the patch by Tomorrow morning (Pacific Time), I will post it after dropping the RFC tag. The current version of the patch to be posted is available at my patches queue[1]. Please let me know if you find anything suspicious on it. Thank you again for your patience and nice reminder! [1] https://git.kernel.org/pub/scm/linux/kernel/git/sj/damon-hack.git/tree/patches/next/mm-damon-core-avoid-overflow-in-damon_feed_loop_next.patch?id=fb13d053bfdd5249bebdd1c253417f97cd41471e Thanks, SJ > > Guenter