From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EAB1D6B6B4 for ; Wed, 30 Oct 2024 23:35:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC8C38D0003; Wed, 30 Oct 2024 19:35:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D78268D0001; Wed, 30 Oct 2024 19:35:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C676F8D0003; Wed, 30 Oct 2024 19:35:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A6FDC8D0001 for ; Wed, 30 Oct 2024 19:35:31 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5CA564116D for ; Wed, 30 Oct 2024 23:35:31 +0000 (UTC) X-FDA: 82731876822.10.48E3EC2 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf19.hostedemail.com (Postfix) with ESMTP id CA8291A000F for ; Wed, 30 Oct 2024 23:34:56 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=0IlHqw4n; dmarc=none; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730331274; a=rsa-sha256; cv=none; b=OUeXCzOnhTPnsE5Dht6w9qAGTRr5mY2tT/769rmTQOpqEo+jqCBXs6F3XoUUzIfQqHKHtx tiMaE317Ql6aLE0QUcH7jYzQa6Vk5uQkPM6l7jp/xkBxvA1mIFNDShii7ZG5OW43sOxHbo zYOL2V/LP0vBS59jOPRBKzadvMJfTVU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=0IlHqw4n; dmarc=none; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730331274; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Arbo5TZV1w647g8aL06NvYUaReH5Gd2SXzhRQen9edg=; b=zHqgA4DJY5HB8r0MNxhAN8vlsCjH9siBiMKOF/s0eiuI3YE3w9LbJIgtO8y/RzCeIpdRYT jAdOUvWQREBQ5ldPdYDRaAtscy+DLEGjbn+/pvZwxzWw6UuM7VRW6cNk7XLuRQooKJCNYA 2TzGU9nkML4mkra0XoO2Nv5ZWWlnqOw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 3DF4FA42DB7; Wed, 30 Oct 2024 23:33:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6EDF9C4DDF9; Wed, 30 Oct 2024 23:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1730331328; bh=VGb5+kePxnHAvj2Y4Su4IxNhTPMs61I7pCNndF/7rro=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0IlHqw4nFE6qsPCwf3chn/p4mvn+U9vIdjmV5C9hblndTnlFrfwdH7koPJFJQP5SS HpGKAUnVPfqd1Qq2hbGhLoligRwcdeBfgEDix5qEyxWqlT95gkQ/H9vZCCaaehW8Ce 6tI4iwKa8pKYimEsWjEs8IRlW43ygoit9QoCxvlc= Date: Wed, 30 Oct 2024 16:35:27 -0700 From: Andrew Morton To: mengensun88@gmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, alexjlzheng@tencent.com, MengEn Sun Subject: Re: [PATCH] vmstat: call fold_vm_zone_numa_events() before show per zone NUMA event Message-Id: <20241030163527.cc9075a4aeb60448873aea73@linux-foundation.org> In-Reply-To: <1730277457-22725-1-git-send-email-mengensun@tencent.com> References: <1730277457-22725-1-git-send-email-mengensun@tencent.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: CA8291A000F X-Rspamd-Server: rspam01 X-Stat-Signature: xcu1m6ocymkxszq77w611k8q46j1ni4x X-HE-Tag: 1730331296-499405 X-HE-Meta: U2FsdGVkX1/eGi3ZMwxvJm38PEgQkIDBsXCbubC4+RgH4a8IsGuo/ylFNSslFsNEQlsdVyNBV/clBP5NT8jYpEpuGdtul3gx53/yONWz12bvSllXWBe80+GKy2QkdksIO9gkiCD1XHgXhz0nmH/slXCrWMRyO6OgONYCNIT9mPSS3yjB1wMY1AptF3AUgETrNf3YWJSLgjHawE0J4WWl38mqJAb9Uc19tH0AA1EPZGFwtfxg9qLaGfGmTrVdloxefJuuSaDmmn0+66rjZR4xcbKi77IPkn0YCGSsYKDcwPCobkInj0pieWXesLBDhUnZZcXPjgS8VBygxindrrC6VuQwMo1UbMrgYBSCPhkWwBu2nW5/CChzYoH7zYdAjs/GBluH++9zkxlJaeDqpGSLqcfxnPVffdXcaYapjcUIeEiNZkxY6YZ8Rq2ZXrwTh+moOb5TGwrYvY2y2P8Qnc0od7AoszVRYvfil3/UbKz1FBiyDIMKai6skPsybHPP7h0Vv2GdimAnzdTkXgZkA+8h2PNtAV7KiOzzC6uCpdEgLyJIKnFBmwLzV2+UpUVqn577ke7RRp3mft8fgveDU4CKcN9eAwb/rR+3tuN0/iVAz3VVMYscNoWNiCpEJOGfCsFRIiV4uVvXgSj2w9BUPZTDZGxHO5qSRm/zgO+HJUtlZzzYOHjhzoPf8nXAZu+N/Ksn22tn1DjwCkp7hm7sHhWyI3Mvg7vNgbWRzE7v8sx5KqzvOB8u4v2PZVf3OldZLK/E7REXXBqQMBeaSvPQiRaXg3Ic+U33KbXTk6adbH7VRJa2GUDlChW8rKHIECxc/fAyUSC76FJEn6FH4Ft9maRU8yxiOrSW5ETqcnj4Rx2D0kQOoJGyzm/hAnAdSVqHixhkW0GfgyULLwh8N3QguScLPr6lfts1itIDX3v/pT2SV7SpDn+2FSzkMc5LsktgYLs4REK21yvPtgDCTYk+rco XQAj084+ w8MNRvTRdNC8iNu6dM0RLSSG/l5Db1QnMUsVGx7TFp6nxr72akIgMWznztagZZEd7CoNi2Bo7tDJXM74ZAdE3ztoMEKEmklMXhVQIqe3FVwojkrTY2zOlvutpLEVqAkZ7jQk/Dbxymrnb0b4D5TjkoOOjlAvwJCDCPcNN8RIoYW2gLD/0C4dL26NsKNA20PKGSfFkVbZa2vxy0KmaxOawSqGNHQBJXyFiPOGFfknCkWiCnKzy9LBT01Bx/Gv9knVFA9nQ81jCYL0Q1l2xnz4EyktY99bwAqehgwGfwFy5CZ4Mv8UXDQ/0bZXIoHyJk9TUlgk26eRZSKYthBCRm/6SyWA8mVe1XSjEDorJe2uv8C/vTk1iJdvjhkkAGg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 30 Oct 2024 16:37:37 +0800 mengensun88@gmail.com wrote: > From: MengEn Sun > > NUMA events will only be folded from per-CPU statistics to per > zone and global statistics when the user actually needs it. > > So, we perform this folding when reading the /proc/zoneinfo When proposing a fix, please always fully describe the userspace-visible effects of that fix. > Fixes: f19298b9516c ("mm/vmstat: convert NUMA statistics to basic NUMA counters") Since v5.14. The information which I requested will help others decide whether earlier kernel versions should apply this fix.