From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5B51D6B6DE for ; Wed, 30 Oct 2024 23:26:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B2DA6B0089; Wed, 30 Oct 2024 19:26:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13CD46B009B; Wed, 30 Oct 2024 19:26:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1EEB6B009C; Wed, 30 Oct 2024 19:26:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D270C6B0089 for ; Wed, 30 Oct 2024 19:26:28 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7D2CCC1112 for ; Wed, 30 Oct 2024 23:26:28 +0000 (UTC) X-FDA: 82731854058.10.22F7581 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf03.hostedemail.com (Postfix) with ESMTP id 9D3E520007 for ; Wed, 30 Oct 2024 23:26:14 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=oFUriJg9; dmarc=none; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730330706; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lCr8UNALvm23z8PW3tS81omAT1iPp9ViKenKaKud5OE=; b=pszpZV1E0tvfNoA9ydzr+Ap69NR4GxzMiTPgnmHs0QQFCb2gzbfv+swmjpU0mrJ6syAEEh KeQ/zXc8Zk0ZkbvoWE+eGJyHtIi5rmP2j+sX+D20tzE4fdNVU+2mTOKoWOsd1AEF6RNJrm cWEhbdvHiKSARRSUzExcAuFkVDUqkFY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=oFUriJg9; dmarc=none; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730330706; a=rsa-sha256; cv=none; b=nhL6ZadAg/y4I+2ghWD5VpO1qzH6t6Qupw9E/iBue6UoaW3LheH1tE6JzOt3HA5ivJawM4 2AWUn5z+pOt7YVr6z7K/PqBaIDDKdsBQHKetdPSqqNX1wFyGNAO48wAJozuZL+qOAvNOQh uyc6NUi8NqLZfZxaq3dinxelpji0XkU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 676A3A429D7; Wed, 30 Oct 2024 23:24:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B2DBC4CED4; Wed, 30 Oct 2024 23:26:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1730330785; bh=wPMPLo0mta4qVpGzLolACfvuHSWiB6tecr7v0QVNiiE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oFUriJg92Dn4a60uaF1IBC3TaNYrQLGQvRPbLY4YNZMSGWLOgpyQrHkE7cN9ybocB EKR7ojApZlS2yHRM5OZq28OKvDu5+jREiU8oD1bwNorRmZh5zdt6zYU4mgpROhQi7w 4PJpBrixkESQxiMBDqaU4jqMjqP9/ccGYLRKUlK0= Date: Wed, 30 Oct 2024 16:26:24 -0700 From: Andrew Morton To: Joshua Hahn Cc: Johannes Weiner , Michal Hocko , nphamcs@gmail.com, shakeel.butt@linux.dev, roman.gushchin@linux.dev, muchun.song@linux.dev, tj@kernel.org, lizefan.x@bytedance.com, mkoutny@suse.com, corbet@lwn.net, lnyng@meta.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v3 1/1] memcg/hugetlb: Adding hugeTLB counters to memcg Message-Id: <20241030162624.2ae779257e68264c4bec99fd@linux-foundation.org> In-Reply-To: References: <20241028210505.1950884-1-joshua.hahnjy@gmail.com> <20241030150102.GA706616@cmpxchg.org> <20241030183044.GA706387@cmpxchg.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 9D3E520007 X-Stat-Signature: qm1ucjep3bdzq8djpcp1993or3btieet X-HE-Tag: 1730330774-785287 X-HE-Meta: U2FsdGVkX19GADOZQGTNU+4LD+YVxnVkE63NWf8UijEMMVF8bEn2nkP3UGm6R7+TIu17luxiTwDsAgpc3GbHboQbC1d6+DqRIXJHE2uUSdIzf8o72GazlkKZiSQWGk1RSArxPoTYu4Z0WRMYCtDn2KhFaMw3M+chZHfwmgCb8WPHZN0YkgoJbskUVoCodcIiua5F/4cN6Sm/EecikoF/JaJtQTQhiY/RSwpnY43/UzAwtF74b78smHeaKkJ/MliFupx2PPZWILLcBkUsobstJaIqWYqbJyWUev9vnprUS0NZiKsqfrP02X5AwCiktx8pfq1RuAsa+8HOQmExdap2qXDmjQhk0xFpfL7rYy05FfAVhEUxVH78UxMGg9Kb8g6mlEbrqqwe4ZgKvSWOV4JSvpNDvS1N5ZFZefZouYm/Ob2oDy7cYyl+NsnnuoPNEKOy5UblS+g5PNDp2BNgf85wAVrYK1xMZ84NDYtePPubIxW4AWycGIR/SGXI8dQGmtTLjdAp4fpexLyJJG4y5p4iJPvvpnHY/Ni7qZUpaO1TyJQ5F8UtzmgvP60gHdPqY+c1WS7AS5twihRmt/bX2JX7Btgqg+OoIdjjcZeyeh+h/CLlW1qQEIMphVOTOUUeDO3Zh/V90iIQXmbfSS7ieC532ATs7wzdqPlK2Qcveff2NoLNz2M5ZwQdqcVkyDx6BZvoHgaIhARHzH2+1CaX7zd5UXcrP3Ow3ic0kQy6YgqeSzz7enRrka/tfNOWHwJ4kpqcCy0Jxpmp5SuZHtX9N2mZM9D5Rr7xWcf0AFmhf7mz3qM2OsA79y8NgXJtIDRZHaej7thGmgXcJ6kJq3Y77+0uiO9in/hlCQuWF1nGaE4xNMKZXPEUOyaZTKsbrueFRorBRmBDuSj7fWnVSfCqsfSZyc95+cdyr+MFFwftIy/siVdJzzUkItyVY3TF6SY4IakeFPuevMxcUs185Nb2Qef dXSZdmCy a43a9Zuc5LqL0Mp1YR8OANZX8gUmOckBROGlZc9JWdrOUYHv25w8itjgMzbqIbFACeEEwzqXzeb4G3hsdfxkBiAQ0TNwf+Ou13M0bCEuHrShVX2PkMBh2YmIRlYxvGbfMeEus0noziPeiGOv1Da3AaEgFtc6BMoJWkGquMwkeZCFQNwBTMrlgX894mWNwMMLKTbxWPjiPXSgWXGGezLSJ90bhfpu5yYtPXKNBZYvuAj+kwzeMmy+N+ef0EmvAEAYGghLiPEFVtgyToOOeftZNlucpWQdjEqP6rk8wWTjgRWJycL+xsgPQc2Dcb0eySIKRCs5NZVTid0GWnq+hFQvztfEnALq49Qlmy68DUBH5NLBx97svKmT4clxg93OttlmzIUpQGg32Ij1q6bfUjXDkGx+mrS7eE0fJDmb3yTtYLqUVzOI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 30 Oct 2024 16:43:42 -0400 Joshua Hahn wrote: > I saw that it was merged into mm-unstable earlier yesterday. Would it > be possible > to add this block of text to the patch description right before the footnotes? > > 3. Implementation Details: > In the alloc / free hugetlb functions, we call lruvec_stat_mod_folio > regardless of whether memcg accounts hugetlb. lruvec_stat_mod_folio > keys off of folio->memcg which is only set up if the > CGRP_ROOT_MEMORY_HUGETLB_ACCOUTING cgroup mount option is used, so > it will not try to accumulate hugetlb unless the flag is set. > This also ensures that memory.stat::hugetlb is the same as > the share of memory.current that is used by hugetlb pages. Thanks, done. > And could you also update the list of signatures to reflect the > responses on this version? > Suggested-by: Nhat Pham > Suggested-by: Shakeel Butt > Suggested-by: Johannes Weiner > Acked-by: Shakeel Butt > Acked-by: Johannes Weiner > Acked-by: Chris Down > Reviewed-by: Roman Gushchin > Reviewed-by: Nhat Pham > Signed-off-by: Joshua Hahn Done2. I already had all that, plus an ack from Chris Down.