From: Andrew Morton <akpm@linux-foundation.org>
To: "Maíra Canal" <mcanal@igalia.com>
Cc: Jonathan Corbet <corbet@lwn.net>, Hugh Dickins <hughd@google.com>,
Barry Song <baohua@kernel.org>,
David Hildenbrand <david@redhat.com>,
Ryan Roberts <ryan.roberts@arm.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Lance Yang <ioworker0@gmail.com>,
linux-mm@kvack.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-dev@igalia.com
Subject: Re: [PATCH v3 0/4] mm: add more kernel parameters to control mTHP
Date: Wed, 30 Oct 2024 15:50:59 -0700 [thread overview]
Message-ID: <20241030155059.9e27019842ef7c009b728b27@linux-foundation.org> (raw)
In-Reply-To: <20241030130308.1066299-1-mcanal@igalia.com>
On Wed, 30 Oct 2024 09:58:54 -0300 Maíra Canal <mcanal@igalia.com> wrote:
> The second and third patches focus on controlling THP support for shmem
> via the kernel command line. The second patch introduces a parameter to
> control the global default huge page allocation policy for the internal
> shmem mount.
The changelogs for patches 2 and 3 both say
: By configuring ..., applications that use shmem, such as the DRM GEM objects,
: can take advantage of mTHP before it's been configured through sysfs.
There isn't a lot of info here - please explain this timing issue in
more detail.
Because the question which leaps to mind is: shouldn't the
"applications that use shmem" be changed to "configure mTHP through
sysfs" *before* "using shmem"? Seems pretty basic.
Also, please consider my question to be a critique of the changelogs.
If the changelogs were complete, I wouldn't need to ask any questions!
next prev parent reply other threads:[~2024-10-30 22:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 12:58 Maíra Canal
2024-10-30 12:58 ` [PATCH v3 1/4] mm: fix docs for the kernel parameter ``thp_anon=`` Maíra Canal
2024-10-30 12:58 ` [PATCH v3 2/4] mm: shmem: control THP support through the kernel command line Maíra Canal
2024-10-31 3:53 ` Baolin Wang
2024-10-31 12:32 ` David Hildenbrand
2024-10-30 12:58 ` [PATCH v3 3/4] mm: shmem: override mTHP shmem default with a kernel parameter Maíra Canal
2024-10-31 12:37 ` David Hildenbrand
2024-10-31 12:51 ` Maíra Canal
2024-10-31 12:57 ` David Hildenbrand
2024-10-31 13:24 ` Maíra Canal
2024-10-31 13:33 ` David Hildenbrand
2024-10-31 14:19 ` Maíra Canal
2024-10-31 21:12 ` Barry Song
2024-10-31 21:12 ` Barry Song
2024-10-31 21:39 ` David Hildenbrand
2024-10-31 22:16 ` Barry Song
2024-10-30 12:58 ` [PATCH v3 4/4] mm: huge_memory: Use strscpy() instead of strcpy() Maíra Canal
2024-10-30 23:07 ` Barry Song
2024-10-31 10:55 ` Maíra Canal
2024-10-31 12:01 ` Barry Song
2024-10-31 12:11 ` Maíra Canal
2024-10-31 20:27 ` Barry Song
2024-10-31 20:31 ` Barry Song
2024-10-31 1:39 ` Lance Yang
2024-10-30 22:50 ` Andrew Morton [this message]
2024-10-31 11:04 ` [PATCH v3 0/4] mm: add more kernel parameters to control mTHP Maíra Canal
2024-11-01 1:12 ` Andrew Morton
2024-11-01 16:34 ` Maíra Canal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241030155059.9e27019842ef7c009b728b27@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=ioworker0@gmail.com \
--cc=kernel-dev@igalia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcanal@igalia.com \
--cc=ryan.roberts@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox