From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B69BD5CCB8 for ; Wed, 30 Oct 2024 15:08:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A571E8D0009; Wed, 30 Oct 2024 11:08:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A06838D0005; Wed, 30 Oct 2024 11:08:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A7AC8D0009; Wed, 30 Oct 2024 11:08:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 694198D0005 for ; Wed, 30 Oct 2024 11:08:57 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F08D9C0BFA for ; Wed, 30 Oct 2024 15:08:56 +0000 (UTC) X-FDA: 82730600862.14.853A394 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) by imf10.hostedemail.com (Postfix) with ESMTP id 34412C002B for ; Wed, 30 Oct 2024 15:08:43 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=XmMu0x6X; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf10.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.180 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730300804; a=rsa-sha256; cv=none; b=h+qnHhu/Ok4cSUKYEcTZgBaAC7g3eKr7wYEFbjUK8AbhjWpJdEP1wbCcEn1tTV/EPgs3Nq ybaXQ0NVtr+ZKbBnyu/sLpcw2/apXZQw+sC10QchaCYWUHJR5pl02dOyOMKR8kaQFfjKcA O91eVs1KnI16AP5NzgFaesBj+DkPldE= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=XmMu0x6X; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf10.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.180 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730300804; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A7/6UYbf7ybZ6VNcKsjEex4GMkaYamVw7s21C2iJmhI=; b=8EX7ZlkKXoysRDJ+A1KDg4JnznGdYTkkSvCRdroG8IIhOknyBfgvo+UwjUPymAc227fabx BqaraN5b+GnBprqdw9CW5W9W4dg1dhb9izzKqiS/YFpCJOlVK+7URaIhqdnCYlj3Gd4Irb GFzNvcd18apCs5pP1fkJv+zjfLUkSjI= Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-7b14077ec5aso93844885a.1 for ; Wed, 30 Oct 2024 08:08:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1730300934; x=1730905734; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=A7/6UYbf7ybZ6VNcKsjEex4GMkaYamVw7s21C2iJmhI=; b=XmMu0x6XEQY2tg+17p5cn65r/idySu3Wdzs/wVLf/B1qPQz6FhbvIs00Q7RDYGE/Nl e/rngbToJxKX2+JjtIsZF2OVjFEmvFTD/GCD/nvX5MDnFwclv5+Mo2fsXUoCKj5LpxlQ hnFUDrqH3FTNBOVPIgBvK0DDIIM4tnWfUS/HLoICLboP58+8RDLb92xsA0df1l/LNSGH xIEsOrMSE9BayAwDgS3le5fSBu1oltSt90hDSJOctRs5ugwvjWQx+UxI/gxRM2xegvpO wzamFw8vITmvOP/DBo75UgBOXo5SagoMnExWhBMqrUIRJ4uNMDxYnip47VNReYB8c3/H 39EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730300934; x=1730905734; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=A7/6UYbf7ybZ6VNcKsjEex4GMkaYamVw7s21C2iJmhI=; b=aMxwjkwjjO2t/+L9S0CjfYjGSVGNW4e5SLLoQPoGMyydJdpJ5puZx5Vw18VjCa+Ton +zReW0A+FerfYhemGC9qMM08tpVZj2/nWdiAiTh2HdIdQTgpWwv2ArcosOhm3yv6Cd8J Fx34N/5YiVoarS+oZo63358zdIRSvLPQozuk9klFhxnON5wfY4NfkMpW0XAOIGzV+0Y9 aF/NeAD6oFq5nHp63X6UftBvkq3YhquhuAoQi2C8Fc0EZZKKRYII/35MFkHe+ZgOBLQb 1mM2gwLRfEAmddXxsbRcI4wkArKBTYW1xXRn2zUTEKUlaA7oC+sl999FWFJaXyFvFBRe puxQ== X-Forwarded-Encrypted: i=1; AJvYcCVsdMEyko9AW9O7fJAbJFFbUGGnxasbEyNyk5kyxcBCsdNbU0boArpGbvE2DHhm1XCmKLgzZ8q5Eg==@kvack.org X-Gm-Message-State: AOJu0YxO+m1m3Xu0tKjB45/sHnNQYmPKCu0kX7HoSwShQI0V5LxUoO9Q WeyFYN7d3ox8T80CQsQ6z3eb+mrmq2mi3KfHQr/oVlsAq3pn7HIy6UQTU1ktEYw= X-Google-Smtp-Source: AGHT+IEL0dQXvbpBYl4+++/Sj921xMYBN2z8f0z/Fw6yy1eHF/5+LTCuLkRdPXctroNbHp8klXSWdA== X-Received: by 2002:a05:620a:f07:b0:7b1:4783:aa2 with SMTP id af79cd13be357-7b1a9cc0e7fmr1135432585a.7.1730300933470; Wed, 30 Oct 2024 08:08:53 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b18d2940f7sm519976985a.37.2024.10.30.08.08.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2024 08:08:52 -0700 (PDT) Date: Wed, 30 Oct 2024 11:08:51 -0400 From: Johannes Weiner To: gutierrez.asier@huawei-partners.com Cc: akpm@linux-foundation.org, david@redhat.com, ryan.roberts@arm.com, baohua@kernel.org, willy@infradead.org, peterx@redhat.com, hocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stepanov.anatoly@huawei.com, alexander.kozhevnikov@huawei-partners.com, guohanjun@huawei.com, weiyongjun1@huawei.com, wangkefeng.wang@huawei.com, judy.chenhui@huawei.com, yusongping@huawei.com, artem.kuzin@huawei.com, kang.sun@huawei.com Subject: Re: [RFC PATCH 0/3] Cgroup-based THP control Message-ID: <20241030150851.GB706616@cmpxchg.org> References: <20241030083311.965933-1-gutierrez.asier@huawei-partners.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241030083311.965933-1-gutierrez.asier@huawei-partners.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 34412C002B X-Stat-Signature: szn8x5e1naz5hf4n3rurhde1hsdiu97x X-Rspam-User: X-HE-Tag: 1730300923-348261 X-HE-Meta: U2FsdGVkX1+SMaainM2JFrRHn7jjAtXusBBKg7b0VpVEJKyjifmvGnKpGOYEbPxJzdtaYG59N5IOuCCANNlo9R0W99s00XDixnUPzNwZXpR6c31n3mD4G7/yDb9RLOVRVFx0ebiLATzliVO/28EEbEH/NwhrR+wnGZjX2EJee+62tlSwC7zwv+UIOrgqzPFAxezRCA/TUsPZ3Y9kCaWfkFS4r78Op1+WD1ArwTPnSi8kzagIZqcaYgjcXCX8TuDkOS/k0iqErseR9BjkUyzT9K99SwNbnM1pX+WCjumxaHXqJYw4kZIRo/2/tJ6vCrjonsz7EkGsJYoRbK3vp13186MblI2oSbQhUifXzyF/RRC82Cl+z0P8Kih2vtDCFcmyZECzaah0q3dzbV+fzf+mI4qhAvrYCvncvepbTprKEKhNTlTyonX+3Tlo2HtR1VmTbeh5oPhnIcZE+5zAgkQruQQLsoND+MpXqOu5zOHwojS/y9aHQ8IB18oD1w46Yi//ZM2ObOgGvN5UYXfD42u9JrufHkkRZQut0nOFSTxk4aPCil4rq9M1njZRgYsrrRBEgwFFtYXvqGKyVJSqKcrE37SRIIs7b57XMaXodvDuwX9FnrWAV+tAYxNrclrS+FhIDQsNmO4lHWwZGFcPejCb/rlTf6zRgAveSVs7SwoIjnePeOCRZUxpIOCSiHY00epdO6DdvDZSjAaT8rUk3WblUUElktz477hmnr8P4C42zhXiCYC+Xx7t2jN5GVWgEgDvkfqb41HC2a6D493CqVGG8/uf4kqrVP0F8J6qrbEoNLsCxwZB2j3cAcf9XRWg8Xqklb7Rpse4ZPq2k2KVA3cmKdcD1BzXu6UhTEss80jOG9d6Smkjob6FabyejPwpGlGj0XvY3+vrozzFUUrWDs9OS3huutQzQqVKRYjzgvGfWbPfy2fuC75qlBcZEt4I3PB9KEkJxxdFKJymRb0LRCQ nhLnN3W/ jjE/WWlogwD8cwx/lZUOmfeBQzWsw5nDIKJu+Qvh3oeha5ZUwljiL4kqCVBg9YN8YVidTfbWY1lsThk3+e3W0PmGzSxTMQ32cNroL/asx6Xd13pubpMpWVGVag1RhBN6pPbEXMif/GcUJinlNq5L3WXFZBGywrC5fidv00NmPKE8TMJ/PFFhyfgUOdr4bAt6DtfrWktehS6aqAJseaJd+F+dm8gO1pfwpFH8GxPWrXfC5VZuSfCsa1eCAXitU6nb2x91kAMRPHTzegBKytdQxst3J6MWBqR2auY2Bo4B7mzbk6162cei9J49hcgwAtYwQPIejmHtLxw0A8BEyevw4zYOpoQKCme1LPLGu5h+5DzNUuTEMQB4GTWYkr8sKRjQpNocBYvPQWOVDYMcwRUNBaxnkeVOmoqt9Oz31rsWO4/3EG6X7TBq8XKhLxW77pePpPx8Go4Y95NDkh5RmJJseHrxEVfrj9mNxa98BcuOc7hg0JJjLcSrZwKlitRKoRR+Cz0Y1LkMyZk2ssiU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001246, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 30, 2024 at 04:33:08PM +0800, gutierrez.asier@huawei-partners.com wrote: > From: Asier Gutierrez > > Currently THP modes are set globally. It can be an overkill if only some > specific app/set of apps need to get benefits from THP usage. Moreover, various > apps might need different THP settings. Here we propose a cgroup-based THP > control mechanism. > > THP interface is added to memory cgroup subsystem. Existing global THP control > semantics is supported for backward compatibility. When THP modes are set > globally all the changes are propagated to memory cgroups. However, when a > particular cgroup changes its THP policy, the global THP policy in sysfs remains > the same. > > New memcg files are exposed: memory.thp_enabled and memory.thp_defrag, which > have completely the same format as global THP enabled/defrag. > > Child cgroups inherit THP settings from parent cgroup upon creation. Particular > cgroup mode changes aren't propagated to child cgroups. Cgroups are for hierarchical resource distribution. It's tempting to add parameters you would want for flat collections of processes, but it gets weird when it comes to inheritance and hiearchical semantics inside the cgroup tree - like it does here. So this is not a good fit. On this particular issue, I agree with what Willy and David: let's not proliferate THP knobs; let's focus on making them truly transparent.