From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D02ED5CCB3 for ; Wed, 30 Oct 2024 15:01:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B64008D0007; Wed, 30 Oct 2024 11:01:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B13CC8D0001; Wed, 30 Oct 2024 11:01:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B4478D0007; Wed, 30 Oct 2024 11:01:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 795A68D0001 for ; Wed, 30 Oct 2024 11:01:12 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D29E5A0D49 for ; Wed, 30 Oct 2024 15:01:11 +0000 (UTC) X-FDA: 82730581332.14.2197B98 Received: from mail-oo1-f48.google.com (mail-oo1-f48.google.com [209.85.161.48]) by imf06.hostedemail.com (Postfix) with ESMTP id 85288180027 for ; Wed, 30 Oct 2024 15:00:50 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b="p//f9AA2"; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf06.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.161.48 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730300414; a=rsa-sha256; cv=none; b=0xGAwEz+VP77fzch/OBgGfDpRPraUq5FNw83Kg9qeiRB6geyEnoRc4DbF0CNAO+zjsoFX3 rvOgvHk1VT3UFDJzDgNsBhbryDAnat9VJ0Zd5dt8OWB0sG4WCfgXDJC/FMwi5XU0EuTgIm J1P9CAUjrFJyA5qNQZnypGDRmcBlpn4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b="p//f9AA2"; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf06.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.161.48 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730300414; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9L+h3DakvrHLU0Mvs5EKdTAhMxHYKDitGx80mazmNoE=; b=M/h3NusMnr5yFU8Wr50TxZh2KzfHt74G7I5sCiWM9r878iOxRQXpuUiYkL32OuFppkdOEU O6hT+fAb/x/w9uj/L0aq0aa10Y9+/q7RYbV2+uYeXNTTSgeRT7CgTP5TmQwQ03UntY+6pM no3sjeh/EA9SUtOKRrkTtogMnUQZXOY= Received: by mail-oo1-f48.google.com with SMTP id 006d021491bc7-5ebc4e89240so3182913eaf.1 for ; Wed, 30 Oct 2024 08:01:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1730300467; x=1730905267; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9L+h3DakvrHLU0Mvs5EKdTAhMxHYKDitGx80mazmNoE=; b=p//f9AA2/08DS7VpHxpEupNIRMtNGXxWuQILGbv0TH7rwRTYEGRe6uf1/1kFOnaTI3 AF+OYdZIL61NTK0B+rVIfwknpaJExbw+lhf2CQFKvkrcYSQLsu5riieXQ5TpiNqaPEdC ECiD18ZYuZsbFUKcZfhC/+aCw4fALUOtTvbr6zHGLcI54fn46LyVW0H6PbfsmrRHJD2K ohJB4slIRikhAXkn3VBVn32YlyfYQ5WcPPHNZMZkzrkta9HQuSke4pA9uWokDuQEeaaJ Mo6XEpKrIVgMHNPVjTr70GWvRDeho71OTFgAgqKTuM1TWy1kswNYWJmkDWW+i7BuVJ3j PXfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730300467; x=1730905267; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9L+h3DakvrHLU0Mvs5EKdTAhMxHYKDitGx80mazmNoE=; b=EfLfr1kTB7/S9eix7DydQcSgRIn5nrtTmOFT9AgYtcpeKZA8AJ3+7/8OsGn+J1Y0CF 2Kpe9qOxUTXD2fmc5tORe+pfcul9OmgsDsXGY/Q283jFvlkIfGHhrhgAqkzDbP0lU4ZC G/Gr/TEtC6R7k5RyPiAS3GDOnfTepqdCye2D8RGOV9AHUhh4xX7qDYQVXGNQnBzfPzRr RkW7A3pdVDb+BDj4lCW6p/mYieMf2LPYg8yb0Y2XPrbiNvLsQoMt3L8QCMXKl4soc1BE LYEJUQIMWDO5uKe+5yuzV3Gj38Jpy9ag6jw7Olea1f4tDaWwXH9u2LdjHc3rXDgdRMl6 +0QA== X-Forwarded-Encrypted: i=1; AJvYcCX7/rcBxoNakupCQtQnJAC1EZjHpS7yZNpRH1T4vqzWzt6csGqGok4VDtQ0lJSXks3kLtTa3xojqg==@kvack.org X-Gm-Message-State: AOJu0Yyx9XcjB2EU4+Fv3CHNcRLh5j+vAluMUZfmeL88XhfAwnHvwJ8T 07bfnRX7JVJFV6JfOZYt7r6KDpDOkDVKd7CYa6Ho1/kIS9bLMED+G9F3YtBjQHU= X-Google-Smtp-Source: AGHT+IG158ptjqLIj0gjGFfB685gOEBJUFjuG7Y8dRLeCk9VafXrmZFUa5vVNmgGQg2umHSprc+JtQ== X-Received: by 2002:a05:6358:729c:b0:1c5:e2eb:2fba with SMTP id e5c5f4694b2df-1c5e2eb32admr285161955d.18.1730300467658; Wed, 30 Oct 2024 08:01:07 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-461323a1bf3sm55265351cf.81.2024.10.30.08.01.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2024 08:01:06 -0700 (PDT) Date: Wed, 30 Oct 2024 11:01:02 -0400 From: Johannes Weiner To: Michal Hocko Cc: Joshua Hahn , nphamcs@gmail.com, shakeel.butt@linux.dev, roman.gushchin@linux.dev, muchun.song@linux.dev, tj@kernel.org, lizefan.x@bytedance.com, mkoutny@suse.com, corbet@lwn.net, lnyng@meta.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v3 1/1] memcg/hugetlb: Adding hugeTLB counters to memcg Message-ID: <20241030150102.GA706616@cmpxchg.org> References: <20241028210505.1950884-1-joshua.hahnjy@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 85288180027 X-Rspamd-Server: rspam01 X-Stat-Signature: gdcgrf8khwh9ht5k3zjijxojp8tefddy X-HE-Tag: 1730300450-407829 X-HE-Meta: U2FsdGVkX1/Oo4DbLuikn5kGcKwudHKRfaOedEFNx0zX9srpZWP5YMfJoxBrmpjGCsCJUUWl1mHOsUKWeeje0vZlJ7PkzPZdQ4Bmy8XhY3nZG3nELOQVd2dSC8j/cmqOJzuzzOsOi3U1+GmpTRTyexeoeIz9kQy5FgGK7d4PLoPk58NpTUia/1np9ZxbyBR+uVgP6VbOLO6vSXS+jJfbCWGYQOQxcQBM4NLaV6v8TTjc2rrVdjyDSOe+xSSQLZ+74BVVIeHQWiM1A7IO/zXL01RvcJQFWfeCmw0yUmr0R5zpdfpvmzKH9oBt2Sm+T7Pwfy9YCObyQVSfQX7fD5ZsyVpZgbm9ksM+QTFCL2lGJwBRlov5C9Pop6yN+8w9156ClD3GSv4k+AyfL9oN73btWBLaJjJFmGVrSqMEXo/deYCtIBbmUUkKrPfopOnP052o7mWyj/xeWJiDRbHMAXz7wH09477YWgtRE4z/AjOm70x6fmRUX6KdR8Bb3vR0GIbBO5EwyAxGXgQK+D6haLXPiebWmSgTHWael978uQdsUOiFZzF1M5Js7tlBF/Y7RR8zelUdAI77GeFybi0ogTCAj2eUmDtnE168z+yrw2uuN14vczFKNztBB4cgoWwwPRK9LJjAo0+mjjO0EM8ITEbLybAg+sR/EH232MfjA73KsKvVRYupAMbiLVWm0xbELHIzF9EN5RCo82nWOwtmylBLqvBOLq0uaPLGO3bN8KxA/I/7ZGiROc1ADGVWnTtuLwkHjz0IgewAOcwK/UjR57OYqr00jM8PCAwbrOlY41EaocouvUXQ4nr7/l9rqGsH9W3Qn/Bthpkiw0JLqLpab5760AwYKQnpPe7S0Tuy7ksH4dhyRGevGOQ3ErchPT3o0LElzQhIQa9Ox9aNQPladmnjuTShhNHZc2kaD2sOa3Qadat50GZossnimEVXIvl77s5h5JNoYVfvEnIQHsxD6wp CaIzRorY +TfDgSA4LBQrL2+v2Zf36fv6uN/m/ozwVsyuFTtwzfEPAvgmeKGtyyD05qqmKzMDff7Znvq++jHNglvILeCoOwmg5QJc2+JgRr0KCewMMsScg/w3egtHW6Qquc/DecgvJpxc4w5e0NLZQSgwxzPFUjZvh7ImRWlifT5x+2jfhdbdinWbEkiOXyU6IViOocCOnznDWld8ECouEXHEp6FJ5TRtyWAkJKOI1kexH4oJBcXHMix+0XHjOmsj4NcmCDFv6O2DUSlVSZkGpdfECDmstX13avygk4EXBRujLNXWqGhs3S3uzoG+grEiXDqawtcfPzOENm3ttfheOq60S/1Hi7GZgExPDrvQFMwPfQ1dvWkMg7Ve9lETImMDLfybz3iWL57kXS7enk+sdYy7DXeZSlf3musS30B+dHXkWnd5l3i1i73YZU+Ic/7JMT+t2H17s1W7iqUXA8+9w7dR4q/mKtvhQIjqal2OkSG4IlbjKc76kCgk3ket/jx6jtjL5gDpT/s6nSYZMPNJw4hu6b/Lqay6IPL9+ZKyGAMJfuhFir0VGnbw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 30, 2024 at 12:35:25PM +0100, Michal Hocko wrote: > On Mon 28-10-24 14:05:05, Joshua Hahn wrote: > [...] > > Changelog > > v3: > > * Removed check for whether CGRP_ROOT_HUGETLB_ACCOUNTING is on, since > > this check is already handled by lruvec_stat_mod (and doing the > > check in hugetlb.c actually breaks the build if MEMCG is not > > enabled. > [...] > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > > index 190fa05635f4..fbb10e52d7ea 100644 > > --- a/mm/hugetlb.c > > +++ b/mm/hugetlb.c > > @@ -1925,6 +1925,7 @@ void free_huge_folio(struct folio *folio) > > pages_per_huge_page(h), folio); > > hugetlb_cgroup_uncharge_folio_rsvd(hstate_index(h), > > pages_per_huge_page(h), folio); > > + lruvec_stat_mod_folio(folio, NR_HUGETLB, -pages_per_huge_page(h)); > > mem_cgroup_uncharge(folio); > > if (restore_reserve) > > h->resv_huge_pages++; > > @@ -3093,6 +3094,7 @@ struct folio *alloc_hugetlb_folio(struct vm_area_struct *vma, > > > > if (!memcg_charge_ret) > > mem_cgroup_commit_charge(folio, memcg); > > + lruvec_stat_mod_folio(folio, NR_HUGETLB, pages_per_huge_page(h)); > > mem_cgroup_put(memcg); > > > > return folio; > > I do not see any specific checks for CGRP_ROOT_MEMORY_HUGETLB_ACCOUNTING > in these paths. I guess you wanted to say that you rely on > mem_cgroup_commit_charge setting memcg pointer which then __lruvec_stat_mod_folio > relies on when updating stats. Yes, this is what Shakeel pointed out here: https://lore.kernel.org/lkml/il346o3nahawquum3t5rzcuuntkdpyahidpm2ctmdibj3td7pm@2aqirlm5hrdh/ > I suspect this all is done because you want a global counter to be > updated as well, right? Changelog doesn't say anything about that > though. Why is this needed when /proc/meminfo already describes the > global hugetlb usage? Sigh. vmstats is the preferred framework for cgroup stats. It makes stat items consistent between global and cgroup. It provides a per-node breakdown as well which is useful. It avoids proliferating cgroup-specific hooks in generic MM code. It was a ton of work to integrate cgroup stats into vmstats and get rid of all the memcg special casing everywhere. You were there for all of it. We're not adding cgroup-specific stats unless unavoidable. Duplication doesn't matter, either. We have plenty of overlap between vmstat and meminfo. By all means, send a follow-up patch to have the meminfo one sourced from global_node_page_state(). But you know all this. I'm having a hard time seeing the way you are, and have been, engaging with this patch as good-faithed.