linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Maíra Canal" <mcanal@igalia.com>
To: Jonathan Corbet <corbet@lwn.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	Hugh Dickins <hughd@google.com>, Barry Song <baohua@kernel.org>,
	David Hildenbrand <david@redhat.com>,
	Ryan Roberts <ryan.roberts@arm.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Lance Yang <ioworker0@gmail.com>
Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel-dev@igalia.com,
	"Maíra Canal" <mcanal@igalia.com>
Subject: [PATCH v3 1/4] mm: fix docs for the kernel parameter ``thp_anon=``
Date: Wed, 30 Oct 2024 09:58:55 -0300	[thread overview]
Message-ID: <20241030130308.1066299-2-mcanal@igalia.com> (raw)
In-Reply-To: <20241030130308.1066299-1-mcanal@igalia.com>

If we add ``thp_anon=32,64K:always`` to the kernel command line, we
will see the following error:

[    0.000000] huge_memory: thp_anon=32,64K:always: error parsing string, ignoring setting

This happens because the correct format isn't ``thp_anon=<size>,<size>[KMG]:<state>```,
as [KMG] must follow each number to especify its unit. So, the correct
format is ``thp_anon=<size>[KMG],<size>[KMG]:<state>```.

Therefore, adjust the documentation to reflect the correct format of the
parameter ``thp_anon=``.

Fixes: dd4d30d1cdbe ("mm: override mTHP "enabled" defaults at kernel cmdline")
Signed-off-by: Maíra Canal <mcanal@igalia.com>
Acked-by: Barry Song <baohua@kernel.org>
Acked-by: David Hildenbrand <david@redhat.com>
---
 Documentation/admin-guide/kernel-parameters.txt | 2 +-
 Documentation/admin-guide/mm/transhuge.rst      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index 1518343bbe22..1666576acc0e 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -6688,7 +6688,7 @@
 			0: no polling (default)
 
 	thp_anon=	[KNL]
-			Format: <size>,<size>[KMG]:<state>;<size>-<size>[KMG]:<state>
+			Format: <size>[KMG],<size>[KMG]:<state>;<size>[KMG]-<size>[KMG]:<state>
 			state is one of "always", "madvise", "never" or "inherit".
 			Control the default behavior of the system with respect
 			to anonymous transparent hugepages.
diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/admin-guide/mm/transhuge.rst
index 203ba7aaf5fc..745055c3dc09 100644
--- a/Documentation/admin-guide/mm/transhuge.rst
+++ b/Documentation/admin-guide/mm/transhuge.rst
@@ -303,7 +303,7 @@ control by passing the parameter ``transparent_hugepage=always`` or
 kernel command line.
 
 Alternatively, each supported anonymous THP size can be controlled by
-passing ``thp_anon=<size>,<size>[KMG]:<state>;<size>-<size>[KMG]:<state>``,
+passing ``thp_anon=<size>[KMG],<size>[KMG]:<state>;<size>[KMG]-<size>[KMG]:<state>``,
 where ``<size>`` is the THP size (must be a power of 2 of PAGE_SIZE and
 supported anonymous THP)  and ``<state>`` is one of ``always``, ``madvise``,
 ``never`` or ``inherit``.
-- 
2.46.2



  reply	other threads:[~2024-10-30 13:03 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30 12:58 [PATCH v3 0/4] mm: add more kernel parameters to control mTHP Maíra Canal
2024-10-30 12:58 ` Maíra Canal [this message]
2024-10-30 12:58 ` [PATCH v3 2/4] mm: shmem: control THP support through the kernel command line Maíra Canal
2024-10-31  3:53   ` Baolin Wang
2024-10-31 12:32   ` David Hildenbrand
2024-10-30 12:58 ` [PATCH v3 3/4] mm: shmem: override mTHP shmem default with a kernel parameter Maíra Canal
2024-10-31 12:37   ` David Hildenbrand
2024-10-31 12:51     ` Maíra Canal
2024-10-31 12:57       ` David Hildenbrand
2024-10-31 13:24         ` Maíra Canal
2024-10-31 13:33           ` David Hildenbrand
2024-10-31 14:19             ` Maíra Canal
2024-10-31 21:12               ` Barry Song
2024-10-31 21:12               ` Barry Song
2024-10-31 21:39                 ` David Hildenbrand
2024-10-31 22:16                   ` Barry Song
2024-10-30 12:58 ` [PATCH v3 4/4] mm: huge_memory: Use strscpy() instead of strcpy() Maíra Canal
2024-10-30 23:07   ` Barry Song
2024-10-31 10:55     ` Maíra Canal
2024-10-31 12:01       ` Barry Song
2024-10-31 12:11         ` Maíra Canal
2024-10-31 20:27           ` Barry Song
2024-10-31 20:31             ` Barry Song
2024-10-31  1:39   ` Lance Yang
2024-10-30 22:50 ` [PATCH v3 0/4] mm: add more kernel parameters to control mTHP Andrew Morton
2024-10-31 11:04   ` Maíra Canal
2024-11-01  1:12     ` Andrew Morton
2024-11-01 16:34       ` Maíra Canal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241030130308.1066299-2-mcanal@igalia.com \
    --to=mcanal@igalia.com \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=corbet@lwn.net \
    --cc=david@redhat.com \
    --cc=hughd@google.com \
    --cc=ioworker0@gmail.com \
    --cc=kernel-dev@igalia.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ryan.roberts@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox