From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AF6ED3A66C for ; Wed, 30 Oct 2024 09:23:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF7618D0005; Wed, 30 Oct 2024 05:23:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA6AF8D0001; Wed, 30 Oct 2024 05:23:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 920338D0005; Wed, 30 Oct 2024 05:23:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 747CF8D0001 for ; Wed, 30 Oct 2024 05:23:36 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E4E91406C0 for ; Wed, 30 Oct 2024 09:23:35 +0000 (UTC) X-FDA: 82729730538.28.88A7A10 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf22.hostedemail.com (Postfix) with ESMTP id E9375C000E for ; Wed, 30 Oct 2024 09:23:01 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=GUfZKJt4; spf=pass (imf22.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730280053; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h2QyrifHMzH2OclDL/eDVhaglcA9L6ksjE5JpdclRwI=; b=cpfXrwF7y9jNMJ7K8BYzDlMGeJASSOHL16W20n0sMa3SMBYT6WUss40m3xaRrqqQAW59F/ ZnqCgxu+ke2Gg3CRMdfyi9bHXiWwKwDSy9XqvyLWdjSML/odlt7azuYLNacBAoXIQ4Q0nW rMUP4OYd6WgUmnPpPh7S4rWy3CD2SgU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730280053; a=rsa-sha256; cv=none; b=2q6nIuLmq4kJeJepsn1zuPYwcUmONgLQhCLDNaSTNy2bkAtMN9SAzqninPljVWp2RWExhw n1xICnsC0I4sFdWap5RKNP9ixkytTQIQ6wxRutRqoGsahUxsQKyg/wr1PiW2A/zYE2puuW UxDg94s7HRWzAY5U8ZbmZ5qucceyMSA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=GUfZKJt4; spf=pass (imf22.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49U2dDm0003625; Wed, 30 Oct 2024 09:23:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=h2QyrifHMzH2OclDL/eDVhaglcA9L6 ksjE5JpdclRwI=; b=GUfZKJt44k/8X711P74wYRfR9AZa6D/OzlQ+G3wbiUXJ6t X8ShV0n0b3bxVaD2zlzalIMneUR+03VlWA9eICcQ/UyR4x79wKBG9hm2riqri1Gn nDzmb7xBcFORsXS/kjpXACAqUM7eC9ynNrS/VN8zCYno64saB81frrLtMN6thPbd 4x5tVL1VA0H+fTjuv7msWGLgZLbE8/AMABqepwJk3QkquSIllxCRF1n9FmgU5wmB vlzLBXtKwFV+9OwIqEMAihBQklAJN63kmyS2iT+uRpHYhVSs5jQDQyIi/LvjVehM Izl0h+L6cbNB1duNVBfSRpag9RQZmil/AkDUKfRQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 42j3nsx921-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Oct 2024 09:23:31 +0000 (GMT) Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 49U9NVo4015023; Wed, 30 Oct 2024 09:23:31 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 42j3nsx91w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Oct 2024 09:23:31 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 49U8tfXw015831; Wed, 30 Oct 2024 09:23:30 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 42hdf1f0ft-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Oct 2024 09:23:30 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 49U9NQvp57540930 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 Oct 2024 09:23:26 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7603420043; Wed, 30 Oct 2024 09:23:26 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 361BC20040; Wed, 30 Oct 2024 09:23:26 +0000 (GMT) Received: from osiris (unknown [9.152.212.60]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTPS; Wed, 30 Oct 2024 09:23:26 +0000 (GMT) Date: Wed, 30 Oct 2024 10:23:24 +0100 From: Heiko Carstens To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, linux-doc@vger.kernel.org, kvm@vger.kernel.org, Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Eric Farman , Andrew Morton , Jonathan Corbet , Mario Casquero Subject: Re: [PATCH v3 3/7] s390/physmem_info: query diag500(STORAGE LIMIT) to support QEMU/KVM memory devices Message-ID: <20241030092324.6264-E-hca@linux.ibm.com> References: <20241025141453.1210600-1-david@redhat.com> <20241025141453.1210600-4-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241025141453.1210600-4-david@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 7PV8sDhpy2m3WwtMDwIzKVS974As3b8o X-Proofpoint-GUID: CoroKk4SrxJOF8YMxe_DpfevRiAUCXDD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 bulkscore=0 mlxlogscore=753 clxscore=1015 priorityscore=1501 suspectscore=0 lowpriorityscore=0 mlxscore=0 impostorscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410300072 X-Stat-Signature: ma3cqfzc8nnpcti7fjfx1mrtizq9hba3 X-Rspamd-Queue-Id: E9375C000E X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1730280181-742063 X-HE-Meta: U2FsdGVkX18lauh4ixvaVin2kNHDY9SjXcd4/rH95YAxjZaD3IAwEB7SSvbDBZCJ9JQ2KHCjn151qQguX9CPAfiq7EmeQooEFRxw3ztolTXBCjQUbF1nhjenytuF3H7q8Ktp7vQP/ThgnVIjVR811nw+MvedVwoN5fuSW6WSNdk9jHGfVeay+tr8OYRmQjoJP4QJe4EU4VLQ9m5qYeot5URiKl69xMv2wMf6Th0o/aNpawUo+X/InCVkf5UdCvOAcqExFG+jj98JeGjnr/yhhPSP29NW80XW35mBVsA6zGx1kyX7oiKqQb7YjOD2DpSiGQzAL/MuyaV2ShYdJW9Jy9/g39PM3lEMRwLA85itcv1G2CcHCAVSHOrmweodqMv9jrWS4T9ZsUPFE80F4mH2vIuqAr37YaUADQSINDkB4+D1x7iqsYv96CSH/bd2tq6pnBnEVCZV+xKOgtF0F7LL0sJiUVHEMWoid7uVKZYx55LAcTteQLTAZRJaLSAVylQSBiLKGoRbKFNVjAxkNgx6rNsjT3D2yfaySyqaARJ2L7T++hy0ET6bDMx49MqoDaZ1WtNv2yQZvDze2Nq4Rqi6xIZXCodMwgoRjS6B2sowr5UiKcCON/vCPA3MLr/7g8ayPABZYX21zhR6tF7hl4IDpaNK5qgfsiA7RW9H0SOVHSuQKqhdV6Yrz5zq7fKNuovOKFjkihXGMw63B63rLvjQXGlqUiH4jg7dHT+zy6HAX9DveU3Tk9yktmRd/Kl/F6FAJ6tQkArCDBAqpM/2G3kqHd+bvOoTtRAfQDnE8OeMyHBODZrc4PmfS6aF4RuFYFbrvDQtdadAFD+qvHYg177VghJlrpr6V2Opap72yAz8tIBv7Nfa1ssujh8J6PkqHMb3oWi3W2vso7X2Bwv0A/amV1Qt88KGaHhm4oC2L1lkeosnBaAtrIxJ3Wg/lIOylkF1ZStPC0YDoL2i0PHp08t zso8aou+ pffpj+/7SQSdd8cQt6QK76x++weiu/wirwC3VvLUDSDsZJEE4wpPoieS9LneoIBl4q2IyDqqOFnBpQDGi9jolnLbtQtC2QjnOMSGyr/i2cjMGQ5K03wMG/ll1Hzyg4za2av8ejBlQJ0ZgVlfIlQ9fCvkTorOpzcVFwsotmn7MTp7Y7n6tS/uJA6hpnGo4p9kN7vEGd8Vppg/+gOr+syYi4hm0Ma542rN2VYjVafV9v2pCmkfpe272F//t3wM81dpcwzG4P3s/++/lQoaXswQ0SdH/lpwcFdmbb/gZiCD2XjMjrIc4FTu8v/J+8pn/C8AmEkFLzM3APwm+7PC9BaH/z/uWA5NgmkDUWaglATV8MALiBhCQK+BJJ2kPjztpliyniRd0naT/63dXeWV7QarJCGENY3q0wkRlR0EopJTBiPpVKCDN8oLN/D1iZzSYpH6tav2O X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 25, 2024 at 04:14:48PM +0200, David Hildenbrand wrote: > To support memory devices under QEMU/KVM, such as virtio-mem, > we have to prepare our kernel virtual address space accordingly and > have to know the highest possible physical memory address we might see > later: the storage limit. The good old SCLP interface is not suitable for > this use case. > > In particular, memory owned by memory devices has no relationship to > storage increments, it is always detected using the device driver, and > unaware OSes (no driver) must never try making use of that memory. > Consequently this memory is located outside of the "maximum storage > increment"-indicated memory range. > > Let's use our new diag500 STORAGE_LIMIT subcode to query this storage > limit that can exceed the "maximum storage increment", and use the > existing interfaces (i.e., SCLP) to obtain information about the initial > memory that is not owned+managed by memory devices. > > If a hypervisor does not support such memory devices, the address exposed > through diag500 STORAGE_LIMIT will correspond to the maximum storage > increment exposed through SCLP. > > To teach kdump on s390 to include memory owned by memory devices, there > will be ways to query the relevant memory ranges from the device via a > driver running in special kdump mode (like virtio-mem already implements > to filter /proc/vmcore access so we don't end up reading from unplugged > device blocks). > > Update setup_ident_map_size(), to clarify that there can be more than > just online and standby memory. > > Tested-by: Mario Casquero > Signed-off-by: David Hildenbrand > --- > arch/s390/boot/physmem_info.c | 47 +++++++++++++++++++++++++++- > arch/s390/boot/startup.c | 7 +++-- > arch/s390/include/asm/physmem_info.h | 3 ++ > 3 files changed, 54 insertions(+), 3 deletions(-) Looks like I couldn't convince you to implement a query subcode. But anyway, let's move on. Acked-by: Heiko Carstens However, I would like to see an Ack or review from Alexander Gordeev or Vasily Gorbik for this patch.