From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 265E3D3A697 for ; Tue, 29 Oct 2024 20:16:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A0D146B0089; Tue, 29 Oct 2024 16:16:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 995C06B008A; Tue, 29 Oct 2024 16:16:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80F806B0092; Tue, 29 Oct 2024 16:16:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5C5BD6B0089 for ; Tue, 29 Oct 2024 16:16:26 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 19A7B1C353E for ; Tue, 29 Oct 2024 20:16:26 +0000 (UTC) X-FDA: 82727746374.26.2C814F3 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf05.hostedemail.com (Postfix) with ESMTP id E1BDA10002A for ; Tue, 29 Oct 2024 20:15:36 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=f231kfJm; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf05.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730232854; a=rsa-sha256; cv=none; b=F3O+q8KU4D65d3qB7/dNHDsF8FEgkZ8IapHor8VgEwiI7k7ENB0hlXgJA0hJcwSPlvl0JM 0qNlb6vsSHuQacTcn2Y/dNlBzz9W8y7vr19mYm6Jvryw7wm4F6IebbvEPOUAIqrxNA51xL jRqvVoniQs+K86KoI4vktTYLP/HSiS0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=f231kfJm; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf05.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730232854; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C8woab/HVpTEdWSqbGbWHPK4TMUsahu9vIQAcQ2mkdo=; b=CCSv3xmwltnDNvPnn2qjGhblsi3ZSQUvpqJAJc/mU0kKyaxOvtfNpJy05179Numo/CNX1L dbO25izJamwLNIfL9hYhz8MVLsj8qYayfY304oTxqw9/dL5iyXjM1bL18Tl++1VjG6ElMy W0YHkk396zNGggPkaviPxv66H1rDDJ8= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 1EACB40E0191; Tue, 29 Oct 2024 20:16:20 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id zmX8fzjVO5aN; Tue, 29 Oct 2024 20:16:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1730232975; bh=C8woab/HVpTEdWSqbGbWHPK4TMUsahu9vIQAcQ2mkdo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f231kfJmRUCtl4M1EDV4aVpEFrpi3fTbRG64EBB2rl90j3llW/hr7CAEEQwFXuAnA nnVVhAJaQAA+NSiELcyoSUvRqbgYm+pU30Bn2MM4UDSVXJJojgWIuvs5654vAh3kin qFCvq4Exs2nABJZ1+cFoFnbda+PqsTjWD7XVQ0toH2kaw9Fku9B/DxfslROIF5ryLd jRTom6SwQgqLHELeKrpdjLGwYX4S0drdddoKpug2PvciAnsv1sZt32PEaW4eTrXfFf clIfxIrf8h+XhE5OMendMIVelFpWRdJisbb9JlIzTPai2w4XaAmAYpud4HysbqlyuN ahd/xqiCj7tfdG5p13ydXbB60XONM/EETz0/ErTTBKweHoC9pCRl61xpGU0+kzxqur T4bcZk5zMivRCG+Nn73IG1+F1qVwpBDXrs7okbbotcX6UUd4xlktl6VhMyZ97eTX32 QnTzATB+Fm43ThOavpQCBII9tJ/M1A2c2od/Y+VeIcZIzkccyJiklPCgQ7mk2meGFH ne1BPzkwR26r28i/ioYitcRMlWtxToSAvCCi+rXmaxK9aUvM/2dysp+dXMH5CrRsF8 YCj6y0JJB42uh1HbLDyvDdHJqydLPJ0twuRm5E1egJCzVNIsEppWJscUdOw/nqavWA 88BOcUSzKiMVWtRt/aaBiqsk= Received: from zn.tnic (p5de8e8eb.dip0.t-ipconnect.de [93.232.232.235]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 7244040E0028; Tue, 29 Oct 2024 20:15:28 +0000 (UTC) Date: Tue, 29 Oct 2024 21:15:27 +0100 From: Borislav Petkov To: shiju.jose@huawei.com Cc: linux-edac@vger.kernel.org, linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, tony.luck@intel.com, rafael@kernel.org, lenb@kernel.org, mchehab@kernel.org, dan.j.williams@intel.com, dave@stgolabs.net, jonathan.cameron@huawei.com, gregkh@linuxfoundation.org, sudeep.holla@arm.com, jassisinghbrar@gmail.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, david@redhat.com, Vilas.Sridharan@amd.com, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, wbs@os.amperecomputing.com, nifan.cxl@gmail.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, roberto.sassu@huawei.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH v14 07/14] cxl/memfeature: Add CXL memory device patrol scrub control feature Message-ID: <20241029201527.GTZyFCX_foMR_GouGN@fat_crate.local> References: <20241025171356.1377-1-shiju.jose@huawei.com> <20241025171356.1377-8-shiju.jose@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20241025171356.1377-8-shiju.jose@huawei.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E1BDA10002A X-Stat-Signature: arsragayiih7bd6g6y666uw7ezrrex7y X-Rspam-User: X-HE-Tag: 1730232936-390185 X-HE-Meta: U2FsdGVkX1/sHgWXd3buCDWi+IP4fYURPP0D1Ex7RFnHi2Q6iXSEXjC3/SiSwzJogqYiknRnIIS9cr+rDw4IEfIhheMF/32Leho3jgRN8K7Zng43LxvoirTWaVJrYEHO8aRZ5MtChE7Vu7pfL5DZQTSSrDAkcizx/35R2M/ZXi3NwzL+/2V/Mnq7RLvzcMHYoZL3TPphyS6Axz6QhIXMTq8ciP89u3uZmNRTR81HFizb60zFvORnkZWZE5GJvmzHb6ETnl1HpN/QyLkxqjvcmaHh4vcTGTSZMMuWRG1pw/qFLCR4lm2bQk654XXYRAEyGQa48FFPYJT4r4Lju69rw+PgNPsabRoAowlv4cGFptf8xYGqlRrnKjgOyXappSSBxD4Yh2NXDASmPoEY19yvmwo80YqFFLI2J5kg165IcAAQa31XTEWA+uCR7YypjM0jNt43nLnjRzx8AsFC97pGx/uLG13l2yVc5HyxTVjSvCtK3ieCxO3UhNY9EGM6AKyVZFz5t4j/Pa5UDNOm60Nt0TrWIrD9zvgOwTIdEBcxa1KTjy5i+tayc5BUuZ6v+iIoXzal9e+O7KLh2a6iT8yvBp0iLIQW8mnQv0sR+KmMhqbQFx98duuo+cOEWFGlIDMmE3ZM4js4UOfmSKZUAjmA0x1y7Pd8MopLsOmDuZu9dh+ITaR0ZND/qI0AGRNeazP2Di80pPZdtw9ViwjA5buaKeR+I9P3tKUc97bihAU5/doPHJCTzT13QShG8CAyZ5q7BVrwZL9CxsyzeNDgRnrKLWIoPgA5kDs4fS4xljpH7dVAHAliceGQNjpxgL7uUEdlHwfYDiAhRDBUTENkD3gMd9/7AuDEuIip/IRmSzHNpYpE8bpKaq2NJ2rSMpbyUsOBW1GPlYUYVd1X8U83aGIQ17TLUJD5c/tZWINWKOWr49TTNrvk+spg7ZlHpFCj4rfFWZ2vAXlDTRL+/cAefYG cv5FMh9e Mya+lfa05CsvkPEWG9gXLwiIA/xed90WIdpsKWBScKWlifz2HWBE6kKtOZ3ynOos0OxHp/i46qyKw6tNg6iovLDrExRyX8yiHGPSykOSpecWqVlF6ut79UWbNUTnbB8I2HJ6OKjaZeFyMbmrDs6dIYKz16mchxJcrekFEdlIuoMuXB/6WownI2S0E/mNarUilHefOM1+wkEIZE+2p2ZBUAFi+BA164dT7JDp8TGVKTY7cPcKIGLpx5fYovyQ0lWyTPvLnJZE4dSpZ1XgQih9cT9zc+PZGHpB7gW2e7QRZI5FnxpgTAHK8skrJjrtSw6EuPSOy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000051, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 25, 2024 at 06:13:48PM +0100, shiju.jose@huawei.com wrote: > diff --git a/Documentation/edac/edac-scrub.rst b/Documentation/edac/edac-scrub.rst > new file mode 100644 > index 000000000000..4aad4974b208 > --- /dev/null > +++ b/Documentation/edac/edac-scrub.rst > @@ -0,0 +1,74 @@ > +.. SPDX-License-Identifier: GPL-2.0 > + > +=================== > +EDAC Scrub control > +=================== > + > +Copyright (c) 2024 HiSilicon Limited. > + > +:Author: Shiju Jose > +:License: The GNU Free Documentation License, Version 1.2 > + (dual licensed under the GPL v2) > +:Original Reviewers: > + > +- Written for: 6.13 > +- Updated for: > + > +Introduction > +------------ > +The EDAC enhancement for RAS featurues exposes interfaces for controlling > +the memory scrubbers in the system. The scrub device drivers in the > +system register with the EDAC scrub. The driver exposes the > +scrub controls to user in the sysfs. > + > +The File System > +--------------- > + > +The control attributes of the registered scrubber instance could be > +accessed in the /sys/bus/edac/devices//scrub*/ > + > +sysfs > +----- > + > +Sysfs files are documented in > +`Documentation/ABI/testing/sysfs-edac-scrub-control`. > + > +Example > +------- > + > +The usage takes the form shown in this example:: > + > +1. CXL memory device patrol scrubber > +1.1 device based > +root@localhost:~# cat /sys/bus/edac/devices/cxl_mem0/scrub0/min_cycle_duration > +3600 > +root@localhost:~# cat /sys/bus/edac/devices/cxl_mem0/scrub0/max_cycle_duration > +918000 > +root@localhost:~# cat /sys/bus/edac/devices/cxl_mem0/scrub0/current_cycle_duration > +43200 > +root@localhost:~# echo 54000 > /sys/bus/edac/devices/cxl_mem0/scrub0/current_cycle_duration > +root@localhost:~# cat /sys/bus/edac/devices/cxl_mem0/scrub0/current_cycle_duration > +54000 > +root@localhost:~# echo 1 > /sys/bus/edac/devices/cxl_mem0/scrub0/enable_background > +root@localhost:~# cat /sys/bus/edac/devices/cxl_mem0/scrub0/enable_background > +1 > +root@localhost:~# echo 0 > /sys/bus/edac/devices/cxl_mem0/scrub0/enable_background > +root@localhost:~# cat /sys/bus/edac/devices/cxl_mem0/scrub0/enable_background > +0 > + > +1.2. region based > +root@localhost:~# cat /sys/bus/edac/devices/cxl_region0/scrub0/min_cycle_duration > +3600 > +root@localhost:~# cat /sys/bus/edac/devices/cxl_region0/scrub0/max_cycle_duration > +918000 > +root@localhost:~# cat /sys/bus/edac/devices/cxl_region0/scrub0/current_cycle_duration > +43200 > +root@localhost:~# echo 54000 > /sys/bus/edac/devices/cxl_region0/scrub0/current_cycle_duration > +root@localhost:~# cat /sys/bus/edac/devices/cxl_region0/scrub0/current_cycle_duration > +54000 > +root@localhost:~# echo 1 > /sys/bus/edac/devices/cxl_region0/scrub0/enable_background > +root@localhost:~# cat /sys/bus/edac/devices/cxl_region0/scrub0/enable_background > +1 > +root@localhost:~# echo 0 > /sys/bus/edac/devices/cxl_region0/scrub0/enable_background > +root@localhost:~# cat /sys/bus/edac/devices/cxl_region0/scrub0/enable_background > +0 This file's addition belongs to some EDAC patch in the series, not here. It could be a separate, last patch in the series too, once everything is settled. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette