From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53281D5B851 for ; Tue, 29 Oct 2024 00:24:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D184C6B00BB; Mon, 28 Oct 2024 20:24:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C9F2A6B00BC; Mon, 28 Oct 2024 20:24:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B18566B00BD; Mon, 28 Oct 2024 20:24:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8F6466B00BB for ; Mon, 28 Oct 2024 20:24:08 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4F78D1A0AB0 for ; Tue, 29 Oct 2024 00:24:08 +0000 (UTC) X-FDA: 82724742072.16.09C7C63 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by imf15.hostedemail.com (Postfix) with ESMTP id 1018DA002D for ; Tue, 29 Oct 2024 00:23:41 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=XhqzgsmJ; spf=pass (imf15.hostedemail.com: domain of mcanal@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=mcanal@igalia.com; dmarc=pass (policy=none) header.from=igalia.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730161289; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x/+J4VNwyIjYndlAztlVz2EFWQN/WXmhUknqKDEMai0=; b=JfeZ31DZJSsroD4qIcXvMO3NYKMet9MkfcDFtx4xRnvNmwMSNfgWuw5ySC8RVYtNio0mNK oCoRVH7i8BjygJw1qNwr6fLmDNvMDn3bgS206YFxWBErqTn9G+Bqg0DsbYTgEstfgU4oyp KX3uttNrepmD0VKGddARArOkVr4h5m4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730161289; a=rsa-sha256; cv=none; b=He5J9n5bee6lm6DzDzmSTstAH69ZiacPY8cU4GF/0L9d93G1UQ3Y/XBpviEwRxz8nnxXJH C6uA47jGKH0JPjHoECNh+cTzzm79p7Rr/B4lTj8LWOkEfHfGF98cF5M91rrfQ/Kd0kD3rT +kimgVl+IA9J/Yu7IJc2TidgYTchd+U= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=XhqzgsmJ; spf=pass (imf15.hostedemail.com: domain of mcanal@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=mcanal@igalia.com; dmarc=pass (policy=none) header.from=igalia.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=x/+J4VNwyIjYndlAztlVz2EFWQN/WXmhUknqKDEMai0=; b=XhqzgsmJFPEicL7uXc8og75hT6 GoLHVGkfeLhnFeZnqsIp/LmFd5p+DMTqpcTnTZfsMNWPvpMO8cOMAdP9dEL+4qLDcz1l22Axah76m 5i8pvPIen5duuIFzXBoxOYd7BriPN3mw1yLxwqosyH5YEDOg2v6xdKMhLPbcYuoXQTjLTcQWzujZB XazKzT53tLeY4W0J9nnM8LxKURXn5gPxzexKe8HoK0Hdjjkmggv3IrEB7I5A1EbZhEYVL48Tqn11g qvO5YgR8dEtRmTQQpliXY0rpILzWz9KAMN1MJpWzmlWTTPVsq3Aoy6WRl1ZLPYDQa5A48redJ6zTc HrqroFaw==; Received: from [187.36.213.55] (helo=morissey..) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1t5a1U-00GIrd-TT; Tue, 29 Oct 2024 01:23:49 +0100 From: =?UTF-8?q?Ma=C3=ADra=20Canal?= To: Jonathan Corbet , Andrew Morton , Hugh Dickins , Barry Song , David Hildenbrand , Ryan Roberts , Baolin Wang , Lance Yang Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-dev@igalia.com, =?UTF-8?q?Ma=C3=ADra=20Canal?= Subject: [PATCH v2 1/4] mm: fix docs for the kernel parameter ``thp_anon=`` Date: Mon, 28 Oct 2024 21:13:05 -0300 Message-ID: <20241029002324.1062723-2-mcanal@igalia.com> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20241029002324.1062723-1-mcanal@igalia.com> References: <20241029002324.1062723-1-mcanal@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 1018DA002D X-Stat-Signature: 37mb3jbyb11cid5t44kwigiotrbt5yr9 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1730161421-266040 X-HE-Meta: U2FsdGVkX1/zL47+PqHZEAtnyG1nHC3TEfcNHZFBqgBLTf3F91iGuJam5a7oPXPMP9EZ9aYNfoIRlfa89pj0u6cuijjX+tgSrDHRzGEqHVJT61bNoeBPcOwj712cwwSiz/gKjDwZGwPLQXhlGl8hsPPAaaPjd8dKu9zUB1lVTJBq4fQpgVSN6z/iFwdf2bU4H4AxqASwkwX96bOE/yn9UIWXyk7xXgfXiLa/bsaxJSejxzeUBKfp/pXaGEgnepOMWbblgGNzC0dZcGVdxKak3PwlWaBJM63QM1p41YMXk0sPMauXIHHAU0eDypgavcy5p5nvKKEFEqXS1R2QJ9ar6RIxow9UZKTFhXcshT70W8AF4Vi4qpMyvSa8Vhsgo9vt1KpU6EMGvM1jj34+DctBW2WIvBIRw0Lcc2N/I7WyU8shcGRewtVLHyiAEC9v8HzK+5E4n9w9EdsfhWhsAMyuEJnXP4pBaL03RKZayPDGxbAzLwoCXgKWusm5jW1wPgMnsgVyBkRIngjN+f9A2NzRjs1mCIUi0TbNC2W3sI6RhhXSA0JwzgIaJPZsb/PATZ0ghVepo/fZiBPDy40FoQOd/VJychLGIerEa569tjDbyrSEDLbA6QA63J/GoXdhtplbLPLbTkbbK7g6WCwVyTXKQ0NeTA01oqHRrW6N8d6/bi57/hhfOrplsrjrmDx0JKo6TVONW9ZX9/qIW0KvoVFFKZ8aXX4Cn1nC4Ef0HsvZQOGQMgNTPZNtw0OMriIfZ61l4BwUsm33qiqfTaHrmyAnKIBn1ZbM00fCoXT0IPVaHDBBu+gfpc97eW2vBYzCoCrsOdB9rH3U6bZyohhE/+wLZJ8CEeVzdUmunp8p9Nn6zfNli5qbIJYN1UoI9GYrQ3sFHBFBCK9gvsNaTniXqFf+SMgRhXIsop4AoyNoOhXTDunPwwMVeABps6RBM041zG6/nMp6na72+WfmNC8H9PP pKMV2Rid q1xfcmAFpAQoBgjcu1Dom2CKjP6t0y2TMAy1M0nIDnRN0nX6MkNgPndWEuzJh6UOQFESk9Ek6Sqx12fg2VLhFGznGYXOZ6v+j/eboBEbnqLGL10qkCDbcD4NKKNeI+jpMBT1raJFG73F39aUSEDofJP0SP0TiWPq73ByOuRrMJOYS+Gw+AUu46XBga48e2pa9dgaGowdwMk9s1azFOVIExXquK1/LAlE/FyP53/Wn8aA8ICDlWKi3Bko7gZOAGFkUr/C38vICYx/+cQUILLkT5OPV+KO75uFJgDAXGJP3Y07dcvR6WlV/wgxfGzN/2ayUT4otJtABecaEAYC/Ckhgkkqg+rB1r79iK3gueyUkYbDu4vVaa/DPYzaU2dN9JC4RYKbn/I19IQWSw722+L1ccoUuPqN6k1Od5rhbpPJtMZhFMvU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: If we add ``thp_anon=32,64K:always`` to the kernel command line, we will see the following error: [ 0.000000] huge_memory: thp_anon=32,64K:always: error parsing string, ignoring setting This happens because the correct format isn't ``thp_anon=,[KMG]:```, as [KMG] must follow each number to especify its unit. So, the correct format is ``thp_anon=[KMG],[KMG]:```. Therefore, adjust the documentation to reflect the correct format of the parameter ``thp_anon=``. Fixes: dd4d30d1cdbe ("mm: override mTHP "enabled" defaults at kernel cmdline") Signed-off-by: Maíra Canal Acked-by: Barry Song Acked-by: David Hildenbrand --- Documentation/admin-guide/kernel-parameters.txt | 2 +- Documentation/admin-guide/mm/transhuge.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index 1518343bbe22..1666576acc0e 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -6688,7 +6688,7 @@ 0: no polling (default) thp_anon= [KNL] - Format: ,[KMG]:;-[KMG]: + Format: [KMG],[KMG]:;[KMG]-[KMG]: state is one of "always", "madvise", "never" or "inherit". Control the default behavior of the system with respect to anonymous transparent hugepages. diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/admin-guide/mm/transhuge.rst index 203ba7aaf5fc..745055c3dc09 100644 --- a/Documentation/admin-guide/mm/transhuge.rst +++ b/Documentation/admin-guide/mm/transhuge.rst @@ -303,7 +303,7 @@ control by passing the parameter ``transparent_hugepage=always`` or kernel command line. Alternatively, each supported anonymous THP size can be controlled by -passing ``thp_anon=,[KMG]:;-[KMG]:``, +passing ``thp_anon=[KMG],[KMG]:;[KMG]-[KMG]:``, where ```` is the THP size (must be a power of 2 of PAGE_SIZE and supported anonymous THP) and ```` is one of ``always``, ``madvise``, ``never`` or ``inherit``. -- 2.46.2