From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBCD9D13592 for ; Mon, 28 Oct 2024 18:28:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 50EBF6B009F; Mon, 28 Oct 2024 14:28:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 496DA6B00A0; Mon, 28 Oct 2024 14:28:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 311246B00A1; Mon, 28 Oct 2024 14:28:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0F3456B009F for ; Mon, 28 Oct 2024 14:28:25 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 85D3B80D02 for ; Mon, 28 Oct 2024 18:28:24 +0000 (UTC) X-FDA: 82723845456.12.F4EE1FD Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf10.hostedemail.com (Postfix) with ESMTP id 68FE8C0013 for ; Mon, 28 Oct 2024 18:28:12 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EtaFK3pd; spf=pass (imf10.hostedemail.com: domain of leon@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730139944; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KFrL9FuvdKBO9EhiqXb//Q4SV/TeRWnP4sdnQwEIZq0=; b=1R8LQVzBugdoh8URiGGP7HmpSEn+3gwUXJb+MyoTuHCbFEpd+J3Wnbk6zd/L4knWmfuprL HhaZNOEsdua6PrsGsQYnKFQoPprNTPEwqGzuBQMpxGJYmbpul8ppZgF2pHZ+36kGpn9odZ PBQH606AAoxM/tF8dtHj0pXVQcwnAHg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730139944; a=rsa-sha256; cv=none; b=YyJ7nfK6Ruuau210v8GCNIHEylMuj3qmMU/xsyn2htiuk2DpaQwKj5ERfCq1ziLVitn9nz D5x/oDXrFsF6VUM8vhQ1OQaIiAZKXo5ULLYr1WlsIwqYlIiOYH94GU2JYriSpDdvGazmgs ooYr9IffbrD+vGQjv4b7Fawpl0iXxJs= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EtaFK3pd; spf=pass (imf10.hostedemail.com: domain of leon@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 40F4EA42AF7; Mon, 28 Oct 2024 18:26:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D46CDC4CEE4; Mon, 28 Oct 2024 18:28:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730140101; bh=9iGMLbwbu5+Y6xL5FtHUey8KkpvIorHUri9eopVp1bE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EtaFK3pduFuYsNn4Y7vW1E2l8VducP0vst+UuBVEbClW4TWipnGHfz233fzJPLCp+ A8MRUIYC0+zA/CM3TbtJ1baS+UV1GvKGP0/Xu+HTYmzt6DJJI4akRbyQlZuKLR1PxK spZ+zcbKZqLolf9P5ku2y3lq4gNNZA+Af5r7z2cpagVx7I8KvRjidzMAXhV0m6tffA S7Z0oPNwV6kv0xsSjIkq0tLfhpRA7b0nVQDSdTWRXEimMGWEhNnHTy/txVooweHpWM wtikULfejvKP5embybCWsN/6Rll2WIBurWpHWzaokEHX3ZC+tVhEJuljI7i+MtbL1d A/quvdDcUEdvA== Date: Mon, 28 Oct 2024 20:28:15 +0200 From: Leon Romanovsky To: Logan Gunthorpe Cc: Jens Axboe , Jason Gunthorpe , Robin Murphy , Joerg Roedel , Will Deacon , Christoph Hellwig , Sagi Grimberg , Keith Busch , Bjorn Helgaas , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 09/18] docs: core-api: document the IOVA-based API Message-ID: <20241028182815.GH1615717@unreal> References: <30e87c78-1021-4fa4-8aa6-e81245e77379@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <30e87c78-1021-4fa4-8aa6-e81245e77379@deltatee.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 68FE8C0013 X-Stat-Signature: 6pquae5fo4z6nxuyd9cqm1ogw3rcc6tt X-HE-Tag: 1730140092-412414 X-HE-Meta: U2FsdGVkX1+O2QldqGvxY6nzkf34kqXdPc/gG1Wa/zjRAfWM4DLGOdsU9eqL6sR8fB4Oap9B1TOxVsjoX28GIimDc2zb51/r8kxZPb6AS33x90yjZ023gPUQpgKFdHngpGh8UkzG1Cmo8mbGMCt20kjKNNTQqQJaKaKE/GUniI3u4G/c1MmOZTc7We0bVNemLsiSzh6P4ogMOo3HcIN2EKuoOWBu0A5J/z+x6R89TCKXiQ1/7ikFQRq8BPFHDRvv2vzzF3D/1YXnDlx3lzWoB9iX7+468HTUNOYfjyHb5YqrEX/RUuKzkrEvLAbF21Yj7/jPwQr5yhMwIIV6eHZ/RgW5P+y0MxDFa+KE07P4OMhYLWGYRZbC1se9ypOkx8JiAz+rPDF5iQFlA3bbpUeEV0LDK4AqWyzVF8HmkTIvuTao4Mz+JDunImTGohIXJa+PPTodRr18GyDLyOR+DrOeVDRAr1aJoKynluP1jLj++MJrdch3DwHaLsofPqvsJBp+wqLqFyw2ZwKmhnIHLIVv7ZFc227gd7sfTemFOmVE4S75audCIAYnFi4yNRjaGvga8N+FSr2pxidAoL/klzhkvf1o/bxeEGkRgvbAHf11VOnEI70oyIYW/gZVy4SaofDhgbyRHsjHC/tF0i7q6fdgZ5vWAyyOLRAgE+0ImoY5owBWUQSoLlwyPcPOKxyKq0m9txDfACYPh65YWDCtEMP1FlnKaStOpSWMMQa0MlovbtnfAiUtDx2Q/l4LAUztONYbYWTH2zGEvIUksrfJ3I2q2kZtP+zA0svGtfUoh/NO6Mky4Mpd9eaFCBhsu5GN1Ru4p7RsZRBLuDiagaulBSB3cVQNtnU4DQZ5ypr0pA49YM+adNyyG0EwJzeHlLGRFwHhaSP2lqEh8k8DIueXy1UDY5QRfUeM4Fck9Dv4sjIXCawYSPWcI9g2ffYCyHXvZC8cOtAgQtLrrBUp/wjaK7A b6a531yk nJ5795a4uUH1FEZBk8GuYCRVRJ0jlnxrAj88Vrxac9M0p86h7RRGzDa0YrVrJisJfjSue41UQH/lloAA+JA1LifCSPRac7CTSVYHO76w+VsZDrwqnVdRI6yEcqFPf0lmQv0CGoPQpJIHh/NYgUR6a3/Uo9Zd48ZZqjKYv0HmVJZS8FvI6le0TTnLwaz0nejGjuxSun9HeS24uDeMymM9hJvFLwkZkJCOPVMqnoXU3Qz254igSx7iY9alnUTVQ5GQa7Mho X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 28, 2024 at 12:12:34PM -0600, Logan Gunthorpe wrote: > > I noticed a couple of typos below: > > On 2024-10-27 08:21, Leon Romanovsky wrote: > > > +Part Ie - IOVA-based DMA mappings > > +--------------------------------- > > + > > +These APIs allow a very efficient mapping when using an IOMMU. They are an > > +optional path that requires extra code and are only recommended for drivers > > +where DMA mapping performance, or the space usage for storing the dma addresses > > The second 'dma' should be capitalized as it is in other uses. > > > > + int dma_iova_sync(struct device *dev, struct dma_iova_state *state, > > + size_t offset, size_t size, int ret); > > + > > +Must called to sync the IOMMU page tables for IOVA-range mapped by one or > > +more calls to ``dma_iova_link()``. > > "Must be called" instead of "Must called" Thanks, will fix. > > Thanks, > > Logan