From: Arnd Bergmann <arnd@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>,
Suren Baghdasaryan <surenb@google.com>,
Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
"Mike Rapoport (Microsoft)" <rppt@kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>, Song Liu <song@kernel.org>,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH] alloc_tag: hide execmem_vmap() on !MMU
Date: Mon, 28 Oct 2024 14:18:09 +0000 [thread overview]
Message-ID: <20241028141818.622917-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
The newly added function fails to link on nommu kernels, but is also
not needed there:
ld.lld-20: error: undefined symbol: __get_vm_area_node
>>> referenced by execmem.c
>>> mm/execmem.o:(execmem_vmap) in archive vmlinux.a
>>> referenced by execmem.c
>>> mm/execmem.o:(execmem_vmap) in archive vmlinux.a
Fixes: 57bc3834fb6f ("alloc_tag: populate memory for module tags as needed")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
mm/execmem.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/mm/execmem.c b/mm/execmem.c
index 5c0f9f2d6f83..b04cfece7356 100644
--- a/mm/execmem.c
+++ b/mm/execmem.c
@@ -368,6 +368,7 @@ void execmem_free(void *ptr)
vfree(ptr);
}
+#ifdef CONFIG_MMU
struct vm_struct *execmem_vmap(size_t size)
{
struct execmem_range *range = &execmem_info->ranges[EXECMEM_MODULE_DATA];
@@ -383,6 +384,7 @@ struct vm_struct *execmem_vmap(size_t size)
return area;
}
+#endif
void *execmem_update_copy(void *dst, const void *src, size_t size)
{
--
2.39.5
next reply other threads:[~2024-10-28 14:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 14:18 Arnd Bergmann [this message]
2024-10-28 14:39 ` Mike Rapoport
2024-10-28 18:51 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028141818.622917-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=mhiramat@kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=rppt@kernel.org \
--cc=song@kernel.org \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox