From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A393D33984 for ; Mon, 28 Oct 2024 14:00:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC8166B008A; Mon, 28 Oct 2024 10:00:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E77836B0092; Mon, 28 Oct 2024 10:00:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3EC66B0093; Mon, 28 Oct 2024 10:00:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B1CFE6B008A for ; Mon, 28 Oct 2024 10:00:53 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5A5D6ACB1C for ; Mon, 28 Oct 2024 14:00:53 +0000 (UTC) X-FDA: 82723170726.09.EA681FE Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com [209.85.161.44]) by imf28.hostedemail.com (Postfix) with ESMTP id AAB98C0032 for ; Mon, 28 Oct 2024 14:00:27 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=xk1nS8cp; spf=pass (imf28.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.161.44 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730123971; a=rsa-sha256; cv=none; b=NmaQzwmr8t8CZFbqM6rtjaJtBVGuDouXAqsZK2YFsoTErEwT/jQecKaXGf3zvNdqpktA7N kmXom2BjZ5xVuvgS/pPPScHYQjBjHjiV3hNxjTloCFzS7GWMyIYVkOC/R0831FR8XUK/5O j7q08F9T5t6RHVlNE/7565Uy998qS1I= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=xk1nS8cp; spf=pass (imf28.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.161.44 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730123971; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5CyyWAppIMSemT0CuK62Hzyft+OY6WztWx8opHDh7Gk=; b=TE7wqrWsthebVKdzGpPHVgV0fJetY5SQCCL2hOSe+Ozfb6NsDOEAqxVx9Hg99oP2tYH5Ds L1xHtTQmb6ph6j2F/8sZ9TSI8xGOyzYPhMGhUewCBMWR9B+QAcLAAyBkWutZ9aYujS/zFE LTaDPMVCpXMMXvZU+H8wdGVjI74Ar0Y= Received: by mail-oo1-f44.google.com with SMTP id 006d021491bc7-5ebc27fdc30so2272666eaf.2 for ; Mon, 28 Oct 2024 07:00:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1730124050; x=1730728850; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5CyyWAppIMSemT0CuK62Hzyft+OY6WztWx8opHDh7Gk=; b=xk1nS8cpRhO8fNFt8aB0DQiU2Sfp+4BNV3RNwarRtF87lK+XOarsOuSfG3FTJaDy8o v564SfQ1LKh0JexB9FzfYVMpKnpzfSjw0o2LqpAoRwyKU9tI4+M1Ptzc8ndppvk82ouW 9sNtseheRhGQW695C1JV93vEFDj4Qs20hKUglsFKkBOZVoE7qmzcxT2a5T6KFyqs9N8J fwSiQDAhx8xUWtSlP57UXMh27FIT7A7yWNEF0nLI/uCA2KqVJWnH5BItX3MX6sqXC4OR Xw46c+GdcWwQlDa7pDzo41S8RaPqX9cv39+5Qc9biz/yNeK/vOrF9Ug9RsMSaz/eopJq D9/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730124050; x=1730728850; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5CyyWAppIMSemT0CuK62Hzyft+OY6WztWx8opHDh7Gk=; b=UgGswuIUHSKUGwDSG7ySOsHyETvuRgZhbjeO+FtaOxIp25pPoQJtDqKIFL1keecTUQ ZKgjrMJ8PkduvcVfYmjSEYyMCW/X5nBJkepv9G32s2IoJzFa2HaQiBl/BDfCUz4NNfgF /G0BUKhdm53UQ8vpiMgaZCLLCl5+aFEOyl23koDxytDuH6VIhvGGsHsKCkcXCTBeFNv7 mNXJiaBMY/uiBf0WbAtmHGrqHJ3RXzlYW3/odB+iGm740ubK2OcAo33jDlAAQLTVEa/N 7w2LPdxsHEFxcVaaYcMsfAv4ND/6URFoNKRhW/quobNBUlyAWct4g2YTEde7rQ0+LcGh lNaQ== X-Forwarded-Encrypted: i=1; AJvYcCUlo7r1yHxRlpOaF6OeHcjLvdphPH8OemQIQamD/w29dSSH4CWATiAzQ2xLTxGfLwIPKQLp/84wgg==@kvack.org X-Gm-Message-State: AOJu0YxBg7FdgZPk+n5lV3O9vTTJ6RBFIsOrVcja7I6B6Yt7ccL8SQp/ rqZRh0bTJ5IahFYpmjQCEe3RWScIHKkb3k4jEQzIaHYxmJ6OuSW/pXquy8BQRWE= X-Google-Smtp-Source: AGHT+IGBtH1NdyVtTtxosvWgimQBcEYOE5uA1gln4dVd1rWRKzOv+q6qmhcV6IpETFtUChiH4J473A== X-Received: by 2002:a05:6358:e4a9:b0:1b8:6074:b53 with SMTP id e5c5f4694b2df-1c3f9e18e55mr223282755d.10.1730124050180; Mon, 28 Oct 2024 07:00:50 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b18d295ebasm318533385a.50.2024.10.28.07.00.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Oct 2024 07:00:48 -0700 (PDT) Date: Mon, 28 Oct 2024 10:00:47 -0400 From: Johannes Weiner To: Shakeel Butt Cc: Andrew Morton , Michal Hocko , Roman Gushchin , Muchun Song , Hugh Dickins , Yosry Ahmed , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, Meta kernel team Subject: Re: [PATCH v1 4/6] memcg-v1: no need for memcg locking for writeback tracking Message-ID: <20241028140047.GD10985@cmpxchg.org> References: <20241025012304.2473312-1-shakeel.butt@linux.dev> <20241025012304.2473312-5-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241025012304.2473312-5-shakeel.butt@linux.dev> X-Stat-Signature: zgrde6gbjkxm4pngu77cbr9q98ebg6xd X-Rspamd-Queue-Id: AAB98C0032 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1730124027-132718 X-HE-Meta: U2FsdGVkX18UJSXfZs3OZwV0tLA6shaWo2lZBmhKDtoaUeHmyfyDYDnGFkd1qDMJh+fkP7+CP7XiyeHuDTeSK7kDQUOSsrVkwy7iJUAhYzRqdd1BeDc/4nNtwoUus/wSnWAsS5o5p1NV6RwS4ttoULdVZ/GIBpe08aGvmAaBAUQ8BfwWGQCZJneAO+AwX1HAvaLq6HTlpRF2cskktQ8COmaDMxgQMcNcJmaxOdnL6KBkqHpbYWeMLZECCSwrhBGDUysOhMgTQqO05pgC6Ma5rJLghHbsaG8P+mjT0HbouhtPMkQztXckvulBYfAG4nLgq2guZ909wI0+sK1X7tdFrt53KR0ETyUNKkeR/3Ia9zLb3MO1jCRc8PaRL9sehN7u8Y/4klA719+us942cWyMcjFnpQbs9Jr2RtdyhrrECLIEKPr4nJw6ZnX2X0uXCMmknwh4+pjVMMJX0L39/nztmuCOJyQz76FkC7ZoT9+x7VJFSrV6L2xMiDs2hfVhS0IoRiBovS7efExDlonhs3hx7a4GRbsWzmJOqWHlWrESyBf5xY2ACSG7nFdE61ceCsrz9W1+FQOFjwSVPdV7cu6NBXzXZRD4o22idooxhX6uwXffM0mZ7sblkVOjeR8RsNtyID3x2TUtg6uzLu4Jf4Hsxwxzm/1lvaQTe9VLmPtAmjL5w2JkV6xaG2N+5NT/rS6PPo4nvowzJgNwP+ftJEz/q/xWUienKq89Q+OckIRXVeeX9X6+7T0nL3TsdZsKhB1c/IR8F179kOpxEp8R7QY86tfIFWVUgZnZE5WlKSp0l45yMrA0ftrPaD45RLVgZInavZTsDWCx/yANWIaxRjwQh8rOgmDdIjSj30PWys2AmrUD6ysne0EtY/m3iYt4GqM64Ni5IE6Wp8pLSOLYnqOqlrH/t5uIbFT1sZz3iW+zi1APAUm9FZ9+m5L3VzEY6P/jodm4SNgchTz86eQfOqX GBk6SZXi GqQgjtAJ+E4zWibyFkdWK2CK65ASlEUeIDnTYqjBX+jufzE3w+1q2FOkhV06kcrUXI81a79CJXGcswC7BwwkLR49lDFz7L9HjhxoYlP/WJ9/9VmqVqR5MCvBXSzhyGjSay1KD+SjeK1nXChTxod0cU5DcPi/IFJbXOS42cCQMeBJLiyyE5gXh/FIASCpZZ603j8cAPGh2p1jly4hvANq8/HojF0T4quGZFtbIl0vpAYR4AU4KM1fYCqJbylOgl0LwOCsu6cOTcOhXxF7kdX0zod8zer+AWDF38ob9wLDKvghxSOyATYk2ltuu7YfZWJneVGuVnsNqKrp4M6cInDBarzcij5dCSeexVKfVFjX9NaH61VLQ/NuLRalhg3XIcUxwamS5svU2HRHN0CMCqEkkOXP0gcH7elD+mEkZ6V0zPg4dsUiRdJBrsic4lClxMR/QljxIQbReYhTVjXt6Vbmm9jDGHvGIRWiBp/GBMOuOheo0TuQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 24, 2024 at 06:23:01PM -0700, Shakeel Butt wrote: > During the era of memcg charge migration, the kernel has to be make sure > that the writeback stat updates do not race with the charge migration. > Otherwise it might update the writeback stats of the wrong memcg. Now > with the memcg charge migration deprecated, there is no more race for > writeback stat updates and the previous locking can be removed. > > Signed-off-by: Shakeel Butt Acked-by: Johannes Weiner