From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF503D33983 for ; Mon, 28 Oct 2024 14:00:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6151D6B0085; Mon, 28 Oct 2024 10:00:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C4CE6B0089; Mon, 28 Oct 2024 10:00:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48CE16B008A; Mon, 28 Oct 2024 10:00:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2D8546B0085 for ; Mon, 28 Oct 2024 10:00:25 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CFBA9A06E4 for ; Mon, 28 Oct 2024 14:00:24 +0000 (UTC) X-FDA: 82723170054.21.63598D0 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) by imf22.hostedemail.com (Postfix) with ESMTP id BA7A6C000F for ; Mon, 28 Oct 2024 13:59:53 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=HZCkilzd; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf22.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.167.172 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730123980; a=rsa-sha256; cv=none; b=Ekhrn5vOiYvpz1TNetLrMoIz1dOsvC1ywB5jztorHUbGzeGPFWPXDGPr/bl83ijduwGoR0 Hk2fD00vV1pFeySlJm8mJLa3P874n6MoRREo8WxqARc38PaTnik2IqSmM3MN52j7jk+7zv fAlSVVLmA64omQia149dSFMzZMmw8h0= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=HZCkilzd; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf22.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.167.172 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730123980; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FihaM4IoEI/TwOyPoeUguS8WS7IqmB9x82K637EGe5Y=; b=Pmpo9izbzO42STXODNvb4Nz+CT7OSo1tT2jGcaRGvNESfrZebJJJCqOqMr4/d1RjldEJsu 4R6WR4H7xYal7Kkk7urjReIMFpn7kccBPFm+0gNqrEHXKK7SApLjqQJH87ezc6o9DgEzWx 03388t3lYbU+la8SfXssXITrOKYTpZ0= Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-3e605ffe10cso2603813b6e.3 for ; Mon, 28 Oct 2024 07:00:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1730124021; x=1730728821; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FihaM4IoEI/TwOyPoeUguS8WS7IqmB9x82K637EGe5Y=; b=HZCkilzd3/azSDh2MImceNCNPOlKU+nFF9Gl5TouhZpzyGZAClLlOwJzYUFGiFoAf6 0REGbutKU1K76/Vg0FaNwI98K0BHgS/hM7rcRFYQ5gOfbDOa+T+8prb7YK2s1uRWs4JL pksTtk13xEDrg+GDeMPPPV9TGpM7RGZXIUwcKSPW4Ylrn+ODivj5LiU7HX/AsXxD7zKP OXyr9FB5PWDosakGviZUQ+FzzayyvQwEghT39wHiAOWljeHKHwlPefAuJKcYj0qAcdbu EhDwJWGTHaXRd8G5hZmwUjo/4UUu4hIj8eDJbrmnXlyfLorFyGKUjCq7kemUI6QrdQBy N1Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730124021; x=1730728821; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FihaM4IoEI/TwOyPoeUguS8WS7IqmB9x82K637EGe5Y=; b=ThIEdZex/HJbC4dpFtDot2qjqQQBW74zQCMkI91JH1XshsaFvXZ01G43HVqtZ4m09i zIlUZULr4q1BroTNn0e15iIyh0WtucMPrBFTRZSTsDX5Jzjw2j83bo1xrdq2v+Th1NA0 fncPc5nK9DHmgQX/l3CUarFiMuukm0GraIU5t0RB26KXbImwvV9FGvpodGFj5K83tM9E 2UWBCFiC2ro5cHMnHtIF1+XTBmx+Gs6Rh6NhVt51AaqUXWv8UEua6L5zObGX4EtpzC/z wDXZ9WE6SmmAUWRjYLVUGavhaeOwIEbxUcvJThGJzxKftwINLlFoRUBvTMme7hJl3IOD tqlA== X-Forwarded-Encrypted: i=1; AJvYcCU2rygu2zkMWp030E3n1EahcCgrQzK6MWslvvaEUxZDmgXJ6sqLZnJJfYA61YMpR3ZLygc3cJngJw==@kvack.org X-Gm-Message-State: AOJu0YyTNXgGGzwiTghbw/TUsPnOZi+qdqCLu2dY3w1Cp/8ObFdgnuO+ WsPVjTXx4C9rA3FEwmp5iH9RtCxVExXls+lqLn1bFrl6fbuwIxrqpS2yE4C55e8= X-Google-Smtp-Source: AGHT+IH9co64vboTin+h8OS63UgFbBeD4w6rdjM3nCxgpXXvLvMDezoy7l2Ep0U63nuT2u+Cay9MJQ== X-Received: by 2002:a05:6808:444c:b0:3e6:4c48:8942 with SMTP id 5614622812f47-3e64c488acamr1321455b6e.35.1730124017959; Mon, 28 Oct 2024 07:00:17 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d17972f5d5sm32494226d6.23.2024.10.28.07.00.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Oct 2024 07:00:17 -0700 (PDT) Date: Mon, 28 Oct 2024 10:00:16 -0400 From: Johannes Weiner To: Shakeel Butt Cc: Andrew Morton , Michal Hocko , Roman Gushchin , Muchun Song , Hugh Dickins , Yosry Ahmed , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, Meta kernel team Subject: Re: [PATCH v1 3/6] memcg-v1: no need for memcg locking for dirty tracking Message-ID: <20241028140016.GC10985@cmpxchg.org> References: <20241025012304.2473312-1-shakeel.butt@linux.dev> <20241025012304.2473312-4-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241025012304.2473312-4-shakeel.butt@linux.dev> X-Rspam-User: X-Stat-Signature: kkmfhwkyphc4dajjmouasdt9kq9k5jj9 X-Rspamd-Queue-Id: BA7A6C000F X-Rspamd-Server: rspam02 X-HE-Tag: 1730123993-121974 X-HE-Meta: U2FsdGVkX1/aaavYs05KXcsvyUqU1uwqfGrDA42C185D+63oDygOZX63vM4xbc8sGunlfdhWRFiZCgvg6s2BaWMTeNi7m+wZOMRA9/cSFMdPlFqYXamuZzPypq++xe5Dg6p75HZm48NN9h2ZwUA/3Zmbny9Dw8hvcwYsCbVSUFft5ODgkAf3pGoMM5zVgU0AOGNFh9RVspdyKq226Uz7JXsyCycMU9CKtLHpWnDSxbBy6iP9wtfaE9U+3ldW8htrf54cC/83ppvIQIoS1qGL5l90k0dOZyzQrnyDm8eYWUhU1P+3dpt+8emwgjWK8mSyW/SGaem8VnDHmDIFmfuxmN4r3uHY0Qe6DUiGNw/VFjwQgV2bpigEKODto1BHetF70GiLhPF4pMOAiZnSlLvAPhVrI1LjOBxnEJ2Zz85c+zDpFlSd7GYBsE+dtnh40LRuEI/MDlrU1quWeTbznyCNNyG8NU7ltmusQMq/FoBU8VsGUXxERO9v8Wd2v8NagMbV9x20ztPwKgV0X3ejK0QlMaw1udlr4EVDgwyCJv/iJIQSvy+gSZ221GW5/a7On/lyvOLEnNkZevoxJsQ0OVFxfZf1hCj04S1511yJds1If1SAEdnhrKK5yXjzYKlsQkXpAY9K+sboXYTIrONQEOuWPco6cKXbd7H1W7zoiGqnSlvEg7J7jNbSXYaiB4/atV7Ll4aLj5ENSU9K+mtYS7UP6WqJZ3bGP3IQrkKabAJe3uqa0nrAzF1H193OnXHy5DOKwDpzFYJfqVFUQOgLGjzt3Sa/w9r4SdWZKrmHltRFP45e6laQgtUQ5WVjbcsk1UCNwpeUvJ0HC3FGnV6yhreUlKUR5cP5U/i+ebtlLYefgO552rJsMU0ylx6lSV3l/+eg8r9CBPtLk9b7N/osslyDYy7EoVDACxB2xWwM+ySqdHSnYSq2bDKO414rY0kZD9gtFLVPw+qKckZxW8loMe1 +IxTnFPu 7vxhskX4vU9vUC3DvN/bbQQp3zZ1HpJ0SQaWkyr2zKjdB5E1q4N+TOI6gvux06YHXLq+QR13l63YiQgAHQsUFPCQTSNkRN5b70KCwcIn2aMHdwQcr/GfvEOWWAS3Cp6ga4LDWuLOdhhQbX2Q2JQ09rKeBTXpvcICjh9JHROVbiD2cZhyQDXFhwWDkoXKH8LXJfDpyPsdRkI7kVtiCfAYnm1xv+CVLWTGhs/2taJzACfd66DrpPAf4MLVEkMwmv+dxAOaLAcuAaYWolESI09g+ru+ASD9EYaA6Vyvjm7IOV4VhK5kAq9OaMrYQt6IhAiTJp3JHlYoXqU+adUNrRij9g8bPN3LqLxlYJsZ+bhNUh2UNPL+DR8cdmhgaNZpv778F4FaGP7UEQJ5rgZE47JFirbrGRVkTtK0MjtNXvNRMGXWTYH+vGQUkl54DfIRiJ5JPc2gW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 24, 2024 at 06:23:00PM -0700, Shakeel Butt wrote: > During the era of memcg charge migration, the kernel has to be make sure > that the dirty stat updates do not race with the charge migration. > Otherwise it might update the dirty stats of the wrong memcg. Now with > the memcg charge migration deprecated, there is no more race for dirty > stat updates and the previous locking can be removed. > > Signed-off-by: Shakeel Butt Acked-by: Johannes Weiner