From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F0E1D13591 for ; Mon, 28 Oct 2024 01:51:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E7956B0095; Sun, 27 Oct 2024 21:51:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 36FB36B0096; Sun, 27 Oct 2024 21:51:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E9BE6B0098; Sun, 27 Oct 2024 21:51:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F05256B0095 for ; Sun, 27 Oct 2024 21:51:33 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B6437C0661 for ; Mon, 28 Oct 2024 01:51:09 +0000 (UTC) X-FDA: 82721333352.21.443420A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id BCB5EC000C for ; Mon, 28 Oct 2024 01:51:21 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=h4cqvTfB; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of mhiramat@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mhiramat@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730080250; a=rsa-sha256; cv=none; b=TmV95nWNezwFem6CxJrI4/jnHApzdaxQc/pGzLKD6xKo+huTrwPSg8fJrAEM4O5IvdABd0 9Ag/3u0dx57I2mblPXVkRXLUVXXPHEWg/zSHKQVgHEn40bky+X5FnbOs1ui6flxCNAkwOU 9/+wOGcVcjTTZsf0ajSMIdFNC1Rjvgo= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=h4cqvTfB; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of mhiramat@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mhiramat@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730080250; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TDzDkv2eEE5b3UPGPzw7co+OhNrsqQMe0eoId/OmhT8=; b=wQk09AXnxtq/7A8BqJeAhXifN5/JjQV1+Ij9NMD8yX5lym/1JUvFUbM+jL1Ny16kk1fRg5 4qIj9WSBD5vuEjYg6dFocC3qKWvc2vXOV2UObCSAunp4plufsVvzV1jhxT5ryQDwpdnzrP e3vcKAppGISTP/7exwm9qs/BuHTuikk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 90BDB5C4982; Mon, 28 Oct 2024 01:50:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0D5AC4CEE5; Mon, 28 Oct 2024 01:51:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730080290; bh=zODM8QIek4pjyL7QBTrHXutihD100zn+5yBx+vpDtpo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=h4cqvTfBjY6zSmRUrHbRxk4oO6JM3O0fcrnPO6DlHd+8Lh00lp+I2giwVDt2Q5Y87 WfxGlEP27BVGuh4C//0ip1aiVrA7vAqwqgQW7E1Xx/UA+yW8bmqv9IYmyvhZT4IeXV W/Oc2/Ipug0BqLXrb0D5dqGGTCdpiiO4/jkQ/wMJhExbgWnE6t6QdIziooCLkcJzbT k/2GNvkqDMzL7T6a7B4rcHpYv4FzE571p12O7sfdq5K2BR4AFdSHUp9kSD4ge9YoqS 3eJhwBsmXnAk0oAHDa5O3HLc2oeNU9scF/PhNNo5z8whoGq6QCAEBhCe4+0hzEdGjb OP7pTv9Gaoy8w== Date: Mon, 28 Oct 2024 10:51:23 +0900 From: Masami Hiramatsu (Google) To: Andrii Nakryiko Cc: linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, peterz@infradead.org, oleg@redhat.com, rostedt@goodmis.org, mhiramat@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, jolsa@kernel.org, paulmck@kernel.org, willy@infradead.org, surenb@google.com, mjguzik@gmail.com, brauner@kernel.org, jannh@google.com, mhocko@kernel.org, vbabka@suse.cz, shakeel.butt@linux.dev, hannes@cmpxchg.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, david@redhat.com, arnd@arndb.de, richard.weiyang@gmail.com, zhangpeng.00@bytedance.com, linmiaohe@huawei.com, viro@zeniv.linux.org.uk, hca@linux.ibm.com Subject: Re: [PATCH v4 tip/perf/core 3/4] uprobes: simplify find_active_uprobe_rcu() VMA checks Message-Id: <20241028105123.c97544285c7e3304138c5a40@kernel.org> In-Reply-To: <20241028010818.2487581-4-andrii@kernel.org> References: <20241028010818.2487581-1-andrii@kernel.org> <20241028010818.2487581-4-andrii@kernel.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: gd99zxa99zf7oukagrouoo1n4ewpr6ht X-Rspamd-Queue-Id: BCB5EC000C X-Rspamd-Server: rspam02 X-HE-Tag: 1730080281-283490 X-HE-Meta: U2FsdGVkX18e4o9ZoumUJ1wRMsZDkZvm+yNik/8EgwBZ3RYe3Wu4zB9NkQnE2910HaPR7P+rErQQpewH57t/P7wNQraSlKgx6qKNq6kli7XODCtNMFwYlfKovmhPmHaAK1jJ+SI5Dj4GZp+i5W/PP4SFMO2i08cdP83ZRHN1z6bBpZTS8zvrhiw5qoSN4AH1MzzGjDQJR+9auvbRu8P3k3Sh0Vd0IYjyVJVnYhLfBHdEIHS8LR/ae8sEABfbJXFZ3L1g4TdOu4rvBUvJSKH0LSRg8zBkdSD611mCfgDfanCddoAx1NEvRf9aRpSA39VOOe4VU5j8uUu0BwmD6lsq53hK0dURXI7qPubws3i1km9bAOyR1s1KMWaRhVlGtHZpvjQD1iMK+3cM5wGCPz46J5qoHxzv+VloK4l3eN/wIKETpA7ZmnMy8Bib2Q1IGzDvP1KN4eXdVGGz6WsFAky5/VyxwXLBaeokzDSAdZG0Iu36erazBDDhroNQWV87w8F0C6I1ce42ngrtaMGZ3AgppUvI7etoAYj1PuOE3elEDcBHMV3SmLxoZuJQ2t7/dR2gwmkrUX6VqEwvwPnct1szArvDiXlSOIITKB69Tr2PDHAvshIe1uzvlEYziYh5D1zNPnb5zfTxZyx496DRDcJ+dD+0/l2Y7kQir5+s9slUyqlnxhSjwnMqlh63ROigmilncyVjgY2zq+mR/ZeDp6qt0QL9To6D3SDV7ewOsmD6N4z4ecWgdMju8+Ifx+xr4yAdetvSp5u8fIWyhnZQ70qddEQk4t8CDFZPpTXP4fXNt9LChaGtf51um07AWec4kx0u3SDQk/ZFO+dGBeHm9YonNaRTBi5MMgnitY9JDatKjPwoJeFtDWo9uZc2OJ2/XmDHnm4bExVo8/NHad6pFGzgsU0g9sTjcTH3mMqmQVNcyERaHhs9geXJrFGIp5DHTkF77u56zDwrQUbH37u7z6F leUgGEPf DMCdxdJ1Epn3U8p+YADflIvZKQtvlBWKIMSrmTtBMQa8RBKVT9vFulGlLz9UMomChgsJvIVdgnyupzJibCe1z/nMgNT6YV95DilHKfTgs+/FyVY8+p6vxSiDImlZaoqAHed9eqf3zdNUOzNzVOxnouTXQcl8SncjWiteaZi67rDCwwBDLx1UaUnJnBc+XtWE5chbXVHzTrRBH7i9Mwh0MislmhCwC9Ip4KHGCP0G1yKQF/M7o90eCRN6JTSavMlJbYx4zS7LC08TXGOn5ZBEGQesiumvEsYTYXPkaPybG4j62PEgHvyK/m16KGGuzBe585pDQJAthzlwy/XArbpGKj6pXHpXEdPow94pGGg5vIUsEx5GU2cTkoSYiByWJwG52ynZKtzrfqQdHsh4xG31KZvOGtyC46gcEPIJc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 27 Oct 2024 18:08:17 -0700 Andrii Nakryiko wrote: > At the point where find_active_uprobe_rcu() is used we know that VMA in > question has triggered software breakpoint, so we don't need to validate > vma->vm_flags. Keep only vma->vm_file NULL check. > Looks good to me. Reviewed-by: Masami Hiramatsu (Google) Thanks, > Acked-by: Oleg Nesterov > Suggested-by: Oleg Nesterov > Signed-off-by: Andrii Nakryiko > --- > kernel/events/uprobes.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c > index 4ef4b51776eb..290c445768fa 100644 > --- a/kernel/events/uprobes.c > +++ b/kernel/events/uprobes.c > @@ -2084,7 +2084,7 @@ static struct uprobe *find_active_uprobe_rcu(unsigned long bp_vaddr, int *is_swb > mmap_read_lock(mm); > vma = vma_lookup(mm, bp_vaddr); > if (vma) { > - if (valid_vma(vma, false)) { > + if (vma->vm_file) { > struct inode *inode = file_inode(vma->vm_file); > loff_t offset = vaddr_to_offset(vma, bp_vaddr); > > -- > 2.43.5 > -- Masami Hiramatsu (Google)