From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3B2AD1039A for ; Mon, 28 Oct 2024 12:41:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FD446B0088; Mon, 28 Oct 2024 08:41:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AD106B0089; Mon, 28 Oct 2024 08:41:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 474A16B008A; Mon, 28 Oct 2024 08:41:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 286926B0088 for ; Mon, 28 Oct 2024 08:41:17 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6CC1EC0AB5 for ; Mon, 28 Oct 2024 12:40:52 +0000 (UTC) X-FDA: 82722970680.24.029B5C1 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf08.hostedemail.com (Postfix) with ESMTP id 76211160015 for ; Mon, 28 Oct 2024 12:40:59 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Ql0dlzhw; spf=pass (imf08.hostedemail.com: domain of brauner@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730119116; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EGA35x4hW0aDVxJuW1wkVxokFyJwnlOH0GV4bU1qYYA=; b=5ClU4q9sQ2S50OOkymNRgMBZIQm06EsOaCHDtP//So3tLB2dXha4O1kNkcBhf1v6WlFWcr 7JCiWnc+y3VONfS/vbGAi1kIDy/gR5hSTiMle6wF0NdzKQztTf/Xt7vlfssC8vbdqHd0k8 nA9xbjo/T1eqbrxxKwYoA3n4WnMABxQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730119116; a=rsa-sha256; cv=none; b=b5JM1mEMTSSPFVu4OahGvn5ehjlsofhp83LGsKmEZWjZLGe0Nr6wjgHmCSh1jjipKg3isz OtI5xOVvI1B8pQ+8SvzXjVAcXTwrPj/1PhNUBfgWZ/3eYCud/SMusUt7FXce7BLS/d5uu5 6jKgw7JADLAk2Awr3WlbdwNtkZjHMIg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Ql0dlzhw; spf=pass (imf08.hostedemail.com: domain of brauner@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 3442CA41F00; Mon, 28 Oct 2024 12:39:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB43CC4CEC3; Mon, 28 Oct 2024 12:41:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730119273; bh=bZuEglKDOjZNBOrJVtiQqz7AMNZWK2RhVSZWBNWNwys=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ql0dlzhwYEguQ9IWl+y5rgXE/woq2d6vj+VTApVdyVxJhLxGlzpCImQ66ND0ppXkw 1tg2361KwcQOhbnAiX7ZS579bQFejbtSDPiiEn7VZfLPxyOHx0dEenD1pkcFbMd3Eh POlLHzc5NZ+EsjV1EoRMtdAEdJxxqtnW3kpnOrcVsX9UwQF8juO1B1GMOSRKJopaFU 7fDXJZTREMgmLasNOorp7X5g9sPJ9VhznhliNskLkZE0hJcfKfDLf0hxltlqWr/8HD /rmp42CvUdlTY1Dcpyaa61ne4uJzSVHy0b26HMR6oYoxxXmm5ou0deI9S1B3Qnnl1T 3AZaEm7CSIBvg== From: Christian Brauner To: Hugh Dickins Cc: Christian Brauner , Andrew Morton , Matthew Wilcox , Christoph Hellwig , Kent Overstreet , "Darrick J. Wong" , Thomas Gleixner , Peter Zijlstra , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Viro Subject: Re: [PATCH] iov_iter: fix copy_page_from_iter_atomic() if KMAP_LOCAL_FORCE_MAP Date: Mon, 28 Oct 2024 13:41:06 +0100 Message-ID: <20241028-gulasch-gestiegen-3b9502e5fbcc@brauner> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1265; i=brauner@kernel.org; h=from:subject:message-id; bh=bZuEglKDOjZNBOrJVtiQqz7AMNZWK2RhVSZWBNWNwys=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaTLtyVN3n33ZIhNyomEKRXvu63e3r107pHjZF33cAau5 I+lkU+KO0pZGMS4GGTFFFkc2k3C5ZbzVGw2ytSAmcPKBDKEgYtTACay/y/Df9dST+UbM58nlZ3o /bXT+mhsLIvPiTMf/FQk/ZhtJNlmbmT4wyF24/KzX6k6/2/bSsxdcU5JfL1K8Y31F8sPBPTf9Uu 4yAYA X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit X-Stat-Signature: niemne3mpfpuauskt9ziudg4g7m4n5ee X-Rspamd-Queue-Id: 76211160015 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1730119259-214129 X-HE-Meta: U2FsdGVkX1+MnmtnZF6TQFNXrTCaskFNKRp78jc8la4idifVSX+GPvbZpq1yrS8pZlkobksHysm3ZXytWA1LBEIoA4xiH3pTE/yaG4mnnMDEyTVTn4994o3AXzWBNfzKaXEbiG/mbqUUQkHlLY2vDhiPhroX3adbUU6ScIQCPmGj5Pukdd9e8vZZ4M3b7MkT7FW6kHMVnB8Fzdxyu1kjF58FfhKIdBg5jYnQNplteDqneuhgxg98E0w/eNlX3WfCbE5S9pRBsbe65JPPB0oac4xKu6NSUxiWTnH7oVPUii+yqNf8uFqwnF3iJYGB4I6oVkQLDU5Be+Z6pz3OYLQEW08ouQ7An/gDuijnSpz8Jdu1e7tGaQLdVpEy2bI+W7Asi8dxfJpI8ANSSPQ8BlPV7MnN3WddadhIkhw8wwEzIJikLw1LlVpNdCGiMCn6Djw/01xAzvN0aTiw2M1rTdxZdqiVhpvBoUlMt81xQ0HZlhPYrkQNmq8wIILfU4Bp51baRUKvlJYqPjUHcifzRB2Dr//PnFbaxNwTYOsBf8sP8d54t/bJRx7gKdfipW5nozCdTFZx1B4hHDnR6l+LCK/+vrHl9ujLwoJBlmsrmkRMYTaAiqGJ98X6xn/nYGpU76T08AUchgW01yZIclFtWC3PogoE147My/sndwsNRrJo1mQoNaKZR954C2cEWdRKIywEWVKN20Zyw1mFp2OCrnZ3NNQYKP2pGPF1ertAb5JQzaNcyCQayqrCW2aF0jF4uBSZyGnpdn2QpHbgbs28d8crdmY1UrOFFQOlO53dXxA8JyP+yxbgxNQw3o/UEcMI9G7xbIkBtR/k2+Z/Oz18DxuEwfAnE/f501Xcp0ooXNX3DTCkzaU0mKT5wZchU7MQxK9hJ2zwkqmjey47jP+WIadS03pvHIXV7EV8jrDxR3NgVHpJAtCP6EjrKJ88w6TxwlMojgJ0MBrab3ncJt4uM/4 FHGb2xsj lkeR4WCcUCeKrcSpXY5qHiAP43ityJPGUyi6OQ7nQTHjwQ6kHG21yLtTTY9xdhOGHg4qQiYnaV7VR2Hgb226LN/TYayUMx+rSBEWKf8BZZnS6GWXy+JbmZkLTAQZrv2pYrwFWT5tjrZtOFU20PO0DyMctDRnk4JywnjdJ4k0eXFeF5Tr98Per9HCv7YB8u81nWcqafILVHFpDOwIMxYmuvE97BeWnC9TSKHxNGKgYYueKayBHiwcXhIbzIc7kmHYTeIX79qvuosA3MUw7GMpeiPzSzAxvNRS74dojN56rdEn2aTNkRBOK/26QewV66KqoVEPygiJp/BtLYkcFR5I5z20kNA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 27 Oct 2024 15:23:23 -0700, Hugh Dickins wrote: > generic/077 on x86_32 CONFIG_DEBUG_KMAP_LOCAL_FORCE_MAP=y with highmem, > on huge=always tmpfs, issues a warning and then hangs (interruptibly): > > WARNING: CPU: 5 PID: 3517 at mm/highmem.c:622 kunmap_local_indexed+0x62/0xc9 > CPU: 5 UID: 0 PID: 3517 Comm: cp Not tainted 6.12.0-rc4 #2 > ... > copy_page_from_iter_atomic+0xa6/0x5ec > generic_perform_write+0xf6/0x1b4 > shmem_file_write_iter+0x54/0x67 > > [...] Applied to the vfs.fixes branch of the vfs/vfs.git tree. Patches in the vfs.fixes branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.fixes [1/1] iov_iter: fix copy_page_from_iter_atomic() if KMAP_LOCAL_FORCE_MAP https://git.kernel.org/vfs/vfs/c/c749d9b7ebbc